Commit Graph

815 Commits

Author SHA1 Message Date
Ray Jenkins 234760f516 Verify process network address filter before attempting setclass. Provide error message if no matching process addresses found 2022-01-24 13:32:44 -08:00
Johannes M. Scheuermann 2b7990102e Fix typo in comment 2022-01-17 06:08:24 +00:00
A.J. Beamon ff1cb58174 Convert hyphens to underscores for all prefix-based arguments (e.g. --knob-, --locality-) 2021-12-14 12:01:44 -08:00
A.J. Beamon f29f487823
Unify flags (#25)
* Unify flags implementation and change help text in backup.actor.cpp
Description

Testing

* Keep LOG_GROUP unchanged

Description

Testing

* Transfer the hyphens to underscores for internal options and user's input, EXCEPT leading hyphens

Description

Testing

* Use a deep copy of the user's input flag to do the match

Description

Testing

* Convert the _ to - in Option arrays of backup.actor.cpp

Description

Testing

* Transter _ to - for files:
        TLSConfig.actor.h, fdbcli.actor.cpp, fdbserver.actor.cpp, FileConverter.h, FileConverter.cpp

Description

Testing

* Change another way to unify flag: using SO_O_ICASE_HYPHEN_AND_UNDERSCORE to determine whether we do the conversion in function IsEqual

Description

Testing

* Change the config command's name from SO_O_ICASE_HYPHEN_AND_UNDERSCORE to SO_O_HYPHEN_TO_UNDERSCORE

Description

Testing

* Update the comment for the SO_O_HYPHEN_TO_UNDERSCORE

Description

Testing

* Fix left underscore in SOption arrays

Description

Testing

* Convert _ to - in several files for commands

Description

Testing

* Make the FDBService and fdbmonitor backward compatible

Description

Testing

* Fix bugs about pointers

Description

Testing

* Check underscore and hyphen at the same time for --knob_, --localily_ and --test_
And fix bugs in fdbmonitor and FDBService
Description

Testing

* Simplify the function in fdbmonitor and FDBService about retrieving arguments.
And fix some documents in masterserver.actor.cpp

Description

Testing

* Convert _ to - for knob in the setKnob functions

Description

Testing

* Convert - to _ in the setKnob functions

Description
Since key in the knob related maps only contain _

Testing

* Rename varialbe name in the fdbmonitor and FDBService for clarification

Description

Testing

Co-authored-by: Chang Liu <chang.liu@snowflake.com>
2021-12-14 08:44:39 -08:00
Suraj Gupta cb568bbd55 Add watch on config key. 2021-12-10 14:00:34 -06:00
Suraj Gupta fc3376fe8f Move client knob to database config for blob granules. 2021-12-10 14:00:34 -06:00
sfc-gh-tclinkenbeard ec64890ac1 Remove some usages of PRId64 by using fmt library 2021-11-30 23:35:36 -08:00
Trevor Clinkenbeard 3d0ed2083c
Merge pull request #6000 from sfc-gh-tclinkenbeard/setup-flow-knobs
Setup global flow knobs in `setupNetwork`
2021-11-18 19:30:26 -08:00
sfc-gh-tclinkenbeard 2613ec7561 Expand use of fmt to get rid of %ld usage 2021-11-17 17:03:32 -08:00
sfc-gh-tclinkenbeard 07349869d9 Use fmt to address -Wformat warnings 2021-11-17 14:45:48 -08:00
sfc-gh-tclinkenbeard 766a05d33c Merge remote-tracking branch 'origin/master' into add-format-warning 2021-11-17 12:14:01 -08:00
sfc-gh-tclinkenbeard 3b1ae39403 Add CLIOptions::setupKnobs method 2021-11-16 10:39:22 -08:00
sfc-gh-tclinkenbeard deb0eb85e8 Initialize global flow knobs in setupNetwork 2021-11-16 00:41:34 -08:00
Evan Tschannen 6909754b21 changefeeds now have a whenAtLeast function for efficiently learning when the version has updated but no mutations have been committed 2021-11-14 19:08:46 -08:00
sfc-gh-tclinkenbeard 13bb7838aa Enable clang -Wformat warning 2021-10-30 21:07:38 -07:00
Josh Slocum 0ff8ddc2b6 Merge branch 'master' into blob_full_clean 2021-10-25 13:38:48 -05:00
Evan Tschannen 6f7558b8ea Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed
# Conflicts:
#	tests/CMakeLists.txt
2021-10-24 21:06:33 -07:00
A.J. Beamon e882eb33fc Abstract the cluster file into a cluster connection record that can be backed by something other than the filesystem. 2021-10-22 11:05:18 -07:00
Josh Slocum 773886515e Merge branch 'feature-range-feed' into blob_full_clean 2021-10-22 11:07:51 -05:00
Evan Tschannen 3f7df58a77 fixed a number of issues 2021-10-19 13:56:52 -07:00
He Liu f20f43a85a Added warning in the `exlucde` cli command help about potential dataloss, as well as in command-line-interface.rst. 2021-10-18 12:10:34 -07:00
Josh Slocum 5f0ec0612a Merge branch 'feature-range-feed' into blob_full 2021-10-13 15:44:35 -05:00
Evan Tschannen d51edf18dc fixed merge conflicts 2021-10-09 19:47:24 -07:00
Evan Tschannen 5c642f706e Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
2021-10-09 19:34:16 -07:00
Chaoguang Lin e2fa511036 Add option --api-version for fdbcli 2021-10-05 13:00:28 -07:00
Neethu Haneesha Bingi cbb3c9a82e Fixed format errors. 2021-09-30 10:00:33 -07:00
Neethu Haneesha Bingi 3e79299898 Locality filter support to perpetual storage wiggler feature. 2021-09-30 10:00:33 -07:00
Xiaoxi Wang 40c6fbcc16 solve comment 2021-09-21 18:11:04 -07:00
Xiaoxi Wang 1730d75f73 change configure test
add store type check
add test file
2021-09-21 18:11:04 -07:00
Chaoguang Lin c6b572dc06 Add makeInterruptable to commands' actors 2021-09-21 10:06:04 -07:00
Chaoguang Lin a6940c6061 Change the return type of triggerddteaminfologCommandActor to bool to make it consistent with others 2021-09-21 10:06:04 -07:00
Chaoguang Lin a871a9fac6 Refactor fileconfigure command 2021-09-21 10:06:04 -07:00
Chaoguang Lin 9f7ca7fafd Fix rreversed return boolean value in configureCommandActor 2021-09-21 10:06:04 -07:00
Chaoguang Lin 65956ae6b7 Refactor configure command; refactor changeConfig to template code to reuse existing tests 2021-09-21 10:06:04 -07:00
Xiaoge Su abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
Chaoguang Lin e7d3516084 solve comments 2021-09-14 11:04:02 -07:00
Chaoguang Lin 6cca6b9e6f Refactor exclude command 2021-09-14 11:04:02 -07:00
Chaoguang Lin ff54ba8626 Refactor coordinators and include command 2021-09-14 11:04:02 -07:00
Josh Slocum 9992a7b33f Added StorageMigrationType and cli commands 2021-09-14 09:55:41 -05:00
Chaoguang Lin cb9dde358c Solve comments, refatctor the error handling part 2021-09-13 13:28:48 -07:00
Chaoguang Lin e81748e732 Fix all tr->get, hold the ThreadFuture for the memory 2021-09-13 13:28:48 -07:00
Chaoguang Lin 7e33e19feb Simplify the code using the function getSpecialKeysFailureErrorMessage 2021-09-13 13:28:48 -07:00
Chaoguang Lin 07ebc2013c Print the updated help message 2021-09-13 13:28:48 -07:00
Chaoguang Lin cfb9b56067 Refactor lock/unlock command, fix the related correctness test, add the documentation for updating usage of the special key 2021-09-13 13:28:48 -07:00
Josh Slocum c2d1d1704f Merge branch 'feature-range-feed' into blob_full 2021-09-10 11:21:52 -05:00
Evan Tschannen ac5b580e2d Merge branch 'master' into feature-range-feed
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/StorageServerInterface.cpp
#	fdbclient/StorageServerInterface.h
#	fdbserver/ApplyMetadataMutation.cpp
#	fdbserver/TLogServer.actor.cpp
#	flow/error_definitions.h
2021-09-09 23:13:22 -07:00
Chaoguang Lin ab29bf05af Solve PR comments 2021-09-08 16:38:42 -07:00
Chaoguang Lin 8cc3f3f49d Code format 2021-09-08 10:56:32 -07:00
Chaoguang Lin 8cef044a8b Remove commented code; simplify code 2021-09-08 10:42:46 -07:00
Chaoguang Lin af5643c998 Fix the issue in CheckStatus where it stuck as we cannot talk to any of the coordinators 2021-09-08 10:05:13 -07:00
Chaoguang Lin 99cc042d9c Fix ProfileCommand.actor.cpp, using the correct way to read from global config 2021-09-07 11:06:47 -07:00
Evan Tschannen 4bbae59bb0 Fixed a few bugs and added a backup popping mechanism 2021-09-02 21:11:44 -07:00
Chaoguang Lin 9b148c6c63 Adding code to hold the threadfuture of ITransaction::get; other fixes for using external clients 2021-09-02 11:52:39 -07:00
Chaoguang Lin feb4e48f20 Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli 2021-08-31 12:26:21 -07:00
Josh Slocum b4bfd58bcb multiple blob workers appears to work 2021-08-30 13:07:25 -05:00
Chaoguang Lin 0f9ba4c6f5 Fix file format 2021-08-27 15:30:30 -07:00
Chaoguang Lin 7168594ae4 Refactor status command 2021-08-27 15:02:49 -07:00
Chaoguang Lin 389e7051af Remove using the RYWTransaction object in fdbcli 2021-08-27 13:52:16 -07:00
Chaoguang Lin 46fd774d8c Move triggerddteaminfolog and tssq to new files; fix the reversed flag in tssq 2021-08-27 13:05:59 -07:00
Chaoguang Lin 555bb70663 Cherry-pick the initialization fix in pr#5291 2021-08-27 12:42:30 -07:00
Chaoguang Lin 991d61923f Refactor tssq command 2021-08-27 11:58:18 -07:00
Chaoguang Lin 140a8f46b6 Refactor triggerddteaminfolog command 2021-08-27 11:57:13 -07:00
Chaoguang Lin 1b57905931 Refactor option command to include the ITransaction handler 2021-08-27 11:56:33 -07:00
Chaoguang Lin 1aa12faf01 Refactor profile command, remove profile heap|flow commands 2021-08-27 11:52:29 -07:00
Chaoguang Lin cb3ca9768f Solve comments, add assertions 2021-08-26 13:43:22 -07:00
Chaoguang Lin d2756b97e3 Add new lines in the two added files 2021-08-25 12:08:27 -07:00
Chaoguang Lin 09ccba67cf Refactor suspend and expensive_data_check commands 2021-08-25 12:05:51 -07:00
Chaoguang Lin ce9bf5c5ce Create a new function to get all worker interfaces 2021-08-25 11:54:08 -07:00
Chaoguang Lin 41f09e9c2e Refactor kill command 2021-08-25 10:47:52 -07:00
Chaoguang Lin 0806309230
Merge pull request #5458 from sfc-gh-clin/refactor-transaction-related-commands
Refactor transaction related commands
2021-08-24 16:42:03 -07:00
Chaoguang Lin 8de3417f24 Fix comment, add a new function for reading special keys' error message 2021-08-24 14:18:43 -07:00
Chaoguang Lin 868fa93d3d Merge branch 'master' of github.com:apple/foundationdb into refactor-cache_range-command 2021-08-24 12:58:23 -07:00
Chaoguang Lin 5f924c8952 Refactor transaction related commands like begin, commit, etc. 2021-08-24 11:53:39 -07:00
Chaoguang Lin a29e380516 Print out setclass special keys' related error if present 2021-08-24 11:51:12 -07:00
Chaoguang Lin e0a01504fd Solve comments, fix the help message 2021-08-24 09:50:31 -07:00
Chaoguang Lin 079719346f Add comments; Add newline in the end of the file 2021-08-20 13:45:16 -07:00
Chaoguang Lin 8ed041132f Rewrite cache_range related functions to template code; Remove duplicate code; fix the existing bug in cache_range; 2021-08-20 13:42:50 -07:00
Chaoguang Lin 8c19969048 Refactor the cache_range command 2021-08-20 10:57:13 -07:00
Chaoguang Lin 3e34769c6d Merge branch 'master' of github.com:apple/foundationdb into ipc-bench 2021-08-19 21:40:27 +00:00
Chaoguang Lin 7258c085ac
Merge pull request #5395 from sfc-gh-clin/add-external-client-fdbcli-test
Add fdbcli external client tests
2021-08-19 14:30:22 -07:00
Chaoguang Lin b2c063dd93 Change g_network->runNetwork to API->runNetwork 2021-08-18 18:09:02 -07:00
Evan Tschannen a278d2977a renamed range feeds to change feeds, data distribution support almost complete 2021-08-13 14:27:15 -07:00
Josh Slocum 1a4e70d22f Merge branch 'feature-range-feed' into blob_full 2021-08-12 10:22:28 -05:00
Chaoguang Lin be796a62a0 Update comments 2021-08-11 18:39:47 -07:00
Chaoguang Lin bf0d0598dc Refactor all ThrottleAPI functions using template and remove duplicate copies 2021-08-11 23:59:25 +00:00
Evan Tschannen 94239098a5 added additional rangefeed commands to fdbcli 2021-08-10 23:59:05 -07:00
Evan Tschannen 7891477a7c added support for streaming range feeds 2021-08-10 21:28:25 -07:00
Chaoguang Lin 618c72f7e2 Draft to use template to rewrite ThrottleApi 2021-08-11 01:07:36 +00:00
Josh Slocum 921a2cfca1 Merge branch 'feature-range-feed' into blob_full 2021-08-10 11:25:48 -05:00
Josh Slocum 247602753d Blob worker handles multiple ranges now 2021-08-10 11:19:43 -05:00
Evan Tschannen ed28aecde0 Merge branch 'master' into feature-range-feed 2021-08-09 20:40:55 -07:00
Evan Tschannen 42ae870c84 added support for querying specific range feed versions 2021-08-09 20:39:28 -07:00
Evan Tschannen 52fcf3f565 fixed a few bugs 2021-08-09 17:16:53 -07:00
Chaoguang Lin 768aaf76c4 Update comments in DataDistributionCommand.actor.cpp 2021-08-06 18:30:14 +00:00
Chaoguang Lin 815ad03122 Refactor datadistribution command 2021-08-06 18:27:45 +00:00
Chaoguang Lin 84e1c693ef Fix naming typo 2021-08-06 18:27:36 +00:00
Josh Slocum a931f70cfb Added fdbcli for blobrange 2021-08-06 11:01:37 -05:00
Chaoguang Lin bbc2ffe527 Remove unnecessay header, add new line at the end of the file 2021-08-05 19:29:01 +00:00
Chaoguang Lin 7f7620d125 Refactor the setclass command 2021-08-05 19:01:17 +00:00
Evan Tschannen 0989c28a6b made range feeds durable on the storage server 2021-07-30 15:23:42 -07:00
Chaoguang Lin 9eec9376bd
Merge pull request #5285 from sfc-gh-clin/refactor-throttle-command
Refactor throttle command
2021-07-28 13:43:15 -07:00
Evan Tschannen 406562b282 Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed 2021-07-27 17:04:58 -07:00
Lukas Joswiak b423432ee1 Make wait interruptable 2021-07-27 15:45:35 -07:00
Lukas Joswiak 08bc787356 Add timeout 2021-07-27 15:22:01 -07:00
Lukas Joswiak acfb9adbd2 Fix ctest timeouts 2021-07-27 15:10:49 -07:00
Lukas Joswiak 52940d38d9 Fix issue where GlobalConfig wasn't initialized in time when running fdbcli --exec 2021-07-27 14:12:01 -07:00
Chaoguang Lin 28128d79b1 Refactor throttle command 2021-07-27 17:58:11 +00:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
Evan Tschannen 15fe00927a Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/NativeAPI.actor.cpp
#	fdbclient/StorageServerInterface.h
#	fdbclient/SystemData.cpp
#	fdbclient/SystemData.h
#	fdbserver/storageserver.actor.cpp
#	flow/ProtocolVersion.h
2021-07-12 19:10:14 -07:00
sfc-gh-tclinkenbeard 8cc40e3a2b Expand use of BOOLEAN_PARAM 2021-07-02 21:41:50 -07:00
sfc-gh-tclinkenbeard 79ff07a071 Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters 2021-07-02 15:04:42 -07:00
neethuhaneesha 63e530fc44
Merge pull request #4832 from neethuhaneesha/master
exclude servers based on locality match
2021-06-28 12:13:09 -07:00
Neethu Haneesha Bingi decfb610ff Minor review comments. 2021-06-25 15:04:49 -07:00
Chaoguang Lin c559621ac6
Merge pull request #4996 from sfc-gh-clin/add-fdbcli-tests
Add test coverage for more fdbcli commands
2021-06-25 12:01:45 -07:00
Chaoguang Lin f62b118915 remove duplicate unset text in help text 2021-06-25 18:21:30 +00:00
Neethu Haneesha Bingi 66f2518405 exclude to work with any locality data match. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi cbe714acd0 Status json schema update, includelocalities back for consistency check, review comments. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi 4ad5926a25 Snake naming of keys and added comments to all new functions. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi 73752f441b exclude locality:clang-format, ranged loops, documentation, tracking addStoragesever for exclusion. 2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi 62355571d0 exclude servers based on locality match 2021-06-23 18:03:27 -07:00
Chaoguang Lin 0fd60cd334 Update the help text of fdbcli command setclass to split proxy into grv_proxy and commit_proxy 2021-06-23 23:34:10 +00:00
sfc-gh-tclinkenbeard 6619545c30 Merge remote-tracking branch 'origin/master' into config-db 2021-06-18 19:59:56 -07:00
Chaoguang Lin 9d823e9592 remove unnecessary version check in fdbcli 2021-06-17 19:13:07 +00:00
sfc-gh-tclinkenbeard 826e70916c Merge remote-tracking branch 'origin/master' into config-db 2021-06-17 09:47:41 -07:00
Chaoguang Lin 563bc681a0 remove code 2021-06-17 00:35:44 +00:00
Chaoguang Lin ecff680b47 Merge branch 'master' of github.com:apple/foundationdb into add-fdbcli-tests 2021-06-17 00:29:41 +00:00
Chaoguang Lin d4f30a7bc7 Write error output to stderr; update output format of unlock 2021-06-17 00:26:43 +00:00
Andrew Noyes 6c2165dfee
Merge pull request #4845 from sfc-gh-clin/refactor-fdbcli-2
Refactor fdbcli commands: advanceversion, maintenance, snapshot, force_recovery_with_data_loss
2021-06-15 11:13:18 -07:00
Andrew Noyes a3e3a18cda
Update fdbcli/ForceRecoveryWithDataLossCommand.actor.cpp 2021-06-15 11:12:14 -07:00
Chaoguang Lin 82c63c154d Merge branch 'master' of github.com:apple/foundationdb into add-fdbcli-tests 2021-06-14 17:35:33 +00:00
Josh Slocum 65c49fc1e4
Merge pull request #4934 from sfc-gh-jslocum/tss_quarantine
Added TSS Quarantine and fixed TSS mapping bug in CommitProxy
2021-06-11 11:52:42 -07:00
Josh Slocum 199d6ed994
Merge pull request #4895 from sfc-gh-jslocum/tss_docs
Added TSS documentation
2021-06-11 11:50:28 -07:00
sfc-gh-tclinkenbeard 41c790b299 Merge remote-tracking branch 'origin/master' into config-db 2021-06-10 22:31:23 -07:00
Chaoguang Lin ce2f6a19f3 Keep the threadFuture<Standalone<...>> alive uto hold up the memory 2021-06-10 19:41:51 +00:00
sfc-gh-tclinkenbeard c272304e60 Manage global flow knobs with global knob collection 2021-06-09 22:33:00 -07:00
sfc-gh-tclinkenbeard 83a0e473e8 Refactor IKnobCollection code 2021-06-09 20:50:00 -07:00
Josh Slocum c6d96c4124 Added TSS Quarantine and fixed TSS mapping bug in CommitProxy 2021-06-09 14:42:50 +00:00
Chaoguang Lin 1f7acc8d02 Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli-2 2021-06-09 02:29:18 +00:00
sfc-gh-tclinkenbeard cfc4545135 Use g_knobs for SERVER_KNOBS and CLIENT_KNOBS 2021-06-07 14:32:51 -07:00
sfc-gh-tclinkenbeard 371a38e6e5 Merge remote-tracking branch 'origin/master' into remove-extra-copies 2021-06-07 10:26:06 -07:00
Trevor Clinkenbeard 866f536983
Merge pull request #4888 from sfc-gh-tclinkenbeard/remove-fdbserver-includes
Remove fdbserver includes from fdbclient
2021-06-07 10:22:13 -07:00
Josh Slocum be9fa2ce52 Added TSS documentation 2021-06-07 14:49:41 +00:00
Chaoguang Lin 11eed5bc71 Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli-2 2021-06-04 22:57:07 +00:00
sfc-gh-tclinkenbeard 89dadf1475 Create IKnobCollection interface 2021-06-02 23:40:52 -07:00
sfc-gh-tclinkenbeard 4c059670a0 Parse configuration knob values on the client 2021-06-02 10:04:46 -07:00
sfc-gh-tclinkenbeard a775f92fca Merge remote-tracking branch 'origin/master' into config-db 2021-06-01 15:39:34 -07:00
sfc-gh-tclinkenbeard 1a40c60674 Move RestoreWorkerInterface into fdbserver 2021-05-30 15:02:33 -07:00
sfc-gh-tclinkenbeard 594e8944ae Move RestoreWorkerInterface into fdbserver 2021-05-30 11:51:47 -07:00
Josh Slocum ce82c9653e Testing Storage Server implementation 2021-05-25 20:28:50 +00:00
Evan Tschannen 6165af81fa Merge branch 'apple:master' into feature-range-feed 2021-05-21 15:21:34 -07:00
Chaoguang Lin 455046de5f fix format, make the call interruptable 2021-05-20 23:29:22 +00:00
Chaoguang Lin 9b228fd4db Refactor snapshot command using the client function 2021-05-20 21:01:50 +00:00
Chaoguang Lin f1a0e4737a update error handling logic in fdbcli 2021-05-20 19:47:47 +00:00
Chaoguang Lin f3854fe8da Refactor force_recovery_with_data_loss command using the corresponding client function 2021-05-20 19:47:00 +00:00
Chaoguang Lin 6df94cba98 Refactor maintenance command using special keys 2021-05-20 18:37:03 +00:00
Chaoguang Lin a2f3aa1fa9 Remove duplicate advanceversion help text 2021-05-18 19:02:32 +00:00
Chaoguang Lin 35b88cd28b refactor advanceversion command 2021-05-18 07:22:17 +00:00
Xiaoxi Wang 8b1f9f7337 Add command line support 2021-05-17 20:57:54 +00:00
Chaoguang Lin 42eced15c9 Update comments and trigger CI 2021-05-11 16:46:07 -07:00
Chaoguang Lin 9a6151d3fc Update fdbcli.h to fdbcli.actor.h, removed the unnecessary wrapper 2021-05-11 14:31:08 -07:00
Chaoguang Lin 8002a389d4 add comments for error handling in ConsistencyCheckCommand.actor.cpp 2021-05-11 12:12:33 -07:00
Chaoguang Lin 359abfb008 Update FDB_API_VERSION to 710 2021-05-11 12:08:48 -07:00
sfc-gh-tclinkenbeard f28ac955c3 Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>> 2021-05-10 16:32:50 -07:00
Chaoguang Lin b5767e2a64 Add documentation for getTransaction function, which is used for refactoring 2021-05-10 12:29:46 -07:00
Chaoguang Lin 520c4fc2b9 Fix typo in the variable name 2021-05-07 16:03:52 -07:00
Chaoguang Lin 73fdb55f4b Add headers in new files 2021-05-06 16:43:56 -07:00
Chaoguang Lin 7da5004690 Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli 2021-05-06 15:44:26 -07:00
sfc-gh-tclinkenbeard 5c2d7b6080 Create RangeResult type alias 2021-05-03 13:14:16 -07:00
Evan Tschannen 78697003ea more formatting 2021-04-30 10:51:35 -07:00
Evan Tschannen d652287bae Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed
# Conflicts:
#	fdbclient/DatabaseContext.h
#	fdbclient/NativeAPI.actor.cpp
#	fdbclient/StorageServerInterface.h
#	fdbserver/storageserver.actor.cpp
2021-04-30 10:29:42 -07:00
Chaoguang Lin 8898a0f4d2 Add new line in the end of the file 2021-04-23 02:04:16 -07:00
Chaoguang Lin d263d011d0 Update the file name to follow normal case naming 2021-04-23 02:02:53 -07:00
Chaoguang Lin 302dd7d54d Update the file/function name to follow normal case naming as consistencyCheck* 2021-04-23 01:49:45 -07:00
Chaoguang Lin 36067e9685 remove unnecessary print message 2021-04-23 01:38:25 -07:00
Chaoguang Lin de4753a5db Add a workaround to temporily use the ryw to create a ThreadTransaction; Make sure we are using the same underlying ryw object 2021-04-23 01:32:30 -07:00
Chaoguang Lin f0a236c544 Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli 2021-04-21 15:36:11 -07:00
Lukas Joswiak 6de28dd916 clang-format 2021-04-14 10:56:33 -07:00
Lukas Joswiak 1c84c04ffc Add global configuration prefix function 2021-04-14 10:56:32 -07:00
Lukas Joswiak c3f68831af Move existing ClientDBInfo variables to global configuration 2021-04-14 10:56:32 -07:00
Chaoguang Lin 3e6215702f Add comments for refactoring 2021-04-13 13:42:19 -07:00
Chaoguang Lin c934e4b3fe Add comments, fix typos 2021-04-13 13:27:40 -07:00
Chaoguang Lin 60747a52a5 Add a thread-safe function that converts ThreadFuture into Future 2021-03-30 14:52:56 -07:00
Chaoguang Lin 41c135ec93 Change namespace FDBCLI to fdb_cli 2021-03-29 12:51:32 -07:00
Chaoguang Lin cb39d1a6ed Refactor consistencycheck command using special keys 2021-03-24 09:33:20 -07:00
Andrew Noyes a76c7b9754 Fix several memory leaks and a thread leak 2021-03-11 23:58:32 +00:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
Evan Tschannen 6cfba6e54b added support for popping rangefeeds 2021-03-05 11:46:33 -08:00
Evan Tschannen e25aac4988 added missing continue 2021-03-04 21:31:21 -08:00
Evan Tschannen fa39ea35b4 added missing break 2021-03-04 20:42:32 -08:00
Evan Tschannen 7d0a86395d compile fix 2021-03-04 20:31:16 -08:00
Evan Tschannen bc757f3e4b basic framework for range feed support 2021-03-04 19:14:54 -08:00
Evan Tschannen 346a4e3ecd Merge branch 'release-6.3'
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbrpc/LoadBalance.actor.h
#	fdbrpc/MultiInterface.h
#	fdbserver/ClusterController.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/masterserver.actor.cpp
2021-03-01 18:52:06 -08:00
Johannes M. Scheuermann 229b4ad2c3 fdbcli: Output errors and warnings to stderr 2021-02-25 11:09:02 +00:00
sfc-gh-tclinkenbeard 7558cd8e06 Merge remote-tracking branch 'origin/master' into simplify-global-knobs 2021-01-26 10:00:25 -08:00
Markus Pilman 074531309b
Merge pull request #3769 from sfc-gh-ljoswiak/binary-info
Add CLI argument to print build information
2021-01-26 10:29:57 -07:00
Andrew Noyes 564c70acb4
Merge branch 'master' into anoyes/modernize-use-override 2021-01-25 18:26:18 -08:00
Andrew Noyes 0ef44739ea Fix OPEN_FOR_IDE build in preparation for using clang-tidy 2021-01-26 02:04:11 +00:00
Andrew Noyes 4f881bff51 Only print general help once in fdbcli
This seems to have been inadvertently changed in
5b2e88b187.
2021-01-25 22:28:09 +00:00
sfc-gh-tclinkenbeard ad99bf0471 Merge remote-tracking branch 'origin' into misc-changes 2021-01-21 10:03:07 -08:00
Lukas Joswiak 9fd71cd1a0 Add build flags option to fdbcli 2021-01-19 11:21:21 -08:00
Andrew Noyes ff7d306b09 Merge branch 'release-6.3' into anoyes/merge-6.3-to-master
Include conflict markers for now. Will resolve.
2021-01-15 18:04:09 +00:00
sfc-gh-tclinkenbeard e29ed3bf99 Remove createGlobal*Knobs functions 2021-01-13 12:14:04 -08:00
sfc-gh-tclinkenbeard 5b2e88b187 Use structured bindings in for loops 2020-12-27 01:46:20 -04:00
Jingyu Zhou bbb56e4089 Merge branch 'release-6.2' of https://github.com/apple/foundationdb into release-6.3 2020-12-23 14:26:59 -08:00
Xin Dong da22308025 Change the new command to be all lower case to follow the convention. Updated the command line interface documentation and the release notes for 6.2.29. 2020-12-03 14:49:23 -08:00
Xin Dong 9505d77ddd Update fdbcli/fdbcli.actor.cpp
Co-authored-by: Andrew Noyes <63815641+sfc-gh-anoyes@users.noreply.github.com>
2020-12-03 14:42:30 -08:00
Xin Dong ac02329d7d Added a command in fdbcli to allow user to manually trigger the detailed teams info loggings in data distributor 2020-12-03 14:42:30 -08:00
sfc-gh-tclinkenbeard b1e3478267 Simplified global knobs 2020-11-21 13:27:48 -08:00
sfc-gh-tclinkenbeard 4669f837fa Add uses of makeReference 2020-11-07 22:10:18 -08:00
sfc-gh-tclinkenbeard a9607bdcec Explicitly seal classes that inherit but aren't inherited from 2020-10-07 21:58:24 -07:00
sfc-gh-tclinkenbeard 8571dcfe28 Use override where applicable in fdbserver 2020-10-07 18:41:19 -07:00
Markus Pilman 268ba0bddc Merge remote-tracking branch 'origin/release-6.3' into merge-6.3 2020-10-01 14:14:06 -06:00
Evan Tschannen 1a28520eb4 fix: fdbcli would double count satellite DCs 2020-09-30 17:42:22 -07:00
Balachandar Namasivayam c7a55fe15f
Merge pull request #3829 from yliucode/process-class
Support specifying proxy as process class and converting it to commit proxy
2020-09-30 16:46:24 -07:00
Young Liu 0c579674e6 Add more help messages for configuring 'proxies' 2020-09-30 13:29:01 -07:00
sfc-gh-tclinkenbeard 6c726ba8dd Improve ConfigurationResult and CoordinatorsResult type safety 2020-09-27 15:29:15 -07:00
sfc-gh-tclinkenbeard 4dda6f4163 Replace NULL with nullptr in fdbcli 2020-09-20 11:33:17 -07:00
Meng Xu cf69f455a9
Merge pull request #3785 from apple/release-6.3
Merge Release 6.3 to master
2020-09-17 14:43:56 -07:00
Young Liu cc5bc16bd8 Rename more places from proxy to commit proxy 2020-09-15 22:29:49 -07:00
Young Liu 35bef73a1c Rename proxy to commit proxy 2020-09-10 17:44:15 -07:00
Young Liu 1867ee1f5f Change cli output format 2020-09-09 22:34:36 -07:00
Young Liu 1615bd1a1d minor improvement 2020-09-09 13:57:26 -07:00
Young Liu 1155d015c9 fetch current log generation as well 2020-09-09 11:54:58 -07:00
Young Liu 63b3612ad5 Merge master branch and resolve conflicts 2020-08-24 16:42:31 -07:00
XiaoxiWang d8a508ce7e fix command line parse 2020-08-21 17:49:21 +00:00
XiaoxiWang 9398a78a3a add busy-read count and busy-write count to status json 2020-08-21 04:50:56 +00:00
XiaoxiWang 7dcce6979e format 2020-08-20 07:00:37 +00:00
XiaoxiWang 0945959a35 add fdbcli support to list recommended tags 2020-08-20 06:26:31 +00:00
Young Liu 79ce16650d merge master branch 2020-08-11 19:22:10 -07:00
Jon Fu a707227092 initial commit to add cache_range to fdbcli 2020-08-06 12:23:31 -04:00
Young Liu d6a23a4d6b Resolve comments to make GRV proxy a separate process class 2020-08-06 00:01:57 -07:00
Meng Xu 62a6e71626
Merge pull request #3591 from apple/release-6.3
Merge Release 6.3 to master
2020-08-02 12:45:02 -07:00
Andrew Noyes 87098afdb4 Add braces around ifs 2020-08-02 17:26:35 +00:00
Andrew Noyes 2d0449dcd6 RebootRequest uses seconds, not ms 2020-08-02 02:19:09 +00:00
Chaoguang Lin de3f243dc1 Fix \xff\xff/worker_interface call in fdbcli 2020-08-01 01:59:48 -07:00
Chaoguang Lin 29f4381c01 Deprecate \xff\xff/suspend in 7.0 2020-08-01 01:09:45 -07:00
Chaoguang Lin d9e5d65aaf Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-08-01 00:31:26 -07:00
Chaoguang Lin fbe36ced23 Rewrite all \xff\xff/reboot_worker call 2020-07-31 16:33:16 -07:00
Chaoguang Lin 05a0a47824 throw actor_cancelled error 2020-07-30 22:15:22 -07:00
Andrew Noyes 29e328cf32 Use addressExcluded to compare exclusions and addresses
Don't convert the exclusion to a NetworkAddress use operator==, since that's problematic for two reasons:

1. The network address of the not-yet-excluded server might compare differently due to flags like private or public
2. The network address of the not-yet-excluded server will never compare equal to a whole-machine exclusion
2020-07-27 18:52:07 +00:00
Andrew Noyes 09cf3e2883 Revert "Use IPAddress instead of NetworkAddress for exclude"
This reverts commit 331ee4dab4.
2020-07-27 18:38:57 +00:00
Andrew Noyes 331ee4dab4 Use IPAddress instead of NetworkAddress for exclude
NetworkAddress has other fields like flags that aren't relevant for
exclude. Network addresses with equal ip addresses not comparing equal
appears to be the cause of #3565
2020-07-27 05:40:14 +00:00
Evan Tschannen e1dedff7b3 Merge branch 'release-6.2' into release-6.3
# Conflicts:
#	CMakeLists.txt
#	bindings/c/test/mako/mako.c
#	cmake/ConfigureCompiler.cmake
#	documentation/sphinx/source/downloads.rst
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/FileBackupAgent.actor.cpp
#	packaging/msi/FDBInstaller.wxs
#	versions.target
2020-07-24 12:10:44 -07:00
Evan Tschannen 5a8a8153ce updated documentation 2020-07-23 11:22:16 -07:00
Evan Tschannen f5e7ee23a8 updated text of fdbcli output 2020-07-23 11:09:59 -07:00
Young Liu 229ab0d5f1 Fix some conflicts and remote debugging trace events 2020-07-22 23:35:46 -07:00
Evan Tschannen 49bf42e66a added the ability to suspend processes from fdbcli 2020-07-22 16:37:00 -07:00
Young Liu 302cf5c45f Remove debug trace events 2020-07-22 12:20:22 -07:00
Young Liu 5b06d69d25 Pass watches test 2020-07-15 00:37:41 -07:00
A.J. Beamon cff0c485b0 Update a comment to remove use of word blacklist 2020-06-15 15:27:35 -07:00
A.J. Beamon e10704fd76 Cherry-pick region related status changes from 6.3 2020-06-09 14:56:21 -07:00
A.J. Beamon 57390bfbc5
Merge pull request #3263 from apple/release-6.2
Merge release-6.2 into release-6.3
2020-05-28 14:14:38 -07:00
A.J. Beamon 382666d21e Permissions were wrong on installed files. A missing DESTINATION for fdbserver caused the binary to be missing. 2020-05-28 10:33:09 -07:00
A.J. Beamon b3c269351a
Merge pull request #3252 from apple/release-6.2
Merge release-6.2 into release-6.3
2020-05-27 19:13:24 -07:00
A.J. Beamon 96f396ec7f Make sure to build the binary stripping targets when packaging stripped binaries 2020-05-27 16:40:07 -07:00
A.J. Beamon 12225c0f46 Adopt consistent use of ... for repeating arguments 2020-05-27 15:27:47 -07:00
A.J. Beamon a632b26beb Add documentation for several fdbcli commands that were present in fdbcli help but were not in our online documentation. 2020-05-27 13:29:01 -07:00
A.J. Beamon d6be580319 Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
# Conflicts:
#	documentation/sphinx/source/command-line-interface.rst
#	documentation/sphinx/source/release-notes.rst
#	fdbcli/fdbcli.actor.cpp
2020-05-27 11:42:27 -07:00
A.J. Beamon e4b1489a0e
Merge pull request #3202 from ajbeamon/cmake-use-stripped-binaries-for-packages
cmake: use stripped binaries for packages unless generating debug packages
2020-05-27 11:36:38 -07:00
A.J. Beamon 1f1a8df7ef Auto completion for "throttle disable auto" were wrong because of logical operator grouping problems. 2020-05-22 09:48:53 -07:00
A.J. Beamon 2f9cd383ea Use stripped executables in packages when not building with debug symbols. 2020-05-21 13:39:55 -07:00
tclinken 3a8efb2d0b Added advanceversion command to fdbcli 2020-05-20 15:47:31 -07:00
tclinken 40aec61d30 Added fdbcli getversion command 2020-05-20 15:47:30 -07:00
tclinken 4f5bf41ed8 Print explanation when fdbcli unlock fails 2020-05-20 15:47:30 -07:00
tclinken 9c6bec1af6 Add unlock command to fdbcli 2020-05-20 15:47:30 -07:00
tclinkenbeard b3aa54e7eb Add lock command to fdbcli 2020-05-20 15:47:30 -07:00
A.J. Beamon cc4874918a Merge branch 'release-6.3' into tag-throttling-by-priority
# Conflicts:
#	fdbserver/Ratekeeper.actor.cpp
2020-05-20 14:26:35 -07:00
Evan Tschannen a3d4f3f4de
Merge pull request #3175 from ajbeamon/fdbcli-throttle-improve-hints-and-completion
Better hint and completion help with throttle command in fdbcli
2020-05-20 14:25:03 -07:00
A.J. Beamon b589c3c940 Remove IncludeVersions.h, which is no longer needed for cmake-only builds 2020-05-20 13:23:02 -07:00
A.J. Beamon 14b23c146f Support throttling and unthrottling tags by priority and their auto/manual state in fdbcli. 2020-05-15 12:47:55 -07:00
A.J. Beamon f1477b09e9 Better hint and completion help with throttle command in fdbcli. 2020-05-14 16:04:03 -07:00
Andrew Noyes 8bd5dcaff8 Merge branch 'master' into atn34/special-key-versioning 2020-05-09 15:34:20 -07:00
Andrew Noyes a7c21cdadd Use new worker_interfaces key range in fdbcli 2020-05-08 05:37:37 +00:00
A.J. Beamon b1055a8501 Merge branch 'master' into transaction-tagging 2020-05-05 16:03:39 -07:00
Alex Miller 78d644f673
Merge branch 'master' into bugfixes/cmake-includes 2020-05-04 02:11:46 -07:00
A.J. Beamon decf3e82b0 Fix various bugs and make sure to cleanup throttles from the database when they expire 2020-05-01 21:36:28 -07:00
A.J. Beamon 41c517a5dd Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbclient/NativeAPI.actor.cpp
2020-04-27 13:05:24 -07:00
A.J. Beamon 239876351b Add some initial auto-throttling. Move the definition of the priority enum to a more global place and use it for all transaction priorites (except in ClientLogEvents, because of serialization incompatibilites). 2020-04-24 11:31:16 -07:00
A.J. Beamon 35c18ac60a Improvements to expiration. Encode throttles with auto/manual and priority in the key to support throttling the same tag with different values in these parameters. 2020-04-23 20:50:40 -07:00
A.J. Beamon f1dd0ee298 Protect against a ratekeeper starting up with a clock set in the past (compared to old ratekeeper) extending the duration of throttles excessively. 2020-04-21 16:35:25 -07:00
A.J. Beamon 78d48a0dad Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/Knobs.h
#	fdbclient/NativeAPI.actor.cpp
#	fdbclient/fdbclient.vcxproj
#	fdbserver/MasterProxyServer.actor.cpp
2020-04-17 09:23:18 -07:00
A.J. Beamon 2b66dcd24a Some more refactoring. Reduce what is sent from RK->MP->clients 2020-04-17 08:07:01 -07:00
A.J. Beamon 0fba8c47be Checkpoint: Ratekeeper sets absolute limits for tag throttles and enforces them by distributing requests to proxies, who distribute them to clients.
A few refactorings.
2020-04-16 14:43:22 -07:00
tclinken 93400d25c8 Added advanceversion command to fdbcli 2020-04-15 20:01:01 -07:00
A.J. Beamon bcb0a4cc78
Merge pull request #2890 from tclinken/expose-lock-fdbcli
Add lock and unlock commands to fdbcli
2020-04-10 13:54:47 -07:00
A.J. Beamon 7f3fa00897 Reorganize a bit of code. 2020-04-10 13:53:23 -07:00
A.J. Beamon 55a0d00ad4 Encoding of tags in the database now supports multiple tags per throttle. Remove throttle prefix search. 2020-04-10 10:12:26 -07:00
tclinken b44105b54c Print explanation when fdbcli unlock fails 2020-04-08 16:38:30 -07:00
A.J. Beamon af4e0088ba
Merge pull request #2896 from tclinken/atomically-update-dependent-knobs
Atomically update dependent knobs
2020-04-08 15:00:49 -07:00
tclinken 52860043c9 Merge remote-tracking branch 'origin' into atomically-update-dependent-knobs 2020-04-08 12:26:21 -07:00
A.J. Beamon 36da61dd9c Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbclient/NativeAPI.actor.cpp
#	fdbclient/vexillographer/fdb.options
2020-04-07 21:12:14 -07:00
A.J. Beamon a1d8623e5f Various changes to the throttling scheme, including most notably that clients now enforce the throttles with info they receive from the proxy. 2020-04-07 16:28:09 -07:00
Markus Pilman d4542dbb5a Delete old build system 2020-04-07 11:03:45 -07:00
Markus Pilman e4611e8ae4 fix versions.h stupidity 2020-04-06 10:28:55 -07:00
Markus Pilman 8b5780c36c don't include source and binary dir
This forces users to use include paths from the sources root.

So `#include "Arena.h"` won't work anymore, only
`#include "flow/Arena.h"` will.
2020-04-06 10:13:49 -07:00
A.J. Beamon 2336f073ad Checkpointing a bunch of work on throttles. Rudimentary implementation of auto-throttling. Support for manual throttling via fdbcli. Throttles are stored in the system keyspace. 2020-04-03 15:24:14 -07:00
A.J. Beamon 638369492f
Merge pull request #2863 from dongxinEric/feature/2290/expose-region-config-via-status-default-or-details
Expose region related configurations in status
2020-04-03 11:42:43 -07:00
Xin Dong eaae9397e5 Address review comments 2020-04-02 11:04:58 -07:00
Markus Pilman bbd2fe62cc Merge branch 'master' of github.com:apple/foundationdb into features/boost70 2020-04-02 09:21:01 -07:00
tclinken aa7d5d8816 Add unlock command to fdbcli 2020-04-01 17:39:16 -07:00