7cb61c766b
Fix tLogLocalities for current LogSet
...
In toCoreState(), the serialization of current LogSet is different from old
TLog sets. The locality data should be generated, not copied over.
Found by:
-r simulation --crash -f tests/fast/KillRegionCycle.txt -s 254666356 -b on
2019-04-21 10:41:07 -07:00
8b67da57bb
Fix upgrade test failure
...
Serialize pseudoLocalities if protocol version is larger than 0x0FDB00B061060001LL.
Note this version may need to be changed to "currentProtocolVersion" when merging
into the master, and "currentProtocolVersion" should be incremented.
2019-04-21 10:41:07 -07:00
9e8ffd2ff7
Refactor OldLogData ctor
2019-04-21 10:41:07 -07:00
97986a28b7
Replace push_back with emplace_back for efficiency
...
And better code readability.
2019-04-21 10:41:07 -07:00
010f825aff
Remove pseudoLocalities from LogSet, TLogSet, and CoreTLogSet
2019-04-21 10:41:07 -07:00
7befce6bf1
More pseudoLocalities and refactors.
2019-04-21 10:41:07 -07:00
66000a07a5
Use emplace_back instead of push_back
2019-04-21 10:41:07 -07:00
966ec30fcc
Add pseudoLocalities for special tag consumers
2019-04-21 10:41:07 -07:00
b4e7e7a85b
Refactor StorageCache updates
2019-04-21 10:41:07 -07:00
82ec80c42f
Refactor TLogSet ctor
2019-04-21 10:41:07 -07:00
d19b0cf1c1
Refactor LogSet with two new constructors
2019-04-21 10:41:07 -07:00
0b1984978a
Small code refactoring.
2019-04-21 10:41:07 -07:00
ec1bc5cfca
Add LogSystemType enum
2019-04-21 10:41:07 -07:00
05c19247b7
Merge pull request #1474 from jzhou77/fix-traceevent
...
Fix unit test failure due to trace event names
2019-04-21 10:37:15 -07:00
e7ee61660c
Fix unit test failure due to trace event names
...
Capitalize the first letter.
2019-04-20 10:19:53 -07:00
65c297bd75
Merge pull request #1465 from atn34/fix-open-for-ide-build
...
Fix OPEN_FOR_IDE -Wunused-variable warnings
2019-04-19 15:08:00 -07:00
40d632b341
Merge pull request #1470 from mpilman/fixes/windows-parallel-build
...
Don't pass options file to coverage tool
2019-04-19 13:08:23 -07:00
d1e86779a6
Address review comments
2019-04-18 08:48:27 -07:00
5af8208c62
Fix JavaWorkload unused variable
2019-04-17 16:29:22 -07:00
33b6e4ec3e
Add /MP option to compiler to allow for more parallelism
2019-04-17 16:13:34 -07:00
ef04471a66
Fix more unused-variable warnings
2019-04-17 16:04:10 -07:00
13ba915a19
Fix more unused variable warnings
2019-04-17 15:38:08 -07:00
8ef453eb2e
Don't pass options file to coverage tool
...
This hopefully fixes a weird msbuild issue where files are generated
more than once. This issue is described here:
https://gitlab.kitware.com/cmake/cmake/issues/16767
This workaround makes coverage_tool not to use the generated options
files, which hopefully will result in msbuild not trying to generate
these files more than once.
2019-04-17 12:10:51 -07:00
6888baf1c3
Fix compile error
2019-04-16 15:44:55 -07:00
08e66d1764
Prefer success to cast-to-void
2019-04-16 15:29:03 -07:00
781b6ece77
Fix OPEN_FOR_IDE -Wunused-variable warnings
...
CC #1255 , #1173
2019-04-16 15:28:01 -07:00
6327c78bac
Merge pull request #1464 from atn34/review-comments
...
Address review comments from #1446
2019-04-16 14:11:24 -07:00
75b9369583
Make checksumHistoryBudget optional
...
See https://github.com/apple/foundationdb/pull/1446#discussion_r275933381
2019-04-16 12:55:53 -07:00
baa3e806ef
Address review comments from #1446
2019-04-16 09:48:15 -07:00
247f95a6e2
Add -Wunused-variable
2019-04-15 18:13:00 -07:00
6207d724f8
Fix all -Wunused-variable warnings
2019-04-15 18:13:00 -07:00
5586f44303
Fix return code plumbing
2019-04-15 18:08:45 -07:00
b90cea4cf3
Merge pull request #1462 from atn34/assert-size-gt-zero
...
Avoid potential index-out-of-bounds
2019-04-15 16:17:36 -07:00
6c7fd1593f
Avoid potential index-out-of-bounds
2019-04-15 15:20:09 -07:00
77843e8494
Merge pull request #1456 from atn34/trace-format-fixes
...
Trace format fixes
2019-04-15 10:19:22 -07:00
dced9232d0
ASSERT_WE_THINK trailing byte is '\0'
2019-04-15 09:43:26 -07:00
a74cccae95
Merge pull request #1458 from atn34/fix-typos
...
Fix a few typos
2019-04-13 21:23:29 -07:00
0dd57dd454
Fix a few typos
2019-04-13 17:29:30 -07:00
369c1a0230
Exclude trailing \0 byte for string literals
...
This will "do the right thing" as long as no one expects something like
char a[] = {'a'};
TraceEvent("Event").detail("a", a);
to trace `{..., "a": "a"}`.
It will trace `{..., "a": ""}`
2019-04-11 10:39:48 -07:00
1135331ce6
Include space as a printable character
2019-04-11 10:01:06 -07:00
cd5c9d91fa
Merge pull request #1443 from etschannen/master
...
Merge 6.1 into master
2019-04-10 17:43:07 -07:00
61864860be
Merge pull request #1449 from tclinken/fix-base16char-bug
...
Handle negative input to base16Char
2019-04-10 11:15:38 -07:00
a9b1b32fde
Handle negative input to base16Char
...
base16Char was being called with (c < 0), causing a failed assertion.
2019-04-09 18:14:09 -07:00
6220a5ce0f
Merge pull request #1370 from jzhou77/fix-unreferenced
...
Remove unused functions
2019-04-09 11:49:45 -07:00
058d028099
Merge pull request #1301 from mpilman/features/cheaper-traces
...
Defer formatting in traces to make them cheaper
2019-04-09 10:11:04 -07:00
af17babb9a
Restore a deleted comment line
2019-04-09 09:38:45 -07:00
e4746888eb
Removed dead code
2019-04-09 09:08:45 -07:00
21c0ba555c
Merge branch 'release-6.1'
...
# Conflicts:
# documentation/sphinx/source/release-notes.rst
# versions.target
2019-04-08 18:38:42 -07:00
9d632e4a85
Merge pull request #1442 from etschannen/post-release-cleanup-6.1.1
...
Post release cleanup 6.1.1
2019-04-08 18:33:01 -07:00
19e0fb15e7
update installer WIX GUID following release
2019-04-08 18:32:25 -07:00
Jingyu Zhou