Commit Graph

34 Commits

Author SHA1 Message Date
gxglass b4fb2f439e
Misc small changes and FIXME comment additions from reading fdbrpc code (#12395)
Small changes accumulated while reading through a bunch of files in fdbrpc (mostly).

Throughout: add FIXME comments where it would be useful to have a comment explaining something or suggesting a change of some kind.

Several places: rename a variable to get a better name

A few places: delete code that has been commented out for > 5 years

A few places: delete useless or apparently out of date, incorrect comments

One place: delete a function that has no callers

One place: reorder methods, listing them in the order which users are to call them (i.e. the natural order for explanation)

One or more places: delete unneeded FIXME comments

network.h: put the function comments before the functions they describe

* put function comments before the function they describe

* add fixme comment

* setLocalAddress had an obviously broken function comment.  Then I noticed nobody was calling it.  So delete it

* QueueModel.h: list methods and comments in order that methods are to be called by users; remove a many years old commented out block of code

* fdbrpc.h: FIXMEs to request explanations of Public and Private

* Add a variety of FIXME comments to FlowTransport.cpp to be revisited later

* add FIXMEs for comment additions; remove useless or outdated comments; rename a variable for clarity; other very cosmetic updates

* add FIXMEs for suggested comments; rename a variable; delete one or more useless comments

* simplify some FIXME comments

* add one space to address CODE FORMAT CLEAN CI check

* Updates based on code review comments

* fix comment
2025-09-26 11:43:19 -07:00
Syed Paymaan Raza c3e7542cda Update end year in copyright header 2024-08-02 09:40:11 -07:00
Sreenath Bodagala 93b62f6299
- Cleanup error/trace messages logged in the context of replica comparison (#11467) 2024-06-18 17:33:19 -04:00
Sreenath Bodagala a4430b9169
Compare storage replicas on reads (#11235)
* - Compare storage replicas on reads (in "loadBalance()")

* - Do consistency check on reads in loadbalance

* - Do replica consistency check in the case where loadBalance issues
requests to multiple storage servers

* - Address a state variable related bug

* - Code formatting

* - API simplification

* - Simplify code

* - Code formatting

* - Address a review comment
2024-04-11 16:08:54 -04:00
Dimitris Apostolou a88114c222
Fix typos 2024-02-07 01:16:00 +02:00
neethuhaneesha 854464a6af
Hex values in TSS logs and rocksb debuglogs mode knob (#10231) 2023-05-16 10:34:58 -07:00
Jingyu Zhou f17e466aa4
Remove printable() from TSS trace events (#9889) 2023-04-04 08:46:39 -07:00
A.J. Beamon b10d1f227b Remove tenant name from the TenantInfo object 2023-01-20 14:04:43 -08:00
Josh Slocum 96574bacaa
Change Feed TSS Support (#8384)
* Change Feed TSS Support

* bug fixing for rare mismatch cases

* Adding rollback handling to tss change feed comparison
2022-10-12 10:23:51 -05:00
Markus Pilman 56541167c2 send token with tenant info object 2022-07-06 20:58:17 -06:00
Markus Pilman 03d913a1de Flow compiling 2022-06-27 17:05:55 -06:00
sfc-gh-tclinkenbeard a71099471b Update copyright header dates 2022-03-21 13:36:23 -07:00
Josh Slocum 5d1affa2c2 Cleaning up and improving TSS debugging traces for range read mismatches 2022-03-11 11:38:58 -06:00
Tao Lin e2c7c30faf
GetMappedRange support serializable & check RYW & continuation (#6181) 2022-03-10 10:05:44 -08:00
A.J. Beamon c99c7cf55f Apply tenant prefixes on the storage server. The commit proxy can serve tenant location requests. Fix some bugs. 2022-03-06 21:54:21 -08:00
Tao Lin fdb3b72e35 Introduce GetRangeAndFlatMap to push computations down to FDB
Re-introduce #5609
2021-11-09 13:52:28 -08:00
Tao Lin 586cc3b102
Revert "Introduce GetRangeAndFlatMap to push computations down to FDB" 2021-11-04 08:46:56 -07:00
Tao Lin 6c98e35893 Rename Hop to FlatMap 2021-11-03 13:32:01 -07:00
Tao Lin 0853661d13 Introduce getRangeAndHop to push computations down to FDB 2021-11-03 13:21:16 -07:00
Josh Slocum 773886515e Merge branch 'feature-range-feed' into blob_full_clean 2021-10-22 11:07:51 -05:00
Evan Tschannen 3f7df58a77 fixed a number of issues 2021-10-19 13:56:52 -07:00
Suraj Gupta a4bcd3919d Add exclusive process class for Blob Worker.
Also introduces a specific machine in the simulated cluster
to test blob worker (similar to what's done for storage cache).
2021-09-23 16:54:44 -04:00
Josh Slocum c2d1d1704f Merge branch 'feature-range-feed' into blob_full 2021-09-10 11:21:52 -05:00
Evan Tschannen ac5b580e2d Merge branch 'master' into feature-range-feed
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/StorageServerInterface.cpp
#	fdbclient/StorageServerInterface.h
#	fdbserver/ApplyMetadataMutation.cpp
#	fdbserver/TLogServer.actor.cpp
#	flow/error_definitions.h
2021-09-09 23:13:22 -07:00
Josh Slocum 714aca4f3c Refactored blob granule reads to actually be in NativeAPI 2021-08-25 15:01:38 -05:00
Evan Tschannen a278d2977a renamed range feeds to change feeds, data distribution support almost complete 2021-08-13 14:27:15 -07:00
Josh Slocum e444d3781c Various TSS improvements from snowblower testing 2021-08-13 10:24:15 -05:00
Evan Tschannen 27f87471ab fixed compile errors 2021-08-09 12:48:38 -07:00
Evan Tschannen e9409b02fe fixed the build 2021-07-28 14:02:12 -07:00
Josh Slocum 9f1afbb709 Added Streaming Read comparison for TSS 2021-07-01 19:00:05 -05:00
Josh Slocum 56dadaa428 TSS Mismatch Changes 2021-06-11 23:13:16 +00:00
Josh Slocum a3a5519b7c Fixing valgrind error in TSS StorageServerInterface unit test 2021-06-03 15:56:27 +00:00
Josh Slocum 4257ac2b4d More TSS Changes/Fixes 2021-05-25 20:37:48 +00:00
Josh Slocum ce82c9653e Testing Storage Server implementation 2021-05-25 20:28:50 +00:00