Chaoguang Lin
731ee8a121
Update ChangeConfig to test coordinators special keys
2021-02-16 13:01:37 -08:00
Chaoguang Lin
3def9731a4
Merge branch 'master' of github.com:apple/foundationdb into add-coordinators-into-special-keys
2021-02-08 18:52:45 -08:00
Chaoguang Lin
b10959be0f
format code, add trace
2021-02-08 18:52:36 -08:00
A.J. Beamon
aaf0a9aa7b
Merge branch 'release-6.3' into merge-release-6.3-into-master
...
# Conflicts:
# build/docker-compose.yaml
# cmake/ConfigureCompiler.cmake
# fdbclient/FileBackupAgent.actor.cpp
# fdbrpc/AsyncFileCached.actor.h
# fdbrpc/IAsyncFile.h
# fdbrpc/IRateControl.h
# fdbrpc/simulator.h
# fdbserver/KeyValueStoreSQLite.actor.cpp
# fdbserver/storageserver.actor.cpp
# fdbservice/ServiceBase.cpp
2021-02-08 12:58:34 -08:00
A.J. Beamon
67e783acf8
Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
...
# Conflicts:
# cmake/CompileBoost.cmake
# cmake/FDBComponents.cmake
# fdbrpc/AsyncFileCached.actor.h
# fdbrpc/simulator.h
# fdbserver/KeyValueStoreSQLite.actor.cpp
# fdbserver/Knobs.cpp
# fdbserver/Knobs.h
# fdbserver/storageserver.actor.cpp
# flow/Knobs.h
# flow/network.h
2021-02-08 09:20:28 -08:00
Steve Atherton
8547abbbe4
Bug fix: In simulation, KVStoreSQLite can outlive its process during a simulated reboot so its file references must be cleared explicitly during shutdown instead of implicitly during destruction. Re-enabled a useful trace event. Some cleanup, removed unnecessary member var initializer and removed unnecessary method.
2021-02-05 21:26:39 -08:00
Trevor Clinkenbeard
2521e74780
Merge pull request #4281 from sfc-gh-ajbeamon/fix-trace-event-name
...
Fix a trace event name that has a space in it
2021-02-05 14:23:28 -08:00
Chaoguang Lin
ae561fcefc
Merge branch 'master' of github.com:apple/foundationdb into add-coordinators-into-special-keys
2021-02-05 14:15:50 -08:00
A.J. Beamon
f636913f92
Fix a trace event name that has a space in it
2021-02-05 13:37:57 -08:00
A.J. Beamon
5e80e16802
Revert "CDs reject requests from external cluster or requests need to be forwarded based on an old forward request."
2021-02-05 13:05:33 -08:00
Andrew Noyes
46f98c8705
Update fdbserver/CMakeLists.txt
...
Co-authored-by: Markus Pilman <markus.pilman@snowflake.com>
2021-02-05 08:21:45 -08:00
Chaoguang Lin
d185ff3752
update \xff\xff/configuration/coordinators/processes
2021-02-05 00:55:34 -08:00
Evan Tschannen
8091d8179d
Merge pull request #4252 from dongxinEric/feature/4251/cds-reject-requests-from-other-cluster
...
CDs reject requests from external cluster or requests need to be forwarded based on an old forward request.
2021-02-04 17:33:07 -08:00
Andrew Noyes
db82da5bc2
Only link to jemalloc in fdbserver
...
Including jemalloc in libfdb_c seems to be problematic, since it's
apparently not recommended to dlopen jemalloc:
https://github.com/jemalloc/jemalloc/issues/937#issuecomment-311242450
2021-02-05 01:30:31 +00:00
Xin Dong
c017b51d66
Fix typo
2021-02-04 13:35:40 -08:00
Xin Dong
549e51f7d6
Fix usage of the new knob value.
2021-02-04 12:43:08 -08:00
Andrew Noyes
08997d8602
Fix bugs turned up by _GLIBCXX_DEBUG
...
Compiling with -D_GLIBCXX_DEBUG enables libstc++ "debug mode", where
additional debug information is tracked with iterators and reported if
iterators are misused. This turned up two bugs.
I threw in removing dead code and avoiding an unnecessary map lookup
while I was in the neighborhood.
2021-02-04 02:37:51 +00:00
Meng Xu
1db4b73215
Merge pull request #4243 from sfc-gh-etschannen/feature-storage-io-timeout
...
throw an io_timeout if it takes more than 2 minutes to commit on the storage server
2021-02-03 18:10:16 -08:00
Meng Xu
675e567305
Merge pull request #4218 from sfc-gh-etschannen/feature-low-priority-reads-6.2
...
Reduce read priority when durability lag is high
2021-02-03 18:09:39 -08:00
Evan Tschannen
164ef39254
more fixes
2021-02-03 16:58:36 -08:00
Evan Tschannen
ed7ec2b728
another attempt to fix compile errors
2021-02-03 16:53:08 -08:00
Evan Tschannen
89651e2461
fix compile error
2021-02-03 16:38:13 -08:00
Evan Tschannen
068647ba1b
updated naming and comments
2021-02-03 14:24:39 -08:00
Evan Tschannen
c4b622e7b8
added a comment and updated a variable name
2021-02-03 13:58:04 -08:00
Evan Tschannen
bb5352deb0
applied clang-format
2021-02-03 13:52:54 -08:00
Evan Tschannen
b2ffdf47f0
added low priority reads to status
2021-02-03 13:24:34 -08:00
Evan Tschannen
a0a71ff7f9
simplified the algorithm based on testing
2021-02-02 17:53:07 -08:00
Evan Tschannen
40d855943c
temporarily disable disk stalls in simulation
2021-02-02 17:33:47 -08:00
Chaoguang Lin
769a3148ba
Format code
2021-02-02 14:36:49 -08:00
Steve Atherton
45262f6702
Fix comment.
2021-02-02 14:26:39 -08:00
Chaoguang Lin
f6342376ab
Update the knob name
2021-02-02 13:31:00 -08:00
Chaoguang Lin
593165679a
Remove unnecessary header
2021-02-02 12:42:46 -08:00
Chaoguang Lin
17671604c0
Add option to define I/O size
2021-02-02 12:39:05 -08:00
Russell Sears
84bb5412f8
Merge pull request #4201 from Daniel-B-Smith/rocksdb-prefix
...
Add knobs for prefix bloom filters and larger block cache
2021-02-01 15:29:28 -08:00
Xin Dong
1cc8c1d8ec
Guard CD's cross cluster check behind a KNOB controlled flag and disable it by default.
2021-02-01 14:39:30 -08:00
Daniel Smith
de700b83f2
Review fixes
2021-02-01 21:58:39 +00:00
Xin Dong
4e81b9275b
Allow the user to diable forward expiry check by setting the threshold to -1
2021-02-01 10:50:04 -08:00
Markus Pilman
e4b953ab38
Merge pull request #4229 from sfc-gh-satherton/afcache-write-limit
...
AsyncFileCached RateControl support and bug fixes
2021-01-31 15:13:03 -07:00
Markus Pilman
824145a074
Merge pull request #4258 from KrzysFR/windows/clang
...
Build on Windows using VS 2019 + LLVM/Clang
2021-01-31 15:10:25 -07:00
Steve Atherton
d607ba3ac1
Removed merge artifact which calls functions not present in release-6.2.
2021-01-31 03:59:36 -08:00
Chaoguang Lin
15aa877388
Use VFSAsyncFile::checkInjectedError() to replace old injected fault detection, see pr#4212
2021-01-30 18:25:43 -08:00
Steve Atherton
bb6608ccd8
Another bug fix in SQLite file instance lifetimes. Writer can be destroyed before doClose() or stopOnError() have a chance to react, so Writer can't be used to get access to file handles to remove the rate limiter and trigger pending requests to complete. New logic is for Writer initialization to place opened file handles in KeyValueStoreSQLite instance and move disableRateControl() there, to be called from doClose().
2021-01-30 18:23:50 -08:00
Steve Atherton
4982787a80
Another attempt to fix SQLite lifetime issues. KeyValueStoreSQLite::doClose() can now access the Writer instance and call disableRateControl() on its SQLiteDB instance prior to stopping the reader and writer thread pools. This should prevent rate limiting from interfering with SQLite shutdown.
2021-01-30 18:18:36 -08:00
Steve Atherton
b0fd6bfbcf
More bug fixes in SQLite file handle lifetimes after storage server restart (including simulated process reboot) when a write rate limit is used. Added several debug trace events, renamed some VFSAsync* events to be more consistent.
2021-01-30 18:18:16 -08:00
Steve Atherton
52c2695f59
Bug fixes involving use of AFCached rate control in simulation.
2021-01-30 18:13:44 -08:00
Steve Atherton
e56fe02a25
Merge branch 'add-throttling-on-AsyncfileCached' of github.com:sfc-gh-clin/foundationdb into afcache-write-limit
2021-01-30 18:11:54 -08:00
Steve Atherton
14af5857ed
Another refactor of SQLite injected error handling to address failures of the previous attempt. Some code cleanup. Added documentation of injected error handling works and why.
2021-01-30 18:06:05 -08:00
Steve Atherton
e72d486215
Refactored how injected fault state is managed to make debugging injected fault handling easier. Moved injected error tracking for open() into an INetwork global since it should be unique per simulated process. Fixed bug where injected error in WAL file was not recognized as injected because it occurred before SQLiteDB's vfsWAL pointer was initialized. Simplified logic in SQLiteDB. Added comments.
2021-01-30 18:06:04 -08:00
Steve Atherton
1a5c40fcef
Bug fixes: Check for null pager and wal pointers, and initialize vfsWAL after SQLite has opened the WAL.
2021-01-30 18:06:04 -08:00
Steve Atherton
e1f8023577
Rewrote how injected faults are handled in SQLite to be more reliable and work with an upcoming write throttling feature in AsyncFileCached.
2021-01-30 18:06:04 -08:00