6de28dd916
clang-format
2021-04-14 10:56:33 -07:00
1260385965
Use object to wrap global configuration history
2021-04-14 10:56:32 -07:00
1c84c04ffc
Add global configuration prefix function
2021-04-14 10:56:32 -07:00
388344c31e
Better estimation for arena size
2021-04-14 10:56:32 -07:00
b7cd8175be
Add arena per object in global config
2021-04-14 10:56:32 -07:00
e5e48da5ce
Revert removal of history size check
2021-04-14 10:56:32 -07:00
e9e2ca54d6
Assert history contains data
2021-04-14 10:56:32 -07:00
70c4bbe119
Fix clear range persistence issue
2021-04-14 10:56:32 -07:00
4a799baa1d
Add clear range for global configuration
2021-04-14 10:56:32 -07:00
c3f68831af
Move existing ClientDBInfo variables to global configuration
2021-04-14 10:56:32 -07:00
80c6048a01
Naming fixes
2021-04-14 10:56:32 -07:00
9587318696
Fix crash when history size is 0
...
This shouldn't happen in normal operation (if ClientDBInfo has been
updated, that means at least one item should have been added to the
history). But there is old functionality that uses other ClientDBInfo
fields to send updates to all nodes, and until this functionality is
removed this check needs to be here.
2021-04-14 10:56:32 -07:00
2acefa2c82
Add double and float support to tuples
...
Note that this functionality is copied from bindings/flow/Tuple.cpp.
These classes should eventually be combined (see #4351 ).
2021-04-14 10:56:32 -07:00
96732810ff
Move actor implementation
2021-04-14 10:56:32 -07:00
c9b0d3dd4e
Fix memory leak
...
The map containing global configuration data had keys of type StringRef,
referencing data allocated in history arenas. When the old history
was deleted, this memory was no longer valid and some keys would point
to garbage memory.
2021-04-14 10:56:32 -07:00
7bb0b3d899
Use commit version for global configuration updates
...
FIXME: There is a memory issue where the underlying data for values set
in the `data` field of GlobalConfig will be freed shortly after being
set.
2021-04-14 10:56:32 -07:00
9e20b08976
Add float and double parsing
2021-04-14 10:56:32 -07:00
f1415412f1
Add global configuration framework implementation
2021-04-14 10:56:32 -07:00
a0430536f1
Remove knob BACKUP_INIT_SNAPSHOT_INTERVAL_SEC.
2021-04-14 10:41:41 -07:00
eab468fecc
Remove extra line caused by commit issue
2021-04-14 09:32:48 -07:00
1d362d8869
Merge remote-tracking branch 'origin/master' into features/actor-lineage
2021-04-14 09:55:04 -06:00
ebf37594f7
Change initialSnapshotIntervalSeconds from knob to a backup argument.
2021-04-13 19:22:13 -07:00
201ca568f9
Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli
2021-04-13 13:51:59 -07:00
feede1d2f6
Fix line length of test macro + comments to be within the 120 character limit
2021-04-13 10:48:52 -07:00
c8b27e71c5
Revert TraceEvent
...
We've found the problem (issue #4640 ), so we no longer need the TraceEvent.
2021-04-12 15:03:47 -07:00
ec95b649b0
Any can't be used as an index type
2021-04-12 09:51:59 -06:00
eb2fe0dbcf
added serializable containers
2021-04-12 09:48:53 -06:00
2efcf8efec
Merge remote-tracking branch 'sfc/features/actor-lineage' into features/actor-serialization
2021-04-12 09:34:03 -06:00
dc00d99626
Log FileBackupLogRangeStart before calling getLogRanges() in .
...
It will tell us if or why this function is legitimately trying to use too much ram. getLogRange() should normally return about 20 items in the result. If the inputs are trash, it could return far more.
If it isn’t the case, then there’s something else wrong that has corrupted something such that when we try to allocate memory.
2021-04-09 15:02:45 -07:00
6656557b6a
made internal collect method private
2021-04-09 15:25:11 -06:00
8a6473c08a
Apply suggestions from code review
...
Co-authored-by: Lukas Joswiak <lukas.joswiak@snowflake.com>
2021-04-09 15:23:42 -06:00
20d98421af
fix compiler errors
2021-04-09 15:16:07 -06:00
2064903705
collect and serialize
2021-04-09 14:25:11 -06:00
5e6655f111
Added temp space to StorageBytes.
2021-04-07 23:56:20 -07:00
f8786da688
Added StorageByte::toString() and printed it in Redwood direct perf test.
2021-04-07 20:14:16 -07:00
83cf965875
Add global variable to fetch each type of sample
2021-04-07 15:38:01 -07:00
130e520ad7
Use object lifetimes instead of function calls
2021-04-07 13:27:31 -07:00
d60011aa74
Update annotation class name
2021-04-07 13:27:31 -07:00
d6c4aa67d7
Sample actors waiting on network
2021-04-07 13:27:31 -07:00
551dfa6ad8
Move description of RESTORE_IGNORE_LOG_FILES to header file.
2021-04-07 10:21:24 -07:00
fadc9cccee
Use knob RESTORE_IGNORE_LOG_FILES in restore.
...
Rename IGNORE_LOG_FILES to RESTORE_IGNORE_LOG_FILES. Also, this knob should be used in regular restore, not parallel restore.
2021-04-07 10:05:56 -07:00
1b6ad42db8
Use a knob to completely ignore log files
2021-04-06 19:07:01 -07:00
cabf192f57
Respond to review comments 3/23
2021-04-06 13:05:09 -04:00
48a475366c
Log latency metrics for batch GRV requests
2021-04-06 13:05:09 -04:00
7e1d60c924
Format BACKUP_INIT_SNAPSHOT_INTERVAL_SEC like other knobs.
2021-04-05 22:53:36 -07:00
edb3dd4414
Control backup's initial snapshot interval via knob.
2021-04-05 18:25:18 -07:00
91afa3cc9c
Merge pull request #4515 from halfprice/zhewu/update-fault-tolerance-calculation
...
Populate min_replicas_remaining fields in the cluster status for all regions. This gives better picture of the data replicas currently exist in the database.
2021-03-31 13:06:17 -07:00
107f66e4e1
Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli
2021-03-30 16:35:41 -07:00
7d44af3fec
Merge pull request #4568 from jzhou77/master
...
Use the restored range in the actual restore
2021-03-30 09:58:31 -07:00
4c73e838ab
Fix a comment on backup log data location
2021-03-30 09:26:48 -07:00
2648d19edd
Update comment
2021-03-29 15:10:57 -07:00
2b4744ad8a
Reword comments.
2021-03-29 13:43:43 -07:00
e2bd500fa7
Remove debug trace
2021-03-29 11:57:14 -07:00
55ef40864f
Add comments for touched functions
2021-03-29 10:09:07 -07:00
1a0ef39e5d
Fix keyRangesFilter with logsOnly flag
...
Remove the Sev 40 trace event.
2021-03-27 21:48:27 -07:00
ff6e922c9d
Clang-format SpecialKeySpace.actor.cpp
2021-03-26 12:24:45 -07:00
747fa2a353
Merge branch 'master' of github.com:apple/foundationdb into add-dd-and-maintenance
2021-03-26 12:22:37 -07:00
0eff74f205
Add special keys for maintenance and datadistribution
2021-03-26 12:19:33 -07:00
c3aff4340f
Address merge conflicts
2021-03-26 11:36:02 -07:00
8d52abf048
Update fdbclient/vexillographer/fdb.options
2021-03-26 11:33:28 -07:00
c3ba4659ff
Document that ryw disable can only be set at beginning of transaction
2021-03-26 18:06:21 +00:00
a9d8806828
Use the restored range in the actual restore
2021-03-25 10:07:25 -07:00
3fefebb23a
Merge pull request #4554 from sfc-gh-satherton/restore-log-filtering2
...
Mutation log filtering during restore
2021-03-24 22:54:09 -07:00
720c0b3a4f
Added const.
...
Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>
2021-03-24 14:36:55 -07:00
ed811008ca
Merge pull request #4504 from sfc-gh-nwijetunga/network_busyness
...
Monitor Network Thread Busyness
2021-03-24 09:44:09 -07:00
a6136ffc62
Applied clang-format to recent changes.
2021-03-24 06:51:08 -07:00
17a19021fb
Added mutation batch filtering during restore, to the extent possible where each restore mutation log task only sees one block of data (usually 1MB) which can contain incomplete and therefore unfilterable mutation sets.
2021-03-24 06:38:50 -07:00
35f9fe08a2
Remove unnecessary header in IClientApi.h
2021-03-23 14:44:14 -07:00
de1c354b12
address pr comments
2021-03-23 20:56:37 +00:00
7f4bde74ef
Add some documentation
2021-03-18 23:34:44 +00:00
73571ad52e
Merge branch 'master' of github.com:sfc-gh-nwijetunga/foundationdb into network_busyness
...
* 'master' of github.com:sfc-gh-nwijetunga/foundationdb: (55 commits)
Port lost changes from #4004
Fix markdown
Factor our refreshTransaction gadget
Align FastAllocator memory to 4096 for size >= 4096
Fix heap-use-after-free's
Disable lsan in joshua
Manually apply changes made to BackupContainer.actor.cpp on release-6.3 to the new files where that code is located.
add release branch instructions
Fix PR number in release note link
fixed a simulation bug where a process on an unreliable machine would be considered reliable by the simulator
Add tini as PID 1 to docker image (#4363 )
Fix typo
Fix broken_promise bug
Explain FastAllocator<4096> special case
Inform LSAN that we have unaligned pointers
apply clang-format to flow/Platform.h
Fix typos
Address review comments
Change the macro that forbids exit() calls to be a static assertion
Add versionstamp serialization information
...
2021-03-18 18:58:43 +00:00
0919eff187
Fix data race in fdb_get_server_protocol
2021-03-18 18:24:12 +00:00
27060cf4a9
Populate min_replicas_remaining field for all regions during cluster status computation. This provides more information about the number of available replicas currently in the database.
2021-03-17 15:45:12 -07:00
ea922aa648
address pr comments
2021-03-17 18:16:18 +00:00
822cbf895d
address pr comments
2021-03-16 23:29:02 +00:00
0c6b9bc541
remove guard around g_network
2021-03-16 21:53:24 +00:00
bf5f83d2bf
address pr comments
2021-03-16 21:49:36 +00:00
5f079904d4
add unit test
2021-03-16 18:30:39 +00:00
17f9da6962
remove traces
2021-03-16 16:47:50 +00:00
3751ecd11f
Merge pull request #4503 from sfc-gh-ajbeamon/merge-release-6.3-into-master
...
Final merge of release-6.3 into master
2021-03-16 09:29:05 -07:00
ffb8e27f43
Merge pull request #4461 from sfc-gh-anoyes/anoyes/fix-thread-leak
...
Fix several leaks
2021-03-15 22:03:45 -07:00
191230a7b3
Factor our refreshTransaction gadget
2021-03-16 00:51:20 +00:00
a892eec57d
Manually apply changes made to BackupContainer.actor.cpp on release-6.3 to the new files where that code is located.
2021-03-15 16:41:22 -07:00
25c4880ebe
Merge branch 'release-6.3' into merge-release-6.3-into-master (temporarily discard all changes to BackupContainer.actor.cpp)
...
# Conflicts:
# fdbclient/BackupContainer.actor.cpp
# fdbserver/Knobs.h
2021-03-15 16:41:04 -07:00
f0d79b3d86
Inital implementation of network busyness
2021-03-15 23:23:56 +00:00
766b9d24d6
Merge branch 'master' into remove-invalid-backup-status-fields
2021-03-14 18:57:03 -07:00
d45481decc
Fix broken_promise bug
2021-03-13 01:16:27 +00:00
6cacf3e002
Fix potential heap-use-after-free
...
If we destroy tr here then we might not be able to dereference |self|.
Keep the window where |self| might have been deleted small.
2021-03-12 00:26:26 +00:00
a76c7b9754
Fix several memory leaks and a thread leak
2021-03-11 23:58:32 +00:00
0dd9fdf9de
Throw an error if the local client is disabled and there are no external clients
2021-03-11 14:09:52 -08:00
2c316db94d
Merge remote-tracking branch 'apple/master' into master-format-final
...
Also format the changes
2021-03-11 12:54:26 -08:00
be980ebb55
Merge pull request #4354 from sfc-gh-clin/add-advanceversion
...
Add advanceversion into special keys
2021-03-11 11:43:53 -08:00
d17702e7c4
Merge pull request #4463 from sfc-gh-ajbeamon/mvc-dont-copy-with-single-thread
...
Multi-version client: don't copy external libraries if we aren't using multiple threads
2021-03-11 11:16:54 -08:00
d7252da951
clang-format: Fix the TEST() macros which require comments in line
2021-03-10 16:50:53 -08:00
2cd3f45fd6
Merge remote-tracking branch 'apple/release-6.3' into master-format-final
...
release-6.3 was recently merged, and there were two PRs which were
merged in between and got those changes in here. Hence, since all the
changes were in, discarded the incoming changes and accepted all
current.
2021-03-10 16:50:44 -08:00
fe4ff420a3
Don't copy the external libraries if you aren't using more than one thread
2021-03-10 15:09:30 -08:00
cfbaaa6001
Merge remote-tracking branch 'origin/release-6.2' into release-6.3
2021-03-10 14:30:47 -07:00
af36e52fdf
Merge branch 'release-6.3-pre-format' into master-format
...
This merges release-6.3 branch right before it was fully formatted.
There were quite a few conflicts that are resolved here. CoroFlow had
a check for OOM errors introduced in 6.3, but didn't seem applicable in
the new implmentation which seems to use boost.
2021-03-10 10:40:53 -08:00
df90cc89de
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-03-10 10:18:07 -08:00
2bb4f2e59f
Merge branch 'release-6.3-pre-format' into master-format
...
This merges release-6.3 branch right before it was fully formatted.
There were quite a few conflicts that are resolved here. CoroFlow had
a check for OOM errors introduced in 6.3, but didn't seem applicable in
the new implmentation which seems to use boost.
2021-03-10 09:37:41 -08:00
f81d4eb6d3
Remove invalid backup status fields
2021-03-08 15:48:46 -08:00
e9c9bd5299
Merge commit 'e2d3ddee2cb4da0bba65346d29ad2212fbce16f0' into file-backup-async-rename
...
# Conflicts:
# fdbclient/BackupContainer.actor.cpp
# fdbclient/FileBackupAgent.actor.cpp
# fdbclient/Knobs.cpp
# fdbrpc/AsyncFileNonDurable.actor.h
# fdbrpc/sim2.actor.cpp
2021-03-08 02:00:40 -08:00
318b862aa3
Apply clang-format to backup changes.
2021-03-08 01:49:29 -08:00
a397d8625f
AsyncFileNonDurable now has a flag for whether or not to emulate AIO mode, so the previous behavior limits are preserved when this flag is set. AsyncFileDurable writes which are selected to be durable are again done in a single write, and the logic to handle non-aligned writes for non-AIO mode is more clear and commented. In simulation, backup files on local filesystems are written with random buffer sizes. Backup container unit test now uses more random file sizes and limits memory consumption for all files being written in parallel.
2021-03-07 22:21:10 -08:00
8a4aca3f47
Bug fix: In simulation only, RangeFileWriter was not waiting on a write future in one location.
2021-03-07 22:19:04 -08:00
1d00c41385
Bug fixes: Avoid empty writes, avoid 0 length truncation, and make AsyncFileNonDurable support writes at arbitrary offsets and lengths. Increase randomness of IBackupFile appends in backup container unit test.
2021-03-05 17:45:36 -08:00
8a8c488ede
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-03-05 18:13:38 -06:00
0c214d71da
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-03-05 16:31:35 -06:00
1025a0da37
File-based backup now uses async rename to prevent blocking the network thread in the event of slow filesystem metadata operations. Backup now opens its write-only files without a block cache so that writes to disk will be larger (1MB by default instead of 4k).
2021-03-03 21:45:33 -08:00
79cec09255
Apply clang-tidy's performance-inefficient-vector-operation fix
...
I ran this command in my build directory after compiling with
OPEN_FOR_IDE. It took a few small tweaks to get it to compile, which is
outside the scope of this commit.
$ python run-clang-tidy.py -j $(nproc) -checks='-*,performance-inefficient-vector-operation' -fix
2021-03-04 03:58:25 +00:00
37d9e975e9
Fix multiple compiler warnings
2021-03-03 10:18:03 -07:00
346a4e3ecd
Merge branch 'release-6.3'
...
# Conflicts:
# fdbcli/fdbcli.actor.cpp
# fdbrpc/LoadBalance.actor.h
# fdbrpc/MultiInterface.h
# fdbserver/ClusterController.actor.cpp
# fdbserver/MasterProxyServer.actor.cpp
# fdbserver/masterserver.actor.cpp
2021-03-01 18:52:06 -08:00
25069a9444
Fix compile error: Related to pr 3961
2021-02-27 17:10:21 -08:00
5b4e77bb99
Update comments, add asssertions
2021-02-25 13:13:34 -08:00
424aae71cc
Solve comments. Disable clear for ClientProfilingImpl and set the upperbound value for advanceversion
2021-02-25 13:02:56 -08:00
d8932f142a
Merge pull request #4350 from sears/multithreaded-pr-comments
...
Multithreaded pr comments
2021-02-23 15:09:52 -07:00
1ee9c3e45d
Apply suggestions from code review
...
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-02-22 20:18:01 -07:00
d2440b5986
Merge pull request #4313 from xumengpanda/mengxu/ha-code
...
Add comments to explain loadBalance algorithm
2021-02-22 18:24:06 -08:00
e9b7e22e02
Merge branch 'rel-6.3'
2021-02-22 08:47:22 -08:00
e49cc68bbc
Merge branch 'rel-6.2' into rel-6.3
2021-02-21 00:15:31 -08:00
ef0bf2728e
Merge branch 'release-6.3' into mengxu/ha-code
...
Resolve Conflicts:
fdbserver/LogRouter.actor.cpp: Only conflicts at comments
2021-02-19 21:47:09 -08:00
9ce9cba0e5
Merge branch 'master' of github.com:apple/foundationdb into add-advanceversion
2021-02-19 14:29:08 -08:00
703107332a
Add special keys for profile client get/set
2021-02-19 12:22:00 -08:00
9fb396e372
Merge pull request #4255 from sfc-gh-clin/add-coordinators-into-special-keys
...
Add coordinators into special keys
2021-02-18 18:26:07 -08:00
fa3834f115
fix bug
2021-02-18 18:23:28 -05:00
70098b752a
Fix typo, solve comments
2021-02-18 14:23:51 -08:00
af77fae131
Fix bug in code I recently added where the process name memory was not long-lived and was later used.
2021-02-18 18:33:23 +00:00
ac860b3c22
Add advanceversion into special keys
2021-02-18 01:27:14 -08:00
971b1aa1e6
Add txnRejectedForQueuedTooLong in ProxyStats
...
Added transactions.rejected_for_queued_too_long for bookkeeping the
number of transactions rejected by commit proxy because its queuing
time exceeds MVCC window.
2021-02-17 21:40:46 -08:00
5324f127c9
Address skipped PR comments from multithreaded client PR
2021-02-17 21:10:42 +00:00
c075415a51
Merge pull request #4344 from sfc-gh-ljoswiak/fixes/remove-async-tracer
...
Remove async tracer
2021-02-17 09:43:24 -08:00
f3a849de10
Update ChangeConfig test for auto coordinators change
2021-02-16 23:55:58 -08:00
30d2d9ff82
Remove async tracer
2021-02-16 16:36:33 -08:00
bcd9a00a50
Backport #4285 and 1513df22f3 to release-6.2
...
Fixes #4342
2021-02-17 00:35:25 +00:00
fca7f753f8
Remove special key for coordinators' 'auto' option
2021-02-16 13:46:45 -08:00
ab1c51618a
Merge pull request #4269 from sears/multithreaded_client
...
Multithreaded client
2021-02-16 13:11:14 -08:00
9dd94499f2
Update traces
2021-02-16 13:06:25 -08:00
731ee8a121
Update ChangeConfig to test coordinators special keys
2021-02-16 13:01:37 -08:00
82cda5448d
Merge pull request #4266 from sfc-gh-nwijetunga/optimize-watches-client
...
Optimize Watches Client
2021-02-16 13:28:51 -07:00
a59f07e6fe
address pr comment
2021-02-16 13:32:03 -05:00
614d1584cc
Update documentation from https://github.com/apple/foundationdb/pull/4278
2021-02-15 23:56:55 -08:00
76a4293d1d
Merge branch 'release-6.3'
...
# Conflicts:
# fdbserver/fdbserver.actor.cpp
2021-02-15 02:13:06 -08:00
bf3e6db9e9
Fix build issues; move to new assert style
2021-02-12 23:52:55 +00:00
36915e848a
clang format
2021-02-12 22:42:57 +00:00
555f3ebfaa
Implement + test corner case configurations for mutlithreaded client.
2021-02-12 22:37:24 +00:00
fb9632297e
Add txnRejectedForQueuedTooLong in ProxyStats
2021-02-12 13:04:58 -08:00
13e4f6d7e1
small formatting fix
2021-02-12 12:57:33 -05:00
6e483b6da8
Remove sendfile.h to fix non-Linux builds
2021-02-12 09:31:22 -08:00
058557a3b1
fix pr issues
2021-02-11 15:51:37 -05:00
4938aee113
Address PR comments, remove some old cruft + comments
2021-02-11 01:27:57 +00:00
9122be4d81
Add comments to HA code and loadBalance code
2021-02-10 13:51:36 -08:00
1dac117543
Merge pull request #4278 from dongxinEric/misc/document-two-new-fields-in-storage-metrics
...
Document two fields in storage metrics
2021-02-10 10:57:38 -08:00
5b74556733
Fix bug in code I recently added where the process name memory was not long-lived and was later used.
2021-02-10 10:46:02 -08:00
270a18f089
formatting fixes
2021-02-10 13:19:59 -05:00
e4f6a39e48
change client thread count from knob to fdb.option (to be more consistent with other multiversion client options)
2021-02-10 16:29:27 +00:00
7acfeda955
cleanup
2021-02-09 20:57:16 -05:00
53739c9da5
Merge pull request #4241 from sfc-gh-clin/add-c-function-snapshot
...
Add c function for snapshot
2021-02-09 15:49:20 -08:00
386e3b0838
minor change
2021-02-09 18:36:45 -05:00
4982679ef2
change function name
2021-02-09 18:06:36 -05:00
3b48942f9a
resolve pr comments
2021-02-09 17:56:30 -05:00
d2233ffa5a
whitespace change
2021-02-09 13:38:24 -05:00
82e9f54938
small change
2021-02-09 13:36:44 -05:00
2d46cfcb80
remove traces
2021-02-09 13:33:19 -05:00
2560dc0227
add test workload
2021-02-09 12:32:37 -05:00
90686a95a0
format code
2021-02-08 22:17:16 -08:00
7c1ef37bcb
format code
2021-02-08 21:42:40 -08:00
61082e70e1
format code, add comments
2021-02-08 19:11:30 -08:00
e3c1530a15
format code
2021-02-08 18:56:12 -08:00
3def9731a4
Merge branch 'master' of github.com:apple/foundationdb into add-coordinators-into-special-keys
2021-02-08 18:52:45 -08:00
b10959be0f
format code, add trace
2021-02-08 18:52:36 -08:00
0947b87b60
Update documentation
2021-02-08 18:47:49 -08:00
e8e11d8f6f
Fix compiler warning now being treated as error
2021-02-08 14:38:41 -08:00
be57b70dbb
Fix function call where the signature changed
2021-02-08 14:00:47 -08:00
9e9bc4abe5
Create one client thread for each one that was requested (assumes local client is disabled)
2021-02-08 21:20:37 +00:00
aaf0a9aa7b
Merge branch 'release-6.3' into merge-release-6.3-into-master
...
# Conflicts:
# build/docker-compose.yaml
# cmake/ConfigureCompiler.cmake
# fdbclient/FileBackupAgent.actor.cpp
# fdbrpc/AsyncFileCached.actor.h
# fdbrpc/IAsyncFile.h
# fdbrpc/IRateControl.h
# fdbrpc/simulator.h
# fdbserver/KeyValueStoreSQLite.actor.cpp
# fdbserver/storageserver.actor.cpp
# fdbservice/ServiceBase.cpp
2021-02-08 12:58:34 -08:00
a78cb179e8
Merge pull request #4291 from sfc-gh-ajbeamon/merge-release-6.2-into-release-6.3
...
Merge release 6.2 into release 6.3
2021-02-08 12:47:50 -08:00
67e783acf8
Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
...
# Conflicts:
# cmake/CompileBoost.cmake
# cmake/FDBComponents.cmake
# fdbrpc/AsyncFileCached.actor.h
# fdbrpc/simulator.h
# fdbserver/KeyValueStoreSQLite.actor.cpp
# fdbserver/Knobs.cpp
# fdbserver/Knobs.h
# fdbserver/storageserver.actor.cpp
# flow/Knobs.h
# flow/network.h
2021-02-08 09:20:28 -08:00
84be77958e
Add a simulator guard
2021-02-05 22:47:49 -08:00
53d8bd5799
If a quorum change has to retry, it's possible that one of our previously chosen coordinators could be rebooting.
2021-02-05 22:36:54 -08:00
5c4863b33e
Fix unit test that set coordinators to fake processes that the simulator didn't know about
2021-02-05 22:07:40 -08:00
83af53b1bb
correctness fixes
2021-02-05 19:23:37 -05:00
618585f9dd
Fix a bug in simulated coordinator selection that could allow an unreliable process to be chosen as coordinator despite the intent that this not happen.
2021-02-05 15:59:14 -08:00
a85458dd1e
Merge branch 'master' of github.com:apple/foundationdb into add-c-function-snapshot
2021-02-05 14:14:52 -08:00
97925de9d4
Update fdb_database_create_snapshot to take a UID as input
2021-02-05 14:14:38 -08:00
d185ff3752
update \xff\xff/configuration/coordinators/processes
2021-02-05 00:55:34 -08:00
10c1bd475e
Improve comments based on review
2021-02-04 17:31:05 -08:00
1095dba821
Document two fields in storage metrics
2021-02-04 16:20:18 -08:00
b1fd8a439e
revert NativeAPI
2021-02-04 12:54:18 -05:00
6c687067a6
refactor
2021-02-04 12:51:53 -05:00
675e567305
Merge pull request #4218 from sfc-gh-etschannen/feature-low-priority-reads-6.2
...
Reduce read priority when durability lag is high
2021-02-03 18:09:39 -08:00
ec6226bde9
change logic
2021-02-03 20:01:26 -05:00
ad3de5c9e0
WIP: seems to work?
2021-02-03 23:19:26 +00:00
1032a5d005
WIP
2021-02-03 21:45:35 +00:00
b2ffdf47f0
added low priority reads to status
2021-02-03 13:24:34 -08:00
f50206aabb
fdbclient: Copy external libraries MULTI_VERSION_CLIENT_THREADS_PER_VERSION times
...
To support multiple threads in for each multi-version clients, we make a copy of
external library for each thread in `/tmp/` directory and load that.
(cherry-picked by Rusty; there were some conflicts, so this has commented out cruft in it)
2021-02-03 20:47:15 +00:00
87aeafb294
partial refactor to support multiple threads per client library
2021-02-03 19:58:37 +00:00
b6e7961b78
change to references
2021-02-02 20:29:03 -05:00
c67aac8212
remove the use of pointers
2021-02-02 13:26:12 -05:00
6f38105e48
fix issue with case 4
2021-02-01 19:07:14 -05:00
6bee8ac0aa
Inital implementation
2021-02-01 18:42:13 -05:00
3fc8870ce3
winbuild: fix duplicate definition of Codec<ERestoreState>::pack and unpack in Debug build
...
- defined twice in FileBackupAgent.actor.cpp and BackupAgent.actor.h
- only fails when building in Debug ?
2021-01-30 19:03:25 +01:00
c2aedb0b94
clang-format, remove comments
2021-01-29 18:20:09 -08:00
766de6574a
Add trace
2021-01-29 15:32:53 -08:00
5a62e0c084
Fix repeated code usage
2021-01-29 12:20:30 -08:00
7d32045506
Merge branch 'master' of github.com:apple/foundationdb into add-coordinators-into-special-keys
2021-01-29 11:46:01 -08:00
e1182f2f86
Add coordinators to special keys
2021-01-29 11:45:52 -08:00
5b5dd0a0d4
Merge pull request #4204 from sfc-gh-ljoswiak/features/network-tracer
...
Add network option to set tracer in fdbclient
2021-01-27 20:00:49 -08:00
cef53b2b40
clang-format
2021-01-26 12:06:40 -08:00
5f912f0deb
Add snapshot c function
2021-01-26 11:53:35 -08:00
7558cd8e06
Merge remote-tracking branch 'origin/master' into simplify-global-knobs
2021-01-26 10:00:25 -08:00
074531309b
Merge pull request #3769 from sfc-gh-ljoswiak/binary-info
...
Add CLI argument to print build information
2021-01-26 10:29:57 -07:00
564c70acb4
Merge branch 'master' into anoyes/modernize-use-override
2021-01-25 18:26:18 -08:00
a51de2f73d
Merge pull request #4220 from sfc-gh-clin/add-c-function-force-recovery
...
Add c function fdb_database_force_recovery_with_data_loss
2021-01-25 18:22:41 -08:00
cec050a1f8
Apply clang-tidy's modernize-use-override fix
2021-01-26 02:04:12 +00:00
4ee97c0784
Use clang-tidy to automatically fix missing overrides
...
Use `clang-tidy -p . $file -checks='-*,modernize-use-override' -header-filter='.*' -fix`
to fix missing overrides, and then use git clang-format to reformat just
those changes. This went pretty well for most files.
Formatting the following files went off the rails, so I'm going to
follow up with a commit that's just clang-tidy and no clang-format.
- fdbclient/DatabaseBackupAgent.actor.cpp
- fdbclient/FileBackupAgent.actor.cpp
- fdbserver/OldTLogServer_4_6.actor.cpp
- fdbmonitor/SimpleIni.h
- fdbserver/workloads/ClientTransactionProfileCorrectness.actor.cpp
2021-01-26 02:04:12 +00:00
c3775ede37
add override keyword properly to squash compiler warnings
2021-01-25 13:24:15 -05:00
6e619e9157
Update the returned future when local client is disabled
2021-01-25 00:41:50 -08:00
29c0e05ea6
Clarify naming of distributed tracing options
2021-01-22 17:30:33 -08:00
e74fa1238b
Merge pull request #4181 from sfc-gh-tclinkenbeard/azure-read-remove-copy
...
Remove unnecessary copy from BackupContainerAzureBlobStoreImpl::read
2021-01-22 14:13:23 -08:00
500eabf6dd
Add network option to set tracer in fdbclient
2021-01-21 12:04:28 -08:00
fb9b4b7626
Merge remote-tracking branch 'origin/master' into misc-changes
2021-01-21 10:45:50 -08:00
ad99bf0471
Merge remote-tracking branch 'origin' into misc-changes
2021-01-21 10:03:07 -08:00
9b5fc3b638
Update code
2021-01-21 01:22:53 -08:00
116f034933
update var names
2021-01-21 01:11:40 -08:00
9cd7c43a2c
Add c function fdb_database_force_recovery_with_data_loss
2021-01-21 00:42:23 -08:00
fd20011276
Remove tags
2021-01-20 17:05:58 -08:00
4d6fbf099c
Use StringRef for span tags
2021-01-20 13:57:36 -08:00
7ae5e98c5a
Add metadata to a few spans
2021-01-20 13:57:36 -08:00
7c9070df39
Fix macOS compilation issue
2021-01-19 11:21:21 -08:00
88f8145dec
Add CLI option to get build information
2021-01-19 11:21:21 -08:00
6fb61ca2bc
Merge pull request #4207 from sfc-gh-anoyes/anoyes/merge-6.3-to-master
...
Merge 6.3 into master
2021-01-19 10:43:34 -08:00
b8ff724232
Merge pull request #4173 from sfc-gh-anoyes/anoyes/fdb-c89-test
...
Make sure that fdb_c.h is c90 compliant
2021-01-19 10:42:40 -08:00
c101c6ec0c
Resolve last conflict
2021-01-15 21:51:25 +00:00
5743fe724c
Restore buffering logic lost to botched merge
2021-01-15 20:10:39 +00:00
dadc4d1b21
Initialize m_offset
2021-01-15 19:56:28 +00:00
b0f61fb74f
Resolve the simple-looking conflicts
2021-01-15 19:35:10 +00:00
ff7d306b09
Merge branch 'release-6.3' into anoyes/merge-6.3-to-master
...
Include conflict markers for now. Will resolve.
2021-01-15 18:04:09 +00:00
13afadfae4
Use c90 compatibility for clarity
2021-01-15 02:50:34 +00:00
8ce9bd4e8e
Merge branch 'master' of github.com:apple/foundationdb into add-c-function-for-management-commands
2021-01-14 17:31:26 -08:00
e32a0fb742
Resolve conflicts
2021-01-14 20:13:29 +00:00
6d6b2843da
Merge remote-tracking branch 'upstream/release-6.2' into anoyes/merge-release-6.2
...
I'm including the conflict markers for now and I'll resolve them in a
subsequent commit
2021-01-14 17:20:11 +00:00
95eaa5e866
Merge remote-tracking branch 'origin/master' into misc-changes
2021-01-13 21:14:36 -08:00
87b4463305
Solve comments: update c api description; refine code
2021-01-13 14:56:41 -08:00
8ff14878fe
Merge remote-tracking branch 'origin/master' into simplify-global-knobs
2021-01-13 14:39:35 -08:00
e29ed3bf99
Remove createGlobal*Knobs functions
2021-01-13 12:14:04 -08:00
fe71ef88c3
Merge pull request #4199 from sfc-gh-satherton/file-backup-write-buffering
...
Add write buffering to BackupContainerLocalDirectory::BackupFile
2021-01-13 12:23:57 -07:00
2609c3d619
Merge pull request #4072 from sfc-gh-tclinkenbeard/improve-type-safety
...
Make enums automatically binary serializable
2021-01-12 10:31:34 -07:00
a860778b51
Add write buffering to BackupContainerLocalDirectory::BackupFile to greatly reduce the number of IAsyncFile::write() calls made when writing backup data. The buffer size is controlled by a knob.
2021-01-09 07:57:48 -08:00
fbcc85843f
clarify comment for serverKeys possible values
2021-01-06 17:15:31 -05:00
43a79a34ff
Merge pull request #4175 from vishesh/task/document
...
Docs, fix and hack for Fault Tolerance
2021-01-05 15:46:45 -08:00
Lukas Joswiak