Commit Graph

4883 Commits

Author SHA1 Message Date
Andrew Noyes 6888baf1c3 Fix compile error 2019-04-16 15:44:55 -07:00
Andrew Noyes 08e66d1764 Prefer success to cast-to-void 2019-04-16 15:29:03 -07:00
Andrew Noyes 781b6ece77 Fix OPEN_FOR_IDE -Wunused-variable warnings
CC #1255, #1173
2019-04-16 15:28:01 -07:00
A.J. Beamon 6327c78bac
Merge pull request #1464 from atn34/review-comments
Address review comments from #1446
2019-04-16 14:11:24 -07:00
Andrew Noyes 75b9369583 Make checksumHistoryBudget optional
See https://github.com/apple/foundationdb/pull/1446#discussion_r275933381
2019-04-16 12:55:53 -07:00
Andrew Noyes baa3e806ef Address review comments from #1446 2019-04-16 09:48:15 -07:00
Andrew Noyes 247f95a6e2 Add -Wunused-variable 2019-04-15 18:13:00 -07:00
Andrew Noyes 6207d724f8 Fix all -Wunused-variable warnings 2019-04-15 18:13:00 -07:00
Andrew Noyes 5586f44303 Fix return code plumbing 2019-04-15 18:08:45 -07:00
A.J. Beamon b90cea4cf3
Merge pull request #1462 from atn34/assert-size-gt-zero
Avoid potential index-out-of-bounds
2019-04-15 16:17:36 -07:00
Andrew Noyes 6c7fd1593f Avoid potential index-out-of-bounds 2019-04-15 15:20:09 -07:00
A.J. Beamon 77843e8494
Merge pull request #1456 from atn34/trace-format-fixes
Trace format fixes
2019-04-15 10:19:22 -07:00
Andrew Noyes dced9232d0 ASSERT_WE_THINK trailing byte is '\0' 2019-04-15 09:43:26 -07:00
Meng Xu a74cccae95
Merge pull request #1458 from atn34/fix-typos
Fix a few typos
2019-04-13 21:23:29 -07:00
Andrew Noyes 0dd57dd454 Fix a few typos 2019-04-13 17:29:30 -07:00
Andrew Noyes 369c1a0230 Exclude trailing \0 byte for string literals
This will "do the right thing" as long as no one expects something like

char a[] = {'a'};
TraceEvent("Event").detail("a", a);

to trace `{..., "a": "a"}`.

It will trace `{..., "a": ""}`
2019-04-11 10:39:48 -07:00
Andrew Noyes 1135331ce6 Include space as a printable character 2019-04-11 10:01:06 -07:00
Evan Tschannen cd5c9d91fa
Merge pull request #1443 from etschannen/master
Merge 6.1 into master
2019-04-10 17:43:07 -07:00
A.J. Beamon 61864860be
Merge pull request #1449 from tclinken/fix-base16char-bug
Handle negative input to base16Char
2019-04-10 11:15:38 -07:00
Trevor Clinkenbeard a9b1b32fde Handle negative input to base16Char
base16Char was being called with (c < 0), causing a failed assertion.
2019-04-09 18:14:09 -07:00
Evan Tschannen 6220a5ce0f
Merge pull request #1370 from jzhou77/fix-unreferenced
Remove unused functions
2019-04-09 11:49:45 -07:00
A.J. Beamon 058d028099
Merge pull request #1301 from mpilman/features/cheaper-traces
Defer formatting in traces to make them cheaper
2019-04-09 10:11:04 -07:00
Jingyu Zhou af17babb9a Restore a deleted comment line 2019-04-09 09:38:45 -07:00
mpilman e4746888eb Removed dead code 2019-04-09 09:08:45 -07:00
Evan Tschannen 21c0ba555c Merge branch 'release-6.1'
# Conflicts:
#	documentation/sphinx/source/release-notes.rst
#	versions.target
2019-04-08 18:38:42 -07:00
Evan Tschannen 9d632e4a85
Merge pull request #1442 from etschannen/post-release-cleanup-6.1.1
Post release cleanup 6.1.1
2019-04-08 18:33:01 -07:00
Evan Tschannen 19e0fb15e7 update installer WIX GUID following release 2019-04-08 18:32:25 -07:00
Evan Tschannen d296ae3c56 update versions target to 6.1.2 2019-04-08 18:32:25 -07:00
Evan Tschannen df8b04a658
Merge pull request #1441 from etschannen/release-6.1
Fixed a spurious error; updated documentation for 6.1.1
2019-04-08 17:11:05 -07:00
Evan Tschannen 5b63e3fbcc updated documentation for 6.1.1 2019-04-08 17:10:01 -07:00
Evan Tschannen d126730b4d fixed a spurious test error where process_behind was treated as an error 2019-04-08 17:09:54 -07:00
Evan Tschannen 64605e2a65
Merge pull request #1440 from etschannen/prepare-release-6.1.1
update installer WIX GUID following release
2019-04-08 17:06:06 -07:00
Evan Tschannen bda6ecd107 update installer WIX GUID following release 2019-04-08 17:04:34 -07:00
A.J. Beamon b66d0a3e3d
Merge pull request #1439 from etschannen/release-6.1
updated release notes for 6.1.1
2019-04-08 15:24:31 -07:00
Evan Tschannen 438be756ae updated release notes for 6.1.1 2019-04-08 15:22:37 -07:00
Evan Tschannen ce2072cb33
Merge pull request #1438 from ajbeamon/throw-process-behind-when-all-storage-behind
Throw process_behind instead of future_version when all storage nodes…
2019-04-08 14:58:29 -07:00
A.J. Beamon 538b431656 Apply suggestions from code review 2019-04-08 14:55:58 -07:00
A.J. Beamon 35cf87007c Update bindings/c/fdb_c.cpp 2019-04-08 14:49:10 -07:00
A.J. Beamon ba93cfda16 Add process_behind and proxy_memory_limit_exceeded to the error codes documentation 2019-04-08 14:26:36 -07:00
A.J. Beamon b6efcdab28 Add PR to release notes 2019-04-08 14:23:00 -07:00
A.J. Beamon a7288e1325 Throw process_behind instead of future_version when all storage nodes on a team are behind. process_behind gets the same backoff behavior as not_committed. Add proxy_memory_limit_exceeded to the retryable predicate. 2019-04-08 14:21:24 -07:00
Evan Tschannen 47931674b5
Merge pull request #1423 from AlvinMooreSr/cmake
Strip Fdbmonitor Symbols
2019-04-08 13:43:46 -07:00
Evan Tschannen 675edd4575
Merge pull request #1410 from AlvinMooreSr/winerr
Fixed Dotnet Reference errors
2019-04-08 13:39:22 -07:00
mpilman 789cd67bcd Don't compile JavaWorkload by default 2019-04-08 13:06:29 -07:00
Balachandar Namasivayam 6a78501d44
Merge pull request #1437 from etschannen/release-6.1
getReplyUnlessFailedFor must still report endpoint failures
2019-04-08 11:47:07 -07:00
Evan Tschannen 7fd0af1888 the default failure state for local addresses should be not failed 2019-04-08 10:43:48 -07:00
Evan Tschannen 1358603c7a fix: getReplyUnlessFailedFor must still report endpoint failures even if the address is local 2019-04-08 10:42:58 -07:00
A.J. Beamon bb0bb597ac
Merge pull request #1422 from etschannen/feature-network-degraded
Degrade processes which show signs of asymmetric network failures
2019-04-08 09:58:37 -07:00
Evan Tschannen 1baae75ac9 merge 6.1 2019-04-07 23:24:31 -07:00
Evan Tschannen 05869a8383 do not log a degraded reset message if the previous reset was more than a week ago 2019-04-07 23:00:58 -07:00