1976f2c371
FlowTransport: Sample connect latencies
2020-11-10 12:12:01 -08:00
16affd3575
Make test macros enforce unique comments
2020-11-10 11:13:34 -07:00
ebca63e3c7
Merge pull request #4026 from sears/histogram_fixes
...
Histogram fixes
2020-11-09 13:12:38 -08:00
08e8a06933
PR comments; add missing addRef when re-using Histogram in HistogramRegistry; Instrument UnsentPacketQueue in FlowTransport
2020-11-08 08:37:16 -08:00
4669f837fa
Add uses of makeReference
2020-11-07 22:10:18 -08:00
a42a431b57
Add makeReference (similar to std::make_shared)
2020-11-07 22:09:53 -08:00
2c56d379b2
Merge pull request #3998 from dongxinEric/misc/attach-dcid-to-process-metrics-when-possible
...
Attach datacenter id to process, network, machine and memory metrics.
2020-11-06 10:54:23 -08:00
df18f20efd
clang format
2020-11-05 10:27:41 -08:00
26a66c632a
Allow histograms to be fetched by name (so multiple instances can share the same histogram
2020-11-05 10:27:37 -08:00
1c05b70942
Add INetwork::timer_monotonic
2020-11-05 17:07:49 +00:00
c50e997f60
Make status tests deterministic
...
This change seems to be incorrect since afaict INetwork::timer isn't
guaranteed to be monotonic. Maybe we can make that guarantee or add an
INetwork::timer_monotonic symbol?
2020-11-05 17:05:34 +00:00
392f18a2de
Fix retrieveTraceLogIssues function name
2020-11-04 22:39:56 -08:00
49d5d2b0a2
Merge pull request #4003 from xis19/sev
...
Remove magic number 5 in severity eventsCount
2020-11-03 10:30:08 -08:00
0ba4e8d64b
Fix make build.
2020-11-02 14:35:17 -08:00
cb004b3b22
Address pull request comments
2020-11-02 12:18:00 -08:00
d1f38077f5
remove virtual
2020-11-02 19:41:20 +00:00
32c87bbb33
Lightweight, power of two spaced histogram implementation + automatic reporting
2020-11-02 11:13:16 -08:00
ac4bebbfad
Remove magic number 5 in severity eventsCount
2020-11-01 22:13:55 -08:00
9c6c2704d0
Merge branch 'master' of https://github.com/apple/foundationdb into stable_interfaces
2020-10-30 23:59:32 +00:00
e73d189f88
Attach datacenter id to process, network, machine and memory metrics.
2020-10-30 11:20:40 -07:00
96cc700440
Merge pull request #3961 from sfc-gh-tclinkenbeard/azure-backup
...
Add support for writing backup files directly to Azure blob storage
2020-10-29 00:30:40 -07:00
e82339f40e
Merge pull request #3906 from sfc-gh-anoyes/anoyes/use-gcov
...
Add USE_GCOV cmake option
2020-10-27 08:27:46 -07:00
9c5032ad9c
Merge branch 'master' of https://github.com/apple/foundationdb into stable_interfaces
2020-10-26 23:10:30 +00:00
8e512f3109
Merge pull request #3943 from sfc-gh-anoyes/anoyes/valgrind-precise
...
Increase valgrind precision if env var FDB_VALGRIND_PRECISE is set
2020-10-26 14:01:58 -07:00
bf7bf470d9
Merge branch 'master' of https://github.com/apple/foundationdb into stable_interfaces
2020-10-26 19:36:19 +00:00
b57d479d49
Fix clang11 warning
...
Apparently clang11 warns if you pass uninitialized memory to a function
accepting a const reference. Seems fair. This change doesn't actually
fix any bugs, but it silences the warning.
2020-10-26 11:31:40 -07:00
8191a38b88
Support rvalue reference overload for Optional::get
2020-10-24 21:05:42 -07:00
82b6daa16b
First draft of Azure blob storage backup container
2020-10-24 16:47:51 -07:00
055add9682
conflicts
2020-10-23 06:33:00 +00:00
18ac901c40
Align memory for FastAllocator with valgrindPrecise
2020-10-23 02:11:50 +00:00
f91079dbe7
Use camelCase
2020-10-22 21:51:00 +00:00
dc5e09ba62
Fix normal build
2020-10-22 16:34:37 +00:00
ab4eb627c2
Replace with environment variable
...
We need to change the behavior of the allocator before main is called,
so a knob won't work.
2020-10-22 16:31:48 +00:00
79163947a6
Add FLOW_KNOBS->VALGRIND_PRECISE
2020-10-22 16:31:48 +00:00
c4fc36ed23
Remove unnecessary copies of errorCodeTable
2020-10-20 15:55:35 -07:00
8cc3e4d3c6
Merge release-6.3 into master
2020-10-19 22:51:56 -07:00
44c62b2d51
Merge pull request #3922 from jzhou77/release-6.3
...
Merge Release 6.2 to Release 6.3
2020-10-19 14:38:36 -07:00
0a1478949a
Merge pull request #3892 from TheBenCollins/log-batch-priority-filter
...
Add a check against the current minimum priority for TraceBatch logging
2020-10-19 13:02:35 -07:00
545ee4269d
master conflicts
2020-10-19 01:03:54 +00:00
1c533e7363
fix flowtransport conflicts
2020-10-19 01:00:03 +00:00
8f17a1a5d6
Merge branch 'release-6.2' into release-6.3
2020-10-16 15:25:39 -07:00
4dff55c4ea
Add comment for PriorityStarved metrics
...
Metrics include:
PriorityStarvedBelowX, PriorityMaxStarvedBelowX and PriorityBusyX
2020-10-16 13:45:03 -07:00
62d3b1c674
Use add_link_options. Also add USE_MSAN
...
And define the macros stacktrace.amalgamation.cpp expects
2020-10-15 17:08:41 +00:00
68de888fb4
Add USE_GCOV cmake option
...
Enabling this option adds --coverage to compilation flags and dumps
coverage data (*.gcda) files in flushAndExit. Otherwise coverage data
would not be dumped in flushAndExit. Applications that exit more
normally (e.g. returning from main) don't need special changes to dump
coverage data.
This is still experimental and we don't exactly have a plan for running
this in CI e.g., so this change just adds the option.
Tested with clang11
2020-10-15 17:08:41 +00:00
24ea35e56f
Merge pull request #3748 from sfc-gh-ljoswiak/visibility-2
...
Add TLogVersion::V6
2020-10-14 17:35:32 -07:00
e47e0108a7
Add new TLogVersion
2020-10-14 15:41:10 -07:00
a1e868a569
Merge pull request #3862 from sfc-gh-tclinkenbeard/use-override-more
...
Add uses of override keyword, remove unnecessary uses of virtual
2020-10-14 15:06:45 -07:00
54d5f6562e
Fix clang11 warning
...
Apparently clang11 warns if you pass uninitialized memory to a function
accepting a const reference. Seems fair. This change doesn't actually
fix any bugs, but it silences the warning.
2020-10-13 17:27:55 +00:00
4eb20a1283
merge anoyes/stable-interface and add back in isCompatible
2020-10-12 20:39:37 +00:00
2f5b0bef08
switch to test newer incompatible version. Fix PR comments. Modify schema
2020-10-12 18:29:16 +00:00
bbf5bdf6da
fix stable interfaces test and corresponding changes in simulator
2020-10-12 18:25:12 +00:00
89469921bb
Merge pull request #3891 from etschannen/feature-reset-proxy-connections
...
Reset a proxy's network connection with the master or resolvers if it is too far behind
2020-10-12 11:21:24 -07:00
41843f07e6
add simulator support for different process versions and ProtocolVersion test
2020-10-12 18:19:31 +00:00
76d0027fa2
merge anoyes/stable-interface and add back in isCompatible
2020-10-12 18:18:30 +00:00
6166f7c99c
Add a check against the current minimum priority for TraceBatch logging
2020-10-12 09:57:57 -04:00
52828f9e03
Added bytesSent to the PingLatency logging; increasing the logging interval from 1 second to 3 seconds
2020-10-11 23:05:21 -07:00
ccf2ca73f3
Fix Windows CMake build
2020-10-08 23:58:58 -07:00
011754fd7e
Merge pull request #3834 from sfc-gh-tclinkenbeard/avoid-ddtracker-slow-task
...
Avoid slow task in ~DataDistributionTracker
2020-10-08 11:00:19 -07:00
a9607bdcec
Explicitly seal classes that inherit but aren't inherited from
2020-10-07 21:58:24 -07:00
8571dcfe28
Use override where applicable in fdbserver
2020-10-07 18:41:19 -07:00
a3de8c333b
Use override where applicable in fdbclient
2020-10-07 16:57:38 -07:00
4005abdeb3
Replace virtual with override in flow
2020-10-07 15:55:11 -07:00
cb52535f46
Merge pull request #3859 from etschannen/release-6.3
...
Merge Release 6.2 into Release 6.3
2020-10-07 15:34:32 -07:00
f03a355c4e
Merge branch 'release-6.2' into release-6.3
...
# Conflicts:
# CMakeLists.txt
# documentation/sphinx/source/downloads.rst
# fdbrpc/FlowTransport.actor.cpp
# fdbrpc/FlowTransport.h
# flow/Arena.h
# flow/Knobs.cpp
# flow/Knobs.h
# packaging/msi/FDBInstaller.wxs
2020-10-07 12:28:22 -07:00
dea7000970
Merge remote-tracking branch 'upstream/master' into visibility-1
2020-10-06 18:38:15 -07:00
29d4d87b56
added a knob for the number of samples
2020-10-06 17:38:09 -07:00
eead9785dd
Merge branch 'release-6.2' of github.com:apple/foundationdb into release-6.2
2020-10-06 15:44:00 -07:00
9efda1fec5
added logging for the ping latencies for all network connections
2020-10-06 13:58:05 -07:00
2c5a2909cd
fixed compiler error
2020-10-06 09:44:16 -07:00
59d4e8b629
added a timeout to TLS handshakes
2020-10-05 15:24:03 -07:00
76da0a7cbc
Backport #3426 to release-6.2
2020-10-05 13:53:51 -07:00
7ba06a4434
fix: min and max compute estimate logging on the proxy was always zero
...
added comments and fixed formatting
2020-10-05 12:35:10 -07:00
5807b1ec3d
changed the recent requests to be the per second amount; increased precision of cpu estimate
2020-10-04 19:31:40 -07:00
614c8bc895
Get read versions requests must be load balanced on the number of requests because ratekeeper gives out an equal budget to each proxy
2020-10-04 16:20:24 -07:00
268ba0bddc
Merge remote-tracking branch 'origin/release-6.3' into merge-6.3
2020-10-01 14:14:06 -06:00
91a8367acb
Avoid slow task in ~DataDistributionTracker
2020-10-01 11:44:55 -07:00
d72d3d6593
Explicit instantiations of internal_error were not logging the usual details about the error.
2020-09-25 08:39:34 -07:00
4042e9c52f
missed a conflict
2020-09-24 17:20:02 -07:00
2d788b309f
Merge branch 'release-6.2' into release-6.3
...
# Conflicts:
# documentation/sphinx/source/api-error-codes.rst
# flow/ThreadHelper.actor.h
# flow/error_definitions.h
2020-09-24 17:16:58 -07:00
9f549f755e
updated the error code for blocked_from_network_thread because 2025 was already in use in release-6.3
2020-09-24 17:11:26 -07:00
862336de8f
Merge branch 'master' into mengxu/merge-to-master-PR
2020-09-24 17:06:00 -07:00
40f750ca55
Fix Windows CMake build
2020-09-20 11:33:18 -07:00
0ac08f6a9b
Replace NULL with nullptr in flow
2020-09-20 11:31:49 -07:00
71309a79f9
Merge branch 'release-6.3' into range
2020-09-17 17:54:33 -07:00
d6e6e96e1f
Weaken claims in documentation
...
In some cases with the multiversion client the deadlock won't be
detected
2020-09-17 20:51:08 +00:00
01998a238f
Add blockUntilReadyCheckOnMainThread
2020-09-17 20:26:28 +00:00
ea27e4bd9c
Merge pull request #3772 from yliucode/rename
...
Rename master proxy as commit proxy
2020-09-16 20:06:50 -07:00
fb49257295
Revert trace change now that blocking on a ready future is ok
2020-09-16 21:53:14 +00:00
f6412c9f82
Only throw if the future is not ready
2020-09-16 21:34:13 +00:00
734bdb72e1
Fix simulation trace impl occurence
2020-09-15 16:49:31 +00:00
0beab42b78
Add blocked_from_network_thread error
2020-09-15 16:49:12 +00:00
3c3943f64f
Disallow calling blockUntilReady from main thread
...
Also fix a data race that apparently hasn't been ported to 6.2 yet
2020-09-14 16:01:45 +00:00
35bef73a1c
Rename proxy to commit proxy
2020-09-10 17:44:15 -07:00
81ac8211d1
Add comment
2020-09-10 08:32:52 -07:00
0c25a953be
Fix compiler error. This cast is safe as it's only used locally so the data layout doesn't matter at all.
2020-09-08 16:05:38 -07:00
3728ed03dd
Resolve comments
2020-09-05 18:55:09 -07:00
0e49542d59
Fix data race described in #3749
2020-09-05 13:58:22 -07:00
1ad5e17458
add support for comparing original and current impls
2020-09-05 11:14:59 -07:00
efde86340a
Add knob to disable span serialization
2020-09-04 17:37:34 -07:00
87693cae81
merge master branch and resolve conflicts
2020-09-02 13:44:33 -07:00
Vishesh Yadav