Commit Graph

478 Commits

Author SHA1 Message Date
Xiaoxi Wang b79268326a Merge branch 'main' of https://github.com/apple/foundationdb into feature/main/dataApi 2022-11-11 08:29:22 -08:00
Xiaoge Su c489dbcb26 Disable forwarding log of RocksDB to FDB by default 2022-11-10 18:58:19 -08:00
Ankita Kejriwal 105648b888 Merge branch 'main' of github.com:apple/foundationdb into commitproxies 2022-11-09 17:38:30 -08:00
Jingyu Zhou b25f9f915e
Merge pull request #8742 from sfc-gh-tclinkenbeard/increase-gtt-folding-time
Increase default `GLOBAL_TAG_THROTTLING_FOLDING_TIME` value
2022-11-08 15:41:15 -08:00
Josh Slocum baa35fbc8f
Blob single part upload (#8703)
* Exposing writeEntireFile up through BackupContainerFileSystem, and using it in blob worker

* Adding blob worker latency metrics

* avoid writeEntireFile if object is too large

* gracefully falling back to multi-part upload if the file is too big
2022-11-08 17:30:01 -06:00
sfc-gh-tclinkenbeard 81dc1a9491 Addressed review comments 2022-11-08 14:46:03 -08:00
sfc-gh-tclinkenbeard 39330c6afa Increase default GLOBAL_TAG_THROTTLING_FOLDING_TIME 2022-11-08 10:02:24 -08:00
neethuhaneesha ca33fe1f1e
Rocksdb stats level knob. (#8711) 2022-11-07 22:32:48 -08:00
He Liu d28187ca90
Do not set timeout for RocksDB reads in simulation. (#8716)
* Do not set timeout for RocksDB reads in simulation.

* Cleanup.

* Ignore validateStorage test.
2022-11-07 15:59:52 -08:00
He Liu bffa838398
Checkpoint restore with shard (#8667)
* Added SSPhysicalShard.

* Update physicalShards in StorageServer::addShard().

* Handle notAssigned shard.

* fetchKeys() are not stopped during TerminateStorageServer since
physicalShards are not cleared.

* Fixed addingSplitLeft unset shardId.

* Increased the timeout for Rocks reads in simulation.

* Cleanup.

* set SERVE_AUDIT_STORAGE_PARALLELISM to 1.

* Disabled ValidateStorage test.

* Resolved comments.

Co-authored-by: He Liu <heliu@apple.com>
2022-11-07 10:02:35 -08:00
Zhe Wu 32bc9b6ebb Fix a race condition between batched peek and pop, where the server removal pop may be lost 2022-11-04 15:05:37 -07:00
Josh Slocum bed057e2d3
moving fdbblob in sim folder for simulations (#8701) 2022-11-04 13:26:44 -05:00
Ankita Kejriwal 27246dd4e6 Merge branch 'main' of github.com:apple/foundationdb into commitproxies 2022-11-03 18:11:56 -07:00
Ankita Kejriwal cd7e5fad00 Fetch the list of tenants over storage quota onto commit proxies from DD 2022-11-03 17:53:42 -07:00
Ankita Kejriwal 412d237761 Merge branch 'main' of github.com:apple/foundationdb into monitorusage 2022-11-03 11:55:38 -07:00
neethuhaneesha 1daa346cb4
Adding boundaries to rocksdb read iterator pool. (#8584) 2022-11-03 10:26:47 -07:00
Ankita Kejriwal e20d0946f9 Enable DD_TENANT_AWARENESS_ENABLED randomly in testing to add test coverage. 2022-11-02 17:37:15 -07:00
Hui Liu f09e995ebb blob migrator: advance version and report data copy progress 2022-11-02 16:00:22 -07:00
Xiaoxi Wang b8baf19634 Merge branch 'main' of https://github.com/apple/foundationdb into feature/main/dataApi 2022-11-02 13:46:58 -07:00
Xiaoxi Wang 55a3db82b5 update the name, comment and discription of write byte sampling; update the calculation of write bandwidth metrics 2022-11-01 14:56:55 -07:00
sfc-gh-tclinkenbeard 80ee79e39b Merge remote-tracking branch 'origin/main' into debug 2022-11-01 12:37:27 -07:00
sfc-gh-tclinkenbeard 047578b3d9 Merge remote-tracking branch 'origin/main' into debug 2022-11-01 12:05:45 -07:00
sfc-gh-tclinkenbeard 5fd8d05810 Make PROXY_MAX_TAG_THROTTLE_DURATION a server knob 2022-11-01 11:00:45 -07:00
Xiaoge Su 520a14cd72 fixup! update code per comments 2022-11-01 10:36:25 -07:00
Trevor Clinkenbeard 39abc712b0
Merge pull request #8549 from sfc-gh-tclinkenbeard/expose-txn-cost
Create `fdb_transaction_get_total_cost` function
2022-11-01 08:14:57 -07:00
Nim Wijetunga 24ce8c0fd0
Commit Proxy Encryption Code Probes (#8618)
* add commit proxy encryption code probes

* fix comment

* address pr comments

* address pr comments

* address pr comments

* address pr comments

* Trigger Build
2022-10-31 20:04:42 -07:00
sfc-gh-tclinkenbeard 0eb1598afa Merge remote-tracking branch 'origin/main' into expose-txn-cost 2022-10-30 09:36:37 -07:00
sfc-gh-tclinkenbeard 1d6bd0057b Merge remote-tracking branch 'origin/main' into add-tag-throttling-latency-bands 2022-10-29 09:49:37 -07:00
Jingyu Zhou 22293ebac5
Merge pull request #8614 from neethuhaneesha/clearRanges
Enable clear range eager reads knob for rocksdb.
2022-10-28 17:03:39 -07:00
neethuhaneesha 55fc0c1a0b Enable clear range eager reads knob for rocksdb. 2022-10-28 14:30:05 -07:00
Steve Atherton 326d45819e Merge branch 'main' into storageserver-pml 2022-10-28 14:14:44 -07:00
Andrew Noyes 0a15f081a1
Proactively clean up idempotency ids for successful commits (#8578)
* Proactively clean up idempotency ids for successful commits

This change also includes some minor changes from my branch working on
an idempotency ids cleaner, that I'd like to get merged sooner rather
than later.

- Adding a timestamp to idempotency values
- Making IdempotencyId an actor file
- Adding commit_unknown_result_fatal
- Checking idempotencyIdsExpiredVersion in determineCommitStatus
- Some testing QOL changes

* Factor out decodeIdempotencyKey logic

* Fix formatting

* Update flow/include/flow/error_definitions.h

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>

* Use KeyBackedObjectProperty for idempotencyIdsExpiredVersion

* Add IDEMPOTENCY_ID_IN_MEMORY_LIFETIME knob

* Rename ExpireIdempotencyKeyValuePairRequest

Also add a code probe for the case where an ExpireIdempotencyIdRequest is
received before the count is known, and add an assert

* Fix formatting and add TODO for nwijetunga

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2022-10-28 09:07:54 -07:00
Steve Atherton 1dad43cb06 Remove unnecessary change feed disk read lock as its functionality is obsoleted by the storage server read priority lock. 2022-10-27 18:03:14 -07:00
Steve Atherton f9ad7fb35b Merge origin/main into storageserver-pml 2022-10-27 18:00:11 -07:00
sfc-gh-tclinkenbeard 6ae0aac153 Merge remote-tracking branch 'origin/main' into add-tag-throttling-latency-bands 2022-10-27 14:07:51 -07:00
Josh Slocum 4d3553481f
Blob connection provider test (#8478)
* Refactoring test blob metadata creation

* Implementing BlobConnectionProviderTest

* createRandomTestBlobMetadata supports blobstore and works outside simulation
2022-10-27 10:44:06 -05:00
Josh Slocum ab6953be7d
Blob Granule read-driven compaction (#8572) 2022-10-26 09:02:50 -07:00
sfc-gh-tclinkenbeard 8cf87c2580 Add latencyBandsMap to GrvProxyTransactionTagThrottler 2022-10-25 17:37:26 -07:00
sfc-gh-tclinkenbeard 1c119be26d Merge remote-tracking branch 'origin/main' into expose-txn-cost 2022-10-25 13:50:43 -07:00
sfc-gh-tclinkenbeard 31a48f4046 Disable GLOBAL_TAG_THROTTLING by default 2022-10-25 13:10:15 -07:00
sfc-gh-tclinkenbeard f339819758 Merge remote-tracking branch 'origin/main' into reject-tag-throttled-txns 2022-10-25 11:59:35 -07:00
Steve Atherton 27dc180b68 Merge commit '0ae568a872e474c8c755e648efbbe4524e63e445' into storageserver-pml
# Conflicts:
#	fdbserver/VersionedBTree.actor.cpp
2022-10-24 22:31:36 -07:00
Ankita Kejriwal ce733cd1a1
Merge pull request #8538 from sfc-gh-akejriwal/monitorusage
Add functionality to get tenants over storage quota and improve the relevant monitors
2022-10-24 16:28:07 -07:00
sfc-gh-tclinkenbeard fef4c9c5b2 Remove SERVER_KNOBS->GLOBAL_TAG_THROTTLING_RW_FUNGIBILITY_RATIO 2022-10-23 20:18:21 -07:00
neethuhaneesha a1eb1d4a48
Rocksdb storage using single_key_deletes instead of deleterange on clearrange operation. (#8452) 2022-10-21 15:47:19 -07:00
Ankita Kejriwal 7647cea4e5 Improve the storage quota monitor code + add a knob for refresh interval 2022-10-21 15:44:13 -07:00
Steve Atherton e5a5ec36a4 Merge commit '0872cbfb2f00886817f18584d95af217e28ad51d' into storageserver-pml
# Conflicts:
#	fdbserver/storageserver.actor.cpp
2022-10-19 13:25:31 -07:00
Jingyu Zhou 0872cbfb2f
Fix a test timeout (#8488)
* Fix a test timeout due to buggified knob MAX_WRITE_TRANSACTION_LIFE_VERSIONS

The buggified knob MAX_WRITE_TRANSACTION_LIFE_VERSIONS can be only 1M. In some
tests, this transaction always end up commitVersion - readVersion is a little
above 1M, thus always getting transaction_too_old error.

* Change MAX_COMMIT_BATCH_INTERVAL instead

So that the master may give out versions fast enough.

* Fix an assertion failure in a unit test

48125>>8 = 187, 48125 = 0xbbfd
48128>>8 = 188, 48128 = 0xbc00
So if 48125 is chosen as the index, 48128 changes the higher order byte.

48125 & 0xff7f = 47997 = 0xbb7d. Thus +5 won't change the higher order byte.
2022-10-19 09:45:56 -07:00
Ankita Kejriwal 3d890ced9a Code cleanup 2022-10-18 15:53:22 -07:00
sfc-gh-tclinkenbeard 003986fdb0 Randomize GLOBAL_TAG_THROTTLING knob 2022-10-18 15:16:24 -07:00