Commit Graph

7540 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard e0981e71b2 Remove invalid assertion from LocalConfiguration::addChanges 2021-08-18 12:49:00 -07:00
sfc-gh-tclinkenbeard a7f9db8b76 Remove knob reinitialization from updateInMemoryState 2021-08-18 12:32:12 -07:00
Josh Slocum 074bd174b6 Fix worker segfault by reference counting LocalConfiguration 2021-08-18 14:07:20 -05:00
Yao Xiao 4b8dadfdfb Use Time instead of Timestamp. 2021-08-18 11:53:52 -07:00
Mohamed Oulmahdi 3a9e7150f7 Add SIGUSR1 and SIGUSR2 macros for Windows 2021-08-18 18:06:36 +02:00
Yao Xiao 977f8f494e Add version and timestamp to TimeKeeperCommit event. 2021-08-18 01:27:38 -07:00
Josh Slocum 6aabd9a03e Adding FIXME for simulation issue 2021-08-17 18:18:28 -05:00
Chaoguang Lin 7ac1d17bcb Add a local namespace in Ratekeeper.actor.cpp to differenitate name GrvProxyInfo 2021-08-17 21:05:57 +00:00
Chaoguang Lin b9628bdb50 Merge branch 'master' of github.com:apple/foundationdb into add-flow-db-interface 2021-08-17 20:24:41 +00:00
Chaoguang Lin 179c313e08 Use DatabaseContext instead of Database in template functions 2021-08-17 20:02:25 +00:00
sfc-gh-tclinkenbeard 0bacc310ef Reenable consumer in config broadcaster 2021-08-17 12:09:12 -07:00
Evan Tschannen 0a78c84a3e
Merge pull request #5183 from sfc-gh-xwang/tlog_dev
TLog Streaming Peek
2021-08-17 11:51:34 -07:00
sfc-gh-tclinkenbeard 616a01d01d Only register each worker once with config broadcaster (consumer currently disabled) 2021-08-17 11:45:50 -07:00
Xiaoxi Wang d12bda94ae disable trace log 2021-08-16 16:33:20 -07:00
Jingyu Zhou bccb09f9dd
Merge pull request #5387 from sfc-gh-tclinkenbeard/improve-worker-const-correctness
Add const qualifiers to several parameters in `worker.actor.cpp`
2021-08-16 13:32:07 -07:00
sfc-gh-tclinkenbeard 51ee619c16 Remove LocalConfiguration::initialize 2021-08-16 11:39:37 -07:00
sfc-gh-tclinkenbeard 3418c20867 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-16 10:49:47 -07:00
sfc-gh-tclinkenbeard 52a64eb04b Improve const-correctness for AsyncVar references 2021-08-14 23:41:39 -07:00
sfc-gh-tclinkenbeard ceb83f7f5e Make ccInterface a const reference in workerServer 2021-08-14 23:41:39 -07:00
sfc-gh-tclinkenbeard 556e4bc283 Add assertion to overlappingMachineMembers 2021-08-13 14:56:22 -07:00
sfc-gh-tclinkenbeard a0a4207ce2 Capture deep copy of machine_info in printSnapshotTeamsInfo 2021-08-13 12:13:54 -07:00
sfc-gh-tclinkenbeard 3f0e07d79c Remove dead code 2021-08-13 09:54:02 -07:00
sfc-gh-tclinkenbeard ea4f6850da Mark ServerStatus::excludeOnRecruit const 2021-08-13 09:52:07 -07:00
sfc-gh-tclinkenbeard 0aafd9d5f0 Mark TCServerInfo::isCorrectStoreType const 2021-08-13 09:49:22 -07:00
Josh Slocum e444d3781c Various TSS improvements from snowblower testing 2021-08-13 10:24:15 -05:00
Neethu Haneesha Bingi c45daf6f51 Disabling option for removing eagerReads for ClearRange mutations. 2021-08-13 01:26:50 -07:00
Steve Atherton 303449f82f
Merge pull request #5378 from FuhengZhao/RedwoodMetricsLevelFix
Redwood Metric Level
2021-08-12 20:29:08 -07:00
Fuheng Zhao 4282911ce2 level off by 1 fixed 2021-08-12 20:06:46 -07:00
sfc-gh-tclinkenbeard 904deb9516 Improve DDTeamCollection const-correctness 2021-08-12 18:52:57 -07:00
sfc-gh-fzhao 29b4f221a7
Merge branch 'apple:master' into RedwoodHistogram 2021-08-12 17:07:05 -07:00
sfc-gh-tclinkenbeard cfe677c100 storageRecruiter only responds to changes in recruitStorage endpoint 2021-08-12 16:24:03 -07:00
Xiaoxi Wang df7a801945 remove FIXME 2021-08-12 14:10:34 -07:00
sfc-gh-tclinkenbeard 45ac667271 Add IsPrimary boolean parameter 2021-08-12 14:05:04 -07:00
Andrew Noyes b39a903af0
Merge pull request #5371 from sfc-gh-anoyes/anoyes/fix-heap-use-after-free
Fix heap use after free
2021-08-12 07:27:05 -07:00
Xiaoxi Wang a97570bd06 solve mis-spelling, trace log and format problems 2021-08-11 18:26:00 -07:00
Chaoguang Lin bf0d0598dc Refactor all ThrottleAPI functions using template and remove duplicate copies 2021-08-11 23:59:25 +00:00
Andrew Noyes ca9f60baef Fix heap use after free 2021-08-11 15:42:01 -07:00
Lukas Joswiak a605fb3852
Merge pull request #5026 from sfc-gh-ljoswiak/fixes/alp6
Actor sampling
2021-08-11 13:44:17 -07:00
Lukas Joswiak 1faec36bc6 Wait for all snapshot replies before sending incremental changes 2021-08-11 11:17:51 -07:00
Lukas Joswiak c098a1128d Push snapshot changes to local configuration on refresh 2021-08-11 09:13:22 -07:00
Josh Slocum 389b71ba72
Merge pull request #5365 from sfc-gh-satherton/debugging-cleanup
Added Label field for keys and ranges in MutationTracking.
2021-08-11 07:07:36 -07:00
Trevor Clinkenbeard bd0a04d4bc
Merge pull request #5345 from sfc-gh-ljoswiak/features/broadcaster-push
Refactor config broadcaster to push updates to workers
2021-08-10 19:56:35 -07:00
Chaoguang Lin 618c72f7e2 Draft to use template to rewrite ThrottleApi 2021-08-11 01:07:36 +00:00
Steve Atherton 09a41ff61b Fix duplicate trace event fields on MutationTracking event. 2021-08-10 17:56:28 -07:00
Steve Atherton f000447414 Fix duplicate TraceEvent detail name. 2021-08-10 17:43:41 -07:00
Steve Atherton 3922fa8cdd Fix duplicate TraceEvent detail name. 2021-08-10 17:41:31 -07:00
Steve Atherton eb5c8eb78d Added Label field for keys and ranges in MutationTracking. 2021-08-10 17:32:32 -07:00
Steve Atherton 01248820a7 Added Label field for keys and ranges in MutationTracking. 2021-08-10 17:30:07 -07:00
Lukas Joswiak 7fe863c2a0 Temporarily remove failing unit test 2021-08-10 16:20:51 -07:00
Steve Atherton 2cf5a3d883 Added range tracking support to MutationTracking. 2021-08-10 15:52:30 -07:00
Lukas Joswiak b112560c94 Reorder registerWorker to prevent potential conflict 2021-08-10 15:09:35 -07:00
Steve Atherton 5482c86d31 Added range tracking support to MutationTracking. 2021-08-10 14:38:02 -07:00
Fuheng Zhao 6dbde9f126 clean the constructor 2021-08-10 14:22:29 -07:00
Lukas Joswiak f018af6ee4
Update fdbserver/ConfigBroadcaster.actor.cpp
Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>
2021-08-10 13:24:41 -07:00
Lukas Joswiak d27c9e2520 Revert error check 2021-08-10 12:41:41 -07:00
Lukas Joswiak a838a47b0b Use ActorCollection for consumer future 2021-08-10 12:27:19 -07:00
Lukas Joswiak 9f4ea02784 Reremove old TODO 2021-08-10 12:14:50 -07:00
Lukas Joswiak 598b23f8d4 Merge branch 'features/broadcaster-push' of github.com:sfc-gh-ljoswiak/foundationdb into features/broadcaster-push 2021-08-10 12:08:16 -07:00
Lukas Joswiak 2ed2294ccb Remove old TODO 2021-08-10 12:00:43 -07:00
Lukas Joswiak 5dfd7c4b1a Remove redundant dead worker check 2021-08-10 11:56:58 -07:00
Lukas Joswiak cf81b0650d Only register consumer once on the broadcaster 2021-08-10 11:56:16 -07:00
Lukas Joswiak 72e55ef72e Add broadcaster error check to unit tests 2021-08-10 11:39:29 -07:00
Lukas Joswiak 564a3d69b7 Rename config broadcast interface messages 2021-08-10 11:39:29 -07:00
Lukas Joswiak 833e53f8f0 Add tests back 2021-08-10 11:39:29 -07:00
Lukas Joswiak 85fa264a16 Remove move constructor and assignment operator 2021-08-10 11:39:29 -07:00
Lukas Joswiak 305a17c811 Improve config broadcaster logic, fix unit tests 2021-08-10 11:39:29 -07:00
Lukas Joswiak 72e63db856 Send ConfigBroadcastInterface to ConfigBroadcaster instead of entire worker interface 2021-08-10 11:39:29 -07:00
Lukas Joswiak 3946cf94ff Push updates to workers (clang-formatted files) 2021-08-10 11:39:29 -07:00
Lukas Joswiak 092ab4302b Push updates to workers 2021-08-10 11:39:29 -07:00
Xiaoxi Wang 1f6cee89ab merge master, fix conflicts 2021-08-10 10:01:45 -07:00
Lukas Joswiak 3a607d9a38
Update fdbserver/ConfigBroadcaster.actor.cpp
Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>
2021-08-10 09:36:39 -07:00
Steve Atherton c73e861074 Move role UIDs for MutationTracking TraceEvents from various inconsistent detail fields into the TraceEvent UID field. 2021-08-10 01:59:28 -07:00
Steve Atherton 54c7036eaf Move role UIDs for MutationTracking TraceEvents from various inconsistent detail fields into the TraceEvent UID field. 2021-08-10 01:52:36 -07:00
Steve Atherton e5e8a56b66 Merge branch 'master' of https://github.com/apple/foundationdb into debugging-cleanup
# Conflicts:
#	fdbbackup/FileDecoder.actor.cpp
2021-08-09 23:36:57 -07:00
Steve Atherton faa4154a56 MutationTracking now uses a vector of keys to track. Removed "Mutation" detail from DEBUG_MUTATION() events because they are duplicates of the fields already logged in the returned MutationTracking event, which are now renamed and combined into "Mutation". Removed more toString() calls in TraceEvent detail values. 2021-08-09 23:30:45 -07:00
Lukas Joswiak ec78fb3060 Add tests back 2021-08-09 17:42:27 -07:00
Lukas Joswiak c97a1b3b4d Remove move constructor and assignment operator 2021-08-09 15:33:01 -07:00
Fuheng Zhao 5e76650d9b update constructor 2021-08-09 15:26:58 -07:00
sfc-gh-fzhao 40e674a6ba
Merge branch 'apple:master' into RedwoodHistogram 2021-08-09 15:14:15 -07:00
Lukas Joswiak 5249105b04 Improve config broadcaster logic, fix unit tests 2021-08-09 13:20:06 -07:00
sfc-gh-tclinkenbeard 79ba9c4e3a Add GetGenerationQuorum to get generation from a quorum of config nodes 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard bd5a87e0e3 Fix TestConfig::ConfigBuilder::trace_visitor::operator()(Optional<std::vector<int>> const* val) 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard f6b6e11d6a Support randomizing configuration database type in simulation 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard 82546853c0 Rename UseConfigDB to ConfigDBType 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard cdbcb69d86 Add configuration database type to ISimulator 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard cd8a82b1b8 Rename GetGenerationRequests metric 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard 42a45ebfc4 Temporarily comment out configuration database code breaking simulation tests 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard 6ac88a3cf9 Fix localIncrementActors calculation in ConfigIncrement workload 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard 6524dd1567 Add random sleep to ConfigIncrement workload 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard 7deb339a0c Added ConfigIncrement.toml test 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard c9ec3d2d93 Added ConfigIncrement workload 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard b15daf1886 Added PImpl class
This class propogates the constness of methods to their pimpl
implementations
2021-08-09 10:04:34 -07:00
Steve Atherton 2626fdc992 Don't loop over mutations with an empty loop if mutation tracking is disabled. 2021-08-08 00:44:17 -07:00
Steve Atherton 2bf7b9b7a9 Remove many calls to .toString(), .printable(), and printable(...) from TraceEvent .detail() values to avoid double-escaping characters such that the same values look different in different events and can't be easily searched for. Also fixed a few warnings found by clang. 2021-08-08 00:04:54 -07:00
Xiaoxi Wang 2263626cdc 200k test clean: enable remote Log pull from LogRouter 2021-08-07 09:53:32 -07:00
Lukas Joswiak fae29dbb1f Send ConfigBroadcastInterface to ConfigBroadcaster instead of entire worker interface 2021-08-06 12:42:07 -07:00
Xiaoxi Wang 80a5120df8 support LogRouter peek from TLog 2021-08-05 19:51:17 -07:00
Lukas Joswiak 38d05a2f49 Push updates to workers (clang-formatted files) 2021-08-05 18:57:12 -07:00
Lukas Joswiak 0116d17dbb Push updates to workers 2021-08-05 18:50:11 -07:00
yao-xiao-github 8609b45354
Add histograms to CommitProxyServer. (#5299) 2021-08-05 09:17:37 -07:00
yao-xiao-github 876c6d72c4
Merge pull request #5278 from yao-xiao-github/histogram
Add histogram in GrvProxyServer.
2021-08-04 16:34:35 -07:00
Yao Xiao f3baedd27f Apply suggestions. 2021-08-04 13:51:56 -07:00
Xiaoxi Wang 7eb9ace031 Merge branch 'master' of https://github.com/apple/foundationdb into tlog_dev 2021-08-03 17:10:15 -07:00
Fuheng Zhao 782a47f45d update histogram constructor 2021-08-03 14:01:39 -07:00
Xiaoxi Wang 2337ec7d4e remove unused variables 2021-08-03 10:15:34 -07:00
Xiaoxi Wang 9986d2b0b6 change log severity 2021-08-02 22:33:17 -07:00
Daniel Smith 0774ce423c
Merge pull request #5320 from sfc-gh-satherton/disable-rocks-valgrind
Disable using rocksdb in valgrind builds.
2021-08-02 18:34:44 -04:00
Xiaoxi Wang 3dfe7a51e0 trivial merge 2021-08-02 14:32:12 -07:00
Xiaoxi Wang fd74a16f35 format code 2021-08-02 14:24:20 -07:00
Xiaoxi Wang 0e03d5e215
Merge pull request #5313 from sfc-gh-xwang/master
add information print in simulation test
2021-08-02 13:59:57 -07:00
Steve Atherton e9c3da1f0f Disable rocksdb selection for VALGRIND builds. 2021-08-02 13:47:37 -07:00
Xiaoxi Wang 2df0474fec merge master 2021-08-02 11:58:35 -07:00
Xiaoxi Wang ae2268f9f2 200k simulation: check stream sequence; delay in GetMore loop 2021-08-02 10:52:24 -07:00
Zhe Wu d9b5a7c38d
Merge pull request #5314 from halfprice/zhewu/optional-tlog-interface
Account for the case where TLogInterface may not present in ServerDbInfo in worker health monitor
2021-08-02 10:09:13 -07:00
Trevor Clinkenbeard 5e1639ad32
Merge pull request #5222 from sfc-gh-tclinkenbeard/paxos-config-db
Simple (non-fault tolerant) implementation of replicated configuration database
2021-08-02 10:03:24 -07:00
Zhe Wu 2c08d17975 Account for the case where TLogInterface may not present in ServerDbInfo in worker health monitor 2021-08-02 07:30:27 -07:00
Lukas Joswiak 5dc9a97230 Merge branch 'master' into fixes/alp6 2021-08-01 20:42:52 -07:00
Lukas Joswiak 78b5635d9f Remove hot lineage modification 2021-08-01 20:21:15 -07:00
Lukas Joswiak d606392c68 Disable more ALP work when sampling disabled 2021-08-01 20:11:50 -07:00
Xiaoxi Wang 2a88033800 clean 100k simulation test. revert changes of fdbrpc.h 2021-07-31 16:46:14 -07:00
Xiaoxi Wang cc7081c044 add information print 2021-07-30 19:22:49 -07:00
Xiaoxi Wang 517ff9801d add information print 2021-07-30 19:10:13 -07:00
Xiaoxi Wang 1c4bce17aa revert code refactor 2021-07-30 19:08:22 -07:00
Yao Xiao 82be496ba3 Updated grvRawDist to grvGetCommittedVersionRpcDist. 2021-07-30 18:01:27 -07:00
Yao Xiao 74a7da0179 Add histogram in GrvProxyServer. 2021-07-30 17:54:51 -07:00
Daniel Smith b35c5b31c6
Merge pull request #5048 from Daniel-B-Smith/rocksdb-metrics
Add a periodic trace message with RocksDB stats
2021-07-30 14:16:50 -04:00
Daniel Smith adc466acb6 Fix key name 2021-07-30 13:27:43 -04:00
Daniel Smith a26dbba66f Add RocksDB metrics 2021-07-30 13:27:43 -04:00
Andrew Noyes 353efe7db2
Merge pull request #5264 from sfc-gh-tclinkenbeard/fix-more-clang-warnings
Enable more warnings for `clang`
2021-07-29 15:43:54 -07:00
sfc-gh-fzhao e8cefacbbe
Merge branch 'apple:master' into RedwoodHistogram 2021-07-28 21:17:06 -07:00
Zhe Wu a0bad000f3
Merge pull request #5279 from halfprice/zhewu/local-dc-count-proxy
Include proxies in the local worker list in health monitoring
2021-07-28 16:13:10 -07:00
Fuheng Zhao e12d2fd38c remove two assertions 2021-07-28 16:05:27 -07:00
sfc-gh-fzhao 09d7ee4741
Merge branch 'apple:master' into RedwoodHistogram 2021-07-28 14:35:53 -07:00
Xiaoxi Wang 10c82b422f merge master branch 2021-07-28 14:19:46 -07:00
Zhe Wu e0a7891d67 Include proxies in the local worker list 2021-07-28 14:16:48 -07:00
Xiaoxi Wang 12d4f5c261 disable streaming peek for localities < 0 2021-07-28 14:11:25 -07:00
sfc-gh-tclinkenbeard 856348f0c7 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-07-28 14:06:52 -07:00
sfc-gh-tclinkenbeard 59ddfd78bd Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-07-28 12:54:02 -07:00
sfc-gh-tclinkenbeard 94a65865d9 Merge remote-tracking branch 'origin/master' into fix-clang-warnings 2021-07-28 12:29:27 -07:00
sfc-gh-tclinkenbeard c74047c665 Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings 2021-07-28 11:51:02 -07:00
A.J. Beamon 9f571255bd
Merge pull request #5271 from sfc-gh-ajbeamon/do-not-reset-committed-transaction
Do not partially reset a transaction when it is committed or fails to commit with an error
2021-07-28 09:02:54 -07:00
Fuheng Zhao edea7f4fe5 addRef 2021-07-27 19:23:47 -07:00
Fuheng Zhao 20b01defa0 Merge branch 'RedwoodHistogram' of https://github.com/FuhengZhao/foundationdb into RedwoodHistogram 2021-07-27 16:19:25 -07:00
Fuheng Zhao 1a609abc68 remove registry in redwood 2021-07-27 16:11:00 -07:00
sfc-gh-fzhao 995b1fa5fc
Merge branch 'apple:master' into RedwoodHistogram 2021-07-27 14:19:25 -07:00
Fuheng Zhao a8f97ac728 remove the .begin() to .end() fix 2021-07-27 12:35:39 -07:00
Lukas Joswiak 3eed4084e2 Merge branch 'master' into fixes/alp6 2021-07-27 11:26:53 -07:00
Lukas Joswiak 59d535149e Merge branch 'master' into fixes/alp6 2021-07-27 10:07:18 -07:00
Lukas Joswiak e9a1679467 Disable sampling everywhere except fdbserver 2021-07-27 09:53:23 -07:00
Fuheng Zhao a5cb173749 initialize all memeber variables 2021-07-26 22:53:23 -07:00
Fuheng Zhao 145bb9ef42 add back the default parameter 2021-07-26 20:15:32 -07:00
Steve Atherton 507c1f11e3 Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use. 2021-07-26 19:55:10 -07:00
Trevor Clinkenbeard e68344e0ea
Fix header for ConfigNode.h
Co-authored-by: Lukas Joswiak <lukas.joswiak@snowflake.com>
2021-07-26 19:26:31 -07:00
Fuheng Zhao 0f363eb624 use fastRef 2021-07-26 18:20:40 -07:00
Dan Lambright 55094bdd00
Merge branch 'master' into expired-forward 2021-07-26 19:58:29 -04:00
Trevor Clinkenbeard 48d4ea6d57
Merge pull request #5231 from sfc-gh-tclinkenbeard/availability-improvements
Throw `failed_to_progress` error when a role fails to make progress
2021-07-26 15:55:14 -07:00
sfc-gh-fzhao c07161ef93
Merge branch 'apple:master' into RedwoodHistogram 2021-07-26 15:09:08 -07:00
Meng Xu d238853193
Merge pull request #5268 from halfprice/zhewu/gray-failure-patch
Change how to wait for goodRecruitmentTime and populate default PEER_LATENCY_CHECK_MIN_POPULATION
2021-07-26 14:00:53 -07:00
Fuheng Zhao 98db02f66b fix a minor error 2021-07-26 13:49:35 -07:00
sfc-gh-tclinkenbeard f4d03562f4 Merge remote-tracking branch 'origin/master' into fix-clang-warnings 2021-07-26 13:38:36 -07:00
Dan Lambright 9f3e5d9bb5 use a BinaryWriter::toValue and BinaryReader::fromStringRef<double> instead of encoding time using a string 2021-07-26 15:58:41 -04:00
A.J. Beamon febc26a1ea Fix some cases where we were reusing a committed transaction without resetting it. 2021-07-26 11:43:07 -07:00
Sajjad Rahnama 9d6402b759 Fault Injection Active/Deactivation - Edit usage in fdbserver 2021-07-26 11:04:18 -07:00
Sajjad Rahnama d36b5d62df Fault Injection Active/Deactivation - Edit TSS mode set_config 2021-07-26 10:41:17 -07:00
Zhe Wu e39cfd48c3 Ignore goodRecruitmentTime and populate default PEER_LATENCY_CHECK_MIN_POPULATION 2021-07-26 10:24:26 -07:00
Fuheng Zhao 98e92ebde4 set local registry to null in destructor 2021-07-26 09:36:55 -07:00
Xiaoxi Wang c6b0de1264 problem: OOM 2021-07-26 09:36:53 -07:00
sfc-gh-tclinkenbeard 36703decee Merge remote-tracking branch 'origin/master' into fix-clang-warnings 2021-07-26 09:32:29 -07:00
Dan Lambright ae424f1195 rebase 2021-07-26 10:55:22 -04:00
Dan Lambright 34fecb61de Reject connections to clusters forwarded in the (configurable) past 2021-07-26 10:18:10 -04:00
sfc-gh-tclinkenbeard 7f727fd616 Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings 2021-07-24 23:18:21 -07:00
sfc-gh-tclinkenbeard 23558a5430 Fix -Wreorder-ctor warnings in TLogServer.actor.cpp 2021-07-24 23:15:22 -07:00
sfc-gh-tclinkenbeard e26efd6799 Fix more -Wreorder-ctor warnings in OldTLogServer_6_2.actor.cpp 2021-07-24 22:51:57 -07:00
sfc-gh-tclinkenbeard a27d7c86f4 Fix more -Wreorder-ctor warnings in DataDistribution.actor.cpp 2021-07-24 22:14:43 -07:00
sfc-gh-fzhao 61ffd6b372
Merge branch 'apple:master' into RedwoodHistogram 2021-07-24 21:33:19 -07:00
sfc-gh-tclinkenbeard e5e449b340 Fix more -Wreorder-ctor warnings in storageserver.actor.cpp 2021-07-24 17:33:29 -07:00
sfc-gh-tclinkenbeard da50e13f3e Fix more -Wreorder-ctor warnings in DataDistribution.actor.cpp, OldTLogServer_4_6.actor.cpp, and Net2.actor.cpp 2021-07-24 17:33:11 -07:00
sfc-gh-tclinkenbeard b20e02ca25 Fix more -Wreorder-ctor warnings across several files 2021-07-24 11:43:19 -07:00
sfc-gh-tclinkenbeard 3442ebd3b7 Fix more -Wreorder-ctor warnings across many files 2021-07-24 11:20:51 -07:00
sfc-gh-tclinkenbeard e006e4fed4 Fix -Wreorder-ctor warnings in LogSystemPeekCursor.actor.cpp and several other files 2021-07-24 00:48:13 -07:00
sfc-gh-tclinkenbeard 64dc1dc185 Fix -Wreorder-ctor warnings in NativeAPI.actor.cpp and several other files 2021-07-24 00:23:06 -07:00
sfc-gh-tclinkenbeard b9a22a61ef Fix many -Wreorder-ctor warnings 2021-07-23 17:33:18 -07:00
Fuheng Zhao 77fa1aadab rename variable 2021-07-23 16:32:58 -07:00
Sajjad Rahnama e04646e267 Fault Injection Active/Deactivation 2021-07-23 16:28:20 -07:00
Fuheng Zhao c9cddd65a0 initialize pointer in constructor and format 2021-07-23 09:18:11 -07:00
Fuheng Zhao 194d93de99 add redwood local historam registry 2021-07-23 09:06:51 -07:00
Fuheng Zhao e0eb7170ba increment the version 2021-07-22 17:13:11 -07:00
Xiaoxi Wang bfebd4e812 Merge branch 'master' of https://github.com/apple/foundationdb into tlog_dev 2021-07-22 16:15:07 -07:00
Xiaoxi Wang 09214b1160 add stream actor to serveTLogInterf 2021-07-22 16:14:55 -07:00
Xiaoxi Wang cd32478b52 memory error(Simple config) 2021-07-22 15:45:59 -07:00
Lukas Joswiak dcaf1c1c38 Enable sampling on fdbserver only 2021-07-22 12:47:35 -07:00
sfc-gh-tclinkenbeard e62e6503ac Fix most delete-non-virtual-dtor clang warnings 2021-07-21 23:32:44 -07:00
Steve Atherton 2d3e78df77 Merge branch 'master' of github.com:apple/foundationdb into redwood-io-priority 2021-07-21 13:44:48 -07:00
Xiaoxi Wang 68b08a3224 add TLog streaming peek to OldTLogServer_x_x 2021-07-21 13:23:16 -07:00
sfc-gh-tclinkenbeard 169df42a8b Merge remote-tracking branch 'origin/master' into const-serverdbinfo 2021-07-21 11:02:47 -07:00
Steve Atherton c16b73bb2f Bug fix, BTreeCursor pager event reason was not being initialized. Changed metric column order. 2021-07-21 01:28:25 -07:00
Steve Atherton 3e2206680d Merge branch 'master' of github.com:apple/foundationdb into redwood-io-priority
# Conflicts:
#	fdbserver/VersionedBTree.actor.cpp
2021-07-20 23:57:03 -07:00
Steve Atherton 2f21e0a6bb BTree levels above the configured count for metrics are now included into the highest level, which fixes some valgrind errors and a crash. 2021-07-20 23:40:35 -07:00
Steve Atherton 5ff58ec824 Fixed valgrind errors caused by memory lifetime bugs in Histogram usage. Removed usage of unneeded level 0. 2021-07-20 22:46:56 -07:00
Steve Atherton 01af706228 Refactor metric logging to be shorter and changed text format to be more condensed. 2021-07-20 21:23:50 -07:00
Trevor Clinkenbeard f7b6996ee8
Merge pull request #5234 from sfc-gh-tclinkenbeard/fix-unittest-datadir
Change default data directory for unit tests outside simulation
2021-07-20 18:13:26 -07:00
Xiaoxi Wang 1057835e8b merge with master 2021-07-20 17:09:34 -07:00
Xiaoxi Wang 974bb4b344 add stream peek function to oldTLogServer_x_x.actor.cpp and LogRouter 2021-07-20 17:01:37 -07:00
Steve Atherton 26d886c600
Merge pull request #5227 from sfc-gh-satherton/redwood-io-priority
Add Priority to Redwood IO, also fixes several bugs with the recent Redwood metrics changes
2021-07-20 16:50:58 -07:00
sfc-gh-tclinkenbeard 4d9574901f Change default data directory for unit tests outside simulation 2021-07-20 11:03:36 -07:00
Xiaoxi Wang 5046ee3b07 add stream peek to logRouter 2021-07-20 17:42:00 +00:00
sfc-gh-tclinkenbeard 6f81155784 Merge remote-tracking branch 'origin/master' into const-serverdbinfo 2021-07-20 10:18:40 -07:00
Evan Tschannen 5c9a38e526
Merge pull request #5198 from Daniel-B-Smith/rocksdb-simulation-roll-forward
Roll forward: RocksDB in Simulation
2021-07-20 09:33:11 -07:00
sfc-gh-tclinkenbeard 62026ce42a Remove ReplyPromise::sendErrorOr 2021-07-19 22:51:47 -07:00
sfc-gh-tclinkenbeard 6836e49073 Throw error when commitProxy gets stuck 2021-07-19 21:00:28 -07:00
sfc-gh-tclinkenbeard d46feb5468 Add COORDINATOR_LEADER_CONNECTION_TIMEOUT server knob 2021-07-19 20:17:46 -07:00
Steve Atherton 80ac791dcf
Priority for commit reads should be == height. 2021-07-19 15:58:38 -07:00
Steve Atherton 275089a9a9
Bug fix, setting var to itself. 2021-07-19 15:16:43 -07:00
Steve Atherton b3cc2beaab
Documentation fix. 2021-07-19 15:10:01 -07:00
Andrew Noyes 9387852fc2 Fix build/memory error
The previous change broke the build intentionally. This fixes it and
also fixes the underlying issue that the previous commit caught.
2021-07-19 14:26:03 -07:00
Xiaoxi Wang f3667ce91a more debug logs; let tryEstablishStream wait until the connection is good 2021-07-19 18:43:51 +00:00
sfc-gh-tclinkenbeard 57033001d3 Remove unnecessary template 2021-07-18 19:26:11 -07:00
sfc-gh-tclinkenbeard b3e2b06553 Remove multiple implementations of ConfigNode 2021-07-18 18:25:06 -07:00
sfc-gh-tclinkenbeard 013a3c60bf Server committed version requests in SimpleConfigDatabaseNode 2021-07-18 17:56:44 -07:00
sfc-gh-tclinkenbeard 9cfd6ed955 Add simple implementation to PaxosConfigConsumer 2021-07-18 17:07:10 -07:00
sfc-gh-tclinkenbeard b24b46c862 Replace Standalone<RangeResultRef> with RangeResult in configuration database code 2021-07-18 14:26:15 -07:00
sfc-gh-tclinkenbeard 54fb0cbe85 Use full generation in ConfigTransactionInterface 2021-07-18 12:23:34 -07:00
Steve Atherton 81e83e2830
Update fdbserver/fdbserver.actor.cpp
Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>
2021-07-18 11:08:27 -07:00
Steve Atherton 13db52f1f2 Changed yield to delay(0) in places that use static counters to avoid trying to yield too often. Bug fixes with lazy delete queue entry heights. 2021-07-18 04:38:42 -07:00
Steve Atherton 294d322c0d Merge branch 'fix-simfdb-cleanup' into redwood-io-priority 2021-07-18 03:08:49 -07:00
Steve Atherton 1af8538727 Simfdb cleanup did not recognize the unittests directory, fixed this and also made the cleanup code a bit cleaner. 2021-07-18 03:06:04 -07:00
Steve Atherton 39eb71f54a Corrections in BTreeCursor event reasons, fixed by BTreeCursor now storing reason as a member because it's much simpler. Some other clang-format changes and a couple of renames. 2021-07-18 03:02:10 -07:00
Steve Atherton 09a8561606 Merge branch 'master' of github.com:apple/foundationdb into redwood-io-priority
# Conflicts:
#	fdbserver/IPager.h
#	fdbserver/VersionedBTree.actor.cpp
2021-07-18 01:49:36 -07:00
Steve Atherton 89140b0281 Fixed PagerEventReason for BTree writePages(). Renamed enums to start with capital letters to match one of the two styles used throughput the code base (CamelCase or ALLCAPS). 2021-07-17 03:44:00 -07:00
Steve Atherton c7bc79ad45 Merge branch 'fix-booleans' into fuheng/redWoodMetricsEnhancements 2021-07-17 02:10:14 -07:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
Steve Atherton 2fcc732c2a Merge branch 'master' of github.com:apple/foundationdb into redWoodMetricsEnhancements 2021-07-16 21:06:47 -07:00
Fuheng Zhao f81e8c3d6c change parameter naming 2021-07-16 14:27:53 -07:00
Fuheng Zhao d87e695fba format files 2021-07-16 14:02:59 -07:00
Fuheng Zhao 29d61b708f fix issues 2021-07-16 13:53:30 -07:00
Xiaoxi Wang 36dca1f927 merge with master 2021-07-16 19:19:51 +00:00
Daniel Smith 66883e5f1c Disable the RocksDB engine in simulation in restarting tests or when it isn't built 2021-07-16 12:51:38 -04:00
Daniel Smith 0f99d449fc Revert "Merge pull request #5194 from apple/revert-5144-rocksdb-in-simulation"
This reverts commit 8ecff8c730, reversing
changes made to c8e18f99f0.
2021-07-16 12:01:01 -04:00
Evan Tschannen 03a01d5eb8 Merge branch 'master' of https://github.com/apple/foundationdb into fix-reply-promise-stream-local-delivery 2021-07-15 16:48:17 -07:00
Evan Tschannen b7b845dab8
Revert "RocksDB in simulation" 2021-07-15 16:41:33 -07:00
Evan Tschannen a5e0e88df8 fix: reply promise streams could receive messages out of order if the sender and receiver were the same process 2021-07-15 15:27:49 -07:00
Xiaoxi Wang 227570357a trace log and reset changes; byteAcknownledge overflow 2021-07-15 21:30:14 +00:00
Daniel Smith 4c1288faa7
Merge pull request #5144 from Daniel-B-Smith/rocksdb-in-simulation
RocksDB in simulation
2021-07-15 16:00:09 -04:00
Steve Atherton 8b0f03f6e8 CommitSubtree was still doing non-caching reads, this was unintentional. 2021-07-15 09:05:36 -07:00
sfc-gh-fzhao af881298de
Merge branch 'apple:master' into redWoodMetricsEnhancements 2021-07-14 18:30:55 -07:00
Fuheng Zhao 08463e0a8b rename record_counter to count 2021-07-14 18:22:38 -07:00
Fuheng Zhao 1c7e3f08c2 format the files 2021-07-14 17:26:24 -07:00
Fuheng Zhao 126c87923f switch unitmapper to static arry 2021-07-14 16:31:13 -07:00
Xiaoxi Wang 1584ed5853 Merge branch 'master' of https://github.com/apple/foundationdb into tlog_dev 2021-07-14 16:20:19 +00:00
Xiaoxi Wang 066d534194 trivial changes 2021-07-14 16:19:23 +00:00