Commit Graph

458 Commits

Author SHA1 Message Date
Fuheng Zhao e0eb7170ba increment the version 2021-07-22 17:13:11 -07:00
Steve Atherton c16b73bb2f Bug fix, BTreeCursor pager event reason was not being initialized. Changed metric column order. 2021-07-21 01:28:25 -07:00
Steve Atherton 2f21e0a6bb BTree levels above the configured count for metrics are now included into the highest level, which fixes some valgrind errors and a crash. 2021-07-20 23:40:35 -07:00
Steve Atherton 5ff58ec824 Fixed valgrind errors caused by memory lifetime bugs in Histogram usage. Removed usage of unneeded level 0. 2021-07-20 22:46:56 -07:00
Steve Atherton 01af706228 Refactor metric logging to be shorter and changed text format to be more condensed. 2021-07-20 21:23:50 -07:00
Steve Atherton 80ac791dcf
Priority for commit reads should be == height. 2021-07-19 15:58:38 -07:00
Steve Atherton 275089a9a9
Bug fix, setting var to itself. 2021-07-19 15:16:43 -07:00
Steve Atherton b3cc2beaab
Documentation fix. 2021-07-19 15:10:01 -07:00
Steve Atherton 13db52f1f2 Changed yield to delay(0) in places that use static counters to avoid trying to yield too often. Bug fixes with lazy delete queue entry heights. 2021-07-18 04:38:42 -07:00
Steve Atherton 39eb71f54a Corrections in BTreeCursor event reasons, fixed by BTreeCursor now storing reason as a member because it's much simpler. Some other clang-format changes and a couple of renames. 2021-07-18 03:02:10 -07:00
Steve Atherton 09a8561606 Merge branch 'master' of github.com:apple/foundationdb into redwood-io-priority
# Conflicts:
#	fdbserver/IPager.h
#	fdbserver/VersionedBTree.actor.cpp
2021-07-18 01:49:36 -07:00
Steve Atherton 89140b0281 Fixed PagerEventReason for BTree writePages(). Renamed enums to start with capital letters to match one of the two styles used throughput the code base (CamelCase or ALLCAPS). 2021-07-17 03:44:00 -07:00
Fuheng Zhao f81e8c3d6c change parameter naming 2021-07-16 14:27:53 -07:00
Fuheng Zhao d87e695fba format files 2021-07-16 14:02:59 -07:00
Fuheng Zhao 29d61b708f fix issues 2021-07-16 13:53:30 -07:00
Steve Atherton 8b0f03f6e8 CommitSubtree was still doing non-caching reads, this was unintentional. 2021-07-15 09:05:36 -07:00
Fuheng Zhao 08463e0a8b rename record_counter to count 2021-07-14 18:22:38 -07:00
Fuheng Zhao 1c7e3f08c2 format the files 2021-07-14 17:26:24 -07:00
Fuheng Zhao 126c87923f switch unitmapper to static arry 2021-07-14 16:31:13 -07:00
Steve Atherton 8a5caeb756 IO priority tweaks. Writes are lowest, queue reads are highest, reads for prefetch, lazy clear, or remap removal are at leaf priority. Count pager disk reads and writes when they start, after the lock is obtained. 2021-07-14 01:51:53 -07:00
Fuheng Zhao 737f053a7c modify the reference 2021-07-13 10:10:23 -07:00
sfc-gh-fzhao 5dabb71095
Update comment on metrics by level
Co-authored-by: Steve Atherton <steve.atherton@snowflake.com>
2021-07-13 09:07:39 -07:00
Fuheng Zhao 79a2950b2f move static potential combination outside the struct 2021-07-12 21:18:06 -07:00
Fuheng Zhao a2ebdaf394 make potential EventReason combinations static const member variables 2021-07-12 20:43:10 -07:00
Fuheng Zhao 4e0bfb05a0 make output more elegant 2021-07-12 19:34:49 -07:00
Fuheng Zhao 6ef332e18a put rangePrefetch statistics in L0 2021-07-12 19:04:09 -07:00
Fuheng Zhao 71966310b2 make level 0 a valid level to represent non BTree level counters 2021-07-12 16:18:16 -07:00
Fuheng Zhao 7dbe10617b format the code with devFormat 2021-07-12 16:07:18 -07:00
Fuheng Zhao 446b564a9d remove unnecessary include 2021-07-12 15:31:31 -07:00
Fuheng Zhao f1e287c9d5 fix height error in preload 2021-07-12 13:30:11 -07:00
Fuheng Zhao 87abc8d302 resolve conflicts 2021-07-12 12:57:40 -07:00
Fuheng Zhao b751f0efcd revert the previous change 2021-07-12 11:55:25 -07:00
Fuheng Zhao be9284c80a fix the minor error in passing height 2021-07-12 11:45:16 -07:00
Fuheng Zhao 5e26592df9 avoid passing reason and level infromation into getIfExists function 2021-07-12 09:26:32 -07:00
Fuheng Zhao dbbf5e2299 add an extra level to summarize non Btree events 2021-07-11 19:30:32 -07:00
Fuheng Zhao 0104edb651 todo: raneg prefetch to leaf level, and format file 2021-07-11 14:09:48 -07:00
Steve Atherton fe575b995a Added IO Priority to Redwood. 2021-07-09 05:05:08 -07:00
Steve Atherton f58d091148 Refactored PriorityMultiLock again, fixed bug where slots could be under-utilized, reduced overhead when locks are released without waiting. 2021-07-09 02:51:34 -07:00
Steve Atherton ac39fd65a7 Bug fixes in PriorityMultiLock related to destruction during a waiter callback. Removed a waitOrError() because it throws internal_error and shouldn't be needed anyway. 2021-07-08 16:16:20 -07:00
Steve Atherton 15a62c417a Less overhead per waiter execution in PriorityMultiLock. 2021-07-08 02:19:00 -07:00
Fuheng Zhao 78b56fe347 refactor get function 2021-07-07 11:22:50 -07:00
Steve Atherton 14724f3e54 Applied clang-format. 2021-07-06 23:24:57 -07:00
Fuheng Zhao fa5a408eb4 change trace message 2021-07-06 22:31:37 -07:00
Fuheng Zhao 4e429b93c7 remove some comments 2021-07-06 22:31:37 -07:00
Fuheng Zhao fbded481f6 tight bound idx 2021-07-06 22:31:37 -07:00
Fuheng Zhao 669c892931 update histogram record count in set page size function 2021-07-06 22:31:37 -07:00
Fuheng Zhao a8cc9dedef fix error in output 2021-07-06 22:31:37 -07:00
Fuheng Zhao 069d52a3cf update trace information and fix minor errors 2021-07-06 22:31:37 -07:00
Fuheng Zhao 4f23cc14ba format output 2021-07-06 22:31:37 -07:00
Fuheng Zhao 3544d1e99e output sketches summary 2021-07-06 22:31:37 -07:00