Commit Graph

5356 Commits

Author SHA1 Message Date
Xiaoxi Wang 0352e8ee0b pick busiest commit tag periodically 2020-08-02 18:38:56 +00:00
Xiaoxi Wang 92c1112c74 consider clear single key 2020-08-01 18:20:13 +00:00
Chaoguang Lin d9e5d65aaf Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-08-01 00:31:26 -07:00
Xiaoxi Wang 1f38c2f2a4 check clear sample on proxy 2020-08-01 06:48:40 +00:00
Meng Xu 0c49646486 Fix:FastRestore:rangeVersion must be 0 when no range file is used
otherwise, all mutations will be ignored by loaders as old mutations
2020-07-31 23:23:17 -07:00
Xiaoxi Wang 4f7dab4951 sample clear op on client 2020-08-01 06:14:52 +00:00
Meng Xu 27a3d37594 RestoreApplier:Change receivedBytes from double to long 2020-07-31 22:10:18 -07:00
Meng Xu e22baa552b FastRestoreApplier:Init stats variables 2020-07-31 21:56:03 -07:00
Meng Xu f36d5aa180 FR:Applier received bytes per batch 2020-07-31 17:48:55 -07:00
Chaoguang Lin fbe36ced23 Rewrite all \xff\xff/reboot_worker call 2020-07-31 16:33:16 -07:00
Evan Tschannen 0e3f4285ec added missing paraetheses 2020-07-31 16:05:21 -07:00
Meng Xu fec3de9b7b Fix RestoreLoader loadedLogBytes counter 2020-07-31 16:00:15 -07:00
Evan Tschannen 5c7b4c7acf Merge branch 'master' of github.com:apple/foundationdb 2020-07-31 15:58:13 -07:00
Evan Tschannen 81cdc64c58 re-added nowAssigned 2020-07-31 15:46:46 -07:00
Evan Tschannen c18dcb500c fixed compile error 2020-07-31 15:39:37 -07:00
Meng Xu 47c35a7a69 FastRestore:Add stats to ApplierBatchData 2020-07-31 14:59:45 -07:00
Meng Xu e4d2ab72fe DumpVersionBatch with log and file summary info 2020-07-31 14:21:33 -07:00
Xiaoxi Wang fc3dfc170f Merge branch 'master' of https://github.com/apple/foundationdb 2020-07-31 19:09:33 +00:00
Xiaoxi Wang c3a629588f add client transaction tag sample 2020-07-31 19:08:42 +00:00
Meng Xu 2f5293fcc7 Introduce knob FASTRESTORE_USE_LOG_FILE and FASTRESTORE_USE_RANGE_FILE 2020-07-31 10:40:29 -07:00
Meng Xu 37c3bd8615 FastRestore:Ensure FASTRESTORE_NOT_WRITE_DB only work in non simulation mode 2020-07-30 20:27:54 -07:00
Chaoguang Lin f2662a9a74 Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-07-30 19:01:11 -07:00
Chaoguang Lin 10540a3c73 Change error name and fix a bug in ExclusionInProgressRangeImpl::getRange() 2020-07-30 18:58:09 -07:00
Meng Xu 8cace30bb2 FastRestore:change TXN_BATCH_MAX_BYTES default to 1KB from 1MB 2020-07-30 16:43:35 -07:00
Young Liu bfa4eb9ab2 Resolve comments 2020-07-30 14:45:03 -07:00
Andrew Noyes db30943fbf
Merge pull request #3399 from sfc-gh-tclinkenbeard/vectorref-emplace-back
Add VectorRef::emplace_back
2020-07-30 13:01:22 -07:00
Meng Xu d16db8e733 FastRestore:Fix segmentation fault 2020-07-30 12:10:32 -07:00
Meng Xu d71361245b FastRestore:Short cut DB for get and clearange 2020-07-30 11:17:05 -07:00
Meng Xu ad915e462e Add knob FASTRESTORE_NOT_WRITE_DB to skip writting to DB 2020-07-30 10:17:17 -07:00
Xin Dong 1bd6ea51ac
Merge pull request #3572 from xumengpanda/mengxu/master-dd-failure-PR
Fix master branch failure on DDBalanceAndRemove.toml test
2020-07-30 10:07:41 -07:00
Meng Xu 17056b2a24
Fix comment grammar typo
Co-authored-by: Xin Dong <jiangzian1987dx@gmail.com>
2020-07-30 10:02:11 -07:00
Daniel Smith 6efd5996c2 Calculate data stored by Rocks 2020-07-29 22:08:32 +00:00
Xiaoge Su 871402f68d Add File field in TestFailure event for cycleCheck and incrementCheck
In workloads, cycleCheck and incrementCheck, both might trigger a test
failure with reason "Rate below desired rate", and the other text are
the same. Adding a File field will help differentiate these two events.
2020-07-29 14:57:05 -07:00
Daniel Smith fd973e5055 RocksDB fixes 2020-07-29 21:26:36 +00:00
Young Liu b5dc6b715f Add file comment for GrvProxyServer.actor.cpp 2020-07-29 12:10:53 -07:00
Young Liu cb0808a170 Resolve comments 2020-07-29 11:19:29 -07:00
Young Liu 86148f1277 Merge branch 'master' into grv-proxy 2020-07-29 11:14:51 -07:00
Young Liu fad18ad85a Remove more debug traces 2020-07-29 08:06:15 -07:00
Young Liu 30ea639666 Remove debug traces 2020-07-29 07:55:05 -07:00
Young Liu f7b76a92af pass joshua 2020-07-29 07:26:55 -07:00
Evan Tschannen a49cb41de7 Merge branch 'release-6.3'
# Conflicts:
#	CMakeLists.txt
#	cmake/ConfigureCompiler.cmake
#	fdbserver/Knobs.cpp
#	fdbserver/StorageCache.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	flow/ThreadHelper.actor.h
#	flow/serialize.h
#	tests/CMakeLists.txt
2020-07-29 00:31:55 -07:00
Meng Xu a2089b354a RemoveServersSafely:Safety check toKill1 to avoid cluster getting stuck
toKill1 and toKill2 are a random subset of all processes. If simply kill all processes in toKill1 or toKill2,
we may kill too many processes to make the cluster unavailable and stuck.

Similar as what toKill2 were modified if it can cause cluster unavailable,
we should do the same thing for toKill1
2020-07-28 21:07:31 -07:00
Trevor Clinkenbeard 602b0f9dea
Merge branch 'master' into vectorref-emplace-back 2020-07-28 17:17:11 -07:00
Meng Xu 35ebdec9d2
Merge pull request #3558 from sfc-gh-anoyes/anoyes/remove-redundant-cast
Remove redundant cast
2020-07-28 17:01:48 -07:00
Meng Xu 2b8aa296bb
Merge pull request #3482 from sfc-gh-tclinkenbeard/support-downgrades
Support and test downgrades
2020-07-28 17:00:54 -07:00
Chaoguang Lin 8a5fde1b85 change SPECIAL_KEY_SPACE_CHANGE_CONFIGURATION to SPECIAL_KEY_SPACE_ENABLE_WRITES 2020-07-28 12:03:00 -07:00
Andrew Noyes d2cf700bd4 Fix compiler warnings 2020-07-28 18:30:26 +00:00
Xiaoxi Wang 819e3ab3e8 Merge branch 'ratekeeper' 2020-07-28 16:48:50 +00:00
Steve Atherton f065cbbd2d
Merge pull request #3534 from sfc-gh-xwang/master
Throttling related workload improvements
2020-07-28 00:40:06 -07:00
Xiaoxi Wang 41a3e6c853 add write throttling 2020-07-28 03:49:47 +00:00
Chaoguang Lin 454ac21daf Add tests for errors introduced by writes module, and shema check for error message 2020-07-27 17:40:55 -07:00
Markus Pilman c6a2043d53
Merge pull request #3450 from sfc-gh-tclinkenbeard/6.3-use-vector-mutations
Replace VersionUpdateRef with VerUpdateRef
2020-07-27 15:21:47 -06:00
Chaoguang Lin a641429d63 Add an enum for implementation type and use for registeration 2020-07-27 12:29:03 -07:00
Evan Tschannen c3348be3a0 changed knobs to improve master recovery speeds 2020-07-27 10:59:06 -07:00
Evan Tschannen e0db748fb3
Merge pull request #3403 from satherton/tls-background-handshake
TLS handshaking in background threads
2020-07-27 10:55:00 -07:00
Evan Tschannen 937df4f839 Merge branch 'release-6.3' of github.com:apple/foundationdb into feature-lifetimetoken-fix
# Conflicts:
#	documentation/sphinx/source/release-notes/release-notes-630.rst
2020-07-27 10:03:02 -07:00
Young Liu b2df089f58 make storefront test pass for now 2020-07-26 10:23:29 -07:00
Young Liu 4b8633587a Add debug trace for storefront failure 2020-07-25 21:38:19 -07:00
Xin Dong 2ac7df8a18
Merge pull request #3563 from xumengpanda/mengxu/fr-filesize-PR
FastRestore:Add trace for file size and bc progress
2020-07-25 20:08:57 -07:00
Meng Xu 99d8399f4e FastRestore:Add trace for file size and bc progress 2020-07-25 19:12:25 -07:00
Young Liu 1826ac75d5 Add some trace events to debug 2020-07-25 18:16:08 -07:00
Xiaoxi Wang 436b6d823e use hyphen 2020-07-25 22:49:08 +00:00
Meng Xu 9d3b1cc4e4
Merge pull request #3562 from sfc-gh-anoyes/anoyes/memory-error
Fix memory error in report conflicting keys special keys
2020-07-24 21:11:42 -07:00
Xiaoxi Wang 48a0fb5154 ask DD for shard info 2020-07-25 04:08:12 +00:00
Evan Tschannen 792eaa2174
Merge pull request #3560 from etschannen/release-6.3
Merge Release 6.2 into Release 6.3
2020-07-24 17:06:15 -07:00
Evan Tschannen cb00879c62
Merge pull request #3561 from satherton/feature-redwood
Redwood pager remapped page cleanup now coalesces writes within a large trailing version window.
2020-07-24 16:56:22 -07:00
Andrew Noyes bc412f39a6 Augment ReportConflictingKeys test to catch memory error 2020-07-24 23:31:00 +00:00
Evan Tschannen e1dedff7b3 Merge branch 'release-6.2' into release-6.3
# Conflicts:
#	CMakeLists.txt
#	bindings/c/test/mako/mako.c
#	cmake/ConfigureCompiler.cmake
#	documentation/sphinx/source/downloads.rst
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/FileBackupAgent.actor.cpp
#	packaging/msi/FDBInstaller.wxs
#	versions.target
2020-07-24 12:10:44 -07:00
Andrew Noyes c15ae7ff02 Remove redundant cast
We don't need to cast away constness here. It's already not const
2020-07-24 16:20:38 +00:00
Young Liu df6b676ccb Fix status bug and backup minKnownCommittedVersion bug 2020-07-24 00:49:16 -07:00
Young Liu 06c081c714 Merge master branch and resolve conflicts 2020-07-23 22:41:10 -07:00
Young Liu 0fc681cc3c Remote some code comments 2020-07-23 22:29:51 -07:00
Young Liu 618414a416 Fix bugs related to getting proxies workers 2020-07-23 18:32:47 -07:00
Young Liu ff4bae5cd3 Fix status test 2020-07-23 12:04:02 -07:00
Young Liu 229ab0d5f1 Fix some conflicts and remote debugging trace events 2020-07-22 23:35:46 -07:00
Meng Xu 05b7d53cc4
Merge pull request #3538 from sfc-gh-tclinkenbeard/make-idatadistributor-constcorrect
Make IDataDistributorTeam const-correct
2020-07-22 22:29:09 -07:00
Young Liu 525f10e30c Merge master branch 2020-07-22 16:08:49 -07:00
Young Liu 302cf5c45f Remove debug trace events 2020-07-22 12:20:22 -07:00
Russell Sears ab0d8b0626
Merge pull request #3509 from sfc-gh-anoyes/anoyes/remove-using-relops
Remove using namespace std::rel_ops
2020-07-22 11:58:25 -07:00
Evan Tschannen bce3b3d401
Merge pull request #3545 from jzhou77/release-6.3
Fix restore_destination_not_empty error in BackupToDB tests
2020-07-22 11:02:37 -07:00
Evan Tschannen ce5deeded1
Merge pull request #3540 from sfc-gh-anoyes/anoyes/fix-pessimizing-moves
Fix several pessimizing move warnings
2020-07-22 11:00:30 -07:00
Xiaoxi Wang 6ef3d04fd7 slight change 2020-07-22 06:16:11 +00:00
Jingyu Zhou 9bf02584a0 Fix restore_destination_not_empty error 2020-07-21 22:56:51 -07:00
Xiaoge Su fdf09c5d00 Use move semantic instead of copy for transactions in commitBatch 2020-07-21 15:36:39 -07:00
sfc-gh-tclinkenbeard 3755b25c43 Make IDiskQueue const-correct 2020-07-21 14:45:04 -07:00
Meng Xu aa4c378cd7
Merge pull request #3539 from apple/release-6.3
Merge Release 6.3 into master
2020-07-21 14:05:13 -07:00
Andrew Noyes c9515fa5d7 Fix several pessimizing move warnings 2020-07-21 19:49:52 +00:00
sfc-gh-tclinkenbeard 638f586f78 Remove unnecessary override 2020-07-21 11:05:46 -07:00
sfc-gh-tclinkenbeard 83c5a30f62 Add encapsulation to TCTeamInfo and ParallelTCInfo 2020-07-21 11:05:41 -07:00
sfc-gh-tclinkenbeard 9a2ce4c981 Make IDataDistributionTeam const-correct 2020-07-21 11:05:34 -07:00
Steve Atherton 5268dbe1ec Use knob for remap cleanup window in write speed test. 2020-07-21 00:42:08 -07:00
Evan Tschannen 54161928aa Merge branch 'release-6.3' of github.com:apple/foundationdb into feature-lifetimetoken-fix 2020-07-20 22:41:05 -07:00
sfc-gh-tclinkenbeard abaae40453 Modified ComposedIdentifier to prevent file identifier conflicts at
compile-time
2020-07-20 18:52:44 -07:00
Xiaoxi Wang 893898818c merge master 2020-07-20 23:38:05 +00:00
Xiaoxi Wang bce0c2758e add fastSuccess 2020-07-20 23:27:20 +00:00
Russell Sears 9416e9139e
Merge pull request #3466 from sears/numeric_asserts
Improved assert messages for numeric comparisons
2020-07-20 14:52:40 -07:00
Russell Sears aa6743e118 improved readability of numeric assertion failures 2020-07-20 14:13:52 -07:00
Evan Tschannen 220ede3564 fixed compile error 2020-07-20 11:35:20 -07:00
Meng Xu b2a3b4fd83 Merge branch 'master' into mengxu/merge-6.3-PR 2020-07-20 11:34:18 -07:00
Evan Tschannen be67e9cfc7 wait for the correct cluster controller interface before starting master recovery 2020-07-20 11:29:37 -07:00
Evan Tschannen 3834682820 Merge branch 'release-6.3' of github.com:apple/foundationdb into feature-lifetimetoken-fix 2020-07-20 10:35:04 -07:00
Evan Tschannen 32c0169fc8 use the old logic for lifetime since we already have verified the cluster controller is correct 2020-07-20 10:26:47 -07:00
Steve Atherton e646361501 Merge branch 'release-6.3' of github.com:apple/foundationdb into feature-redwood 2020-07-20 07:25:29 -07:00
Steve Atherton d05b7ee785 Pager remap remover now accumulates a configurable version interval of page updates behind the oldest retained version which are used to coalesce updates to the same original page ID to reduce write amplification for many workloads. 2020-07-20 04:08:33 -07:00
Alex Miller 878254497a Merge remote-tracking branch 'upstream/master' into toml-testspec 2020-07-19 22:18:31 -07:00
Xiaoxi Wang f3ee60b10b slight change 2020-07-20 03:17:46 +00:00
Chaoguang Lin c7206aedbf Add special keys writes handling in FuzziApiCorrectness workload 2020-07-19 19:16:52 -07:00
Xiaoxi Wang 1c483d3423 rewrite Throttling.actor.cpp; fix '/' bug in HealthMetricsApi 2020-07-20 01:20:14 +00:00
Steve Atherton 38cade1146 Merged tag release-6.3.3 into tls-background-handshake. 2020-07-17 23:39:57 -07:00
Young Liu 2703cedac5 Fixed known bugs 2020-07-17 22:24:52 -07:00
Meng Xu f22a6c2bcf
Merge pull request #3512 from sfc-gh-xwang/master
Add write/atomicOp/clear cost estimation
2020-07-17 20:19:09 -07:00
Xiaoxi Wang 0df2a8d014 better code style 2020-07-18 01:48:58 +00:00
Jingyu Zhou b0983f4a9a
Merge pull request #3530 from xumengpanda/mengxu/ssfailure-fix-PR
Fix wild pointer to destructed DD that causes DD crash rarely
2020-07-17 18:08:50 -07:00
Chaoguang Lin 6216dce22d Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-07-17 16:14:22 -07:00
Meng Xu df39a0eaa8
Merge pull request #3479 from sfc-gh-anoyes/anoyes/add-wall-wextra
Add -Wall and -Wextra for clang, and explicitly ignore some warnings for now
2020-07-17 15:07:41 -07:00
Evan Tschannen 6a38f81269 do not kill the master unless we have a dbInfo from the current cluster controller 2020-07-17 14:59:38 -07:00
Meng Xu 1ba9b6b07f DD:Change SendRelocateToDDQx100 to SendRelocateToDDQueue 2020-07-17 14:10:17 -07:00
Evan Tschannen e4613bcdb2 fix: do not kill a master because on an uninitialized lifetime token 2020-07-17 10:40:52 -07:00
Steve Atherton d375ee7939 Rolled back the knob and logic for doing multiple write() calls in write loops before yielding, because they are not necessary. The testing that suggested otherwise was in error. 2020-07-16 22:54:14 -07:00
Meng Xu 098cdfb558 Replace actor_cancelled error with dd_cancelled 2020-07-16 20:26:07 -07:00
Meng Xu d161d8f298 Merge branch 'release-6.3' into mengxu/fr-rename-master-PR 2020-07-16 16:46:32 -07:00
Meng Xu 8cffd30951 FastRestore:Replace master word with controller 2020-07-16 16:37:13 -07:00
Young Liu 21c1998cca Fix MaxTLogQueueSize Bug 2020-07-16 15:56:04 -07:00
Meng Xu 49095160e3
Merge pull request #3267 from Nishikoh/rename
Rename fastRestore_agent to fastRestoreTool
2020-07-16 15:33:07 -07:00
Meng Xu ba3c631350 Remove spammy trace 2020-07-16 10:33:24 -07:00
Meng Xu 638e612a97 Improve coding style and trace events 2020-07-16 10:25:42 -07:00
Meng Xu acbb389862 Debug and fix very rare crash in TeamTracker
teamTracker only works when all DDTeamCollections are valid.
However, teamTracker can be triggered by zeroTeamSignalling event
after a DDTeamCollection is destructed and the other DDTeamCollection has not been
destructed yet.

This causes teamTracker to uses a pointer to the destructed DDTeamCollection and thus
has mysterious failure.
2020-07-16 10:23:02 -07:00
Steve Atherton c4f3553826 TLS handshake limit changed to regular flow lock, added new knob for simultaneous handshakes limit and removed old knobs. Added knob to control how much data the FlowTransport connectionWriter() can write using multiple write() calls before yielding to other tasks, and updated p2p network test to use the same logic. Changed knob defaults for send limit on single writes and TLS handshake thread count. 2020-07-16 02:31:17 -07:00
Xiaoxi Wang 9d0d189cc8 better serialize; TransactionOption::clear patch 2020-07-15 22:39:21 +00:00
Xin Dong e3f89ec3d1
Merge pull request #3526 from xumengpanda/mengxu/tmp-minor-PR
Add number comment to limitReason_t entries
2020-07-15 11:06:14 -07:00
Meng Xu 27a21e23bd Add number comment to limitReason_t entries 2020-07-15 10:57:50 -07:00
Xiaoxi Wang eb44ae0e86 finish local shard estimation 2020-07-15 16:08:00 +00:00
Young Liu 5b06d69d25 Pass watches test 2020-07-15 00:37:41 -07:00
Xiaoxi Wang bcb858288b eliminate cost estimation when tagSet is empty 2020-07-14 23:07:21 +00:00
Evan Tschannen 7affda3c8b Merge branch 'release-6.3'
# Conflicts:
#	CMakeLists.txt
2020-07-14 14:57:24 -07:00
Chaoguang Lin 3f4da830a2 Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-07-14 10:36:47 -07:00
Xiaoxi Wang a310faf9d1 solve some code reviews 2020-07-14 17:19:55 +00:00
Jingyu Zhou 773e533a09 Make Arena's impl private 2020-07-13 21:39:36 -07:00
Jingyu Zhou 9cb83db2ef
Merge pull request #3501 from xumengpanda/mengxu/tmp-minor-comment-PR
Minor improvement on comments
2020-07-13 19:02:13 -07:00
Xiaoxi Wang c56daf3be7 merge with master 2020-07-14 01:08:56 +00:00
Xiaoxi Wang d512170cd8 add clear cost estimation 2020-07-14 00:18:52 +00:00
Meng Xu 29da89525f
Merge pull request #3510 from apple/release-6.3
Merge Release 6.3 into master
2020-07-13 17:09:47 -07:00
Meng Xu 815e403009 Add comment to DDQueue GetTeam
Comments to help understand Evan's PR 3487
that fix the problem: replication factor could drop unexpected in fearless config.
2020-07-13 17:05:50 -07:00
Meng Xu 47ae66bd61 Merge branch 'master' into mengxu/tmp-minor-comment-PR
Resolve conflict at waitFailureClient
2020-07-13 16:17:50 -07:00
Evan Tschannen fc49f432c6
Merge pull request #3437 from ajbeamon/auto-tag-throttling-fixes
Various fixes to tag throttling
2020-07-13 10:52:46 -07:00
Xiaoxi Wang 6ec2f92a8d merge master 2020-07-13 17:22:37 +00:00
Xiaoxi Wang c06d24497f send commitCostEstimation to ratekeeper 2020-07-13 17:18:13 +00:00
Meng Xu ef8c1060a2 Merge branch 'master' into mengxu/tmp-merge-6.3 2020-07-13 10:15:56 -07:00
Meng Xu efc446f529 Add a comment to DD 2020-07-13 10:12:39 -07:00
Meng Xu ea48975c6e
Merge pull request #3492 from ajbeamon/merge-release-6.2-into-release-6.3
Merge release 6.2 into release 6.3
2020-07-13 10:02:13 -07:00
Meng Xu eb401e1788
Merge pull request #3503 from sfc-gh-tclinkenbeard/relax-commit-latency
Relax commit latency requirement for LowLatency workload
2020-07-13 09:39:27 -07:00
sfc-gh-tclinkenbeard d0189ad0d4 Relax commit latency requirement for LowLatency workload 2020-07-12 20:01:57 -07:00
Alex Miller eb7ad07df0 Final cleanups. 2020-07-12 19:53:44 -07:00
Alex Miller 0a8f61b967 Make TOML mandatory. 2020-07-12 19:43:38 -07:00
Alex Miller 2876763623 Add errors if unknown params are used in a global or test section. 2020-07-12 19:41:09 -07:00
Meng Xu 6f2e12be42 Minor improvement on comments 2020-07-12 18:32:47 -07:00
sfc-gh-tclinkenbeard de2b35f727 Simplified Downgrade workload 2020-07-12 16:08:54 -07:00
Alex Miller 0131f0dc48 Make simulation able to load and run .toml files 2020-07-12 14:47:39 -07:00
Alex Miller 464e9332e4 Refactor testspec parsing.
This separates the file format and how to read it from how to apply a key/value
to a TestSpec.  This will allow us to reuse the same code when implementing a
TOML parser later.
2020-07-12 14:47:39 -07:00
Alex Miller c20fc87d6a Fix the cmake things 2020-07-12 14:47:39 -07:00
Alex Miller f08f0255cc Copy paste cmake code until it seems like it maybe downloads TOML11 2020-07-12 14:47:39 -07:00
Jingyu Zhou 749e3e9d86 Address review comment 2020-07-10 18:07:17 -07:00
Xiaoxi Wang 5986ed3a3b Merge branch 'cost' 2020-07-10 23:08:03 +00:00
Xiaoxi Wang 6374cd96c9 add commit cost estimation 2020-07-10 23:07:29 +00:00
Andrew Noyes f470ba8316 Remove using namespace std::rel_ops
This causes the following to not compile anymore

\#include <utility>
\#include <vector>

using namespace std::rel_ops;

int main() {
    std::vector<int> xs;
    return xs.rbegin() != xs.rend();
}

See https://godbolt.org/z/s1977n
2020-07-10 22:58:15 +00:00
Jingyu Zhou 5cc5d9cf1e Log peer address whose failure can cause master recovery
So when there is master recovery due to failed tlog, proxy, resolver, log
router, or resolver, we can have a trace event tells which address that the
master thinks is dead.
2020-07-10 15:57:03 -07:00
A.J. Beamon b09dddc07e Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
# Conflicts:
#	cmake/ConfigureCompiler.cmake
#	documentation/sphinx/source/downloads.rst
#	fdbrpc/FlowTransport.actor.cpp
#	fdbrpc/fdbrpc.vcxproj
#	fdbserver/DataDistributionQueue.actor.cpp
#	fdbserver/Knobs.cpp
#	fdbserver/Knobs.h
#	fdbserver/LogSystemPeekCursor.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/Status.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	flow/flow.vcxproj
2020-07-10 15:06:34 -07:00
Jingyu Zhou 2e5ae8eed5 Change iterator name to small case 2020-07-10 10:56:41 -07:00
Jingyu Zhou 1a57d88179 Add const iterator for RangeMap 2020-07-10 10:56:41 -07:00
Evan Tschannen 4492a50e72 Merge branch 'release-6.2' of github.com:apple/foundationdb into feature-ha-fixes
# Conflicts:
#	documentation/sphinx/source/mr-status-json-schemas.rst.inc
#	documentation/sphinx/source/mr-status.rst
#	fdbclient/Schemas.cpp
2020-07-10 10:37:43 -07:00
Evan Tschannen 2f22ce1677
Merge pull request #3484 from ajbeamon/change-latency-sample-size
Increase size of latency sample
2020-07-10 10:32:10 -07:00
Evan Tschannen 8befb0829d
Merge pull request #3481 from ajbeamon/fix-dc-timeout-message
Add missing messages to schema and rename one to match later versions
2020-07-10 10:30:21 -07:00
A.J. Beamon 28b6281848 Increase latency sample size by a factor of 10. 2020-07-10 08:52:59 -07:00
Evan Tschannen dd10dbe7c7 Merge branch 'release-6.2' of github.com:apple/foundationdb into feature-ha-fixes 2020-07-09 23:09:14 -07:00
Evan Tschannen 33c9b1374a more compile fixes 2020-07-09 22:57:43 -07:00
Evan Tschannen f6163d0a79 fix compile errors 2020-07-09 22:53:02 -07:00
Evan Tschannen 717242a0ee reset WAN network connections every 5 minutes is responses take more than 500ms 2020-07-09 22:50:47 -07:00
Meng Xu 7bbdfeca05
Merge pull request #3474 from jzhou77/master
Use KeyRangeMap for splitMutation
2020-07-09 21:52:12 -07:00
Markus Pilman 27ee5dc4de fixed refactoring bug 2020-07-09 20:13:54 -06:00
sfc-gh-tclinkenbeard bb54f8ab8a Parametrize numObjects in Downgrade workload 2020-07-09 17:52:34 -07:00
A.J. Beamon b51beead53 The backport of a change in later versions didn't include some updates to the schema and a change to the name of one of the messages. 2020-07-09 16:58:13 -07:00
A.J. Beamon 04d1217941 Track statistics about server-side request latency on each process, to include min, max, mean, and various percentiles. 2020-07-09 16:39:15 -07:00
sfc-gh-tclinkenbeard cf4f753836 Test ArenaReader in Downgrade workload 2020-07-09 16:26:27 -07:00
Markus Pilman cc60597739
Merge branch 'master' into bugfixes/visibility-perf-regression 2020-07-09 17:04:04 -06:00
Andrew Noyes 6446b4c082 WIP 2020-07-09 22:02:43 +00:00
sfc-gh-tclinkenbeard 373b5ffb4f Added forward compatibility and Downgrade workload 2020-07-09 14:28:35 -07:00
Xiaoxi Wang 2a848edb41 Merge remote-tracking branch 'upstream/master' 2020-07-09 18:10:38 +00:00
Xiaoxi Wang c40c4693b4 better correctness criteria 2020-07-09 18:10:12 +00:00
Markus Pilman 69864c9f96 Make Spans not allocate heap memory 2020-07-09 11:49:33 -06:00
Evan Tschannen 0e2f5e8bb5 Added a flow lock to prevent too many source server fetches from happening at the same time and running the data distributor out of memory 2020-07-09 10:38:19 -07:00
Meng Xu 1dead7c199
Merge pull request #3440 from sfc-gh-xwang/master
add HealthMetricsWorkload and WriteTagThrottlingWorkload
2020-07-09 10:04:46 -07:00
Jingyu Zhou a5af214861 Use KeyRangeMap for splitMutation
This simplifies code by reuse KeyRangeMap class.
2020-07-09 09:59:37 -07:00
Xiaoxi Wang 25e55d4b9a add simplest correctness check 2020-07-09 05:57:27 +00:00
Xiaoxi Wang 9e8a2c1434 add comment 2020-07-09 04:39:31 +00:00
Meng Xu 1b68665228 Merge branch 'master' into release-6.3 2020-07-08 18:52:05 -07:00
Meng Xu 2f602b42e9 Revert "Merge pull request #3467 from jzhou77/release-6.3"
This reverts commit 32d76fcff1, reversing
changes made to 5e8eeadd7e.
2020-07-08 18:51:54 -07:00
Meng Xu 32d76fcff1
Merge pull request #3467 from jzhou77/release-6.3
Use KeyRangeMap for splitMutation
2020-07-08 18:40:47 -07:00
Jingyu Zhou 7279beb662 Add old splitMutation for unit test 2020-07-08 17:57:20 -07:00
Jingyu Zhou d6dd88c2b9 Move building of KeyRangeMap out of the loop
So that it is only done once.
2020-07-08 14:16:10 -07:00
Meng Xu d61206e126
Merge pull request #3453 from thisismiller/restrict-testspec
Make testspec more restrictive and correctly "scoped"
2020-07-08 11:43:37 -07:00
Jingyu Zhou a187eeebee Add assertions back and comments for splitMutation 2020-07-08 11:08:23 -07:00
Russell Sears 5e8eeadd7e
Merge pull request #3446 from sfc-gh-tclinkenbeard/use-stl-for-optional-variant
Use STL for optional and variant
2020-07-08 10:40:17 -07:00
Evan Tschannen 3eb3e23ae0
Merge pull request #3425 from sfc-gh-anoyes/anoyes/health-metrics
Expose health metrics via special keys
2020-07-08 10:37:31 -07:00
Andrew Noyes fa266b1272 Address review comments 2020-07-08 16:54:54 +00:00
Jingyu Zhou e78cc9ee4b Use KeyRangeMap for splitMutation
This simplifies code by reuse KeyRangeMap class.
2020-07-08 09:53:34 -07:00
Young Liu 7afee53f4c Clean up code that serves GRV through other proxies 2020-07-07 21:19:11 -07:00
Markus Pilman 0fbe7101c3 Revert "Revert "Request tracing""
This reverts commit 327cc31e35.
2020-07-07 10:06:13 -06:00
Chaoguang Lin a43afb9d97 Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-07-06 15:47:00 -07:00
sfc-gh-tclinkenbeard e516a20c43 Revert "Fixed some dangling pointers"
This reverts commit 0c39006b07.
2020-07-06 15:26:42 -07:00
Steve Atherton 97cc0a63e0 P2P network test now does a request/response sequence on outgoing connections and repeats it a configurable number of times. 2020-07-06 15:14:53 -07:00
Jingyu Zhou cd75cce8fe
Merge pull request #3441 from yliucode/fix-joshua-real
Re-enable asking read version from master
2020-07-06 13:35:35 -07:00
Young Liu 832c6d0d65 Add comment about invariant master's committed version >= proxy's committedVersion 2020-07-06 12:34:15 -07:00
Xiaoxi Wang e29333656f better wait 2020-07-06 18:36:06 +00:00
Xiaoxi Wang 627075e0ef 1. add test parameters; 2. change ContinuousSample initialization 3. add&change metrics 2020-07-06 18:18:15 +00:00
Alex Miller 17570b5b10 Make the testspec more restrictive in terms of what can be set where.
Testspec is currently very permissive in very misleading ways.  In particular,
the tester parser itself will swallow K=V settings and apply them at the test
level, which breaks how a person would expect the scoping to work.  Other
settings apply to the entire simulation run globally, but appear to be workload
specific.  Even further, others affect simulation cluster creation or test
harness behavior, but can again be set anywhere in a testspec.

This changes testspec parsing to error if a setting that applies globally is
anywhere but the top of the file, or if a setting that applies test-wide is
applied to a workload instead of a test.
2020-07-06 02:03:30 -07:00
sfc-gh-tclinkenbeard e6d92c9fbe Test writes in LowLatency workload 2020-07-05 14:49:04 -07:00
tclinken 28dc47efb2 Replace VersionUpdateRef with VerUpdateRef 2020-07-04 22:17:21 -07:00
sfc-gh-tclinkenbeard 1b55d75896 Remove TRIVIALLY_DESTRUCTIBLE macro 2020-07-04 19:28:10 -07:00
sfc-gh-tclinkenbeard dd5cd762a8 Removed dead code 2020-07-04 12:50:40 -07:00
sfc-gh-tclinkenbeard 0c39006b07 Fixed some dangling pointers 2020-07-04 12:50:40 -07:00
sfc-gh-tclinkenbeard bcbca81dfe Remove ROW_LIMIT_UNLIMITED and BYTE_LIMIT_UNLIMITED from CLIENT_KNOBS 2020-07-04 12:48:44 -07:00
Young Liu 44331f50dc Add back conditional report 2020-07-03 17:26:44 -07:00
Xiaoxi Wang 121465b051 change metrics
fix latency sum bug
2020-07-03 21:49:44 +00:00
Steve Atherton a8d56ddd41 Don't delay after incoming accept() error. 2020-07-03 12:22:41 -07:00
Xiaoxi Wang 98b3ef69aa 1.change metrics; 2.change the way to generate key (avoid to much confict) 2020-07-03 00:20:39 +00:00
Russell Sears fcaaf11678
Merge pull request #3402 from sfc-gh-tclinkenbeard/improve-const-correctness
Added more const-correctness improvements
2020-07-02 16:43:06 -07:00
Young Liu 286988c914 Report commit version later in the commit path 2020-07-02 16:14:50 -07:00
Young Liu 7546ed3edf Remove trace events 2020-07-02 15:17:11 -07:00
Young Liu 323c65071d Discard the condition to report commit version: only when commitVersion > committedVersion and leave trace events 2020-07-02 15:13:28 -07:00
Young Liu 31c70a873f Report commit version to master as soon as possible 2020-07-02 15:13:28 -07:00
Young Liu ed89d69916 Change order between reporting commit version and setting committedVersion 2020-07-02 15:13:28 -07:00
Daniel Smith bca740342b Merge remote-tracking branch 'upstream/release-6.3' into rocksdb-fixes 2020-07-02 20:34:50 +00:00
Xiaoxi Wang c1face27f1 fix dangling pointer bugs 2020-07-02 18:35:39 +00:00
Xiaoxi Wang 55315ea550 1. add different tags to different work; 2. clang format 2020-07-02 16:10:17 +00:00
KoukiNishihara ab3de8700e Rename fastRestoreAgent to fastRestoreTool 2020-07-03 00:16:39 +09:00
Steve Atherton acddb68aba
Merge pull request #3381 from Daniel-B-Smith/rocksdb-corruption
Allow detection of storage engines by presence of directory.
2020-07-01 22:11:13 -07:00
Xiaoxi Wang 25201be0ad fix TransactionTagRef construction 2020-07-01 23:46:04 +00:00
Xiaoxi Wang 73554fe242 1.add tag logic; 2.fix typo; 3. enable simulation test 2020-07-01 23:27:47 +00:00
Xiaoxi Wang 7dbd1acc31 1.initialize member varibles; 2. code format 2020-07-01 18:50:35 +00:00
Xiaoxi Wang 03535abd18 replace LONG_LONG_MAX with LLONG_MAX(c++11) 2020-07-01 16:23:11 +00:00
Alex Miller c76e0cfe04 Add a ReadAfterWrite workload, to measure TLog->SS propagation delay. 2020-07-01 02:17:43 -07:00
Xiaoxi Wang 74b1146d5b reformat code 2020-07-01 06:46:30 +00:00
Xiaoxi Wang 6ebd3c8083 1. add range clear operation to workload
2. add tag logic to WriteTagThrottling
2020-07-01 06:35:14 +00:00
Xiaoxi Wang ad6904413c Merge branch 'master' of https://github.com/apple/foundationdb 2020-07-01 04:58:02 +00:00
Xiaoxi Wang dc568cad21 add HealthMetricsWorkload and WriteTagThrottlingWorkload to prepare for new throttling feature 2020-07-01 04:56:21 +00:00
Young Liu ab95de6e1e Add a warning message 2020-06-30 17:43:07 -07:00
Young Liu e613d85895 Fix errors in joshua related to PR_3307 2020-06-30 17:22:59 -07:00
A.J. Beamon 11b136c745 Various fixes to tag throttling:
* Master proxy reports transaction counts to ratekeeper for throttled tags only
* The ramp up behavior at the end of an auto-throttle was broken
* Fixed some issues with computing the initial transaction rate for auto-throttles
2020-06-30 16:24:41 -07:00
Jingyu Zhou 20658f0326
Merge pull request #3428 from yliucode/fix-lock-grv
Fix getting read version while locked
2020-06-30 11:14:44 -07:00
Meng Xu f3302833ce
Merge pull request #3435 from apple/release-6.3
Merge Release 6.3 to master
2020-06-30 10:08:28 -07:00