Commit Graph

2742 Commits

Author SHA1 Message Date
Chaoguang Lin a1eeb9c3ee Update traces for debugging 2020-07-17 12:36:50 -07:00
Chaoguang Lin 1e5096990e Add the function to return the special key for given management api command and option 2020-07-17 12:32:42 -07:00
Chaoguang Lin 96e5a4c827 Replace all \xff\xff/conf with managementApiRange.begin 2020-07-17 11:56:27 -07:00
Chaoguang Lin 4d993771e4 Add managementApiRange KeyRangeRef in SystemData.h 2020-07-17 10:40:22 -07:00
Chaoguang Lin 5fa6785fb8 Add special keys for command options 2020-07-16 18:15:35 -07:00
Meng Xu d161d8f298 Merge branch 'release-6.3' into mengxu/fr-rename-master-PR 2020-07-16 16:46:32 -07:00
Meng Xu 8cffd30951 FastRestore:Replace master word with controller 2020-07-16 16:37:13 -07:00
Young Liu 21c1998cca Fix MaxTLogQueueSize Bug 2020-07-16 15:56:04 -07:00
Meng Xu 49095160e3
Merge pull request #3267 from Nishikoh/rename
Rename fastRestore_agent to fastRestoreTool
2020-07-16 15:33:07 -07:00
Chaoguang Lin 52778bdf84 Add debugging trace 2020-07-15 17:30:45 -07:00
Daniel Smith a88bbd6405 s/fake/declval/ 2020-07-15 23:33:01 +00:00
Chaoguang Lin 1e7db425d0 fix bug when returning the error message for checkExclusion 2020-07-15 16:15:43 -07:00
Xiaoxi Wang 9d0d189cc8 better serialize; TransactionOption::clear patch 2020-07-15 22:39:21 +00:00
Jingyu Zhou 6c06f7f945
Merge pull request #3515 from oleg68/fdbbackup_symlink
Unclear error message in fdbbackup if the backup url uses a symlink
2020-07-15 10:20:52 -07:00
Xiaoxi Wang eb44ae0e86 finish local shard estimation 2020-07-15 16:08:00 +00:00
Young Liu 5b06d69d25 Pass watches test 2020-07-15 00:37:41 -07:00
Xiaoxi Wang bcb858288b eliminate cost estimation when tagSet is empty 2020-07-14 23:07:21 +00:00
Chaoguang Lin 3593ceffde Add back previous implementation code for versioning 2020-07-14 12:38:06 -07:00
Chaoguang Lin e9d0205091 fix a boundary bug when throw cross-module-clear errors 2020-07-14 11:56:40 -07:00
Chaoguang Lin 3f4da830a2 Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-07-14 10:36:47 -07:00
Chaoguang Lin 1635e8e0ba using special keys in management api for include when api_version >= 700 2020-07-14 10:31:19 -07:00
Xiaoxi Wang a310faf9d1 solve some code reviews 2020-07-14 17:19:55 +00:00
Chaoguang Lin 4d7e573469 using special keys in management api for exclude when api_version >= 700 2020-07-14 09:52:38 -07:00
Oleg Samarin 18964fae2a Unclear error message in fdbbackup if the backup url uses a symlink 2020-07-14 15:39:31 +03:00
Xiaoxi Wang c56daf3be7 merge with master 2020-07-14 01:08:56 +00:00
Xiaoxi Wang d512170cd8 add clear cost estimation 2020-07-14 00:18:52 +00:00
Chaoguang Lin 60d1bfc247 Add read impl for inProgressExclusionServers 2020-07-13 13:35:25 -07:00
Chaoguang Lin b0b601478c Add TODO comments 2020-07-13 13:34:15 -07:00
Chaoguang Lin 13c37f7e10 Fix the wrong name in header 2020-07-13 11:41:20 -07:00
Chaoguang Lin 2a434791ad Exposing transaction based function to get excluded and failed server addresses 2020-07-13 10:28:34 -07:00
Chaoguang Lin 407985e142 Revert separating excluding function into excluded and failed 2020-07-13 10:25:36 -07:00
Xiaoxi Wang 6ec2f92a8d merge master 2020-07-13 17:22:37 +00:00
Meng Xu ef8c1060a2 Merge branch 'master' into mengxu/tmp-merge-6.3 2020-07-13 10:15:56 -07:00
Chaoguang Lin 69a8c16e1c Fix the bug that forgot to break after setting the transaction option 2020-07-12 11:04:54 -07:00
Chaoguang Lin b8251878c4 Separating two functions for excluded and failed list. Exposing transaction based interface from Management Api 2020-07-12 10:41:46 -07:00
Meng Xu dfca94d00f
Merge pull request #3488 from jzhou77/rangemap
Add const iterator for RangeMap
2020-07-10 20:48:09 -07:00
Xiaoxi Wang 5986ed3a3b Merge branch 'cost' 2020-07-10 23:08:03 +00:00
Xiaoxi Wang 6374cd96c9 add commit cost estimation 2020-07-10 23:07:29 +00:00
Andrew Noyes f470ba8316 Remove using namespace std::rel_ops
This causes the following to not compile anymore

\#include <utility>
\#include <vector>

using namespace std::rel_ops;

int main() {
    std::vector<int> xs;
    return xs.rbegin() != xs.rend();
}

See https://godbolt.org/z/s1977n
2020-07-10 22:58:15 +00:00
A.J. Beamon b09dddc07e Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
# Conflicts:
#	cmake/ConfigureCompiler.cmake
#	documentation/sphinx/source/downloads.rst
#	fdbrpc/FlowTransport.actor.cpp
#	fdbrpc/fdbrpc.vcxproj
#	fdbserver/DataDistributionQueue.actor.cpp
#	fdbserver/Knobs.cpp
#	fdbserver/Knobs.h
#	fdbserver/LogSystemPeekCursor.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/Status.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	flow/flow.vcxproj
2020-07-10 15:06:34 -07:00
Jingyu Zhou 90654628fb
Merge pull request #3490 from apple/release-6.3
Merge Release 6.3
2020-07-10 12:54:37 -07:00
Jingyu Zhou 2e5ae8eed5 Change iterator name to small case 2020-07-10 10:56:41 -07:00
Evan Tschannen 8befb0829d
Merge pull request #3481 from ajbeamon/fix-dc-timeout-message
Add missing messages to schema and rename one to match later versions
2020-07-10 10:30:21 -07:00
Jingyu Zhou abfc3effe4
Merge pull request #3483 from oleg68/detach-dr-clone-63
Detach a Clone of DR Site without Affecting Replication to the Original DR Site
2020-07-10 09:38:21 -07:00
Oleg Samarin 4c9df78076 dstonly 2020-07-10 15:13:42 +03:00
A.J. Beamon b51beead53 The backport of a change in later versions didn't include some updates to the schema and a change to the name of one of the messages. 2020-07-09 16:58:13 -07:00
A.J. Beamon 693595f4e5 Fix make build, fix GRV schema 2020-07-09 16:50:08 -07:00
A.J. Beamon 04d1217941 Track statistics about server-side request latency on each process, to include min, max, mean, and various percentiles. 2020-07-09 16:39:15 -07:00
Markus Pilman cc60597739
Merge branch 'master' into bugfixes/visibility-perf-regression 2020-07-09 17:04:04 -06:00
Andrew Noyes 941cf7b03b Fix const return warning 2020-07-09 22:17:54 +00:00
Andrew Noyes 6446b4c082 WIP 2020-07-09 22:02:43 +00:00
Markus Pilman 69864c9f96 Make Spans not allocate heap memory 2020-07-09 11:49:33 -06:00
Meng Xu 1dead7c199
Merge pull request #3440 from sfc-gh-xwang/master
add HealthMetricsWorkload and WriteTagThrottlingWorkload
2020-07-09 10:04:46 -07:00
Meng Xu 1b68665228 Merge branch 'master' into release-6.3 2020-07-08 18:52:05 -07:00
Chaoguang Lin 5f6093b59e Add an option to enable write in special key space, which is by default not allowed 2020-07-08 15:49:34 -07:00
A.J. Beamon c94f46440b
Merge pull request #3094 from sfc-gh-dyoungworth/dyoungworth/asyncFindFiles
Make platform::findFiles asynchronous
2020-07-08 11:47:09 -07:00
Russell Sears 5e8eeadd7e
Merge pull request #3446 from sfc-gh-tclinkenbeard/use-stl-for-optional-variant
Use STL for optional and variant
2020-07-08 10:40:17 -07:00
Evan Tschannen 3eb3e23ae0
Merge pull request #3425 from sfc-gh-anoyes/anoyes/health-metrics
Expose health metrics via special keys
2020-07-08 10:37:31 -07:00
Young Liu 7afee53f4c Clean up code that serves GRV through other proxies 2020-07-07 21:19:11 -07:00
Markus Pilman 0fbe7101c3 Revert "Revert "Request tracing""
This reverts commit 327cc31e35.
2020-07-07 10:06:13 -06:00
Chaoguang Lin caebc5b6d0 Fix typo 2020-07-06 16:42:42 -07:00
Chaoguang Lin a43afb9d97 Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-07-06 15:47:00 -07:00
Chaoguang Lin 0361eb5079 Add FailedServersImpl 2020-07-06 15:40:21 -07:00
sfc-gh-tclinkenbeard e516a20c43 Revert "Fixed some dangling pointers"
This reverts commit 0c39006b07.
2020-07-06 15:26:42 -07:00
Chaoguang Lin aa587ee6c2 Move Implementations to .cpp file 2020-07-06 14:02:22 -07:00
Chaoguang Lin 38e2310530 Enable range clear in special key space 2020-07-06 12:11:01 -07:00
Chaoguang Lin 784d0f6d00 A basic feasible version for exclude and include commands 2020-07-06 11:02:48 -07:00
Jingyu Zhou 3ef341b157
Merge pull request #3436 from oleg68/osamarin5
Speed up sync between Primary and DR
2020-07-04 20:21:45 -07:00
sfc-gh-tclinkenbeard 1b55d75896 Remove TRIVIALLY_DESTRUCTIBLE macro 2020-07-04 19:28:10 -07:00
sfc-gh-tclinkenbeard dd5cd762a8 Removed dead code 2020-07-04 12:50:40 -07:00
sfc-gh-tclinkenbeard 0c39006b07 Fixed some dangling pointers 2020-07-04 12:50:40 -07:00
sfc-gh-tclinkenbeard bcbca81dfe Remove ROW_LIMIT_UNLIMITED and BYTE_LIMIT_UNLIMITED from CLIENT_KNOBS 2020-07-04 12:48:44 -07:00
Oleg Samarin 2fd9e040cd Merge branch 'osamarin5' of github.com:oleg68/foundationdb into osamarin5
line alignement
2020-07-04 21:53:36 +03:00
Oleg Samarin 00fe923eaa Speed up sync between Primary and DR: Line allignement 2020-07-04 21:40:57 +03:00
Oleg Samarin 6d70887d68
Update fdbclient/DatabaseBackupAgent.actor.cpp
Speed up sync between Primary and DR: Event Name Correction

Co-authored-by: Jingyu Zhou <jingyuzhou@gmail.com>
2020-07-04 21:37:28 +03:00
Oleg Samarin 6c23901e61 Speed up sync between Primary and DR 2020-07-03 11:38:54 +03:00
Russell Sears fcaaf11678
Merge pull request #3402 from sfc-gh-tclinkenbeard/improve-const-correctness
Added more const-correctness improvements
2020-07-02 16:43:06 -07:00
Xiaoxi Wang 55315ea550 1. add different tags to different work; 2. clang format 2020-07-02 16:10:17 +00:00
KoukiNishihara ab3de8700e Rename fastRestoreAgent to fastRestoreTool 2020-07-03 00:16:39 +09:00
A.J. Beamon b7189f5168
Merge pull request #3426 from Clikengo/fix-3424
fix ClientVersionRef versionString should be passed by ref
2020-07-02 08:06:04 -07:00
Xin Dong ae63304392 Address Meng's comment 2020-07-01 20:23:18 -07:00
Xiaoxi Wang 73554fe242 1.add tag logic; 2.fix typo; 3. enable simulation test 2020-07-01 23:27:47 +00:00
Xin Dong 3ecdaf24ce Use the actual range begin and end key instead of the shard begin and shard end key 2020-07-01 16:07:59 -07:00
Andrew Noyes 409ccf3be2 Use snake_case to match status json convention 2020-06-30 17:05:29 +00:00
Andrew Noyes e1dfa410c1 Remove "Storages" field from data_distribution_stats
It seems like a cool idea, but it feels rushed to me. Reverting for now.
2020-06-30 15:24:16 +00:00
Andrew Noyes a55b0771c5 Test schemas
Also remove an ASSERT_WE_THINK that doesn't seem to hold now that we
include shards
2020-06-30 15:24:16 +00:00
Andrew Noyes 403274bba8 Add schemas, and check dataDistributionStatsSchema 2020-06-30 15:24:16 +00:00
Andrew Noyes f8bb76a607 Add CLIENT_BUGGIFY 2020-06-30 15:24:16 +00:00
Andrew Noyes b1d5e99494 Update documentation 2020-06-30 15:24:16 +00:00
Andrew Noyes 1c30adce74 WIP 2020-06-30 15:24:16 +00:00
Andrew Noyes 0db3145e82 Include storage id's in data_distribution_stats 2020-06-30 15:24:15 +00:00
Andrew Noyes e304697eca WIP 2020-06-30 15:24:15 +00:00
Andrew Noyes ffd1467367 Add \xff\xff/metrics/health/* 2020-06-30 15:24:15 +00:00
Chaoguang Lin e2c5938c28 Update module registration for readwrite module 2020-06-29 15:37:46 -07:00
Vincent Rouillé 1082ab2caa
fix ClientVersionRef versionString should be passed by ref 2020-06-29 21:23:56 +02:00
Meng Xu 22f7f804b8 Merge branch 'release-6.3' into mengxu/merge-6.3-PR 2020-06-28 11:19:39 -07:00
Chaoguang Lin 18ff6efbf3 Add failure module for special key space 2020-06-27 12:22:32 -07:00
Oleg Samarin 1832b88e3f Removed debug messages 2020-06-26 13:34:52 +03:00
Oleg Samarin d887d5dd70 Increased CopyLogRange performance 2020-06-26 13:34:35 +03:00
Steve Atherton 648c870fec Merge branch 'release-6.3' of https://github.com/apple/foundationdb into tls-background-handshake 2020-06-26 00:21:57 -07:00
Steve Atherton 0da4c91ad5 Performance improvements in socket use and buffering which results in TLS network connections using around 3.5x less CPU.
PacketBuffers are 16k minimum sizes, using FastAlloc.  All calling paths to PacketBuffer creation now pass a size hint if known.  P2PNetworkTest improved in many ways, errors go to TraceEvents instead of stdout, error counts are reported in stats, range min/max parameters are combined into "min:max" strings, new options to "stutter" connections by delaying randomly before socket read or write, message size to send is now configured separately for incoming vs outgoing sessions.
2020-06-25 20:44:43 -07:00
Jingyu Zhou 8f842a66e4
Merge pull request #3397 from xumengpanda/mengxu/fr-addPrefix-PR
Fast Restore: Support and test addPrefix and removePrefix feature
2020-06-25 14:06:39 -07:00
Steve Atherton af6b141736
Merge pull request #3407 from sfc-gh-tclinkenbeard/fix-vectorref-memory-leaks
Fix memory leaks in VectorRef
2020-06-25 00:54:33 -07:00
Meng Xu c13ba7aeb4 FastRestore:Cosmetic code style improvement
Also mute some trace events
2020-06-24 21:25:37 -07:00
Meng Xu 94b1e17a96 FastRestore:Fix:Avoid reset txn backoff time in sanity check 2020-06-24 21:10:47 -07:00
Meng Xu d2b71e77c2 FastRestore:Fix:checkDatabaseLock tr should not reset 2020-06-24 20:21:49 -07:00
Jingyu Zhou 5cd3dad986
Merge pull request #3409 from sears/assert_strings
Print out the text (to stderr and as trace) of the failed condition o…
2020-06-24 14:58:12 -07:00
Russell Sears 422003df34 Print out the text (to stderr and as trace) of the failed condition on assert failure 2020-06-24 14:21:48 -07:00
sfc-gh-tclinkenbeard 8de70432a6 Fix memory leaks in VectorRef
VectorRef<T> relies on T being trivially destructible, but this was not
yet enforced. By statically asserting that T is trivially destructible,
we avoid leaking memory by not calling the destructor for non-trivially
destructible types
2020-06-24 10:54:19 -07:00
Meng Xu b69c36f0d6 transformDatabaseContents:cosmetic change 2020-06-23 19:27:58 -07:00
Meng Xu 198696bc1e Move transformRestoredDatabase from server to client
AtomicRestore workload turns out to rely on the FileBackupAgent
client. Keeping transformRestoredDatabase in server makes linking harder.
2020-06-23 15:48:43 -07:00
Meng Xu 6eb8dc58b6 FastRestore:addPrefixTest:Fix calling transformRestoredDatabase 2020-06-23 15:02:38 -07:00
Meng Xu 84a640e4ee AtomicRestore:Add addPrefix test for fast restore 2020-06-23 14:52:27 -07:00
Meng Xu 4e27fd34e5 Refactor transformDatabaseContents into RestoreCommon
Prepare to enable addPrefix for atomicRestore
2020-06-23 14:33:13 -07:00
Chaoguang Lin f011ff2c66 Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space 2020-06-23 11:23:18 -07:00
Chaoguang Lin fc8715dacd Adding write support for special-key-space 2020-06-23 11:21:03 -07:00
Meng Xu 9cff90fb5f runRYWTransaction:Add comment to remind func should be idempodent 2020-06-22 23:04:09 -07:00
Meng Xu dd5c1ec416 FastRestore:Add debug trace
The bug behavior is:
In transformDatabaseContents(), we write all new kvs into the DB in 100 keys batch.
We immediately read these keys out.
There are 100 keys missing.
2020-06-22 19:47:21 -07:00
Andrew Noyes 42159ccfe0 Add -Wpessimizing-move and -Wredundant-move for clang 2020-06-22 23:45:03 +00:00
Chaoguang Lin 59361cedaa Rename to have read and write impls and add set, clear, clearrange interfaces 2020-06-22 14:02:03 -07:00
Chaoguang Lin 5f4dde0b7a Rename member variables 2020-06-22 13:59:16 -07:00
Chaoguang Lin 98026486fc fix small issues 2020-06-22 13:53:24 -07:00
Chaoguang Lin 84c0856897 add management api to special-key-space getrange 2020-06-22 13:52:48 -07:00
Meng Xu 3d6f69c8e2 FastRestore:addPrefix:Transform must clear both orignal and transformed range
Otherwise, anything left in the range can interfer with the result.
2020-06-21 22:18:12 -07:00
sfc-gh-tclinkenbeard a59925dd73 Added more const-correctness improvements 2020-06-20 22:15:19 -07:00
sfc-gh-tclinkenbeard 85a284b13c Use VectorRef::emplace_back in several places 2020-06-19 23:02:28 -07:00
A.J. Beamon c01a345652
Merge pull request #3386 from sfc-gh-tclinkenbeard/improve-const-correctness
Improve const-correctness
2020-06-18 12:40:08 -07:00
Meng Xu 2fcef90cbc FastRestore:Add addPrefix and removePrefix feature 2020-06-18 11:58:42 -07:00
sfc-gh-tclinkenbeard ef3aa3b1c4 Replace comments with assertions in WriteMap.h 2020-06-18 11:53:36 -07:00
Meng Xu d7a8e554ed FastRestore:Test for addPrefix and removePrefix
Add the skeleton code to test;
addPrefix and removePrefix are all empty for now.
2020-06-17 20:36:53 -07:00
Meng Xu 5455467f31 Merge branch 'release-6.3' into mengxu/fr-addPrefix-PR 2020-06-17 19:16:22 -07:00
A.J. Beamon 76ac5dfeaf Merge branch 'release-6.3' into merge-release-6.3-into-master
# Conflicts:
#	documentation/sphinx/source/release-notes/release-notes-630.rst
2020-06-17 18:31:06 -07:00
sfc-gh-tclinkenbeard 2a393633b6 Improved const-correctness
Using the recently added IndexedSet::const_iterator
(https://github.com/apple/foundationdb/pull/3185), we can improve the
const-correctness of many functions. In this PR const is added where
applicable. Also, wherever I came across the following while adding
const, I made the following changes:

- virtual function overrides are marked as override
- NULL is replaced with nullptr
- git clang-format is applied
2020-06-17 18:20:43 -07:00
Meng Xu e0fbbea79e
Merge pull request #3380 from sfc-gh-clin/update-cross-module-read-error-handler
Update special_keys_cross_module_read error handler
2020-06-17 18:17:32 -07:00
Chaoguang Lin 65916d7b10 Solve comments 2020-06-17 12:47:54 -07:00
Chaoguang Lin 9fbdd770ba Update comments 2020-06-17 11:28:52 -07:00
Chaoguang Lin 0d9d20998e Assert ryw not null, remove unit tests 2020-06-17 11:13:55 -07:00
Chaoguang Lin 32794a6917 Make key selectors clamp up to the boundary of the module rather than throw cross_module_error 2020-06-17 10:33:52 -07:00
Meng Xu bbdd451fb6 FastRestore:Add priorities for loader and applier endpoints
Endpoint for later restore step should have higher priority for
better performance: later step will not be blocked by the
next version batch's earlier steps.
2020-06-16 22:48:32 -07:00
Chaoguang Lin c2a5b36eda Change to initialization list for SpecialKeySpace constructor 2020-06-16 19:27:21 -07:00
Jingyu Zhou 327cc31e35
Revert "Request tracing" 2020-06-16 12:32:42 -07:00
Meng Xu 96206a8032
Merge pull request #3368 from apple/release-6.3
Merge Release 6.3 to master
2020-06-15 20:15:22 -07:00
Meng Xu 39c50798b8
Merge pull request #3341 from sfc-gh-clin/fix-rpc-calls-in-special-key-space
Fix fetchShardMetricsList_impl and add read cache in special key space
2020-06-15 16:12:38 -07:00
Chaoguang Lin 7a5fe3800d Add comments, refine traces, add delay to dd rpc calls in the test 2020-06-15 15:31:55 -07:00
Meng Xu fabdffd6e4
Merge pull request #3332 from sfc-gh-tclinkenbeard/fix-memaccess-warnings
Fix class-memaccess warnings
2020-06-15 15:22:19 -07:00
sfc-gh-tclinkenbeard 4cd4c2ff9b Added comment to TransactionOptions 2020-06-15 12:12:08 -07:00
Daniel Smith acbfe2e4c9
Revert "Revert "Initial RocksDB"" 2020-06-15 12:45:36 -04:00
sfc-gh-tclinkenbeard 3a914c71f2 Add TransactionOptions::clear function 2020-06-13 17:17:06 -07:00
Meng Xu 8595813b7d
Merge pull request #3355 from apple/release-6.3
Merge Release 6.3 into master branch
2020-06-12 20:08:47 -07:00
Meng Xu f1ff29d70b Revert debugTransaction in ReadYourWritesTransaction
This was accidentally smuggled in at PR 3329.
2020-06-12 15:23:31 -07:00
Meng Xu 80334351c7
Merge pull request #3329 from sfc-gh-mpilman/features/flatbuffers-debugtx
Request tracing
2020-06-12 14:50:19 -07:00
Chaoguang Lin 5bc2e2e595 update comments, make isAsync() virtual, remove unused code 2020-06-12 10:12:44 -07:00
Chaoguang Lin 980bee1d13 Fix fetchShardMetricsList_impl and add read cache in special key space 2020-06-12 10:12:44 -07:00
negoyal 1cbbd865de Remove unused member from SSI. 2020-06-11 18:35:48 -07:00
Jingyu Zhou 9cd1614c82
Revert "Initial RocksDB" 2020-06-11 15:29:46 -07:00
Markus Pilman ae6b716820 addressed more review comments 2020-06-11 09:58:41 -07:00
Daniel Smith a4dbb5dd01 Merge branch 'trace-batch-thread-hostile' into rocksdb-6.3 2020-06-11 15:53:57 +00:00
Markus Pilman 9ef93714ac Address review comments 2020-06-10 15:48:49 -07:00
Markus Pilman 4ab3441a95 Merge remote-tracking branch 'origin/master' into features/flatbuffers-debugtx 2020-06-10 15:31:29 -07:00
Markus Pilman d9ddb84d34 remove weird include (added by clangd) 2020-06-10 13:18:26 -07:00
sfc-gh-tclinkenbeard a332dff2ec Fix class-memaccess warnings 2020-06-10 12:34:14 -07:00
Meng Xu ae10aaf5d6
Merge pull request #3323 from sfc-gh-tclinkenbeard/remove-boost-noexcept
Replace BOOST_NOEXCEPT with noexcept
2020-06-10 12:07:25 -07:00
Evan Tschannen f72d0a6a35
Merge pull request #3302 from sfc-gh-anoyes/anoyes/fix-watch-counting
Don't double count watches for too_many_watches
2020-06-10 10:40:11 -07:00
Meng Xu 097261b7a4
Merge pull request #3326 from apple/release-6.3
Merge release 6.3 into master
2020-06-10 09:00:14 -07:00
sfc-gh-tclinkenbeard 99bf993815 Replace BOOST_NOEXCEPT with noexcept 2020-06-09 22:39:19 -07:00
Meng Xu 164814cd23 Merge branch 'release-6.3' into mengxu/fr-addPrefix-PR
Also remove the unnecessary try catch block for unlockDatabase() in
parallelRestoreFinish actor
2020-06-09 22:04:19 -07:00
Jingyu Zhou df064ac922
Merge pull request #3321 from xumengpanda/mengxu/fr-restore-ranges-PR
Fast Restore: Support restoring sub ranges in the framework
2020-06-09 21:01:39 -07:00
Steve Atherton 61fcce08cc
Merge pull request #3324 from apple/release-6.3
merge Release 6.3
2020-06-09 18:56:47 -07:00
Meng Xu dd8af487ec FileBackupAgent:parallelRestoreFinish:verify if operation_cancelled error ever happens 2020-06-09 17:08:57 -07:00
Meng Xu 8533daac50 parallelRestoreFinish:fix used_during_commit error 2020-06-09 15:40:24 -07:00
sfc-gh-ngoyal 693d9e8b89
Merge branch 'master' into fdb_cache_wo_allocator 2020-06-09 15:09:58 -07:00
A.J. Beamon e10704fd76 Cherry-pick region related status changes from 6.3 2020-06-09 14:56:21 -07:00
Meng Xu e5e4cb5c90 parallelRestoreFinish:separate check restore finished and clear restoreRequestDoneKey 2020-06-09 11:32:20 -07:00
Meng Xu d85dc5a4d3 FastRestore:Only clear ranges that will be restored
Instead of clearning the entire normal key space.

This commit also removes some unnecessary tr->reset() which can invalid the txn backoff time.
2020-06-08 22:41:49 -07:00
Meng Xu e7fdd614fe Remove assert on error_code_key_not_found in previous commit
Correctnss shows the assert does not hold in all scenarios
2020-06-08 19:02:56 -07:00
Markus Pilman c829b12bbf defined spans for read requests 2020-06-08 17:26:15 -07:00
Meng Xu 5022566b35 Validate if key_not_found error ever happens 2020-06-08 16:59:00 -07:00
Markus Pilman 09c136e434 Framework for transaction tracing 2020-06-08 16:09:37 -07:00
Andrew Noyes 55448a8d5a Remove call in watch actor instead of Transaction::watch 2020-06-08 18:19:18 +00:00
Russell Sears 3278222e2c
Merge pull request #3077 from tclinken/reenable-wclass-memaccess
Fix segmentation fault and reenable -Wclass-memaccess
2020-06-08 09:42:35 -07:00
Andrew Noyes 731b77a8c2 Don't double count watches for too_many_watches 2020-06-07 23:54:22 +00:00
negoyal 23a565ec63 Few bug fixes. 2020-06-05 16:27:04 -07:00
Meng Xu 558fd6ba16
Merge pull request #3296 from apple/release-6.3
Merge release 6.3 to master
2020-06-05 10:49:06 -07:00
Evan Tschannen 30bfd606c0 Merge branch 'release-6.2' into release-6.3
# Conflicts:
#	CMakeLists.txt
#	documentation/sphinx/source/downloads.rst
#	documentation/sphinx/source/release-notes.rst
#	fdbserver/worker.actor.cpp
#	packaging/msi/FDBInstaller.wxs
#	versions.target
2020-06-04 19:21:32 -07:00
Steve Atherton bf072d68ec Workarounds for strange behaviors in Boost ssl sockets on MacOS and Linux. When writing to the ssl socket, write_some() would sometimes return BrokenPipe instead of WouldBlock unless onWriteable on the raw socket was checked first. On MacOS, even with the onWriteable check using a send size greater than 2016 (determined experimentally) would still result in the error. Also consolidated two identical copies of SendBufferIterator. 2020-06-04 01:44:05 -07:00
Daniel Smith dfd44da02c Fix enum ordering 2020-06-03 20:09:31 +00:00
negoyal cf13e00a8f Merge remote-tracking branch 'origin/release-6.3' into fdb_cache_wo_allocator 2020-06-01 17:38:31 -07:00
A.J. Beamon 414206015d
Merge pull request #3273 from apple/release-6.3
Merge release-6.3 into master
2020-05-29 16:58:36 -07:00
A.J. Beamon 8329a242d2 Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
# Conflicts:
#	documentation/sphinx/source/downloads.rst
#	documentation/sphinx/source/release-notes.rst
2020-05-29 15:51:56 -07:00
Markus Pilman ba63a66d12 Merge remote-tracking branch 'origin/master' into features/flatbuffers-debugtx 2020-05-29 15:38:09 -07:00
Andrew Noyes 48eedb071f Only destroy db if non-null
It could be the case that db is null for old client versions
2020-05-28 23:22:45 +00:00
David Youngworth c12c11acd3 Merge branch 'master' into dyoungworth/asyncFindFiles 2020-05-27 17:51:08 -07:00
Markus Pilman 8a7d98ab21 Started instrumentation 2020-05-27 15:36:04 -07:00
Daniel Smith 8731700d80 Merge remote-tracking branch 'upstream/release-6.3' into rocksdb-6.3 2020-05-27 20:02:25 +00:00
A.J. Beamon fa08384bc3
Merge pull request #3239 from apple/release-6.3
Merge release 6.3 into master
2020-05-27 08:29:28 -07:00
Meng Xu 755267a7db
Merge pull request #3229 from ajbeamon/calling-run-network-twice-is-error
Eliminate the undefined behavior of calling run_network twice, instead returning an error
2020-05-26 21:24:52 -07:00
Meng Xu 36ad1a95f4 Resolve conflicts when merge release-6.3 into master 2020-05-25 12:11:59 -07:00
Meng Xu 1c35ad884f Merge branch 'master' into mengxu/release-6.3-conflict-PR
Has conflict with master;
Next commit will fix the conflicts.
2020-05-25 12:01:49 -07:00
sfc-gh-tclinkenbeard 8a98ea3320 Changed non_flow_ref to flow_ref for clarity.
Also updated comment to explain that std::is_trivially_copyable
cannot be used to determine whether or not a type is a flow ref.
2020-05-23 22:57:41 -07:00
Evan Tschannen 138569a489 another compile fix 2020-05-22 17:19:46 -07:00
Evan Tschannen ced65cd30b finished explicitly versioning everything stored in the database 2020-05-22 17:14:21 -07:00
Evan Tschannen 72ce997d22 explicitly versioned every key in systemData, so we only will update the associated protocolVersion when the serialization actually changes 2020-05-22 16:35:01 -07:00
A.J. Beamon 86f712657e Eliminate the undefined behavior of calling run_network twice, instead returning an error. 2020-05-22 13:31:06 -07:00
A.J. Beamon d128252e90 Merge release-6.3 into master 2020-05-22 09:25:32 -07:00
Daniel Smith 5d361fe532 Copy/paste rebase onto 6.3 2020-05-22 15:02:51 +00:00
Andrew Noyes 7f9bdbb2b1 Update DDStatsRangeImpl 2020-05-21 18:26:34 +00:00
Andrew Noyes a2fd6d46a0 Cancel pending special key space reads on destroy
Previously the special key space would take a reference to the
transaction, but this doesn't make sense since the transaction might not
be refcounted
2020-05-21 17:37:11 +00:00
David Youngworth f22a8845e4 Finish putting actors in Platform.actor.cpp 2020-05-20 18:14:29 -07:00
Evan Tschannen cc9dd8ac72
Merge pull request #3214 from etschannen/release-6.3
Do not use tags in the keyServers map in the initial version of 6.3
2020-05-20 17:12:43 -07:00
Meng Xu 3bf2ff9ae8
Merge pull request #2547 from tclinken/add-data-distribution-metrics
Add data distribution metrics
2020-05-20 17:11:40 -07:00
Evan Tschannen 7d91a3a919 Merge branch 'release-6.3' of github.com:apple/foundationdb into release-6.3 2020-05-20 16:30:14 -07:00
Chaoguang Lin afa7c0a9cc Change the value format to as json string 2020-05-20 15:59:01 -07:00
tclinken 3a8efb2d0b Added advanceversion command to fdbcli 2020-05-20 15:47:31 -07:00
Chaoguang Lin 0d9135ee57 Merge remote-tracking branch 'upstream/release-6.3' into add-data-distribution-metrics 2020-05-20 15:21:26 -07:00
A.J. Beamon 2aac9d1202
Merge pull request #3178 from ajbeamon/tag-throttling-by-priority
Tag (un)throttling by priority in fdbcli
2020-05-20 15:17:51 -07:00
Evan Tschannen f1dca05cf3
Merge pull request #3194 from etschannen/feature-small-endpoint
Optimized failure monitor performance
2020-05-20 14:48:13 -07:00
Evan Tschannen 06676fc88f
Merge pull request #3166 from tclinken/6.3-avoid-ub
Eliminate some undefined behavior and const_cast usage
2020-05-20 14:36:30 -07:00
A.J. Beamon cc4874918a Merge branch 'release-6.3' into tag-throttling-by-priority
# Conflicts:
#	fdbserver/Ratekeeper.actor.cpp
2020-05-20 14:26:35 -07:00
Evan Tschannen 6a006c4c1f use the first RequestStream as the base endpoint 2020-05-20 13:52:22 -07:00
A.J. Beamon b589c3c940 Remove IncludeVersions.h, which is no longer needed for cmake-only builds 2020-05-20 13:23:02 -07:00
A.J. Beamon 0f43ccbbf0
Merge pull request #3205 from bnamasivayam/add-locality-data
Add locality data
2020-05-20 10:56:31 -07:00
Evan Tschannen 78bad4b07e
Merge pull request #3196 from ajbeamon/remove-deprecated-status-fields
Remove deprecated fields in status
2020-05-20 10:45:29 -07:00
Chaoguang Lin 298b94a044 clang-format the change 2020-05-19 20:51:02 -07:00
Chaoguang Lin 7971be2a19 update commetns 2020-05-19 20:48:21 -07:00
Chaoguang Lin a6aff22e65 Update the special key prefix for dd-stats to \xff\xff/data_distribution_stats 2020-05-19 20:47:52 -07:00
A.J. Beamon 2fbbf1e60c
Merge pull request #3203 from apple/release-6.3
Merge release-6.3 into master
2020-05-19 18:02:01 -07:00
Evan Tschannen 2557da1d47 fix compiler errors 2020-05-19 16:53:14 -07:00
Evan Tschannen 9313e490aa change the first part of the UID to make comparisons cheaper 2020-05-19 16:48:20 -07:00
Evan Tschannen ead17d6a7f another attempt at changing serialization 2020-05-19 16:28:01 -07:00
Balachandar Namasivayam 16990aeb6f Add dcId to client transaction events. 2020-05-19 16:07:54 -07:00
Evan Tschannen 7dd226d264 readded a missing line 2020-05-19 15:35:57 -07:00
Chaoguang Lin 93ca130602 Delete the unnecessay endKey field in DDMetricsRef, since each begin key is the previous end key 2020-05-19 13:32:42 -07:00
A.J. Beamon d636194d0d Remove deprecated fields in status: worst_version_lag_storage_server and limiting_version_lag_storage_server 2020-05-19 13:12:10 -07:00
A.J. Beamon 7a09d016a6 Merge branch 'release-6.3' into merge-release6.3-into-master 2020-05-19 12:52:44 -07:00
Evan Tschannen 99e1fbdd47 another attempt at speeding up serialization 2020-05-19 12:36:11 -07:00
Evan Tschannen b7126f0acb experimentally revert serialization of storage server interface 2020-05-18 19:54:09 -07:00
Evan Tschannen 5013bc9106 fixed client compile issues; reduced the size of storage server interface 2020-05-18 17:20:15 -07:00
Chaoguang Lin 00dce3ca1d clang-format 2020-05-18 14:23:17 -07:00
Chaoguang Lin e3921504d7 Delete comments 2020-05-18 14:21:38 -07:00
A.J. Beamon fcca49f4d5 Add back an std::move that was accidentally removed. Some other small tweaks to avoid map lookups when tags aren't used. 2020-05-18 13:45:51 -07:00
Chaoguang Lin 6e684dda35 Using dd-stats zerobytes const in the workload 2020-05-18 11:53:26 -07:00
Chaoguang Lin 117ed14321 Add dd-stats zerobytes const to systemData 2020-05-18 11:52:36 -07:00
Chaoguang Lin 4bb90cb038 fix serilizer issue 2020-05-18 10:56:10 -07:00
Chaoguang Lin bf62ef7c3e Add dd-stats into special-key-space 2020-05-18 10:38:23 -07:00
Chaoguang Lin f515e2c9d0 Add systemdata for dd-stats 2020-05-18 10:36:34 -07:00
Markus Pilman d748166ed3 Merge branch 'master' of github.com:apple/foundationdb into features/flatbuffers-debugtx 2020-05-18 10:15:58 -07:00
Chaoguang Lin 6ce574f5ad Merge remote-tracking branch 'upstream/release-6.3' into add-data-distribution-metrics 2020-05-17 23:36:52 -07:00
Evan Tschannen be2246c0ee Merge branch 'release-6.3' of github.com:apple/foundationdb into release-6.3 2020-05-17 15:29:12 -07:00
Chaoguang Lin 8597b38d10 Add an assertion in SingleSpecialKeyImpl 2020-05-15 16:34:43 -07:00
Chaoguang Lin 87ac003967 add tests for no_module_found error, fix one bug caught by the test 2020-05-15 16:34:43 -07:00