Commit Graph

11159 Commits

Author SHA1 Message Date
A.J. Beamon 11b136c745 Various fixes to tag throttling:
* Master proxy reports transaction counts to ratekeeper for throttled tags only
* The ramp up behavior at the end of an auto-throttle was broken
* Fixed some issues with computing the initial transaction rate for auto-throttles
2020-06-30 16:24:41 -07:00
Andrew Noyes 409ccf3be2 Use snake_case to match status json convention 2020-06-30 17:05:29 +00:00
Jingyu Zhou 89c8764cd6
Merge pull request #3432 from xumengpanda/mengxu/fr-applier-perf-circus-PR
Fast Restore: Improvements based on circus performance test
2020-06-30 09:10:48 -07:00
Andrew Noyes e1dfa410c1 Remove "Storages" field from data_distribution_stats
It seems like a cool idea, but it feels rushed to me. Reverting for now.
2020-06-30 15:24:16 +00:00
Andrew Noyes a55b0771c5 Test schemas
Also remove an ASSERT_WE_THINK that doesn't seem to hold now that we
include shards
2020-06-30 15:24:16 +00:00
Andrew Noyes 403274bba8 Add schemas, and check dataDistributionStatsSchema 2020-06-30 15:24:16 +00:00
Andrew Noyes f8bb76a607 Add CLIENT_BUGGIFY 2020-06-30 15:24:16 +00:00
Andrew Noyes b1d5e99494 Update documentation 2020-06-30 15:24:16 +00:00
Andrew Noyes 1c30adce74 WIP 2020-06-30 15:24:16 +00:00
Andrew Noyes 4a584a6f6b Fix copy pasta 2020-06-30 15:24:15 +00:00
Andrew Noyes 0db3145e82 Include storage id's in data_distribution_stats 2020-06-30 15:24:15 +00:00
Andrew Noyes 39cb0ec751 Add documentation 2020-06-30 15:24:15 +00:00
Andrew Noyes e304697eca WIP 2020-06-30 15:24:15 +00:00
Andrew Noyes ffd1467367 Add \xff\xff/metrics/health/* 2020-06-30 15:24:15 +00:00
Meng Xu efb61bcac0 Rename knob to FASTRESTORE_TXN_EXTRA_DELAY 2020-06-29 21:16:30 -07:00
Meng Xu a5febfbc75 Remove spurious comments 2020-06-29 10:26:01 -07:00
Meng Xu 8f5ee1f4aa Refine trace events for better perf diagnosis 2020-06-29 10:22:07 -07:00
Meng Xu 97e26d8eb0 FastRestore:Count appliedBytes 2020-06-29 10:18:18 -07:00
Meng Xu 4b35685e99 FastRestore:Adjust knob based on circus test 2020-06-29 10:13:18 -07:00
Evan Tschannen 44975be5b2 Merge branch 'release-6.2' of github.com:apple/foundationdb into feature-ha-fixes 2020-06-29 10:02:49 -07:00
Evan Tschannen 5e02fd490e fix: the check for if a teamCollection was tracking a source server was unreliable, leading to scenarios where we would temporarily replicate a shard less than teamSIze 2020-06-29 10:02:27 -07:00
Daniel Smith ab56afbaee Merge branch 'rocksdb-corruption' into rocksdb-fixes 2020-06-29 16:30:55 +00:00
Daniel Smith 9c2937d4d0 Only check for files/directories when needed 2020-06-29 16:25:36 +00:00
bchavez ecf340da88
Corrects spelling mistakes in various markdown files. 2020-06-28 21:30:34 -07:00
Meng Xu a708e8e09a
Merge pull request #3422 from jzhou77/fdbconvert
Fix a spurious SevError and a spammy trace event
2020-06-28 17:42:49 -07:00
Meng Xu 82dfb5ce3f FastRestore:Update process metrics for restore master 2020-06-28 12:37:04 -07:00
Meng Xu bc98c84346 RestoreLoader release data early and revert Lower priority for RestoreApplierReceiveMutations actor
A quick evalution shows lowering priority for receive mutation actor does not help restore speed but hurt it.
2020-06-28 11:12:06 -07:00
Jingyu Zhou 8263c25336 Really ignore the error from uploading actor 2020-06-27 22:36:53 -07:00
Jingyu Zhou d883426c6a Fix spammy GotBackupProgress events
Only print this types of events during master recovery and don't log them for
backup workers.
2020-06-27 21:30:38 -07:00
Jingyu Zhou b8c77ead43 Fix spurious SevError from backup workers
While displaced backup workers wait for uploading to finish, it can get
connection_failed error, which caused spurious SevError of BackupFailed. Fix
by ignoring any errors from the uploading actor.
2020-06-27 21:24:22 -07:00
Meng Xu 026a735703 Test perf without gracefully clear memory 2020-06-27 16:15:56 -07:00
Meng Xu d6381de16f RestoreLoader:Clear memory per loading param 2020-06-27 15:51:19 -07:00
Meng Xu ca7beb5a26 Fix compilation 2020-06-27 15:21:06 -07:00
Meng Xu f18a0a242d FastRestore:Loader frees mutation memory immediately after send mutations 2020-06-27 15:19:08 -07:00
Meng Xu e57dba00bd FastRestore:Lower priority for RestoreApplierReceiveMutations actor 2020-06-27 15:16:38 -07:00
Meng Xu 78c45c1200 Knob for txn delay and add back FlowLock to control txn concurrency 2020-06-27 10:13:34 -07:00
Meng Xu ecd2d8b239 FastRestore:Add counters for applier and disable FlowLock on applyStagingKeysBatch 2020-06-27 00:20:54 -07:00
Jingyu Zhou 8f842a66e4
Merge pull request #3397 from xumengpanda/mengxu/fr-addPrefix-PR
Fast Restore: Support and test addPrefix and removePrefix feature
2020-06-25 14:06:39 -07:00
Meng Xu 43d55fb73f AtomicRestore:Fix typo in comments 2020-06-25 13:24:58 -07:00
Steve Atherton af6b141736
Merge pull request #3407 from sfc-gh-tclinkenbeard/fix-vectorref-memory-leaks
Fix memory leaks in VectorRef
2020-06-25 00:54:33 -07:00
Meng Xu 5860a5b4db FastRestore:Suppress or mute spammy trace events 2020-06-24 22:10:54 -07:00
Meng Xu c13ba7aeb4 FastRestore:Cosmetic code style improvement
Also mute some trace events
2020-06-24 21:25:37 -07:00
Meng Xu 94b1e17a96 FastRestore:Fix:Avoid reset txn backoff time in sanity check 2020-06-24 21:10:47 -07:00
Meng Xu d2b71e77c2 FastRestore:Fix:checkDatabaseLock tr should not reset 2020-06-24 20:21:49 -07:00
Jingyu Zhou 5cd3dad986
Merge pull request #3409 from sears/assert_strings
Print out the text (to stderr and as trace) of the failed condition o…
2020-06-24 14:58:12 -07:00
Meng Xu a0edd1d4eb FastRestore:Disable addPrefix test 2020-06-24 14:26:33 -07:00
Russell Sears 422003df34 Print out the text (to stderr and as trace) of the failed condition on assert failure 2020-06-24 14:21:48 -07:00
sfc-gh-tclinkenbeard 3f6222a04d Mark DebugEntryRef trivially destructible 2020-06-24 14:08:22 -07:00
Daniel Smith 69139e3593 Remove unneeded option 2020-06-24 20:30:18 +00:00
sfc-gh-tclinkenbeard 8de70432a6 Fix memory leaks in VectorRef
VectorRef<T> relies on T being trivially destructible, but this was not
yet enforced. By statically asserting that T is trivially destructible,
we avoid leaking memory by not calling the destructor for non-trivially
destructible types
2020-06-24 10:54:19 -07:00