A.J. Beamon
36435af4f5
Add support for a limits hint in special keys. Fix a typo and resolve some comment formatting weirdness.
2022-03-06 21:52:39 -08:00
Trevor Clinkenbeard
b84d3af533
Merge pull request #6499 from sfc-gh-ajbeamon/fix-trace-overflow-bug
...
Fix possible infinite loop when a trace event is too long
2022-03-04 16:11:37 -08:00
Trevor Clinkenbeard
ddb42f33e5
Merge pull request #6475 from sfc-gh-ajbeamon/fix-trace-double-escaping
...
Fix several instances where trace events were double-escaping strings
2022-03-04 16:10:49 -08:00
Jingyu Zhou
89648769d0
Fix clang format and cmake files for fmt 8.1.1
2022-03-04 15:52:06 -08:00
Jingyu Zhou
1a5bf25b5c
Update code base to use fmt 8.1.1
2022-03-04 15:52:06 -08:00
Jingyu Zhou
212e5147b9
Update fmt from 8.0.1 to 8.1.1
...
8.1.1 provides fmt::fprintf().
2022-03-04 15:52:06 -08:00
A.J. Beamon
ad792630aa
Fix formatting
2022-03-04 14:06:16 -08:00
A.J. Beamon
d45bae11b7
Fix substring call when reporting details about a trace event that was longer than the legal limit.
2022-03-04 13:59:49 -08:00
A.J. Beamon
41d1e4b5d5
Fix several instances where we were converting keys, ranges, and key selectors into strings before passing them into trace events. This had the effect of double escaping certain characters.
2022-03-04 13:58:36 -08:00
A.J. Beamon
45649c543d
Merge pull request #6500 from sfc-gh-ajbeamon/fix-merge-error
...
Fix conflict between two recent merges by using the new errorUnsuppressed function
2022-03-04 13:56:52 -08:00
Andrew Noyes
2bd2ddd779
Fix FastAlloc thread cleanup on OSX ( #6485 )
...
* Use ThreadData constructor and destructor
Instead of pthread api
* Make threadData a function static thread local variable
* Fix linux build
2022-03-04 12:49:40 -08:00
A.J. Beamon
f4291af1ab
Merge pull request #6476 from sfc-gh-ajbeamon/fix-clang-formatting-issues
...
Fix formatting issues caused by clang-format in WriteDuringRead workload
2022-03-04 12:46:12 -08:00
A.J. Beamon
11fbd1564e
Fix two more cases of error(e, true)
2022-03-04 12:44:52 -08:00
A.J. Beamon
1555c0e2aa
Fix conflict between two recent merges by using the new errorUnsuppressed function.
2022-03-04 12:41:21 -08:00
A.J. Beamon
cdebda35ab
Merge pull request #5725 from sfc-gh-jfu/jfu-grv-cache
...
Add transaction option for clients to use cached read versions
2022-03-04 09:17:27 -08:00
neethuhaneesha
49bd0c34cc
Merge pull request #6493 from neethuhaneesha/rocks-compaction
...
RocksDB increasing background threads to speedup compaction.
2022-03-04 07:24:19 -08:00
Andrew Noyes
0ff13c1bb6
Allow for mako tmp directory to already exist ( #6494 )
2022-03-03 18:07:29 -08:00
Xiaoxi Wang
6024bf0109
Merge pull request #6482 from sfc-gh-xwang/ppw-status
...
Print the IP:Port address of wiggling server in status
2022-03-03 15:50:58 -08:00
Neethu Haneesha Bingi
83e0368eaa
RocksDB increasing background threads to speedup compaction.
2022-03-03 15:14:37 -08:00
Trevor Clinkenbeard
e7a82b68f2
Merge pull request #6486 from sfc-gh-tclinkenbeard/fix-commitlatencybands-sample
...
Fix name of `ProxyCommitData::commitLatencyBands` sample
2022-03-02 16:24:19 -08:00
sfc-gh-tclinkenbeard
8b2b74980e
Fix name of ProxyCommitData::commitLatencyBands sample
2022-03-02 14:57:42 -08:00
Xiaoxi Wang
887d5a25cb
add storage wiggle to status
2022-03-02 11:31:55 -08:00
Xiaoxi Wang
e73c0a31e6
add wiggle_server_ids and wiggle_server_addresses in status json
2022-03-02 10:03:23 -08:00
Andrew Noyes
9a45df8e6c
Change fdb_c's dep on fdbclient to be private ( #6466 )
...
That way transitive dependencies (e.g. libfdb_java.so) don't include
unnecessary fdbclient code. Related: #6455
2022-03-01 18:08:50 -08:00
A.J. Beamon
1ab963eb5b
Merge pull request #6477 from sfc-gh-ajbeamon/trace-overflow-debug-line
...
Add some extra print debugging if we overflow the trace buffer
2022-03-01 10:12:09 -08:00
Josh Slocum
92a888910f
Fix many repeated recruitment bug
2022-03-01 12:00:53 -06:00
A.J. Beamon
beac368ba9
Add a mechanism to enable error backtrace logging for select errors
2022-03-01 09:11:21 -08:00
A.J. Beamon
f6b24cd644
Add some extra print debugging if we overflow the trace buffer.
2022-03-01 09:04:15 -08:00
A.J. Beamon
97aec45ce8
Fix formatting issues caused by clang-format
2022-03-01 08:51:50 -08:00
Renxuan Wang
fa2eee8279
Use PRId64 and PRIu64 to replace lld and llu.
...
This fixes https://github.com/apple/foundationdb/pull/6148#issuecomment-1054575608 .
2022-02-28 21:30:14 -08:00
Xiaoge Su
5e39da7741
fixup! Reformat the source
2022-02-28 18:03:52 -08:00
Xiaoge Su
02e396274f
Fix the compile error on NativeAPI.actor.cpp
2022-02-28 18:03:52 -08:00
Zhe Wu
aadd706a0a
Port back addressed comments for fixing get key location issue
2022-02-28 16:08:57 -08:00
zhenfeng yang
847cff72b7
Add a target to generate profile ( #6396 )
...
add a target to generate profile
2022-02-28 17:00:30 -06:00
Andrew Noyes
2e8bce04c6
Remove brittle fdbcli help text snapshot test
...
This seems to be more trouble than value so far.
2022-02-28 15:24:29 -06:00
Andrew Noyes
24f37aceb7
Avoid conflict between versioned client/server rpms
...
Building locally this seems to cause a conflict between the versioned
client and server rpms. Not sure why this doesn't always show up.
2022-02-28 15:24:29 -06:00
Andrew Noyes
d559caefea
Use centos:7 for pkg_tester
...
yum update with just `centos` seems to have problems
2022-02-28 15:24:29 -06:00
Trevor Clinkenbeard
fe957deef8
Merge pull request #6399 from sfc-gh-bvr/fdb#4271
...
Introduce a new server knob and use it to test if storage servers are…
2022-02-28 13:02:23 -08:00
sfc-gh-tclinkenbeard
90927cffe9
Set disableHostname=true in CycleTestRestart downgrade test
2022-02-26 17:56:56 -08:00
Renxuan Wang
233c918ffb
Replace printf() and fprintf() with fmt::print().
2022-02-25 19:06:57 -08:00
Renxuan Wang
f7eb66441d
Try eliminating warnings in macOS and Windows CI builds.
...
MacOS warnings are format warnings, e.g., `format specifies type 'long' but the argument has type 'Version' (aka 'long long')`.
Windows warnings are `ACTOR does not contain a wait() statement`.
2022-02-25 19:06:57 -08:00
Markus Pilman
079de5ba57
Enable rocksdb unit tests
2022-02-25 15:38:16 -08:00
Markus Pilman
a61dd41b45
Add an empty test to make sure noSim tests succeed
2022-02-25 15:38:16 -08:00
Andrew Noyes
276cf3a402
Fix minor bugs turned up by _GLIBCXX_DEBUG ( #6375 )
...
* Fix a benign bug turned up by _GLIBCXX_DEBUG
Just calling std::vector::operator[] with an out of bounds index at all
is technically undefined behavior.
* Fix compilation issue with _GLIBCXX_DEBUG
For some reason std::max with an initializer list isn't constexpr with
_GLIBCXX_DEBUG set
2022-02-25 13:50:41 -08:00
Andrew Noyes
b58739093e
Account for possibility that fopen might fail in mako ( #6442 )
...
Fix an issue in mako where the stats process would hang if the worker process
was unable to open a file. Previously, the worker process would segfault when
trying to dereference a null FILE* and never increment the stopcount variable
in shared memory. Now we check for a null FILE* and increment stopcount when
the worker process stops regardless of success or failure.
Also don't ignore the return value from mkdir
2022-02-25 13:18:59 -08:00
Andrew Noyes
7a9217a392
Add contrib/debug_determinism ( #6389 )
...
* Add contrib/debug_determinism
Add an instrumentation-based technique for debugging unseen mismatches. Also guard a few existing sources of nondeterminism that don't affect unseen with the DEBUG_DETERMINISM macro.
Also change the simulated run loop to not run as the only task inside the real run loop, since that was a source of nondeterminism.
Also fix nondeterminism from calling timer_int
* Add StorageMetadataType::currentTime
Basically a deterministic-in-simulation version of timer_int that we can
use instead of timer_int for StorageMetadataType::createdTime
2022-02-25 12:54:31 -08:00
Zhe Wu
57e931b489
Update 6.3.24 release notes
2022-02-25 12:12:17 -08:00
A.J. Beamon
d4e6123971
Merge pull request #6457 from Doxense/fix-6449-windows-build
...
Fix Windows build broken by #6449
2022-02-25 09:07:20 -08:00
Mohamed Oulmahdi
5b6098b5be
Fix Windows build broken by #6449
2022-02-25 16:25:45 +01:00
Renxuan Wang
06b1d06d38
Support hostname in coordinators commands.
2022-02-24 23:02:29 -08:00