Commit Graph

695 Commits

Author SHA1 Message Date
Jon Fu 4e8625ccc0 retain old behaviour along with explicit request 2021-11-03 17:23:07 -04:00
Jon Fu 59f0a2c3e5 Change dbinfo broadcast to be explicitly requested by the worker registration message 2021-11-03 15:51:21 -04:00
Evan Tschannen ee00135a6b skip good recruitment errors when doing simulation only validation 2021-11-01 13:24:15 -07:00
Evan Tschannen 78e36e7590 fix: simulation only validation could throw errors which would impact the behavior of the cluster controller 2021-11-01 13:24:15 -07:00
Evan Tschannen ddf235713e strengthen assert 2021-10-28 16:40:30 -07:00
Evan Tschannen 4d8ee2ed33 fix: simple recruitment could succeed with less than the required replication factor 2021-10-28 16:38:04 -07:00
Vaidas Gasiunas 875824b186 MVC2.0: Notify clients about relevant changes of client libraries 2021-10-27 23:43:40 +02:00
Josh Slocum 0ff8ddc2b6 Merge branch 'master' into blob_full_clean 2021-10-25 13:38:48 -05:00
A.J. Beamon e882eb33fc Abstract the cluster file into a cluster connection record that can be backed by something other than the filesystem. 2021-10-22 11:05:18 -07:00
Josh Slocum 773886515e Merge branch 'feature-range-feed' into blob_full_clean 2021-10-22 11:07:51 -05:00
Josh Slocum 912ef76f1c cleanup before merge 2021-10-18 17:11:14 -05:00
Suraj Gupta 5466bdb569 Gate more entry points to BM recruitment. 2021-10-18 15:04:22 -04:00
A.J. Beamon 507a09893c
Add ClientCount to ClusterControllerMetrics (#5748) 2021-10-17 20:47:11 -07:00
Josh Slocum 5f0ec0612a Merge branch 'feature-range-feed' into blob_full 2021-10-13 15:44:35 -05:00
Suraj Gupta 2ec8781224 Merge knobs into one. 2021-10-13 14:00:37 -04:00
Suraj Gupta 5a6a052c55 Add a knob to gate blob-related work. 2021-10-13 09:48:02 -04:00
Zhe Wu 645cfc85a0 fix remote health variables declaration order 2021-10-07 21:54:25 -07:00
Zhe Wu 6540b6eec5 Some improvements for grey failure failover 2021-10-07 20:42:55 -07:00
Zhe Wu c07a07dbbe Take uptime into account when making failover decision 2021-10-07 11:19:34 -07:00
Zhe Wu 62197faa46 Add more comments to the code 2021-10-07 11:19:34 -07:00
Zhe Wu c0fbe5471f Implement the core logic of grey failure triggered failover 2021-10-07 11:19:34 -07:00
Suraj Gupta 282f9d35cd Cleanup comments and debugging code. 2021-10-04 11:07:08 -04:00
Suraj Gupta 4d54669ccd Recruit the blob workers via blob manager.
In this PR, the blob manager now recruits blob workers
(via communication with the cluster controller). Blob workers
are onboarded as blob worker processes enter the cluster.
2021-10-04 11:07:08 -04:00
Chang Liu c523964ff7 Fix roll trace event issue
Description

Testing
2021-09-24 09:53:32 -07:00
Chang Liu 8427e40cbe Fix roll trace event issue
Description

Testing
2021-09-24 09:53:32 -07:00
Chang Liu 48990058a3 Fix roll trace event issue
Description

Testing
2021-09-24 09:53:32 -07:00
Zhe Wu e28fef6264 Fix failover logic in checkRecoveryStalled: failover only when remote is enabled 2021-09-23 20:12:22 -07:00
Suraj Gupta 5fa6c687d6 Add blob manager as a singleton. 2021-09-23 10:45:37 -04:00
Suraj Gupta 95c004f80b Add missing namespace qualifier to vector. 2021-09-22 16:57:04 -05:00
Suraj Gupta 2b9dfc1371 Simplify count increments. 2021-09-22 16:56:59 -05:00
Suraj Gupta 4530e746d6 Address PR comments.
Adds comment for constant and changes method name for `setonDb`.
2021-09-22 16:56:49 -05:00
Suraj Gupta 4a71f3d0f8 Fix recruitment bug. 2021-09-22 16:56:44 -05:00
Suraj Gupta 72edcd8d73 Address PR comments.
Revert knob name change, fix comparison between new and old
recruitments, and get rid of empty `if` block.
2021-09-22 16:56:34 -05:00
Suraj Gupta 10807ddebc Rename function to be more clear. 2021-09-22 16:56:27 -05:00
Suraj Gupta 0b6fecddbc Refactor logic for recruiting singletons.
This commit refactors the logic for recruiting singletons,
which is done by the ClusterController. This allows for far
easier additions of new singletons in the future, and also
cleans up the code.

Also, the logic for recruiting DD was changed to mirror
the logic for recruiting RK. Although the logic for RK
allows there to be many RKs existing at once, the moveKeysLock
mechanism used by DD still prevents multiple DDs existing at once.
2021-09-22 16:56:18 -05:00
Suraj Gupta 90e102cfd2 Add missing namespace qualifier to vector. 2021-09-20 16:43:08 -05:00
Suraj Gupta 0f898fe138 Simplify count increments. 2021-09-20 14:26:42 -05:00
Suraj Gupta bac9d4cca8 Address PR comments.
Adds comment for constant and changes method name for `setonDb`.
2021-09-20 14:26:42 -05:00
Suraj Gupta 1420106d8f Fix recruitment bug. 2021-09-20 14:26:42 -05:00
Suraj Gupta 6533678f0d Address PR comments.
Revert knob name change, fix comparison between new and old
recruitments, and get rid of empty `if` block.
2021-09-20 14:26:42 -05:00
Suraj Gupta 6b4eb06201 Rename function to be more clear. 2021-09-20 14:26:42 -05:00
Suraj Gupta fe098b3b11 Refactor logic for recruiting singletons.
This commit refactors the logic for recruiting singletons,
which is done by the ClusterController. This allows for far
easier additions of new singletons in the future, and also
cleans up the code.

Also, the logic for recruiting DD was changed to mirror
the logic for recruiting RK. Although the logic for RK
allows there to be many RKs existing at once, the moveKeysLock
mechanism used by DD still prevents multiple DDs existing at once.
2021-09-20 14:26:42 -05:00
Xiaoge Su abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
Zhe Wu 51920ffa16 RecruitFromConfigurationRetry should wait for goodRecruitmentTime to be ready 2021-09-02 09:32:08 -07:00
Zhe Wu 6e4f74c9b3 Remove checkRegions in shouldTriggerRecoveryDueToDegradedServers 2021-08-30 13:03:14 -07:00
FDB Formatster 2c788c233d apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-08-27 17:07:47 -07:00
Zhe Wang 7f595f4925 add_trace_event_for_role_recruitment_by_CC 2021-08-23 20:23:55 -05:00
Zhe Wu a8655e5f4e Allow CC health monitor to handle cancellation 2021-08-19 16:32:18 -07:00
yao-xiao-github 0afb63c13f
Update fdbserver/ClusterController.actor.cpp
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-08-18 15:29:13 -07:00
Yao Xiao 7f0a09d1e2 Enable debugTransaction before getReadVersion. 2021-08-18 15:22:58 -07:00
Yao Xiao 4b8dadfdfb Use Time instead of Timestamp. 2021-08-18 11:53:52 -07:00
Yao Xiao 977f8f494e Add version and timestamp to TimeKeeperCommit event. 2021-08-18 01:27:38 -07:00
Jingyu Zhou bccb09f9dd
Merge pull request #5387 from sfc-gh-tclinkenbeard/improve-worker-const-correctness
Add const qualifiers to several parameters in `worker.actor.cpp`
2021-08-16 13:32:07 -07:00
sfc-gh-tclinkenbeard 3418c20867 Merge remote-tracking branch 'origin/master' into paxos-config-db 2021-08-16 10:49:47 -07:00
sfc-gh-tclinkenbeard ceb83f7f5e Make ccInterface a const reference in workerServer 2021-08-14 23:41:39 -07:00
Lukas Joswiak 305a17c811 Improve config broadcaster logic, fix unit tests 2021-08-10 11:39:29 -07:00
Lukas Joswiak 72e63db856 Send ConfigBroadcastInterface to ConfigBroadcaster instead of entire worker interface 2021-08-10 11:39:29 -07:00
Lukas Joswiak 3946cf94ff Push updates to workers (clang-formatted files) 2021-08-10 11:39:29 -07:00
Lukas Joswiak 092ab4302b Push updates to workers 2021-08-10 11:39:29 -07:00
sfc-gh-tclinkenbeard 82546853c0 Rename UseConfigDB to ConfigDBType 2021-08-09 10:04:35 -07:00
sfc-gh-tclinkenbeard c74047c665 Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings 2021-07-28 11:51:02 -07:00
A.J. Beamon 9f571255bd
Merge pull request #5271 from sfc-gh-ajbeamon/do-not-reset-committed-transaction
Do not partially reset a transaction when it is committed or fails to commit with an error
2021-07-28 09:02:54 -07:00
Steve Atherton 507c1f11e3 Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use. 2021-07-26 19:55:10 -07:00
A.J. Beamon febc26a1ea Fix some cases where we were reusing a committed transaction without resetting it. 2021-07-26 11:43:07 -07:00
Zhe Wu e39cfd48c3 Ignore goodRecruitmentTime and populate default PEER_LATENCY_CHECK_MIN_POPULATION 2021-07-26 10:24:26 -07:00
sfc-gh-tclinkenbeard 3442ebd3b7 Fix more -Wreorder-ctor warnings across many files 2021-07-24 11:20:51 -07:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
Markus Pilman 3169f8d25b
Merge pull request #5104 from sfc-gh-ljoswiak/fixes/remote-satellite-determinism
Disable recruitment determinism check for configurations with remote satellites
2021-07-13 10:57:38 -06:00
Xiaoxi Wang f8a21f4f6c fix invalid trace detail name 2021-07-12 17:44:26 +00:00
Zhe Wu 8773cb1a42
Merge pull request #5088 from halfprice/zhewu/cc-health-triggered-recovery
Implement the main logic of gray network triggered recovery in Cluster Controller
2021-07-11 20:50:34 -07:00
sfc-gh-tclinkenbeard 79ff07a071 Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters 2021-07-02 15:04:42 -07:00
Lukas Joswiak e828a498cd Pass vector by const reference 2021-07-01 11:01:52 -07:00
Lukas Joswiak 0bd6ac2a8e Disable recruitment determinism check for configurations with remote satellites 2021-07-01 09:30:46 -07:00
Zhe Wu 5a325aded9 Implement the core logic of gray network triggered recovery in cluster controller 2021-06-30 11:27:05 -07:00
Zhe Wu 865367fb72 Add updateWorkerHealth interface in cluster controller 2021-06-24 19:42:28 -07:00
sfc-gh-tclinkenbeard 41c790b299 Merge remote-tracking branch 'origin/master' into config-db 2021-06-10 22:31:23 -07:00
sfc-gh-tclinkenbeard 13ee24f464 Add UseConfigDB class 2021-06-10 20:57:50 -07:00
Jingyu Zhou e34df983ee
Merge pull request #4800 from sfc-gh-tclinkenbeard/remove-extra-copies
Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>>
2021-06-07 13:23:50 -07:00
A.J. Beamon e02ef3b8d8
Merge pull request #4842 from RenxuanW/config
Improve logging on the current view of the database configuration that the cluster controller is using.
2021-06-07 11:28:40 -07:00
sfc-gh-tclinkenbeard 371a38e6e5 Merge remote-tracking branch 'origin/master' into remove-extra-copies 2021-06-07 10:26:06 -07:00
sfc-gh-tclinkenbeard f10dd70c37 Remove configuration_database from status when disabled 2021-06-06 08:51:18 -07:00
Josh Slocum 9b36f69b8d
Merge pull request #4892 from sfc-gh-jslocum/tss_mappingv2
TSS Mapping Change
2021-06-04 14:57:51 -07:00
Lukas Joswiak ba25b95c6a Fix global config not updating on server processes 2021-06-03 14:27:24 -07:00
Josh Slocum b3e4f182ef TSS Mapping Change 2021-06-02 17:30:09 +00:00
sfc-gh-tclinkenbeard a775f92fca Merge remote-tracking branch 'origin/master' into config-db 2021-06-01 15:39:34 -07:00
RenxuanW 4f6b983bfb Address comments. 2021-05-27 12:58:47 -07:00
Josh Slocum 4257ac2b4d More TSS Changes/Fixes 2021-05-25 20:37:48 +00:00
Josh Slocum ce82c9653e Testing Storage Server implementation 2021-05-25 20:28:50 +00:00
RenxuanW caeceb932e Improve logging on the current view of the database configuration that the cluster controller is using. 2021-05-24 09:37:57 -07:00
RenxuanW 319e77eef1 Add severity in logWorkerUnavailable(). Also, only log when fitness is GoodFit or BestFit. 2021-05-18 12:57:39 -07:00
sfc-gh-tclinkenbeard fcc6efd3b1 Add .cluster.configuration status json field 2021-05-18 10:47:16 -07:00
sfc-gh-tclinkenbeard ea8396c9be Improve decoupling of configuration database interfaces and implementations 2021-05-17 15:31:03 -07:00
sfc-gh-tclinkenbeard e8040dc609 Get /fdbserver/ConfigDB/ConfigBroadcaster/Simple unit test passing 2021-05-14 00:41:02 -07:00
RenxuanW 8a15d7d14b Bring #4518 (Logging more detailed information during Tlog recruitment) back. 2021-05-13 12:20:31 -07:00
sfc-gh-tclinkenbeard a5749de6b6 Refactor ConfigBroadcaster 2021-05-11 16:57:37 -07:00
Lukas Joswiak 4ea760b2a9 Revert "Merge pull request #4136 from sfc-gh-mpilman/features/actor-lineage"
This reverts commit da41534618, reversing
changes made to e6300905d6.
2021-05-10 20:26:12 -07:00
sfc-gh-tclinkenbeard f28ac955c3 Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>> 2021-05-10 16:32:50 -07:00
Lukas Joswiak cdf98f987d
Revert "Fix global config not triggering changes on server processes" 2021-05-10 12:18:28 -07:00
Markus Pilman ccfc48d89a
Merge pull request #4782 from sfc-gh-ljoswiak/fixes/global-config-processes
Fix global config not triggering changes on server processes
2021-05-07 21:15:36 -06:00
Neethu Haneesha Bingi 3c94a09baf Using failedWorkerInfo before its gets erased 2021-05-06 17:04:25 -07:00
Neethu Haneesha Bingi d975e563cc Rename of variables in trace event. 2021-05-06 16:48:36 -07:00
Neethu Haneesha Bingi 7a6d7cae96 Added worker network address and process class details to trace log. 2021-05-06 16:48:36 -07:00
Neethu Haneesha Bingi 97cd53d649 Adding TraceEvent when a worker is removed from cluster controller. 2021-05-06 16:48:35 -07:00
Lukas Joswiak 0fc1552683 Fix global config updates not triggering on fdbserver processes 2021-05-06 15:46:34 -07:00
Lukas Joswiak e7d7b39f12
Merge pull request #4744 from sfc-gh-tclinkenbeard/add-rangeresult-type-alias
Create RangeResult type alias
2021-05-03 16:29:33 -07:00
sfc-gh-tclinkenbeard 5c2d7b6080 Create RangeResult type alias 2021-05-03 13:14:16 -07:00
sfc-gh-tclinkenbeard f9ede75b42 Remove unused variable in ClusterController.actor.cpp 2021-05-03 11:10:43 -07:00
Markus Pilman 54919d4f3b Merge remote-tracking branch 'sfc/features/actor-lineage' into features/actor-lineage 2021-04-28 09:22:14 -06:00
Evan Tschannen 1f98dec1df cleaned up default constructed maps 2021-04-26 19:26:25 -07:00
sfc-gh-tclinkenbeard dc577b6608 Fix some bugs in distribution of configBroadcaster interface 2021-04-26 18:46:22 -07:00
sfc-gh-tclinkenbeard 7211d838cf Remove broadcastConfigDatabase actor 2021-04-26 15:54:08 -07:00
Evan Tschannen 451609e6be code cleanup 2021-04-26 10:16:18 -07:00
Evan Tschannen 50bb9b51b4 simulation does recruitment twice and compares the results to ensure recruitment is deterministic 2021-04-26 10:13:59 -07:00
Evan Tschannen 49ca48f82e fix: tlog recruitment could select more than the desired about of tlogs
fix: tlog recruitment did not attempt to avoid longLivedStateless processes
2021-04-26 10:09:44 -07:00
Evan Tschannen 7503964ee9 recruitment tries to avoid degraded processes altogether, rather than just the worst one. Since this is a behavior change from the backup recruitment, we cannot compared degraded between the two recruitments 2021-04-26 10:01:54 -07:00
Evan Tschannen ccfc77f6fb changed preferredSharing to be ordered, so that recruitment will always share with the same other role when everything else is equal 2021-04-26 09:57:46 -07:00
sfc-gh-tclinkenbeard 9bed1f7aa5 Run SimpleConfigBroadcaster on cluster controller 2021-04-25 17:20:02 -07:00
Evan Tschannen b61a911685 removed an ASSERT that was for debugging purposed, and increased the max commit latency, because it can be spuriously triggered by dummy transactions that take 5+ seconds each 2021-04-21 14:30:06 -07:00
Evan Tschannen e18c9961b4 rewrote tlog recruitment logic so that it is deterministic, to prevent better master exists from triggering spuriously 2021-04-21 00:22:33 -07:00
Lukas Joswiak c81e1e9519 Add sampling profiler frequency to global config 2021-04-19 22:46:57 -07:00
RenxuanW 4bf7218e8f
Merge pull request #4635 from RenxuanW/priority_logging
Log a warning when remote dc is disabled (priority < 0)
2021-04-15 17:00:41 -07:00
Lukas Joswiak 7de23918c0 Add comments, fix erase bug, make optimizations 2021-04-14 10:56:33 -07:00
Lukas Joswiak c38ddf5eb7 Add comments 2021-04-14 10:56:33 -07:00
Lukas Joswiak 7ba7257cd2 Store global config data on heap 2021-04-14 10:56:33 -07:00
Lukas Joswiak 1c60653c2a Add fix to conditionally set global config history 2021-04-14 10:56:33 -07:00
Lukas Joswiak 6de28dd916 clang-format 2021-04-14 10:56:33 -07:00
Lukas Joswiak 1260385965 Use object to wrap global configuration history 2021-04-14 10:56:32 -07:00
Lukas Joswiak fb9a929780 Fix issue with freed memory being accessed 2021-04-14 10:56:32 -07:00
Lukas Joswiak c3f68831af Move existing ClientDBInfo variables to global configuration 2021-04-14 10:56:32 -07:00
Lukas Joswiak 7bb0b3d899 Use commit version for global configuration updates
FIXME: There is a memory issue where the underlying data for values set
in the `data` field of GlobalConfig will be freed shortly after being
set.
2021-04-14 10:56:32 -07:00
Lukas Joswiak f1415412f1 Add global configuration framework implementation 2021-04-14 10:56:32 -07:00
Evan Tschannen bd6db9ca7c
Update fdbserver/ClusterController.actor.cpp
Co-authored-by: Markus Pilman <markus.pilman@snowflake.com>
2021-04-13 15:13:45 -07:00
RenxuanW 7be8dab045 Change DcPriorityNegative to CCDcPriorityNegative 2021-04-08 16:00:37 -07:00
RenxuanW 738e7402f7 Log a warning when remote dc is disabled (priority < 0) 2021-04-08 15:36:52 -07:00
RenxuanW f3d5fa4750 Revert "Log a warning when remote dc's priority doesn't match the original primary."
This reverts commit 1d701e8bcf.
2021-04-08 15:19:43 -07:00
RenxuanW 1d701e8bcf Log a warning when remote dc's priority doesn't match the original primary. 2021-04-08 14:38:37 -07:00
Evan Tschannen a90c26f1d0 The master, proxies, and resolver all need to have the same machine class fitness function besides best fit to ensure recruitment is deterministic
if the first GRV proxy or resolver is forced to share a process, it should prefer to share with the commit proxy so that the commit proxy has more potential options it can share with
2021-04-08 14:29:12 -07:00
Evan Tschannen 5695a1816f fix: requiredFitness was being set to one higher than the actual requirement 2021-04-07 21:31:14 -07:00
Evan Tschannen 1b1f73ea16 added comments 2021-04-07 20:40:42 -07:00
Evan Tschannen 4d8dd0b0a0 fix: desired must be greater than or equal to required 2021-04-07 20:32:45 -07:00
Evan Tschannen 14213b0151 code cleanup 2021-04-07 20:06:30 -07:00
Evan Tschannen 15e8b43961 rewrote getWorkersForTLogs to do a much better job of avoiding degraded processes and processes in the same DC as the cluster controller 2021-04-07 19:57:24 -07:00
Evan Tschannen c27d82cecd tlog recruitment used a degraded LogClass process over a non-degraded TransactionClass process
tlog recruitment would not use TransactionClass processes if it fulfulled the required amount with LogClass processes
Better master exists did not account for how many times a process had been used when comparing recruitments
Better master exists did not account for the fact that tlogs prefer to be in a different dc than the cluster controller
RoleFitness comparison did not properly order count before degraded or bestFit
betterCount was returning worstFit when worstIsDegraded did not match
backupWorker recruitment did not attempt to avoid sharing processes with other roles
If any of the commit_proxy, grv_proxy, or resolver are forced to share a process, allow the recruitment for all of them to share to an equal degree, this change allows BetterMasterExists to be refactors as a tuple comparison
2021-04-07 16:04:08 -07:00
Markus Pilman 50342b5082 fix a second low-latency bug 2021-03-29 13:31:26 -06:00
Markus Pilman 8555723b98 removing testing case 2021-03-26 15:46:54 -06:00
Markus Pilman 43bed1d9dd Fix bug where betterMasterExist and recruitment disagree 2021-03-26 15:06:59 -06:00
Evan Tschannen 10b6b5d710 If the current configuration does not have a satellite fallback policy we do not care if the old configuration is in fallback mode 2021-03-23 13:02:31 -07:00
A.J. Beamon 99f3bb6d7d
Merge pull request #4509 from sfc-gh-etschannen/feature-bme-count
Do not trigger BetterMasterExists if it lowers the number of processes
2021-03-22 13:43:24 -07:00
Zhe Wu 15f3699e22 Add targeting DC ids in the tlog recruitment event trace. 2021-03-19 14:10:38 -07:00
Meng Xu 0cedef123b
Merge pull request #4518 from halfprice/zhewu/log-tlog-recruitment-failure-reason
Logging more detailed information during Tlog recruitment
2021-03-19 11:36:05 -07:00
Zhe Wu 58d9f47782 log fitness for excluded workers as well 2021-03-19 11:04:53 -07:00
Zhe Wu 4c00361f1c Add comment for 'getWorkersForTlogs' method, and addressed TraceEvent formatting comments. 2021-03-18 21:33:43 -07:00
Zhe Wu 9419387295 Update logging field. 2021-03-18 14:53:43 -07:00
Evan Tschannen 2ff63f544e
Update fdbserver/ClusterController.actor.cpp
Co-authored-by: Lukas Joswiak <lukas.joswiak@snowflake.com>
2021-03-18 13:45:51 -07:00
Zhe Wu 451b14af09 Log detailed information when a worker is considered as unavailable by the cluster controller for TLog recruitment. 2021-03-18 12:18:03 -07:00
Zhe Wu 6468c5aed6 Fix string join 2021-03-17 23:46:11 -07:00
Zhe Wu 1205650a69 Log the dcid during TLog recruitment, so that we can tell in which DC the recruitment is happening 2021-03-17 23:22:42 -07:00
Evan Tschannen 9aeb69ca1c added a comment 2021-03-16 14:19:23 -07:00
Evan Tschannen d0f134c20e added a comment 2021-03-16 13:17:56 -07:00
Evan Tschannen 2a272e525f fix compile error 2021-03-16 12:21:21 -07:00
Evan Tschannen 10fd094920 Better master exists should not trigger if it will lower the total number of processes being recruited 2021-03-16 12:14:19 -07:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
Evan Tschannen 346a4e3ecd Merge branch 'release-6.3'
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbrpc/LoadBalance.actor.h
#	fdbrpc/MultiInterface.h
#	fdbserver/ClusterController.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/masterserver.actor.cpp
2021-03-01 18:52:06 -08:00
Meng Xu 33eb1de00e Add some comment to log system
and resolve review comment by deleting my questions.
2021-02-19 21:44:13 -08:00
Meng Xu 9122be4d81 Add comments to HA code and loadBalance code 2021-02-10 13:51:36 -08:00
Richard Chen c77d9e4abe merge conflicts 2020-12-02 21:53:19 +00:00
Markus Pilman bdd3dbfa7d remove duplicates 2020-11-10 14:01:07 -07:00
sfc-gh-tclinkenbeard 4669f837fa Add uses of makeReference 2020-11-07 22:10:18 -08:00
Xin Dong 99d31391ca Fixed a crash found by nightly correctness. 2020-11-03 09:28:04 -08:00
Richard Chen bbf5bdf6da fix stable interfaces test and corresponding changes in simulator 2020-10-12 18:25:12 +00:00
Richard Chen 5488ff1d81 draft diff protocol 2020-10-12 18:24:03 +00:00
Richard Chen 41843f07e6 add simulator support for different process versions and ProtocolVersion test 2020-10-12 18:19:31 +00:00
Xin Dong 175d52312a Prevent segmentation fault. 2020-10-08 13:36:15 -07:00
Young Liu cc5bc16bd8 Rename more places from proxy to commit proxy 2020-09-15 22:29:49 -07:00
Young Liu 35bef73a1c Rename proxy to commit proxy 2020-09-10 17:44:15 -07:00
Young Liu 87693cae81 merge master branch and resolve conflicts 2020-09-02 13:44:33 -07:00
Evan Tschannen 12edadd059 Merge branch 'release-6.3'
# Conflicts:
#	CMakeLists.txt
#	fdbclient/Knobs.cpp
#	fdbclient/MasterProxyInterface.h
#	fdbrpc/simulator.h
#	fdbserver/MasterProxyServer.actor.cpp
#	tests/fast/CycleAndLock.txt
#	tests/fast/TxnStateStoreCycleTest.txt
#	tests/fast/VersionStamp.txt
#	tests/slow/ParallelRestoreOldBackupApiCorrectnessAtomicRestore.txt
#	tests/slow/ParallelRestoreOldBackupCorrectnessCycle.txt
#	versions.target
2020-08-31 19:33:34 -07:00
Evan Tschannen d42a6b6ea7 remove spammy trace event 2020-08-31 10:37:00 -07:00
Young Liu 19df032aec Change some formatting issues 2020-08-13 15:30:21 -07:00
Young Liu 4a30492186 Remove debug trace 2020-08-13 14:42:00 -07:00
Young Liu 79ce16650d merge master branch 2020-08-11 19:22:10 -07:00
Young Liu ba803a5ea3 Fixed formatting issues and removed GRV related code in MasterProxy 2020-08-11 18:54:54 -07:00
Young Liu 104bac3cbd Add trace to debug 2020-08-07 13:02:41 -07:00
Young Liu 56cc15ee71 Add trace to debug 2020-08-07 01:02:07 -07:00
Young Liu d6a23a4d6b Resolve comments to make GRV proxy a separate process class 2020-08-06 00:01:57 -07:00
Young Liu 30ea639666 Remove debug traces 2020-07-29 07:55:05 -07:00
Young Liu f7b76a92af pass joshua 2020-07-29 07:26:55 -07:00
Meng Xu a2089b354a RemoveServersSafely:Safety check toKill1 to avoid cluster getting stuck
toKill1 and toKill2 are a random subset of all processes. If simply kill all processes in toKill1 or toKill2,
we may kill too many processes to make the cluster unavailable and stuck.

Similar as what toKill2 were modified if it can cause cluster unavailable,
we should do the same thing for toKill1
2020-07-28 21:07:31 -07:00
Young Liu 1826ac75d5 Add some trace events to debug 2020-07-25 18:16:08 -07:00
Young Liu 0fc681cc3c Remote some code comments 2020-07-23 22:29:51 -07:00
Young Liu 618414a416 Fix bugs related to getting proxies workers 2020-07-23 18:32:47 -07:00
Young Liu 229ab0d5f1 Fix some conflicts and remote debugging trace events 2020-07-22 23:35:46 -07:00
Young Liu 525f10e30c Merge master branch 2020-07-22 16:08:49 -07:00
Young Liu 302cf5c45f Remove debug trace events 2020-07-22 12:20:22 -07:00
Young Liu 2703cedac5 Fixed known bugs 2020-07-17 22:24:52 -07:00
Young Liu 21c1998cca Fix MaxTLogQueueSize Bug 2020-07-16 15:56:04 -07:00
Young Liu 5b06d69d25 Pass watches test 2020-07-15 00:37:41 -07:00
Andrew Noyes f470ba8316 Remove using namespace std::rel_ops
This causes the following to not compile anymore

\#include <utility>
\#include <vector>

using namespace std::rel_ops;

int main() {
    std::vector<int> xs;
    return xs.rbegin() != xs.rend();
}

See https://godbolt.org/z/s1977n
2020-07-10 22:58:15 +00:00
Meng Xu 9668f32df5
Merge pull request #3388 from apple/release-6.3
Merge Release 6.3 into master
2020-06-18 08:50:25 -07:00
Vishesh Yadav 3068a37e1b refactor: Remove dead failureDetectionServer code 2020-06-17 15:40:21 -07:00