Meng Xu
22f7f804b8
Merge branch 'release-6.3' into mengxu/merge-6.3-PR
2020-06-28 11:19:39 -07:00
Steve Atherton
af6b141736
Merge pull request #3407 from sfc-gh-tclinkenbeard/fix-vectorref-memory-leaks
...
Fix memory leaks in VectorRef
2020-06-25 00:54:33 -07:00
Jingyu Zhou
5cd3dad986
Merge pull request #3409 from sears/assert_strings
...
Print out the text (to stderr and as trace) of the failed condition o…
2020-06-24 14:58:12 -07:00
Russell Sears
422003df34
Print out the text (to stderr and as trace) of the failed condition on assert failure
2020-06-24 14:21:48 -07:00
sfc-gh-tclinkenbeard
8de70432a6
Fix memory leaks in VectorRef
...
VectorRef<T> relies on T being trivially destructible, but this was not
yet enforced. By statically asserting that T is trivially destructible,
we avoid leaking memory by not calling the destructor for non-trivially
destructible types
2020-06-24 10:54:19 -07:00
Evan Tschannen
01030672a0
Merge pull request #3307 from yliucode/read-version
...
Serve GetReadVersion through master
2020-06-23 15:10:39 -07:00
A.J. Beamon
c01a345652
Merge pull request #3386 from sfc-gh-tclinkenbeard/improve-const-correctness
...
Improve const-correctness
2020-06-18 12:40:08 -07:00
A.J. Beamon
76ac5dfeaf
Merge branch 'release-6.3' into merge-release-6.3-into-master
...
# Conflicts:
# documentation/sphinx/source/release-notes/release-notes-630.rst
2020-06-17 18:31:06 -07:00
sfc-gh-tclinkenbeard
7a28ace7eb
Mark IKeyValueContainer::getElementBytes constexpr
2020-06-17 18:20:44 -07:00
sfc-gh-tclinkenbeard
77e3b314f6
Mark IKeyValueStore::getStorageBytes const
2020-06-17 18:20:43 -07:00
sfc-gh-tclinkenbeard
2a393633b6
Improved const-correctness
...
Using the recently added IndexedSet::const_iterator
(https://github.com/apple/foundationdb/pull/3185 ), we can improve the
const-correctness of many functions. In this PR const is added where
applicable. Also, wherever I came across the following while adding
const, I made the following changes:
- virtual function overrides are marked as override
- NULL is replaced with nullptr
- git clang-format is applied
2020-06-17 18:20:43 -07:00
Young Liu
8cd97a2be8
Resolve Evan's comments:
...
- Only report commit version when commit version is larger than the known committed version.
- Fix task priorities of [Get/Report]LiveCommittedVersion [request/reply].
- Fix some code style issues.
2020-06-17 10:02:25 -07:00
Meng Xu
bbdd451fb6
FastRestore:Add priorities for loader and applier endpoints
...
Endpoint for later restore step should have higher priority for
better performance: later step will not be blocked by the
next version batch's earlier steps.
2020-06-16 22:48:32 -07:00
Jingyu Zhou
327cc31e35
Revert "Request tracing"
2020-06-16 12:32:42 -07:00
Evan Tschannen
4c7d43271a
merge 6.3 into 7.0
2020-06-15 11:14:11 -07:00
Meng Xu
8595813b7d
Merge pull request #3355 from apple/release-6.3
...
Merge Release 6.3 into master branch
2020-06-12 20:08:47 -07:00
Russell Sears
2cee47b235
Merge pull request #3314 from sfc-gh-tclinkenbeard/optimize-deque-copy-ctor
...
Use std::copy in Deque copy constructor
2020-06-12 16:47:35 -07:00
A.J. Beamon
9ac8a2007a
Merge pull request #3351 from xumengpanda/mengxu/proto-version-comment-PR
...
Explain the dev version in protocol version
2020-06-12 15:57:31 -07:00
sfc-gh-tclinkenbeard
f7835ee2cf
Made Deque copy constructor and assignment operator consistent
2020-06-12 15:02:19 -07:00
Trevor Clinkenbeard
9f0487506c
Style change in deque copy
...
Co-authored-by: Russell Sears <sears@cs.berkeley.edu>
2020-06-12 14:58:34 -07:00
Trevor Clinkenbeard
f6051202df
Style change in deque copy
...
Co-authored-by: Russell Sears <sears@cs.berkeley.edu>
2020-06-12 14:58:21 -07:00
Trevor Clinkenbeard
e223726c92
Update comment in Deque.h
...
Co-authored-by: Russell Sears <sears@cs.berkeley.edu>
2020-06-12 14:57:56 -07:00
Meng Xu
80334351c7
Merge pull request #3329 from sfc-gh-mpilman/features/flatbuffers-debugtx
...
Request tracing
2020-06-12 14:50:19 -07:00
Meng Xu
5da8f1b9aa
Protocol dev version revision by A.J.
2020-06-12 14:48:11 -07:00
A.J. Beamon
6f4d6f1923
Refreshing TLS files was done to an incorrect location that resulted in random memory being wiped out. Also fixed a typo that loaded the key bytes into the CA bytes in some cases.
2020-06-12 14:40:10 -07:00
Meng Xu
9ed6780f35
Explain the dev version in protocol version
2020-06-12 14:19:30 -07:00
Russell Sears
87a53be22f
silence macos x linker warning
2020-06-11 13:30:29 -07:00
Markus Pilman
ae6b716820
addressed more review comments
2020-06-11 09:58:41 -07:00
Daniel Smith
2243ee0033
s/NULL/nullptr/
...
Co-authored-by: A.J. Beamon <ajbeamon@users.noreply.github.com>
2020-06-11 12:06:16 -04:00
Daniel Smith
8088bf7212
Move flush call onto main thread to make TraceBatch not thread hostile
2020-06-11 15:53:29 +00:00
sfc-gh-tclinkenbeard
4376f441f7
Added comment for Deque copy ctor
2020-06-11 08:45:44 -07:00
Markus Pilman
eb8a40b079
Put trace interfaces in separate file
2020-06-10 16:38:25 -07:00
Markus Pilman
9ef93714ac
Address review comments
2020-06-10 15:48:49 -07:00
Markus Pilman
f6c50c60f3
Fix Windows build failure
2020-06-10 15:31:37 -07:00
Markus Pilman
4ab3441a95
Merge remote-tracking branch 'origin/master' into features/flatbuffers-debugtx
2020-06-10 15:31:29 -07:00
Trevor Clinkenbeard
c2587bd87c
Merge branch 'master' into optimize-deque-copy-ctor
2020-06-10 14:38:30 -07:00
sfc-gh-tclinkenbeard
99bf993815
Replace BOOST_NOEXCEPT with noexcept
2020-06-09 22:39:19 -07:00
sfc-gh-ngoyal
693d9e8b89
Merge branch 'master' into fdb_cache_wo_allocator
2020-06-09 15:09:58 -07:00
sfc-gh-tclinkenbeard
39a6c0a2f4
Use std::copy in Deque copy constructor
2020-06-08 22:36:07 -07:00
Markus Pilman
09c136e434
Framework for transaction tracing
2020-06-08 16:09:37 -07:00
Russell Sears
817b8df739
Merge pull request #3185 from tclinken/add-indexedset-const-iterator
...
Add IndexedSet::const_iterator
2020-06-08 09:42:48 -07:00
Russell Sears
3278222e2c
Merge pull request #3077 from tclinken/reenable-wclass-memaccess
...
Fix segmentation fault and reenable -Wclass-memaccess
2020-06-08 09:42:35 -07:00
Meng Xu
558fd6ba16
Merge pull request #3296 from apple/release-6.3
...
Merge release 6.3 to master
2020-06-05 10:49:06 -07:00
Evan Tschannen
30bfd606c0
Merge branch 'release-6.2' into release-6.3
...
# Conflicts:
# CMakeLists.txt
# documentation/sphinx/source/downloads.rst
# documentation/sphinx/source/release-notes.rst
# fdbserver/worker.actor.cpp
# packaging/msi/FDBInstaller.wxs
# versions.target
2020-06-04 19:21:32 -07:00
Steve Atherton
bf072d68ec
Workarounds for strange behaviors in Boost ssl sockets on MacOS and Linux. When writing to the ssl socket, write_some() would sometimes return BrokenPipe instead of WouldBlock unless onWriteable on the raw socket was checked first. On MacOS, even with the onWriteable check using a send size greater than 2016 (determined experimentally) would still result in the error. Also consolidated two identical copies of SendBufferIterator.
2020-06-04 01:44:05 -07:00
Russell Sears
3415bbcd09
Fix ARM build; add ACKNOWLEDGEMENTS entries
2020-06-02 16:09:43 -07:00
Russell Sears
a99ceb9c42
Add cmake option to enable avx512
2020-06-02 15:07:00 -07:00
Russell Sears
c5e2df99a2
comments
2020-06-02 15:07:00 -07:00
Russell Sears
11f658cfe2
Add cmake option to disable AVX
2020-06-02 15:07:00 -07:00
Russell Sears
e77f9701f3
Settle on using rte_memcpy when we do not know the copy size at runtime, and builtin memcpy otherwise
2020-06-02 15:06:57 -07:00