Xin Dong
|
c95fa062b2
|
For the read sampling, use a specialized notify function to avoid unnecessary stack object allocation and a lot branch misses.
|
2019-11-22 15:21:09 -08:00 |
|
Xin Dong
|
b6e1839d84
|
Code clean up
|
2019-11-21 13:39:19 -08:00 |
|
Xin Dong
|
b282e180d5
|
Added a knob to disable read sampling
|
2019-11-20 14:03:20 -08:00 |
|
Xin Dong
|
25fb63e68a
|
For performance concerns, change the read sampling when doing a range read. Now it bills the total cost of a range read to the start key of the range returned.
|
2019-11-20 14:03:20 -08:00 |
|
Xin Dong
|
3d3e186c83
|
Removed a place where it's essentially double logging the read size
|
2019-11-20 14:03:20 -08:00 |
|
negoyal
|
a4a0bf18f9
|
Merging with Master.
|
2019-11-12 13:01:29 -08:00 |
|
Xin Dong
|
199a34b827
|
Defined a minimum read cost (a penalty) for empty read or read size smaller than it. Fixed several review comments.
|
2019-10-30 10:04:19 -07:00 |
|
Xin Dong
|
fe54a4bde1
|
- Changed SHARD_MAX_BYTES_READ_PRE_KEYSEC to be equivalent to 8MiB/s, which when times the sample expire interval(120 seconds) yields 960MiB/s. A shard having a read rate larger than that will be marked as read-hot. The number 960MiB was chosen to be roughtly twice the size of the max allowed shard size to avoid wrongly marking a shard as read-hot when doing a table scan on it.
- Also tuned down the empty key sampling percentage to be 5%.
|
2019-10-23 12:00:19 -07:00 |
|
Xin Dong
|
e6f5748791
|
Use a large value for read sampling size threshold. Also at sampling site, don't round up small values to avoid sampling every key.
|
2019-10-22 13:47:58 -07:00 |
|
Xin Dong
|
3efeff04e6
|
Remove iosPerKSecond metric increment.
|
2019-10-09 16:42:42 -07:00 |
|
Xin Dong
|
cd4757b06c
|
Address review comments
|
2019-10-09 16:42:42 -07:00 |
|
Xin Dong
|
6b0f771cc0
|
Fixex a typo in knobs. Addressed some review comments. Added code for actual metric collecting.
|
2019-10-09 16:42:42 -07:00 |
|
Meng Xu
|
d0147e5e5d
|
Merge branch 'release-6.2' into mengxu/merge-release620-to-master-v3
Resolved Conflicts:
documentation/sphinx/source/release-notes.rst
fdbserver/DataDistribution.actor.cpp
versions.target
|
2019-10-02 13:22:56 -07:00 |
|
Evan Tschannen
|
d0e5b0d3a1
|
Added a buggify
|
2019-09-30 13:24:28 -07:00 |
|
Evan Tschannen
|
27db0ca530
|
Update fdbserver/storageserver.actor.cpp
Co-Authored-By: Jingyu Zhou <jingyuzhou@gmail.com>
|
2019-09-30 13:16:31 -07:00 |
|
Evan Tschannen
|
eee4404e4e
|
fix: when the shard pointer is replaced with a new AddingShard, we need to restart the warningLogger because the old one will have a pointer to the deleted AddingShard
|
2019-09-27 19:11:34 -07:00 |
|
Evan Tschannen
|
b495cc697b
|
Merge branch 'release-6.2'
# Conflicts:
# CMakeLists.txt
# documentation/sphinx/source/release-notes.rst
# versions.target
|
2019-09-13 09:25:08 -07:00 |
|
A.J. Beamon
|
e6fbc602df
|
Add metric to track empty reads.
|
2019-09-12 15:09:22 -07:00 |
|
A.J. Beamon
|
41fd3d9467
|
Merge branch 'master' into remove-unused-ssi-get-version
# Conflicts:
# fdbclient/StorageServerInterface.h
# fdbserver/storageserver.actor.cpp
|
2019-09-10 08:11:43 -07:00 |
|
A.J. Beamon
|
3d5f769ea3
|
Add a storage server metric for bytes cleared based on the byte sample.
|
2019-09-05 11:31:26 -07:00 |
|
Meng Xu
|
c2355f721e
|
Merge branch 'master' into mengxu/performant-restore-PR
|
2019-09-04 17:11:42 -07:00 |
|
Meng Xu
|
d160810662
|
FastRestore:Resolve review comments
|
2019-09-04 16:48:43 -07:00 |
|
Evan Tschannen
|
a7237c4302
|
Merge pull request #2045 from atn34/disallow-scalar-network-messages
Disallow scalar network messages
|
2019-08-30 13:38:54 -07:00 |
|
A.J. Beamon
|
1fdabe62c2
|
Merge pull request #2048 from etschannen/feature-fix-connections
Fixed two different ways useful connections were being closed
|
2019-08-30 11:05:02 -07:00 |
|
Evan Tschannen
|
1c0484cffc
|
fix: do not close connections which have outstanding tryGetReplies with the peer
|
2019-08-29 16:49:57 -07:00 |
|
Andrew Noyes
|
6aa0ada7b1
|
Replace scalar root types with proper messages
|
2019-08-28 14:40:50 -07:00 |
|
A.J. Beamon
|
64ce0c3285
|
Remove the unused getVersion from StorageServerInterface.
|
2019-08-26 13:53:54 -07:00 |
|
Evan Tschannen
|
297b65236f
|
added additional trace events to warn when different parts of shard relocations take more than 10 minutes
|
2019-08-16 14:56:58 -07:00 |
|
Meng Xu
|
7ccaeddf05
|
Merge branch 'master' into mengxu/performant-restore-PR
|
2019-08-01 13:23:17 -07:00 |
|
Andrew Noyes
|
1bad0fd44e
|
Make requestTime private
|
2019-07-31 17:59:35 -07:00 |
|
A.J. Beamon
|
14648e20f9
|
Merge pull request #1901 from ajbeamon/data-distribution-receives-bytes-input-rate
Send bytes input rate to data distribution
|
2019-07-30 15:01:36 -07:00 |
|
Evan Tschannen
|
3ad1d95049
|
Merge pull request #1894 from ajbeamon/trace-file-detail-rename
Expand undefined acronym in trace event detail
|
2019-07-26 13:34:45 -07:00 |
|
Evan Tschannen
|
8149b5b352
|
Merge pull request #1413 from atn34/change-connection-file
Switch cluster file feature
|
2019-07-26 13:27:37 -07:00 |
|
Meng Xu
|
1706aaf199
|
Merge branch 'master' into mengxu/performant-restore-PR
Fix conflict in TlogServer.actor.cpp by accepting master changes
|
2019-07-26 11:46:27 -07:00 |
|
sramamoorthy
|
9afd162e2f
|
remove snap v1 related code
|
2019-07-25 17:29:31 -07:00 |
|
A.J. Beamon
|
b91795d288
|
Send bytes input rate to DD.
|
2019-07-25 16:27:32 -07:00 |
|
Meng Xu
|
45083edf74
|
Merge branch 'master' into mengxu/performant-restore-PR
Fix conflicts as well.
|
2019-07-25 10:46:11 -07:00 |
|
sramamoorthy
|
8f1f0c0435
|
snap v2: worker and other helper related changes
|
2019-07-24 15:36:28 -07:00 |
|
Trevor Clinkenbeard
|
9ad9bd4c1f
|
Merge branch 'master' of https://github.com/apple/foundationdb into change-connection-file
|
2019-07-24 15:22:26 -07:00 |
|
A.J. Beamon
|
639df02f20
|
Expand undefined acronym in trace event detail
|
2019-07-24 08:38:36 -07:00 |
|
Evan Tschannen
|
3045826e3c
|
Merge pull request #1819 from mpilman/flatbuffers-fixes2
Flatbuffers fixes2
|
2019-07-19 16:33:50 -07:00 |
|
Alex Miller
|
c3a8ae4752
|
Merge pull request #1791 from fzhjon/fetch-keys-requests-priority
Introduce priority to fetchKeys requests from data distribution
|
2019-07-19 14:54:51 -07:00 |
|
Alex Miller
|
9863ace96c
|
Replace usages with intialization lists.
But C++ needs a bit of help to inference though the templates.
|
2019-07-18 22:27:36 -07:00 |
|
mpilman
|
1ac2d01b03
|
Merge remote-tracking branch 'upstream/master' into flatbuffers-fixes2
|
2019-07-18 09:50:08 -07:00 |
|
A.J. Beamon
|
2cd05e9ac9
|
Merge pull request #1712 from tclinken/add-local-rk-to-status
Track the local ratekeeper rate in status
|
2019-07-15 15:17:11 -07:00 |
|
mpilman
|
54416f46fd
|
Pass type as param to VectorRef instead of bool
|
2019-07-15 15:08:49 -07:00 |
|
Trevor Clinkenbeard
|
e1541778ab
|
Added readsRejected counter to storage server
|
2019-07-15 10:53:19 -07:00 |
|
Jon Fu
|
4b0fdabae5
|
mark test file as IGNORE and comment out dead placeholder code
|
2019-07-15 09:45:16 -07:00 |
|
mpilman
|
b68f2d925f
|
Serialize range result to string for speed
|
2019-07-11 23:03:31 -07:00 |
|
Jon Fu
|
652cd77689
|
fixed merge conflicts and use new TaskPriority enum class
|
2019-07-11 09:56:59 -07:00 |