Commit Graph

7111 Commits

Author SHA1 Message Date
Steve Atherton 2d3e78df77 Merge branch 'master' of github.com:apple/foundationdb into redwood-io-priority 2021-07-21 13:44:48 -07:00
sfc-gh-tclinkenbeard 169df42a8b Merge remote-tracking branch 'origin/master' into const-serverdbinfo 2021-07-21 11:02:47 -07:00
Steve Atherton c16b73bb2f Bug fix, BTreeCursor pager event reason was not being initialized. Changed metric column order. 2021-07-21 01:28:25 -07:00
Steve Atherton 3e2206680d Merge branch 'master' of github.com:apple/foundationdb into redwood-io-priority
# Conflicts:
#	fdbserver/VersionedBTree.actor.cpp
2021-07-20 23:57:03 -07:00
Steve Atherton 2f21e0a6bb BTree levels above the configured count for metrics are now included into the highest level, which fixes some valgrind errors and a crash. 2021-07-20 23:40:35 -07:00
Steve Atherton 5ff58ec824 Fixed valgrind errors caused by memory lifetime bugs in Histogram usage. Removed usage of unneeded level 0. 2021-07-20 22:46:56 -07:00
Steve Atherton 01af706228 Refactor metric logging to be shorter and changed text format to be more condensed. 2021-07-20 21:23:50 -07:00
Trevor Clinkenbeard f7b6996ee8
Merge pull request #5234 from sfc-gh-tclinkenbeard/fix-unittest-datadir
Change default data directory for unit tests outside simulation
2021-07-20 18:13:26 -07:00
Steve Atherton 26d886c600
Merge pull request #5227 from sfc-gh-satherton/redwood-io-priority
Add Priority to Redwood IO, also fixes several bugs with the recent Redwood metrics changes
2021-07-20 16:50:58 -07:00
sfc-gh-tclinkenbeard 4d9574901f Change default data directory for unit tests outside simulation 2021-07-20 11:03:36 -07:00
sfc-gh-tclinkenbeard 6f81155784 Merge remote-tracking branch 'origin/master' into const-serverdbinfo 2021-07-20 10:18:40 -07:00
Evan Tschannen 5c9a38e526
Merge pull request #5198 from Daniel-B-Smith/rocksdb-simulation-roll-forward
Roll forward: RocksDB in Simulation
2021-07-20 09:33:11 -07:00
Steve Atherton 80ac791dcf
Priority for commit reads should be == height. 2021-07-19 15:58:38 -07:00
Steve Atherton 275089a9a9
Bug fix, setting var to itself. 2021-07-19 15:16:43 -07:00
Steve Atherton b3cc2beaab
Documentation fix. 2021-07-19 15:10:01 -07:00
Andrew Noyes 9387852fc2 Fix build/memory error
The previous change broke the build intentionally. This fixes it and
also fixes the underlying issue that the previous commit caught.
2021-07-19 14:26:03 -07:00
Steve Atherton 81e83e2830
Update fdbserver/fdbserver.actor.cpp
Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>
2021-07-18 11:08:27 -07:00
Steve Atherton 13db52f1f2 Changed yield to delay(0) in places that use static counters to avoid trying to yield too often. Bug fixes with lazy delete queue entry heights. 2021-07-18 04:38:42 -07:00
Steve Atherton 294d322c0d Merge branch 'fix-simfdb-cleanup' into redwood-io-priority 2021-07-18 03:08:49 -07:00
Steve Atherton 1af8538727 Simfdb cleanup did not recognize the unittests directory, fixed this and also made the cleanup code a bit cleaner. 2021-07-18 03:06:04 -07:00
Steve Atherton 39eb71f54a Corrections in BTreeCursor event reasons, fixed by BTreeCursor now storing reason as a member because it's much simpler. Some other clang-format changes and a couple of renames. 2021-07-18 03:02:10 -07:00
Steve Atherton 09a8561606 Merge branch 'master' of github.com:apple/foundationdb into redwood-io-priority
# Conflicts:
#	fdbserver/IPager.h
#	fdbserver/VersionedBTree.actor.cpp
2021-07-18 01:49:36 -07:00
Steve Atherton 89140b0281 Fixed PagerEventReason for BTree writePages(). Renamed enums to start with capital letters to match one of the two styles used throughput the code base (CamelCase or ALLCAPS). 2021-07-17 03:44:00 -07:00
Steve Atherton c7bc79ad45 Merge branch 'fix-booleans' into fuheng/redWoodMetricsEnhancements 2021-07-17 02:10:14 -07:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
Steve Atherton 2fcc732c2a Merge branch 'master' of github.com:apple/foundationdb into redWoodMetricsEnhancements 2021-07-16 21:06:47 -07:00
Fuheng Zhao f81e8c3d6c change parameter naming 2021-07-16 14:27:53 -07:00
Fuheng Zhao d87e695fba format files 2021-07-16 14:02:59 -07:00
Fuheng Zhao 29d61b708f fix issues 2021-07-16 13:53:30 -07:00
Daniel Smith 66883e5f1c Disable the RocksDB engine in simulation in restarting tests or when it isn't built 2021-07-16 12:51:38 -04:00
Daniel Smith 0f99d449fc Revert "Merge pull request #5194 from apple/revert-5144-rocksdb-in-simulation"
This reverts commit 8ecff8c730, reversing
changes made to c8e18f99f0.
2021-07-16 12:01:01 -04:00
Evan Tschannen 03a01d5eb8 Merge branch 'master' of https://github.com/apple/foundationdb into fix-reply-promise-stream-local-delivery 2021-07-15 16:48:17 -07:00
Evan Tschannen b7b845dab8
Revert "RocksDB in simulation" 2021-07-15 16:41:33 -07:00
Evan Tschannen a5e0e88df8 fix: reply promise streams could receive messages out of order if the sender and receiver were the same process 2021-07-15 15:27:49 -07:00
Daniel Smith 4c1288faa7
Merge pull request #5144 from Daniel-B-Smith/rocksdb-in-simulation
RocksDB in simulation
2021-07-15 16:00:09 -04:00
Steve Atherton 8b0f03f6e8 CommitSubtree was still doing non-caching reads, this was unintentional. 2021-07-15 09:05:36 -07:00
sfc-gh-fzhao af881298de
Merge branch 'apple:master' into redWoodMetricsEnhancements 2021-07-14 18:30:55 -07:00
Fuheng Zhao 08463e0a8b rename record_counter to count 2021-07-14 18:22:38 -07:00
Fuheng Zhao 1c7e3f08c2 format the files 2021-07-14 17:26:24 -07:00
Fuheng Zhao 126c87923f switch unitmapper to static arry 2021-07-14 16:31:13 -07:00
Steve Atherton 8a5caeb756 IO priority tweaks. Writes are lowest, queue reads are highest, reads for prefetch, lazy clear, or remap removal are at leaf priority. Count pager disk reads and writes when they start, after the lock is obtained. 2021-07-14 01:51:53 -07:00
Daniel Smith ed35df9a00 Add comment explaining coro threads 2021-07-13 14:56:23 -04:00
sfc-gh-fzhao 3b40d49a10
Merge branch 'apple:master' into redWoodMetricsEnhancements 2021-07-13 11:36:03 -07:00
Lukas Joswiak 5338251946 Fix invalid read 2021-07-13 10:44:37 -07:00
Fuheng Zhao 737f053a7c modify the reference 2021-07-13 10:10:23 -07:00
Markus Pilman 3169f8d25b
Merge pull request #5104 from sfc-gh-ljoswiak/fixes/remote-satellite-determinism
Disable recruitment determinism check for configurations with remote satellites
2021-07-13 10:57:38 -06:00
Daniel Smith ac46992120 Add warn trace event about non-determinism 2021-07-13 12:25:11 -04:00
Daniel Smith 0613ff892f Enable RocksDB in simulation 2021-07-13 12:25:11 -04:00
sfc-gh-fzhao 62ad629b44
fix comment typo
Co-authored-by: Steve Atherton <steve.atherton@snowflake.com>
2021-07-13 09:08:02 -07:00
sfc-gh-fzhao 5dabb71095
Update comment on metrics by level
Co-authored-by: Steve Atherton <steve.atherton@snowflake.com>
2021-07-13 09:07:39 -07:00