Commit Graph

8136 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard 0fe4dcf469 Make several more TCServerInfo fields private 2022-02-11 19:41:04 -08:00
sfc-gh-tclinkenbeard 4aa5a329ac Encapsulate TCServerInfo::collection and TCServerInfo::tracker 2022-02-11 19:41:04 -08:00
sfc-gh-tclinkenbeard 711462dfd7 Encapsulate TCServerInfo::inDesiredDC 2022-02-11 19:41:04 -08:00
Trevor Clinkenbeard b8d8eafdec
Merge pull request #6379 from sfc-gh-tclinkenbeard/dd-refactor
Shrink public interface of `DDTeamCollection`
2022-02-11 11:44:15 -08:00
sfc-gh-tclinkenbeard 9158564bfc Fix formatting 2022-02-11 10:27:41 -08:00
sfc-gh-tclinkenbeard 3f8c1e2e69 Encapsulate TCServerInfo::id 2022-02-10 23:04:25 -08:00
Trevor Clinkenbeard ef68e6fe0d
Merge pull request #6353 from sfc-gh-ljoswiak/fixes/dynamic-knobs
Fix dynamic knobs correctness issues
2022-02-10 22:13:02 -08:00
sfc-gh-tclinkenbeard 6e87c01404 Move implementations of TC*Info methods to TCInfo.actor.cpp 2022-02-10 19:19:50 -08:00
sfc-gh-tclinkenbeard 2165635478 Make printSnapshotTeamsInfo a static function of DDTeamCollection 2022-02-10 18:45:52 -08:00
sfc-gh-tclinkenbeard 9bc38ae73e Make DDTeamCollection::distributorId private 2022-02-10 18:26:06 -08:00
sfc-gh-tclinkenbeard 14c8483e9d Mark DDTeamCollection::primary private 2022-02-10 18:16:57 -08:00
sfc-gh-tclinkenbeard 8e7963172b Mark DDTeamCollection::excludedServers private 2022-02-10 17:58:59 -08:00
sfc-gh-tclinkenbeard 7ba250a991 Fix -Wreorder-ctor warnings 2022-02-10 17:54:57 -08:00
sfc-gh-tclinkenbeard 1f64477938 Make more DDTeamCollection fields private 2022-02-10 17:44:49 -08:00
sfc-gh-tclinkenbeard 6e60e26730 Make some DDTeamCollection fields private 2022-02-10 16:48:26 -08:00
sfc-gh-tclinkenbeard 641a38bd0b Make more DDTeamCollection methods private.
The methods only used by DDTeamCollection::run can now be made private.
2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard c4508330d2 Make dataDistributionTeamCollection a static function of DDTeamCollection 2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard 5477012ad8 Change DDTeamCollection method signatures to accept references.
Passing nullptr to these methods is invalid, but previously the
signature didn't indicate this. We previously needed to pass pointers
due to actor compiler restrictions, but these restrictions no longer
apply.
2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard b51944b262 Pass constant reference to DDTeamCollection::isCorrectDC 2022-02-10 16:19:32 -08:00
sfc-gh-tclinkenbeard c024fbe845 Mark DDTeamCollection::waitUntilHealthy const 2022-02-10 16:19:32 -08:00
Trevor Clinkenbeard f7118ad406
Merge pull request #6371 from sfc-gh-tclinkenbeard/dd-refactor
Move `DDTeamCollection` method implementations into `.cpp` file
2022-02-10 15:03:01 -08:00
Zhe Wang d684508540 Add RatekeeperLimitReasonDetails traceevent for RK 2022-02-10 13:59:47 -08:00
sfc-gh-tclinkenbeard 0dce252c92 Make many DDTeamCollection methods private 2022-02-10 13:44:39 -08:00
sfc-gh-tclinkenbeard 36700791a1 Use structured bindings in some for loops in DDTeamCollection.actor.cpp 2022-02-10 12:10:45 -08:00
sfc-gh-tclinkenbeard 3141698c41 Use special ASSERT_* macros for numeric comparison in data distribution
code.

This helps debugging by printing the exact input values when an
assertion fails.
2022-02-10 11:59:19 -08:00
sfc-gh-tclinkenbeard 975b9f3b32 Remove get helper function from DataDistribution.actor.cpp 2022-02-10 11:32:33 -08:00
sfc-gh-tclinkenbeard f16aa56d4c Fix comment grammar 2022-02-10 11:26:39 -08:00
sfc-gh-tclinkenbeard b5cefdbcc2 Mark DDTeamCollection methods const 2022-02-10 11:26:04 -08:00
sfc-gh-tclinkenbeard 3c00a66f36 Remove public DDTeamCollection::zeroServerLeftLoggerActor method 2022-02-10 11:19:34 -08:00
sfc-gh-tclinkenbeard b96c2477a3 Mark TSSPairState methods const 2022-02-10 11:12:40 -08:00
sfc-gh-tclinkenbeard c37be7a898 Move DDTeamCollection method implementations into cpp file 2022-02-10 11:09:31 -08:00
Ben Collins 017f9b2308 ApiWorkload ctor failed to perform null check on g_simulator 2022-02-10 09:51:37 -08:00
sfc-gh-tclinkenbeard 1b3aba018c Mark DDTeamCollection::isCorrectDC const 2022-02-09 15:51:52 -08:00
sfc-gh-tclinkenbeard 3f0e2ae62e Merge remote-tracking branch 'origin/main' into dd-refactor 2022-02-09 14:29:16 -08:00
Lukas Joswiak f300cec6ed Fast-track ConfigNode registration with Simple DB
When using the `ConfigDBType::Simple` configuration database, allow
nodes to immediately register with the broadcaster without having to
wait for a quorum.
2022-02-09 14:18:48 -08:00
Lukas Joswiak e8354d82bd Fix timeout issue when using >3 coordinators
The calculation to determine how many non-timeout replies had been
received was incorrect, causing rollback/rollforward requests to not be
sent, causing the dynamic knob subsystem to get stuck.
2022-02-09 13:43:33 -08:00
Lukas Joswiak 7fc4f0d649 Reuse existing quorum timeout error code 2022-02-09 13:43:33 -08:00
Lukas Joswiak ce67d1937f Add explanation of out-or-order messages from broadcaster 2022-02-09 13:43:33 -08:00
Lukas Joswiak b5a3312a26 Factor out known replica update step 2022-02-09 13:43:33 -08:00
Lukas Joswiak 1d496b7b30 Remove timeout
There are a few occasional failures after removing this timeout. They
mostly seem to be caused from contention among the ConfigIncrement
actors which have similar backoffs, causing an infinite loop of attempts
to get their generation accepted on a majority of ConfigNodes.
2022-02-09 13:43:33 -08:00
Lukas Joswiak c86712b4c0 Move single interface serve functions to testing interface 2022-02-09 13:43:33 -08:00
Lukas Joswiak 1d15aa5580 Fix internal function name 2022-02-09 13:43:32 -08:00
Lukas Joswiak d5a562e6b8 Fix dynamic knobs correctness issues 2022-02-09 13:43:32 -08:00
sfc-gh-tclinkenbeard dcbbee56a0 Update copyright dates 2022-02-09 13:28:40 -08:00
Aaron Molitor 96dd86ebf8 update RocskDB and Boost
add Finduring, and include into fdbserver
add BOOST asio/uring settings to fdbserver compile
move portable rocks, liburing up to be configurable at build time.
2022-02-09 10:48:18 -06:00
sfc-gh-tclinkenbeard 3d3223d13c Remove uses of pid2server_info 2022-02-08 15:58:20 -08:00
sfc-gh-tclinkenbeard ebf940b710 Remove pid2server_info field 2022-02-08 14:25:16 -08:00
sfc-gh-tclinkenbeard acb3e840ac Merge remote-tracking branch 'origin/main' into dd-refactor 2022-02-08 00:33:51 -08:00
sfc-gh-tclinkenbeard 04a1347df2 Merge remote-tracking branch 'origin/main' into dd-refactor 2022-02-08 00:33:27 -08:00
Yi Wu 607b2a0184 update comment 2022-02-07 13:32:52 -08:00