Commit Graph

22715 Commits

Author SHA1 Message Date
Xiaoge Su 0f8820e03d
Fix RocksDB link issue (#8296)
* Fix the RocksDB compile issue with clang

By default, RocksDB is using its own compile/link flags, no matter how
FDB flags are. This led to the issue that if FDB decides to use
clang/ldd/libc++, RocksDB will pick up the compiler/linker but still use
libstdc++, which is incompatible to libc++, causing Symobl Missing error
during the link stage.

With this patch, if FDB uses libc++, then the information is stored in
CMAKE_CXX_FLAGS and being forwarded to RocksDB. RocksDB will then use
libc++ and compatible with FDB.

* fixup! update the indentation
2022-09-26 09:19:21 -07:00
Dennis Zhou 080acd811f
tuple: user defined type support (#8300)
* tuple: add support for usertype as last part of tuple

The expectation is user defined types come at the end as there is no
delimiter standard. In that case, if we encounter a user defined type,
we append it to the end of the tuple and allow users to transform that
type by parsing raw string returned.

* blob: use Tuple::unpackUserType() for key alignment

We want blob granule key alignment to be able to understand user data
types. This upgrades support and allows user data types to be the last
key in a blob granule and for us to be able to parse that properly.
2022-09-26 09:18:37 -07:00
Andrew Noyes dc828d8407
Port #7123 (#8315)
Only run valgrind on the binary under test
2022-09-26 09:14:15 -07:00
Josh Slocum f95c22c6a2
Blob Granule Database API tests (#8276)
* adding verify

* Adding error test cases

* more fixes to bg api tests
2022-09-26 11:15:10 +02:00
Dan Adkins df2c1374cb
Correct a couple of comments in simulator and simulated workloads. (#8310) 2022-09-24 22:52:13 -07:00
Markus Pilman 45ef302af6
Merge pull request #8306 from apple/revert-7578-RedwoodIOLaunchLimit
Revert "[DRAFT] Redwood PriorityMultiLock enable different launch limits to be specified based on different priority level."
2022-09-23 16:56:32 -06:00
Xiaoxi Wang d643313793
Merge pull request #8278 from sfc-gh-xwang/feature/main/txnProcessor_queue
Replace BgDDMountainChopper and BgDDValleyFiller with BgDDLoadRebalance and make DDQueue use txnProcessor
2022-09-23 13:01:39 -07:00
Markus Pilman 5774249e5b
Revert "[DRAFT] Redwood PriorityMultiLock enable different launch limits to be specified based on different priority level." 2022-09-23 12:22:47 -06:00
Andrew Noyes fee77c8702
Change crashAndDie to abort instead of segv (#7827)
* Change crashAndDie to abort instead of segv

This way we still terminate early when `--crash` is set, but folks
inspecting error reports don't get mislead and confuse assertion
failures with genuine memory errors.

* Add SIGABRT to crash handler
2022-09-23 11:06:53 -07:00
Markus Pilman 82d8c17d00
Merge pull request #8272 from sfc-gh-dadkins/sfc-gh-dadkins/bugs/reboot-not-kill
Downgrade kill to reboot in Rollback workload.
2022-09-23 11:32:04 -06:00
Markus Pilman 6081f40cfc
Merge pull request #8269 from sfc-gh-dadkins/sfc-gh-dadkins/bugs/kill-process
sim: don't allow calls to killProcess or killInterface to kill protected processes.
2022-09-23 11:31:53 -06:00
Markus Pilman fe4c33fabb
Merge pull request #8302 from sfc-gh-huliu/testfix2
disable MoveKeysWorkload for a few tests that need to manipulate dd
2022-09-23 11:02:04 -06:00
Jingyu Zhou d43df45eff
Merge pull request #8284 from sfc-gh-anoyes/anoyes/disable-aws-backup-aarch64-for-now
Limit BUILD_AWS_BACKUP to x86_64 for now
2022-09-23 09:35:11 -07:00
Markus Pilman eaccfc1923
Merge pull request #8298 from sfc-gh-huliu/testfix
disallow MoveKeysWorkload running in parallel
2022-09-23 10:11:08 -06:00
Hui Liu 9fd16bd38e disable MoveKeysWorkload for a few tests that need to manipulate dd 2022-09-23 08:56:27 -07:00
A.J. Beamon 993e30e563
Merge pull request #8292 from sfc-gh-ajbeamon/move-fdbcli-tests
Move fdbcli tests into the fdbcli directory
2022-09-23 08:40:55 -07:00
Xiaoxi Wang 11a6cba2c6 rename dbProcessor to db; readability improvement 2022-09-22 17:11:07 -07:00
Dan Adkins 48e1b06d29 Add comments about the use of protectedAddresses. 2022-09-22 17:01:01 -07:00
Hui Liu c9b4fc5761 disallow MoveKeysWorkload running in parallel 2022-09-22 17:00:01 -07:00
Josh Slocum 430f6e9670
Fix purge at latest racing with other checking threads at the end of BlobGranuleVerify (#8281) 2022-09-22 16:32:33 -07:00
Josh Slocum 9122e6e5fe
fixing off by one (#8279) 2022-09-22 16:31:55 -07:00
Josh Slocum f78eb8c778
Adding bg read amp metrics (#8275) 2022-09-22 16:31:27 -07:00
Josh Slocum 339183228d
allowing ss feed fetches to go over hard limit (#8243) 2022-09-22 16:31:06 -07:00
A.J. Beamon 2e41eb8a4a Move fdbcli tests into the fdbcli directory 2022-09-22 16:05:56 -07:00
Josh Slocum 28f3cacfd7
Merge pull request #8285 from sfc-gh-jslocum/bg_history_fdbcli
Adding blobkey history fdbcli debug command
2022-09-22 16:56:59 -05:00
Ata E Husain Bohra 52169d2b8e
Enable ZSTD compression support (#8014)
* Enable ZSTD compression filter

Description

  diff-4: Randomize Knob Compression filter selection
  diff-3: Minor refactoring
  diff-2: Limit ZSTD availability to CLANG compiler
  diff-1: Add ZSTD compression option to BlobGranule tests

Major changes includes:
1. Update FDB CMake to download, install and build Boost with
ZSTD compatibility
2. Update CompressionUtils to enable boost::iostreams::zstd
compression filter

Testing

CompressionUtilsUnit.toml
BlobGranuleCorrectness/BlobGranuleCorrectnessClean
devRunCorrectness - 100K (in-progress)
2022-09-22 14:31:49 -07:00
A.J. Beamon bd006526d6
Merge pull request #8251 from sfc-gh-ajbeamon/fdbcli-tenant-group-metadata
Fdbcli command to get tenant group metadata
2022-09-22 14:17:08 -07:00
Josh Slocum 949a5581ba fix format 2022-09-22 15:50:17 -05:00
Josh Slocum 36df430b14 Merge branch 'main' into bg_history_fdbcli 2022-09-22 15:49:07 -05:00
A.J. Beamon 97a325adab Add an fdbcli command to get tenant group metadata 2022-09-22 13:24:21 -07:00
Jingyu Zhou 61b1798634
Merge pull request #8249 from jzhou77/fix-tuple
Fix rare/CheckRelocation setup failure
2022-09-22 12:59:57 -07:00
Steve Atherton 7831f6b2f1
Merge pull request #7578 from sfc-gh-fzhao/RedwoodIOLaunchLimit
[DRAFT] Redwood PriorityMultiLock enable different launch limits to be specified based on different priority level.
2022-09-22 12:29:17 -07:00
Junhyun Shim 2cf38efa00
Merge pull request #8283 from sfc-gh-jshim/disable-authz-integration-test-for-sanitizer-builds
Disable authz integration test for sanitizer builds
2022-09-22 20:55:38 +02:00
Nim Wijetunga 37b93a6232
fix tests (#8286) 2022-09-22 11:34:06 -07:00
Fuheng Zhao 85761bcc87 Empty-Commit 2022-09-22 11:16:57 -07:00
Josh Slocum 21c627ba97 Adding blobkey history fdbcli debug command 2022-09-22 13:03:53 -05:00
A.J. Beamon 41993c41fd
Merge pull request #8271 from sfc-gh-ajbeamon/fdbcli-updated-tenant-command
Convert fdbcli tenant commands to a single command with subcommands
2022-09-22 10:31:53 -07:00
Andrew Noyes 129edebb91 Limit BUILD_AWS_BACKUP to x86_64 for now
With aarch64, in the current docker image, linking curl statically doesn't work yet.

This is the diagnostic:

```
fdbclient/awssdk-build/curl/lib/strerror.c:32:6: error: #error "strerror_r MUST be either POSIX, glibc or vxworks-style"
2022-09-22 16:05:30   #    error "strerror_r MUST be either POSIX, glibc or vxworks-style"
2022-09-22 16:05:30        ^~~~~
```

The root cause is that curl's cmake feature detection logic gets
confused since it can't build binaries that execute successfully with
the link flags it wants:

```
$ cc test.c -lssl
$ ./a.out
./a.out: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory
```
2022-09-22 09:35:38 -07:00
Junhyun Shim 25d551d2f7 Disable authz integration test for sanitizer builds
Language bindings do not work well with sanitizer instrumentation
2022-09-22 18:30:42 +02:00
Steve Atherton 04b4960786 Merge branch 'main' into fzhao/RedwoodIOLaunchLimit
# Conflicts:
#	fdbserver/VersionedBTree.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	fdbserver/workloads/ReadWrite.actor.cpp
2022-09-22 00:39:51 -07:00
Steve Atherton a6fa8cd345 Rework event detail names to sort differently and remove stats for ReadType::Eager because it is only used internally within the storage server. 2022-09-22 00:20:17 -07:00
Xiaoxi Wang e7a280ec03 format code 2022-09-21 20:49:39 -07:00
Xiaoxi Wang aaed0c8b7e Actor to DDQueue methods 2022-09-21 17:57:40 -07:00
Jon Fu 7a09b701cc
Merge pull request #8141 from sfc-gh-jfu/network-disable-bypass
Introduce network option for disabling mvc bypass
2022-09-21 17:33:48 -07:00
Hui Liu bf943bfd57
Merge pull request #8273 from sfc-gh-huliu/testfix
disable MoveKeysWorkload when running SpecialKeySpaceCorrectness test
2022-09-21 17:32:44 -07:00
Jon Fu 937fb38dcc address review comments 2022-09-21 16:23:12 -07:00
A.J. Beamon 64c8e0e2b1 Convert fdbcli tenant commands to a single command with subcommands. Update the structure of fdbcli tenant tests. 2022-09-21 16:22:58 -07:00
Hui Liu f115599a67 disable MoveKeysWorkload when running SpecialKeySpaceCorrectness test 2022-09-21 16:12:20 -07:00
A.J. Beamon 5511f1753a
Merge pull request #8209 from sfc-gh-ajbeamon/fix-base64-decoder-bug
Fix base64 decoder bug
2022-09-21 15:54:09 -07:00
Xiaoxi Wang 141bd99133 Merge branch 'main' of https://github.com/apple/foundationdb into feature/main/txnProcessor_team 2022-09-21 15:35:26 -07:00