Commit Graph

4896 Commits

Author SHA1 Message Date
A.J. Beamon 71e2fdafb8 Changes to ratekeeper camel case 2019-03-27 08:24:25 -07:00
A.J. Beamon d508658569 Make ratekeeper one word to match our existing convention 2019-03-27 08:15:19 -07:00
Evan Tschannen 9e8237955f BinaryWriter uses arena allocation 2019-03-26 17:27:33 -07:00
Evan Tschannen 83b2ff8b08
Merge pull request #1366 from ajbeamon/docs-update-batch-priority
Update documentation about batch priority transactions
2019-03-26 16:08:27 -07:00
Evan Tschannen 75f2929f6b
Merge pull request #1357 from jzhou77/ratekeeper
Add data distributor and ratekeeper to status output
2019-03-26 16:07:44 -07:00
Evan Tschannen efa9b1cd73
Merge pull request #1359 from ajbeamon/fix-database-memory-leak
Avoiding holding references to ThreadSafeDatabase on the main thread.
2019-03-26 16:02:03 -07:00
A.J. Beamon f363bdb007 Update documentation about batch priority transactions 2019-03-26 15:45:38 -07:00
Jingyu Zhou 38c6681349 Fix some signed and unsigned mismatch warnings. 2019-03-26 14:54:11 -07:00
Jingyu Zhou c0b58080ee Fix type name warning for DDTeamCollection
Seen using 'class' now seen using 'struct' in DataDistribution.actor.cpp
2019-03-26 14:18:25 -07:00
Jingyu Zhou 7c02ee6fdd Fix compiler warning about unreferenced exception variable 2019-03-26 13:43:47 -07:00
Evan Tschannen ea38b78768 BinaryWriter uses fastAllocator 2019-03-26 12:06:39 -07:00
Evan Tschannen 3b5b03e435 ReplyPromise does not serialize an empty NetworkAddress 2019-03-26 12:05:43 -07:00
A.J. Beamon cb93f3f8c8
Merge pull request #1308 from xumengpanda/mengxu/schema-doc-PR
Auto-generate the machine-readable status document
2019-03-26 10:42:49 -07:00
Steve Atherton 040513b8fe
Merge pull request #1361 from ajbeamon/fix-parsetime-uninitialized-mem
Initialize the tm.tm_isdst field because it isn't set by strptime.
2019-03-26 10:36:38 -07:00
A.J. Beamon ffb1a666b7
Merge pull request #1362 from apple/release-6.1
Merge release-6.1 into master
2019-03-26 09:15:07 -07:00
A.J. Beamon c3e7611415
Merge pull request #1347 from atn34/fix-fdbcli-trace-format
Fix fdbcli and fdbbackup --trace_format option
2019-03-26 09:13:41 -07:00
A.J. Beamon 1429ffe8ab Initialize the tm.tm_isdst field because it isn't set by strptime. 2019-03-26 09:00:45 -07:00
A.J. Beamon fe68a1f7fb Avoiding holding references to ThreadSafeDatabase on the main thread because this can cause a race with fdb_stop_network when it comes time to destroy it. 2019-03-25 16:11:50 -07:00
Jingyu Zhou 466a59a99d Merge remote-tracking branch 'apple/release-6.1' into ratekeeper 2019-03-25 15:27:38 -07:00
Jingyu Zhou f57a22e2ed Add data distributor and ratekeeper to status output 2019-03-25 15:11:29 -07:00
Meng Xu e30f5ff70d FastRestore: conitnue debugging the cyclic test failure error 2019-03-25 14:09:45 -07:00
Evan Tschannen 5e03e178de
Merge pull request #1345 from ajbeamon/support-multiple-client-or-worker-issues
Add support for a client or worker having multiple issues.
2019-03-24 17:27:50 -07:00
Evan Tschannen d45159ebf7
Merge pull request #1307 from jzhou77/ratekeeper
Monitor placement of Ratekeeper and DataDistributor
2019-03-24 17:26:07 -07:00
Evan Tschannen d6ad027d37 ratekeeper needs to be recruited for proxies to make progress, so if one has not registered with the cluster controller by the time we are accepting commits, recruit a new one 2019-03-24 16:48:24 -07:00
Evan Tschannen f426d732ea fix: forgot to remove one location where id_used was incremented for distributor and ratekeeper 2019-03-24 16:04:59 -07:00
Steve Atherton 8b60c75271
Merge pull request #1353 from alecgrieser/windows-path-check-build-failure
Fix build failure on Windows in Platform.cpp
2019-03-24 15:19:07 -07:00
Evan Tschannen e8948726e8 once we recruit a ratekeeper, do not allow any other ratekeepers to register 2019-03-24 11:04:39 -07:00
Alec Grieser 0ad351751a
fix build failure on Windows from undefined constant and mising parenthesis 2019-03-24 14:03:24 -04:00
Evan Tschannen 24c92a1870
Merge pull request #1352 from etschannen/feature-network-address-list
Changed NetworkAddressList to at most two addresses for performance
2019-03-24 10:22:38 -07:00
Evan Tschannen 38ed21328a fix: the failure monitoring client did not update secondaryAddress correctly 2019-03-23 23:51:12 -07:00
Evan Tschannen 50a4403661 fix: missing parathesis 2019-03-23 21:52:15 -07:00
Jingyu Zhou 40eec20252 Restore master PID in worker registration
This fix is lost during merge.
2019-03-23 21:02:11 -07:00
Jingyu Zhou 3ef26e6be3 Fix fitness assignment statements
Found by MacOS build.
2019-03-23 19:16:04 -07:00
Evan Tschannen 1fc6937802 changed NetworkAddressList to at most two addresses for performance 2019-03-23 17:54:46 -07:00
Evan Tschannen b51a24453e the data distributor and ratekeeper are not included in id_used, but when comparing equally good options we prefer to avoid sharing with those roles
excluded data distributor and ratekeeper were improperly killed when the best option was also excluded
2019-03-23 13:25:36 -07:00
Jingyu Zhou 10988f89d9 Code refactoring for ConsistencyCheck.actor.cpp 2019-03-23 11:06:43 -07:00
Jingyu Zhou fdc5b5ddbf Fix: spurious ratekeeper registration
A rare race condition:
-r simulation -f ./foundationdb/tests/slow/WriteDuringReadAtomicRestore.txt -s 114256311 -b on

- A is the ratekeeper.
- CC recruit B and B starts
- CC halts ratekeeper A and A is halted
- A registers back with CC, which then halts B. CC sets A to be the ratekeeper.

CC starts recruiting and finds A is the best machine. But skips recruiting
because CC thinks A is already used. Now the cluster is left with no ratekeeper.

Fix by disallowing ratekeeper registration with previous ID.
2019-03-23 11:03:51 -07:00
Jingyu Zhou 6523cd4931 Fix: recruit ratekeeper is not triggerred 2019-03-23 09:20:54 -07:00
Steve Atherton 09f37cf3d2
Merge pull request #533 from ajbeamon/fix-parent-directory
Fixes to parentDirectory() and abspath()
2019-03-22 23:53:46 -07:00
Evan Tschannen 2da46e3172 fix: halt if datacenters are different 2019-03-22 23:53:21 -07:00
Evan Tschannen b68bc46042
Merge pull request #1348 from ajbeamon/fix-missing-metrics-when-ss-down
Fix missing read workload metrics
2019-03-22 19:08:04 -07:00
Evan Tschannen d34c56c9a5 ensure that the processId exists in id_worker before accessing it 2019-03-22 18:54:39 -07:00
Balachandar Namasivayam ac8ad07b45 Address review comments. 2019-03-22 18:48:49 -07:00
Balachandar Namasivayam 4ed323ac52 Fixed bug and addressed review comments. 2019-03-22 18:48:49 -07:00
Balachandar Namasivayam d75020b44a Fix bug where accessing shared memory created by boost 1.52 leads to error when accessed by boost 1.67. 2019-03-22 18:48:49 -07:00
Andrew Noyes eacde47050 Disable setMemoryQuota for ASAN 2019-03-22 18:47:38 -07:00
Evan Tschannen 36ab852bb1 Merge branch 'master' into ratekeeper
# Conflicts:
#	fdbserver/ClusterController.actor.cpp
2019-03-22 18:41:00 -07:00
Evan Tschannen add66350f6 Merge branch 'master' of github.com:apple/foundationdb 2019-03-22 18:38:32 -07:00
Evan Tschannen e3400c13ae fixed a performance regression related to broadcasting a read version to too many transactions simultaneously 2019-03-22 18:37:39 -07:00
Evan Tschannen e37e45723c fix: CompareAndClear does not coalesce with itself 2019-03-22 18:37:39 -07:00