Commit Graph

442 Commits

Author SHA1 Message Date
Steve Atherton 507c1f11e3 Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use. 2021-07-26 19:55:10 -07:00
sfc-gh-tclinkenbeard b9a22a61ef Fix many -Wreorder-ctor warnings 2021-07-23 17:33:18 -07:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
sfc-gh-tclinkenbeard 020371a78f Merge remote-tracking branch 'origin/master' into add-boolean-param 2021-07-07 16:50:51 -07:00
Trevor Clinkenbeard f24581b644
Merge pull request #5120 from sfc-gh-tclinkenbeard/improve-poll-delay-safety
Improve safety of backup agent poll delay
2021-07-07 14:42:33 -07:00
sfc-gh-tclinkenbeard 3d0536dcec Improve safety of backup agent poll delay 2021-07-05 13:22:31 -07:00
sfc-gh-tclinkenbeard 8370d92c20 Expand use of BOOLEAN_PARAM in backup code 2021-07-04 18:30:55 -07:00
sfc-gh-tclinkenbeard cadfdc551e Use BOOLEAN_PARAM for backup agents 2021-07-04 16:27:26 -07:00
sfc-gh-tclinkenbeard 8cc40e3a2b Expand use of BOOLEAN_PARAM 2021-07-02 21:41:50 -07:00
sfc-gh-tclinkenbeard 79ff07a071 Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters 2021-07-02 15:04:42 -07:00
sfc-gh-tclinkenbeard 27e44c1bb9 Add support for encryption testing in BackupCorrectness workload 2021-06-26 11:15:12 -07:00
sfc-gh-tclinkenbeard 1afae7623b Added /backup/containers/localdir/encrypted unit test 2021-06-25 22:33:26 -07:00
sfc-gh-tclinkenbeard f5aa3df917 Add --encryption_key_file command line argument to fdbbackup and fdbrestore 2021-06-25 15:11:03 -07:00
sfc-gh-tclinkenbeard 41c790b299 Merge remote-tracking branch 'origin/master' into config-db 2021-06-10 22:31:23 -07:00
sfc-gh-tclinkenbeard c272304e60 Manage global flow knobs with global knob collection 2021-06-09 22:33:00 -07:00
sfc-gh-tclinkenbeard 83a0e473e8 Refactor IKnobCollection code 2021-06-09 20:50:00 -07:00
sfc-gh-tclinkenbeard 371a38e6e5 Merge remote-tracking branch 'origin/master' into remove-extra-copies 2021-06-07 10:26:06 -07:00
sfc-gh-tclinkenbeard 89dadf1475 Create IKnobCollection interface 2021-06-02 23:40:52 -07:00
sfc-gh-tclinkenbeard 4c059670a0 Parse configuration knob values on the client 2021-06-02 10:04:46 -07:00
Andrew Noyes 061afda2ec
Fix several package issues (#4801)
* Make the structure of the server pkg match 6.2.28

* Fix OSX lib path

* Fix install destinations in client

Previously, backup_agent would map to fdbmonitor installation dir -
which is incorrect in the sense that it disagrees with where the default
foundationdb.conf expects to find backup_agent. Add a new backupagent
installation dir and install there, matching foundationdb.conf's
expectations.

Also fix an issue where several of the versions of fdbbackup weren't
being installed

* Update packaging/osx/buildpkg.sh for cmake

* Update README instructions for pkg file

* Remove osx cpack config

* Remove pm install destinations

* Fix weird syntax

* Remove cpack reference to PM

* Address review comments
2021-05-12 11:41:26 -05:00
sfc-gh-tclinkenbeard f28ac955c3 Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>> 2021-05-10 16:32:50 -07:00
sfc-gh-tclinkenbeard 5c2d7b6080 Create RangeResult type alias 2021-05-03 13:14:16 -07:00
RenxuanW 719f810676 Rename incrementalBackupOnly to onlyAppyMutationLogs in all restore configs and functions. 2021-04-26 12:30:46 -07:00
RenxuanW 41ca11c3e5 Implement restoring an inconsistent snapshot as a real feature. 2021-04-22 13:53:37 -07:00
Steve Atherton 75425b5a24
Merge pull request #4620 from RenxuanW/renxuan/first-pr
Control backup's initial snapshot interval via backup cmd argument.
2021-04-19 23:59:02 -07:00
RenxuanW 41104040ad Rename init_snapshot_interval to initial_snapshot_interval. 2021-04-15 15:24:24 -07:00
RenxuanW a0430536f1 Remove knob BACKUP_INIT_SNAPSHOT_INTERVAL_SEC. 2021-04-14 10:41:41 -07:00
RenxuanW ebf37594f7 Change initialSnapshotIntervalSeconds from knob to a backup argument. 2021-04-13 19:22:13 -07:00
Jingyu Zhou cf70575d74 Refactor fdbbackup with BackupTLSConfig 2021-04-08 21:56:02 -07:00
Jingyu Zhou 0ce3ed93ec Refactor TLS config for backup 2021-04-08 21:56:02 -07:00
Jingyu Zhou 86482606bb Add blob credentials option for fdbdecode 2021-04-08 21:56:02 -07:00
Jingyu Zhou a5841dad7b Add TLS support to fdbdecode 2021-04-08 21:56:02 -07:00
Jingyu Zhou 219c8d8526 Remove verbose help output 2021-04-08 21:56:02 -07:00
Jingyu Zhou 7652bd1c08 Update help with all command line options 2021-04-08 21:56:02 -07:00
Jingyu Zhou 55ef40864f Add comments for touched functions 2021-03-29 10:09:07 -07:00
Jingyu Zhou a9d8806828 Use the restored range in the actual restore 2021-03-25 10:07:25 -07:00
Trevor Clinkenbeard 766b9d24d6
Merge branch 'master' into remove-invalid-backup-status-fields 2021-03-14 18:57:03 -07:00
Vishesh Yadav 2cd3f45fd6 Merge remote-tracking branch 'apple/release-6.3' into master-format-final
release-6.3 was recently merged, and there were two PRs which were
merged in between and got those changes in here. Hence, since all the
changes were in, discarded the incoming changes and accepted all
current.
2021-03-10 16:50:44 -08:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
sfc-gh-tclinkenbeard f81d4eb6d3 Remove invalid backup status fields 2021-03-08 15:48:46 -08:00
FDB Formatster 8a8c488ede apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-05 18:13:38 -06:00
Evan Tschannen 346a4e3ecd Merge branch 'release-6.3'
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbrpc/LoadBalance.actor.h
#	fdbrpc/MultiInterface.h
#	fdbserver/ClusterController.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/masterserver.actor.cpp
2021-03-01 18:52:06 -08:00
Evan Tschannen c128e59a6f Merge branch 'release-6.2' into release-6.3
# Conflicts:
#	CMakeLists.txt
#	cmake/InstallLayout.cmake
#	packaging/msi/FDBInstaller.wxs
#	versions.target
2021-03-01 18:35:20 -08:00
Jon Fu aaee4d1df7 added help messages to fdbbackup and fdbrestore for incremental backup 2021-02-25 16:29:23 -05:00
Andrew Noyes 8b308ed2da Fix syntax 2021-02-23 04:50:39 +00:00
Andrew Noyes 0167a449f0 Fix fdbrestore,dr_agent,fdbdr,backup_agent for FDB_RELEASE 2021-02-23 03:05:29 +00:00
Andrew Noyes 56f1912900 Avoid using relative symlinks to work around cpack bug
https://discourse.cmake.org/t/installing-a-symlink-with-a-relative-path-for-rpm/895

closes #2681
2021-02-22 22:56:30 +00:00
sfc-gh-tclinkenbeard 089394abeb Only change name of BackupType::DELETE to BackupType::DELETE_BACKUP 2021-01-30 13:34:48 -08:00
sfc-gh-tclinkenbeard a29c5fb2bc s/BackupType::/BackupType::BACKUP_ 2021-01-29 21:48:27 -08:00
sfc-gh-tclinkenbeard 7558cd8e06 Merge remote-tracking branch 'origin/master' into simplify-global-knobs 2021-01-26 10:00:25 -08:00
Markus Pilman 074531309b
Merge pull request #3769 from sfc-gh-ljoswiak/binary-info
Add CLI argument to print build information
2021-01-26 10:29:57 -07:00
sfc-gh-tclinkenbeard 3e72163374 Fix compile issues 2021-01-21 10:22:48 -08:00
sfc-gh-tclinkenbeard ad99bf0471 Merge remote-tracking branch 'origin' into misc-changes 2021-01-21 10:03:07 -08:00
Lukas Joswiak f011af14bc Add build flags option to fdbdecode binary 2021-01-19 11:21:21 -08:00
Lukas Joswiak b7758cd6b4 Add build flags option to fdbconvert binary 2021-01-19 11:21:21 -08:00
Lukas Joswiak 39c6cedf10 Add build flags option to backup binaries 2021-01-19 11:21:21 -08:00
Lukas Joswiak 2c4b5acd28 Add help option back to actions 2021-01-19 10:33:55 -08:00
Lukas Joswiak d82b61ee0f Update help message for top level options 2021-01-15 17:05:11 -08:00
Lukas Joswiak 1177183819 Copy help option to top level 2021-01-15 17:05:11 -08:00
Lukas Joswiak 14b08e1103 Add top level binary CLI options 2021-01-15 17:05:10 -08:00
sfc-gh-tclinkenbeard 95eaa5e866 Merge remote-tracking branch 'origin/master' into misc-changes 2021-01-13 21:14:36 -08:00
sfc-gh-tclinkenbeard 8ff14878fe Merge remote-tracking branch 'origin/master' into simplify-global-knobs 2021-01-13 14:39:35 -08:00
sfc-gh-tclinkenbeard e29ed3bf99 Remove createGlobal*Knobs functions 2021-01-13 12:14:04 -08:00
Markus Pilman 2609c3d619
Merge pull request #4072 from sfc-gh-tclinkenbeard/improve-type-safety
Make enums automatically binary serializable
2021-01-12 10:31:34 -07:00
sfc-gh-tclinkenbeard 86c7c1e946 Fix IAsyncFileSystem method signatures 2020-12-28 01:57:42 -04:00
sfc-gh-tclinkenbeard 5b2e88b187 Use structured bindings in for loops 2020-12-27 01:46:20 -04:00
sfc-gh-tclinkenbeard b7f4d69dc4 Added VersionedKVPart class to FileDecoder.actor.cpp 2020-12-26 21:53:14 -04:00
sfc-gh-tclinkenbeard 5bfa6cea98 Merge remote-tracking branch 'origin/master' into misc-changes 2020-12-26 20:47:00 -04:00
sfc-gh-tclinkenbeard 0740e35621 Use unique_ptr for backup args 2020-12-08 09:09:32 -08:00
Richard Chen c77d9e4abe merge conflicts 2020-12-02 21:53:19 +00:00
Jon Fu 89194a48b9 Enable --incremental usage for fdbbackup on command line 2020-12-01 15:53:20 -05:00
sfc-gh-tclinkenbeard b1e3478267 Simplified global knobs 2020-11-21 13:27:48 -08:00
sfc-gh-tclinkenbeard 79146d2e31 Improve type-safety of backup.actor.cpp 2020-11-14 22:25:32 -08:00
sfc-gh-tclinkenbeard 4669f837fa Add uses of makeReference 2020-11-07 22:10:18 -08:00
Richard Chen 9c6c2704d0 Merge branch 'master' of https://github.com/apple/foundationdb into stable_interfaces 2020-10-30 23:59:32 +00:00
sfc-gh-tclinkenbeard 55e86c1336 Disambiguate between S3BlobStore and other blob stores 2020-10-29 20:42:23 -07:00
Richard Chen 41843f07e6 add simulator support for different process versions and ProtocolVersion test 2020-10-12 18:19:31 +00:00
Meng Xu bbc7ce581e Resolve conflicts merging from 6.3 to master 2020-09-25 16:08:31 -07:00
Meng Xu 862336de8f Merge branch 'master' into mengxu/merge-to-master-PR 2020-09-24 17:06:00 -07:00
sfc-gh-tclinkenbeard d13a9d3c91 Make EBackupState an enum class 2020-09-23 15:14:09 -07:00
Young Liu 60ccaa2ae9 Support finding max restorable version for key ranges when keyspace's max restorable version is unavailable 2020-09-17 17:58:58 -07:00
Young Liu d4e3e98957 Use new getRestoreSet in RestoreController 2020-09-17 17:56:36 -07:00
Meng Xu f9a5b727a6 Add comments questions and TODOs 2020-09-14 16:28:01 -07:00
Young Liu 3728ed03dd Resolve comments 2020-09-05 18:55:09 -07:00
Young Liu e9d1f1c9c8 change formatting 2020-08-31 09:43:11 -07:00
Young Liu b6c0299d09 Add help message in backup CLI for added options 2020-08-31 09:31:57 -07:00
Young Liu 30e27ba27b Add support for keys in CLI 2020-08-30 00:44:17 -07:00
Young Liu 33aa10b461 Minor optimizations 2020-08-29 20:10:45 -07:00
Young Liu fd7198d874 Extend backup container interface to support query restorable files set by key ranges 2020-08-29 19:58:07 -07:00
Jon Fu 00c77ba2b4 Added beginVersion cmd line option and addressed code review comments 2020-08-28 14:29:22 -04:00
Jon Fu 0270ee13c8 change targetversion from maxlogend to contiguouslogend. also adjusted test workload and specs 2020-08-28 12:46:34 -04:00
Jon Fu ae999aa118 Merge branch 'master' of https://github.com/apple/foundationdb into jfu-incremental-backup-only 2020-08-19 16:36:47 -04:00
Jon Fu 6e1d3f6cbf comment out command-line arguments until atomics are supported 2020-08-19 14:36:11 -04:00
Jon Fu 35aa1034cd added new test spec and workload to verify correctness of incremental backup and restore 2020-08-19 13:45:51 -04:00
Jon Fu 7dce3a9187 fixed issue with mutations not applying and allow backup to non-empty db 2020-08-11 15:39:21 -04:00
Jon Fu 21635f8a28 update backup restore for local testing 2020-08-04 15:48:43 -04:00
Evan Tschannen a49cb41de7 Merge branch 'release-6.3'
# Conflicts:
#	CMakeLists.txt
#	cmake/ConfigureCompiler.cmake
#	fdbserver/Knobs.cpp
#	fdbserver/StorageCache.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	flow/ThreadHelper.actor.h
#	flow/serialize.h
#	tests/CMakeLists.txt
2020-07-29 00:31:55 -07:00
Andrew Noyes d2cf700bd4 Fix compiler warnings 2020-07-28 18:30:26 +00:00
Balachandar Namasivayam 9c569c6ecf
Merge pull request #3569 from xumengpanda/mengxu/fr-fix-frtool-PR
FastRestoreTool: Fix --dest_cluster_file option
2020-07-28 09:56:00 -07:00
Jon Fu 2d09d2f68e re-ordered parameters to fit existing test workloads 2020-07-28 12:39:35 -04:00