wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: coordinators would process forwarding requests before making them durable

This commit is contained in:
Evan Tschannen 2021-11-16 12:21:26 -08:00
parent c8cbb03f51
commit fd635432c4
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fdbserver/Coordination.actor.cpp
View File

@ -528,7 +528,11 @@ struct LeaderRegisterCollection {
// When the lead coordinator changes, store the new connection ID in the "fwd" keyspace.
// If a request arrives using an old connection id, resend it to the new coordinator using the stored connection id.
// Store when this change took place in the fwdTime keyspace.
ACTOR static Future<Void> setForward(LeaderRegisterCollection* self, KeyRef key, ClusterConnectionString conn) {
ACTOR static Future<Void> setForward(LeaderRegisterCollection* self,
KeyRef key,
ClusterConnectionString conn,
ForwardRequest req,
UID id) {
double forwardTime = now();
LeaderInfo forwardInfo;
forwardInfo.forward = true;
@ -539,6 +543,7 @@ struct LeaderRegisterCollection {
store->set(KeyValueRef(key.withPrefix(fwdKeys.begin), conn.toString()));
store->set(KeyValueRef(key.withPrefix(fwdTimeKeys.begin), BinaryWriter::toValue(forwardTime, Unversioned())));
wait(store->commit());
self->getInterface(req.key, id).forward.send(req);
return Void();
}
@ -708,8 +713,7 @@ ACTOR Future<Void> leaderServer(LeaderElectionRegInterface interf,
req.reply.sendError(wrong_connection_file());
} else {
forwarders.add(LeaderRegisterCollection::setForward(
&regs, req.key, ClusterConnectionString(req.conn.toString())));
regs.getInterface(req.key, id).forward.send(req);
&regs, req.key, ClusterConnectionString(req.conn.toString()), req, id));
}
}
}