wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove tags

This commit is contained in:
Lukas Joswiak 2021-01-20 17:05:58 -08:00
parent 4d6fbf099c
commit fd20011276
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fdbclient/NativeAPI.actor.cpp
View File

@ -1913,7 +1913,7 @@ ACTOR Future<Optional<Value>> getValue( Future<Version> version, Key key, Databa
{ {
state Version ver = wait( version ); state Version ver = wait( version );
state Span span("NAPI:getValue"_loc, info.spanID); state Span span("NAPI:getValue"_loc, info.spanID);
span.addTag(LiteralStringRef("key"), key); span.addTag("key"_sr, key);
cx->validateVersion(ver); cx->validateVersion(ver);
loop { loop {
@ -4107,7 +4107,6 @@ ACTOR Future<Version> extractReadVersion(Location location, SpanID spanContext,
} }
metadataVersion.send(rep.metadataVersion); metadataVersion.send(rep.metadataVersion);
span.addTag(LiteralStringRef("read_version"), std::to_string(rep.version));
return rep.version; return rep.version;
} }

1
fdbserver/masterserver.actor.cpp
View File

@ -1006,7 +1006,6 @@ ACTOR Future<Void> getVersion(Reference<MasterData> self, GetCommitVersionReques
rep.version = self->version; rep.version = self->version;
rep.requestNum = req.requestNum; rep.requestNum = req.requestNum;
span.addTag(LiteralStringRef("version"), std::to_string(rep.version));
proxyItr->second.replies.erase(proxyItr->second.replies.begin(), proxyItr->second.replies.upper_bound(req.mostRecentProcessedRequestNum)); proxyItr->second.replies.erase(proxyItr->second.replies.begin(), proxyItr->second.replies.upper_bound(req.mostRecentProcessedRequestNum));
proxyItr->second.replies[req.requestNum] = rep; proxyItr->second.replies[req.requestNum] = rep;

6
fdbserver/storageserver.actor.cpp
View File

@ -974,8 +974,7 @@ ACTOR Future<Version> waitForVersionNoTooOld( StorageServer* data, Version versi
ACTOR Future<Void> getValueQ( StorageServer* data, GetValueRequest req ) { ACTOR Future<Void> getValueQ( StorageServer* data, GetValueRequest req ) {
state int64_t resultSize = 0; state int64_t resultSize = 0;
Span span("SS:getValue"_loc, { req.spanContext }); Span span("SS:getValue"_loc, { req.spanContext });
span.addTag(LiteralStringRef("key"), req.key); span.addTag("key"_sr, req.key);
span.addTag(LiteralStringRef("tag"), data->tag.toString());
try { try {
++data->counters.getValueQueries; ++data->counters.getValueQueries;
@ -3060,8 +3059,7 @@ ACTOR Future<Void> update( StorageServer* data, bool* pReceivedUpdate )
rd >> msg; rd >> msg;
Span span("SS:update"_loc, { spanContext }); Span span("SS:update"_loc, { spanContext });
span.addTag(LiteralStringRef("key"), msg.param1); span.addTag("key"_sr, msg.param1);
span.addTag(LiteralStringRef("tag"), data->tag.toString());
if (ver != invalidVersion) { // This change belongs to a version < minVersion if (ver != invalidVersion) { // This change belongs to a version < minVersion
DEBUG_MUTATION("SSPeek", ver, msg).detail("ServerID", data->thisServerID); DEBUG_MUTATION("SSPeek", ver, msg).detail("ServerID", data->thisServerID);