wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tight bound idx

This commit is contained in:
Fuheng Zhao 2021-06-30 13:43:57 -07:00
parent 0eeaf01883
commit fbded481f6
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fdbserver/VersionedBTree.actor.cpp
View File

@ -469,7 +469,7 @@ public:
nextPageID = id; nextPageID = id;
debug_printf( debug_printf(
"FIFOQueue::Cursor(%s) loadPage start id=%s\n", toString().c_str(), ::toString(nextPageID).c_str()); "FIFOQueue::Cursor(%s) loadPage start id=%s\n", toString().c_str(), ::toString(nextPageID).c_str());
nextPageReader = waitOrError(queue->pager->readPage(pagerEventReasons::metaData, 0, nextPageID, true), queue->pagerError); // check if 0 is correct nextPageReader = waitOrError(queue->pager->readPage(pagerEventReasons::metaData, 0, nextPageID, true), queue->pagerError);
} }
Future<Void> loadExtent() { Future<Void> loadExtent() {
@ -2918,7 +2918,7 @@ public:
Reference<ArenaPage> data = wait(self->readPage(pagerEventReasons::metaData, 0, p.newPageID, false, true)); Reference<ArenaPage> data = wait(self->readPage(pagerEventReasons::metaData, 0, p.newPageID, false, true));
// Write the data to the original page so it can be read using its original pageID // Write the data to the original page so it can be read using its original pageID
self->updatePage(pagerEventReasons::metaData, 0, p.originalPageID, data); // check if this should be 0 self->updatePage(pagerEventReasons::metaData, 0, p.originalPageID, data);
++g_redwoodMetrics.metric.pagerRemapCopy; ++g_redwoodMetrics.metric.pagerRemapCopy;
} else if (firstType == RemappedPage::REMAP) { } else if (firstType == RemappedPage::REMAP) {
++g_redwoodMetrics.metric.pagerRemapSkip; ++g_redwoodMetrics.metric.pagerRemapSkip;
@ -8997,7 +8997,7 @@ TEST_CASE(":/redwood/correctness/pager/cow") {
pager->updatePage(pagerEventReasons::commit, 0, id, p); pager->updatePage(pagerEventReasons::commit, 0, id, p);
pager->setMetaKey(LiteralStringRef("asdfasdf")); pager->setMetaKey(LiteralStringRef("asdfasdf"));
wait(pager->commit()); wait(pager->commit());
Reference<ArenaPage> p2 = wait(pager->readPage(pagerEventReasons::pointRead, 0, id, true)); // check if this level 0 is correct Reference<ArenaPage> p2 = wait(pager->readPage(pagerEventReasons::pointRead, 0, id, true));
printf("%s\n", StringRef(p2->begin(), p2->size()).toHexString().c_str()); printf("%s\n", StringRef(p2->begin(), p2->size()).toHexString().c_str());
// TODO: Verify reads, do more writes and reads to make this a real pager validator // TODO: Verify reads, do more writes and reads to make this a real pager validator

4
flow/Histogram.h
View File

@ -136,7 +136,7 @@ public:
pct = 1.24; pct = 1.24;
} }
size_t idx = (pct*100) / 4; size_t idx = (pct*100) / 4;
ASSERT(idx < 32); ASSERT(idx < 32 && idx >= 0);
buckets[idx]++; buckets[idx]++;
} }
@ -147,7 +147,7 @@ public:
sample = upperBound; sample = upperBound;
} }
size_t idx = ( (sample - lowerBound) * 31.0 ) / (upperBound - lowerBound); size_t idx = ( (sample - lowerBound) * 31.0 ) / (upperBound - lowerBound);
ASSERT(idx < 32); ASSERT(idx < 32 && idx >= 0);
buckets[idx]++; buckets[idx]++;
} }