wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix #2119:remove checkOnly parameter for cycleTest 

`checkOnly` param added for cycleTest verification actually
fails the test during verification.
`runSetup=false` is sufficient for cycleTest verification in
real world or in the simulator.
This commit is contained in:
sramamoorthy 2019-09-30 10:07:02 -07:00 committed by Alex Miller
parent d41852abbc
commit f923fdb166
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fdbserver/workloads/Cycle.actor.cpp
View File

@ -28,7 +28,6 @@ struct CycleWorkload : TestWorkload {
int actorCount, nodeCount; int actorCount, nodeCount;
double testDuration, transactionsPerSecond, minExpectedTransactionsPerSecond; double testDuration, transactionsPerSecond, minExpectedTransactionsPerSecond;
Key keyPrefix; Key keyPrefix;
bool checkOnly;
vector<Future<Void>> clients; vector<Future<Void>> clients;
PerfIntCounter transactions, retries, tooOldRetries, commitFailedRetries; PerfIntCounter transactions, retries, tooOldRetries, commitFailedRetries;
@ -45,7 +44,6 @@ struct CycleWorkload : TestWorkload {
nodeCount = getOption(options, LiteralStringRef("nodeCount"), transactionsPerSecond * clientCount); nodeCount = getOption(options, LiteralStringRef("nodeCount"), transactionsPerSecond * clientCount);
keyPrefix = unprintable( getOption(options, LiteralStringRef("keyPrefix"), LiteralStringRef("")).toString() ); keyPrefix = unprintable( getOption(options, LiteralStringRef("keyPrefix"), LiteralStringRef("")).toString() );
minExpectedTransactionsPerSecond = transactionsPerSecond * getOption(options, LiteralStringRef("expectedRate"), 0.7); minExpectedTransactionsPerSecond = transactionsPerSecond * getOption(options, LiteralStringRef("expectedRate"), 0.7);
checkOnly = getOption(options, LiteralStringRef("checkOnly"), false);
} }
virtual std::string description() { return "CycleWorkload"; } virtual std::string description() { return "CycleWorkload"; }
@ -53,7 +51,6 @@ struct CycleWorkload : TestWorkload {
return bulkSetup( cx, this, nodeCount, Promise<double>() ); return bulkSetup( cx, this, nodeCount, Promise<double>() );
} }
virtual Future<Void> start( Database const& cx ) { virtual Future<Void> start( Database const& cx ) {
if (checkOnly) return Void();
for(int c=0; c<actorCount; c++) for(int c=0; c<actorCount; c++)
clients.push_back( clients.push_back(
timeout( timeout(