From f923fdb16679b39c23163935cf301e6a6e43e653 Mon Sep 17 00:00:00 2001 From: sramamoorthy Date: Mon, 30 Sep 2019 10:07:02 -0700 Subject: [PATCH] Fix #2119:remove checkOnly parameter for cycleTest `checkOnly` param added for cycleTest verification actually fails the test during verification. `runSetup=false` is sufficient for cycleTest verification in real world or in the simulator. --- fdbserver/workloads/Cycle.actor.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/fdbserver/workloads/Cycle.actor.cpp b/fdbserver/workloads/Cycle.actor.cpp index fb3324a3bb..e033f28ec0 100644 --- a/fdbserver/workloads/Cycle.actor.cpp +++ b/fdbserver/workloads/Cycle.actor.cpp @@ -28,7 +28,6 @@ struct CycleWorkload : TestWorkload { int actorCount, nodeCount; double testDuration, transactionsPerSecond, minExpectedTransactionsPerSecond; Key keyPrefix; - bool checkOnly; vector> clients; PerfIntCounter transactions, retries, tooOldRetries, commitFailedRetries; @@ -45,7 +44,6 @@ struct CycleWorkload : TestWorkload { nodeCount = getOption(options, LiteralStringRef("nodeCount"), transactionsPerSecond * clientCount); keyPrefix = unprintable( getOption(options, LiteralStringRef("keyPrefix"), LiteralStringRef("")).toString() ); minExpectedTransactionsPerSecond = transactionsPerSecond * getOption(options, LiteralStringRef("expectedRate"), 0.7); - checkOnly = getOption(options, LiteralStringRef("checkOnly"), false); } virtual std::string description() { return "CycleWorkload"; } @@ -53,7 +51,6 @@ struct CycleWorkload : TestWorkload { return bulkSetup( cx, this, nodeCount, Promise() ); } virtual Future start( Database const& cx ) { - if (checkOnly) return Void(); for(int c=0; c