Expose CommitBatchingWindowSize metric to fdbcli status
Changes: Schemas.cpp: - Extend JSON schema to include aggregated information about CommitBatchingWindowSize samples. Status.actor.cpp: - Extend getStorageServersAndMetrics() to gather metrics about CommitBatchingWindowSize. - Extend CommitProxy AddRole() to populate the status-JSON object with the metrics about CommitBatchingWindowSize.
This commit is contained in:
parent
a445e09c2d
commit
f151df3203
|
@ -181,6 +181,18 @@ const KeyRef JSONSchemas::statusSchema = LiteralStringRef(R"statusSchema(
|
|||
"p99":0.0,
|
||||
"p99.9":0.0
|
||||
},
|
||||
"commit_batching_window_size":{
|
||||
"count":0,
|
||||
"min":0.0,
|
||||
"max":0.0,
|
||||
"median":0.0,
|
||||
"mean":0.0,
|
||||
"p25":0.0,
|
||||
"p90":0.0,
|
||||
"p95":0.0,
|
||||
"p99":0.0,
|
||||
"p99.9":0.0
|
||||
},
|
||||
"grv_latency_bands":{
|
||||
"$map": 1
|
||||
},
|
||||
|
|
|
@ -615,6 +615,11 @@ struct RolesInfo {
|
|||
TraceEventFields const& commitLatencyBands = metrics.at("CommitLatencyBands");
|
||||
if (commitLatencyBands.size()) {
|
||||
obj["commit_latency_bands"] = addLatencyBandInfo(commitLatencyBands);
|
||||
}
|
||||
|
||||
TraceEventFields const& commitBatchingWindowSize = metrics.at("CommitBatchingWindowSize");
|
||||
if (commitBatchingWindowSize.size()) {
|
||||
obj["commit_batching_window_size"] = addLatencyStatistics(commitBatchingWindowSize);
|
||||
}
|
||||
} catch (Error& e) {
|
||||
if (e.code() != error_code_attribute_not_found) {
|
||||
|
@ -1839,7 +1844,7 @@ ACTOR static Future<vector<std::pair<CommitProxyInterface, EventMap>>> getCommit
|
|||
vector<std::pair<CommitProxyInterface, EventMap>> results =
|
||||
wait(getServerMetrics(db->get().client.commitProxies,
|
||||
address_workers,
|
||||
std::vector<std::string>{ "CommitLatencyMetrics", "CommitLatencyBands" }));
|
||||
std::vector<std::string>{ "CommitLatencyMetrics", "CommitLatencyBands", "CommitBatchingWindowSize"}));
|
||||
|
||||
return results;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue