wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Resolve review comments: No functional change

This commit is contained in:
Meng Xu 2022-12-13 15:54:14 -08:00 committed by Meng Xu
parent a1d513b355
commit e6b2254726
3 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fdbserver/DDTeamCollection.actor.cpp
View File

@ -4242,7 +4242,7 @@ int DDTeamCollection::addBestMachineTeams(int machineTeamsToBuild) {
} else { } else {
// When too many teams exist in simulation, traceAllInfo will buffer too many trace logs before // When too many teams exist in simulation, traceAllInfo will buffer too many trace logs before
// trace has a chance to flush its buffer, which causes assertion failure. // trace has a chance to flush its buffer, which causes assertion failure.
traceAllInfo(g_network->isSimulated() ? false : true); traceAllInfo(!g_network->isSimulated());
TraceEvent(SevWarn, "DataDistributionBuildTeams", distributorId) TraceEvent(SevWarn, "DataDistributionBuildTeams", distributorId)
.detail("Primary", primary) .detail("Primary", primary)
.detail("Reason", "Unable to make desired machine Teams") .detail("Reason", "Unable to make desired machine Teams")

1
flow/flow.cpp
View File

@ -449,6 +449,7 @@ void bindDeterministicRandomToOpenssl() {
} }
int nChooseK(int n, int k) { int nChooseK(int n, int k) {
assert(n >= k && k >= 0);
if (k == 0) { if (k == 0) {
return 1; return 1;
} }

1
flow/include/flow/flow.h
View File

@ -100,6 +100,7 @@ extern StringRef strinc(StringRef const& str, Arena& arena);
extern Standalone<StringRef> addVersionStampAtEnd(StringRef const& str); extern Standalone<StringRef> addVersionStampAtEnd(StringRef const& str);
extern StringRef addVersionStampAtEnd(StringRef const& str, Arena& arena); extern StringRef addVersionStampAtEnd(StringRef const& str, Arena& arena);
// Return the number of combinations to choose k items out of n choices
int nChooseK(int n, int k); int nChooseK(int n, int k);
template <typename Iter> template <typename Iter>