Mitigate transitive includes.

fdbclient/BlobGranuleCommon.h

@@ -22,6 +22,8 @@
 #define FDBCLIENT_BLOBGRANULECOMMON_H
 #pragma once
 
+#include <sstream>
+
 #include "fdbclient/CommitTransaction.h"
 #include "fdbclient/FDBTypes.h"
 
@@ -129,4 +131,4 @@ struct BlobGranuleHistoryValue {
 	}
 };
 
-#endif
+#endif

fdbclient/BlobGranuleReader.actor.cpp

@@ -18,9 +18,15 @@
  * limitations under the License.
  */
 
+#include <map>
+#include <vector>
+
 #include "fdbclient/AsyncFileS3BlobStore.actor.h"
 #include "fdbclient/Atomic.h"
+#include "fdbclient/BlobGranuleCommon.h"
 #include "fdbclient/BlobGranuleReader.actor.h"
+#include "fdbclient/BlobWorkerCommon.h"
+#include "fdbclient/BlobWorkerInterface.h"
 #include "fdbclient/SystemData.h" // for allKeys unit test - could remove
 #include "flow/UnitTest.h"
 #include "flow/actorcompiler.h" // This must be the last #include.
@@ -263,13 +269,13 @@ static void applyDeltas(std::map<KeyRef, ValueRef>* dataMap,
 	}
 }
 
-// TODO: improve the interface of this function so that it doesn't need 
+// TODO: improve the interface of this function so that it doesn't need
 //       to be passed the entire BlobWorkerStats object
 ACTOR Future<RangeResult> readBlobGranule(BlobGranuleChunkRef chunk,
                                           KeyRangeRef keyRange,
                                           Version readVersion,
                                           Reference<BackupContainerFileSystem> bstore,
-                                          Optional<BlobWorkerStats *> stats) {
+                                          Optional<BlobWorkerStats*> stats) {
 
 	// TODO REMOVE with V2 of protocol
 	ASSERT(readVersion == chunk.includedVersion);

fdbclient/NativeAPI.actor.cpp

@@ -35,6 +35,7 @@
 #include "fdbclient/ActorLineageProfiler.h"
 #include "fdbclient/AnnotateActor.h"
 #include "fdbclient/Atomic.h"
+#include "fdbclient/BlobGranuleCommon.h"
 #include "fdbclient/ClusterInterface.h"
 #include "fdbclient/CoordinationInterface.h"
 #include "fdbclient/DatabaseContext.h"

fdbclient/NativeAPI.actor.h

@@ -31,7 +31,6 @@
 #include "flow/flow.h"
 #include "flow/TDMetric.actor.h"
 #include "fdbclient/FDBTypes.h"
-#include "fdbclient/BlobGranuleCommon.h"
 #include "fdbclient/CommitProxyInterface.h"
 #include "fdbclient/ClientBooleanParams.h"
 #include "fdbclient/FDBOptions.g.h"

fdbserver/BlobManager.actor.cpp

@@ -21,6 +21,7 @@
 #include <vector>
 #include <unordered_map>
 
+#include "fdbclient/BlobGranuleCommon.h"
 #include "fdbclient/BlobWorkerInterface.h"
 #include "fdbclient/KeyRangeMap.h"
 #include "fdbclient/ReadYourWrites.h"
@@ -33,8 +34,6 @@
 #include "flow/IRandom.h"
 #include "flow/UnitTest.h"
 #include "flow/actorcompiler.h" // has to be last include
-#include "flow/flow.h"
-#include "flow/genericactors.actor.h"
 
 #define BM_DEBUG false
 

fdbserver/BlobWorker.actor.cpp

@@ -18,10 +18,14 @@
  * limitations under the License.
  */
 
+#include <tuple>
+#include <utility>
+#include <vector>
+
 #include "fdbclient/FDBTypes.h"
 #include "fdbclient/SystemData.h"
-#include "fdbrpc/simulator.h"
 #include "fdbclient/BackupContainerFileSystem.h"
+#include "fdbclient/BlobGranuleCommon.h"
 #include "fdbclient/BlobGranuleReader.actor.h"
 #include "fdbclient/BlobWorkerCommon.h"
 #include "fdbclient/BlobWorkerInterface.h"

fdbserver/WorkerInterface.actor.h

@@ -32,6 +32,7 @@
 #include "fdbserver/RatekeeperInterface.h"
 #include "fdbserver/BlobManagerInterface.h"
 #include "fdbserver/ResolverInterface.h"
+#include "fdbclient/BlobWorkerInterface.h"
 #include "fdbclient/ClientBooleanParams.h"
 #include "fdbclient/StorageServerInterface.h"
 #include "fdbserver/TesterInterface.actor.h"

fdbserver/workloads/BlobGranuleVerifier.actor.cpp

@@ -18,6 +18,10 @@
  * limitations under the License.
  */
 
+#include <map>
+#include <utility>
+#include <vector>
+
 #include "fdbclient/BlobGranuleReader.actor.h"
 #include "fdbclient/NativeAPI.actor.h"
 #include "fdbclient/ReadYourWrites.h"