wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mako: add comments

This commit is contained in:
Christian Wende 2023-01-20 12:27:03 +01:00
parent df0999bee2
commit e2913b5b3d
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bindings/c/test/mako/mako.cpp
View File

@ -1573,6 +1573,8 @@ int Arguments::validate() {
logr.error("--num_databases ({}) must be >= number of clusters({})", num_databases, num_fdb_clusters);
return -1;
}
// In sync mode, threads, and in async mode, async workers are assigned to databases. Having more databases than
// threads or async workers leads to unused databases.
if (async_xacts == 0 && num_threads < num_databases) {
logr.error("--threads ({}) must be >= number of databases ({}) in sync mode", num_threads, num_databases);
return -1;
@ -1581,6 +1583,7 @@ int Arguments::validate() {
logr.error("--async_xacts ({}) must be >= number of databases ({}) in async mode", async_xacts, num_databases);
return -1;
}
// Having more threads than async workers in the async mode does lead to unused threads.
if (async_xacts > 0 && num_threads > async_xacts) {
logr.error("--threads ({}) must be <= --async_xacts", num_threads);
return -1;