wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6131 from sfc-gh-anoyes/anoyes/sanitizer-fixes 

Fix some problems when running ctest with ASAN builds
This commit is contained in:
Andrew Noyes 2021-12-09 09:13:25 -08:00 committed by GitHub
parent c24826430f 79116ea887
commit e27d5f6208
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bindings/python/tests/fdbcli_tests.py
View File

@ -188,7 +188,7 @@ def kill(logger):
# and then specify the certain process to kill # and then specify the certain process to kill
process = subprocess.Popen(command_template[:-1], stdin=subprocess.PIPE, stdout=subprocess.PIPE, env=fdbcli_env) process = subprocess.Popen(command_template[:-1], stdin=subprocess.PIPE, stdout=subprocess.PIPE, env=fdbcli_env)
# #
output2, err = process.communicate(input='kill; kill {}\n'.format(address).encode()) output2, err = process.communicate(input='kill; kill {}; sleep 1\n'.format(address).encode())
logger.debug(output2) logger.debug(output2)
# wait for a second for the cluster recovery # wait for a second for the cluster recovery
time.sleep(1) time.sleep(1)
@ -218,7 +218,7 @@ def suspend(logger):
logger.debug("Pid: {}".format(pid)) logger.debug("Pid: {}".format(pid))
process = subprocess.Popen(command_template[:-1], stdin=subprocess.PIPE, stdout=subprocess.PIPE, env=fdbcli_env) process = subprocess.Popen(command_template[:-1], stdin=subprocess.PIPE, stdout=subprocess.PIPE, env=fdbcli_env)
# suspend the process for enough long time # suspend the process for enough long time
output2, err = process.communicate(input='suspend; suspend 3600 {}\n'.format(address).encode()) output2, err = process.communicate(input='suspend; suspend 3600 {}; sleep 1\n'.format(address).encode())
# the cluster should be unavailable after the only process being suspended # the cluster should be unavailable after the only process being suspended
assert not get_value_from_status_json(False, 'client', 'database_status', 'available') assert not get_value_from_status_json(False, 'client', 'database_status', 'available')
# check the process pid still exists # check the process pid still exists

2
cmake/FDBComponents.cmake
View File

@ -210,7 +210,7 @@ set(DEFAULT_COROUTINE_IMPL boost)
if(WIN32) if(WIN32)
# boost coroutine not available in windows build environment for now. # boost coroutine not available in windows build environment for now.
set(DEFAULT_COROUTINE_IMPL libcoro) set(DEFAULT_COROUTINE_IMPL libcoro)
elseif(NOT APPLE AND CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "^x86") elseif(NOT APPLE AND NOT USE_SANITIZER AND CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "^x86")
# revert to libcoro for x86 linux while we investigate a performance regression # revert to libcoro for x86 linux while we investigate a performance regression
set(DEFAULT_COROUTINE_IMPL libcoro) set(DEFAULT_COROUTINE_IMPL libcoro)
endif() endif()