From d1fe9d4c507e84bfcb370e7e5052802fac73edc5 Mon Sep 17 00:00:00 2001 From: Suraj Gupta Date: Thu, 14 Oct 2021 19:25:34 -0400 Subject: [PATCH] Remove old comments from BM. --- fdbserver/BlobManager.actor.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fdbserver/BlobManager.actor.cpp b/fdbserver/BlobManager.actor.cpp index 6bebf4ee5c..a46a22de6b 100644 --- a/fdbserver/BlobManager.actor.cpp +++ b/fdbserver/BlobManager.actor.cpp @@ -477,7 +477,6 @@ ACTOR Future checkManagerLock(Reference tr, Blo bmData->iAmReplaced.send(Void()); } - // TODO different error? throw granule_assignment_conflict(); } tr->addReadConflictRange(singleKeyRange(blobManagerEpochKey)); @@ -508,7 +507,6 @@ ACTOR Future monitorClientRanges(BlobManagerData* bmData) { ar.dependsOn(results.arena()); VectorRef rangesToAdd; VectorRef rangesToRemove; - // TODO hack for simulation updateClientBlobRanges(&bmData->knownBlobRanges, results, ar, &rangesToAdd, &rangesToRemove); for (KeyRangeRef range : rangesToRemove) { @@ -572,7 +570,6 @@ ACTOR Future monitorClientRanges(BlobManagerData* bmData) { } } -// FIXME: propagate errors here ACTOR Future maybeSplitRange(BlobManagerData* bmData, UID currentWorkerId, KeyRange granuleRange, @@ -902,8 +899,7 @@ ACTOR Future monitorBlobWorker(BlobManagerData* bmData, BlobWorkerInterfac return Void(); } -// TODO this is only for chaos testing right now!! REMOVE LATER -ACTOR Future rangeMover(BlobManagerData* bmData) { +ACTOR Future chaosRangeMover(BlobManagerData* bmData) { ASSERT(g_network->isSimulated()); loop { wait(delay(30.0)); @@ -1135,7 +1131,7 @@ ACTOR Future blobManager(BlobManagerInterface bmInterf, self.addActor.send(rangeAssigner(&self)); if (BUGGIFY) { - self.addActor.send(rangeMover(&self)); + self.addActor.send(chaosRangeMover(&self)); } // TODO probably other things here eventually