wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adding random prefix to blob worker generated files

This commit is contained in:
Josh Slocum 2022-01-28 07:43:34 -06:00
parent df1a21564b
commit cfbb3f5b2b
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
fdbserver/BlobWorker.actor.cpp
View File

@ -438,9 +438,10 @@ ACTOR Future<BlobFileIndex> writeDeltaFile(Reference<BlobWorkerData> bwData,
Optional<std::pair<KeyRange, UID>> oldGranuleComplete) {
wait(delay(0, TaskPriority::BlobWorkerUpdateStorage));
// TODO: this will induce S3 hotspotting, so we should rethink if we want to prefix the file name
// with the granuleID or just add it somewhere in the file name
state std::string fname = granuleID.toString() + "_T" + std::to_string((uint64_t)(1000.0 * now())) + "_V" +
// Prefix filename with random chars both to avoid hotspotting on granuleID, and to have unique file names if
// multiple blob workers try to create the exact same file at the same millisecond (which observably happens)
state std::string fname = deterministicRandom()->randomUniqueID().shortString() + "_" + granuleID.toString() +
"_T" + std::to_string((uint64_t)(1000.0 * now())) + "_V" +
std::to_string(currentDeltaVersion) + ".delta";
state Value serialized = ObjectWriter::toValue(deltasToWrite, Unversioned());
@ -538,10 +539,11 @@ ACTOR Future<BlobFileIndex> writeSnapshot(Reference<BlobWorkerData> bwData,
Version version,
PromiseStream<RangeResult> rows,
bool createGranuleHistory) {
// TODO: this will induce S3 hotspotting, so we should rethink if we want to prefix the file name
// with the granuleID or just add it somewhere in the file name
state std::string fname = granuleID.toString() + "_T" + std::to_string((uint64_t)(1000.0 * now())) + "_V" +
std::to_string(version) + ".snapshot";
// Prefix filename with random chars both to avoid hotspotting on granuleID, and to have unique file names if
// multiple blob workers try to create the exact same file at the same millisecond (which observably happens)
state std::string fname = deterministicRandom()->randomUniqueID().shortString() + "_" + granuleID.toString() +
"_T" + std::to_string((uint64_t)(1000.0 * now())) + "_V" + std::to_string(version) +
".snapshot";
state Arena arena;
state GranuleSnapshot snapshot;