diff --git a/fdbserver/TLogServer.actor.cpp b/fdbserver/TLogServer.actor.cpp index 1561b2f81f..5c744f2e78 100644 --- a/fdbserver/TLogServer.actor.cpp +++ b/fdbserver/TLogServer.actor.cpp @@ -665,24 +665,6 @@ struct LogData : NonCopyable, public ReferenceCounted { specialCounter(cc, "SharedBytesDurable", [tLogData]() { return tLogData->bytesDurable; }); specialCounter(cc, "SharedOverheadBytesInput", [tLogData]() { return tLogData->overheadBytesInput; }); specialCounter(cc, "SharedOverheadBytesDurable", [tLogData]() { return tLogData->overheadBytesDurable; }); - specialCounter( - cc, "KvstoreBytesUsed", [tLogData]() { return tLogData->persistentData->getStorageBytes().used; }); - specialCounter( - cc, "KvstoreBytesFree", [tLogData]() { return tLogData->persistentData->getStorageBytes().free; }); - specialCounter(cc, "KvstoreBytesAvailable", [tLogData]() { - return tLogData->persistentData->getStorageBytes().available; - }); - specialCounter( - cc, "KvstoreBytesTotal", [tLogData]() { return tLogData->persistentData->getStorageBytes().total; }); - specialCounter( - cc, "QueueDiskBytesUsed", [tLogData]() { return tLogData->rawPersistentQueue->getStorageBytes().used; }); - specialCounter( - cc, "QueueDiskBytesFree", [tLogData]() { return tLogData->rawPersistentQueue->getStorageBytes().free; }); - specialCounter(cc, "QueueDiskBytesAvailable", [tLogData]() { - return tLogData->rawPersistentQueue->getStorageBytes().available; - }); - specialCounter( - cc, "QueueDiskBytesTotal", [tLogData]() { return tLogData->rawPersistentQueue->getStorageBytes().total; }); specialCounter(cc, "PeekMemoryReserved", [tLogData]() { return tLogData->peekMemoryLimiter.activePermits(); }); specialCounter(cc, "PeekMemoryRequestsStalled", [tLogData]() { return tLogData->peekMemoryLimiter.waiters(); }); specialCounter(cc, "Generation", [this]() { return this->recoveryCount; }); @@ -2672,7 +2654,23 @@ ACTOR Future tLogCore(TLogData* self, logData->logId, SERVER_KNOBS->STORAGE_LOGGING_DELAY, &logData->cc, - logData->logId.toString() + "/TLogMetrics")); + logData->logId.toString() + "/TLogMetrics", + [self=self](TraceEvent& te) { + StorageBytes sbTlog = self->persistentData->getStorageBytes(); + te.detail("KvstoreBytesUsed", sbTlog.used); + te.detail("KvstoreBytesFree", sbTlog.free); + te.detail("KvstoreBytesAvailable", sbTlog.available); + te.detail("KvstoreBytesTotal", sbTlog.total); + te.detail("KvstoreBytesTemp", sbTlog.temp); + + StorageBytes sbQueue = self->rawPersistentQueue->getStorageBytes(); + te.detail("QueueDiskBytesUsed", sbQueue.used); + te.detail("QueueDiskBytesFree", sbQueue.free); + te.detail("QueueDiskBytesAvailable", sbQueue.available); + te.detail("QueueDiskBytesTotal", sbQueue.total); + te.detail("QueueDiskBytesTemp", sbQueue.temp); + })); + logData->addActor.send(serveTLogInterface(self, tli, logData, warningCollectorInput)); logData->addActor.send(cleanupPeekTrackers(logData.getPtr())); logData->addActor.send(logPeekTrackers(logData.getPtr())); diff --git a/fdbserver/storageserver.actor.cpp b/fdbserver/storageserver.actor.cpp index 8c26f955bb..5ded5d78d1 100644 --- a/fdbserver/storageserver.actor.cpp +++ b/fdbserver/storageserver.actor.cpp @@ -717,10 +717,6 @@ public: specialCounter(cc, "ActiveWatches", [self]() { return self->numWatches; }); specialCounter(cc, "WatchBytes", [self]() { return self->watchBytes; }); - specialCounter(cc, "KvstoreBytesUsed", [self]() { return self->storage.getStorageBytes().used; }); - specialCounter(cc, "KvstoreBytesFree", [self]() { return self->storage.getStorageBytes().free; }); - specialCounter(cc, "KvstoreBytesAvailable", [self]() { return self->storage.getStorageBytes().available; }); - specialCounter(cc, "KvstoreBytesTotal", [self]() { return self->storage.getStorageBytes().total; }); specialCounter(cc, "KvstoreSizeTotal", [self]() { return std::get<0>(self->storage.getSize()); }); specialCounter(cc, "KvstoreNodeTotal", [self]() { return std::get<1>(self->storage.getSize()); }); specialCounter(cc, "KvstoreInlineKey", [self]() { return std::get<2>(self->storage.getSize()); }); @@ -4240,7 +4236,15 @@ ACTOR Future metricsCore(StorageServer* self, StorageServerInterface ssi) SERVER_KNOBS->STORAGE_LOGGING_DELAY, &self->counters.cc, self->thisServerID.toString() + "/StorageMetrics", - [tag](TraceEvent& te) { te.detail("Tag", tag.toString()); })); + [tag, self=self](TraceEvent& te) { + te.detail("Tag", tag.toString()); + StorageBytes sb = self->storage.getStorageBytes(); + te.detail("KvstoreBytesUsed", sb.used); + te.detail("KvstoreBytesFree", sb.free); + te.detail("KvstoreBytesAvailable", sb.available); + te.detail("KvstoreBytesTotal", sb.total); + te.detail("KvstoreBytesTemp", sb.temp); + })); loop { choose {