Add a new workload: BackupToDBAbort, which does an ACI switchover.

This is to allower easier testing of non-durable switchovers without having to
wiggle into BackupToDBCorrectness's view of the world.

fdbrpc/FlowTransport.actor.cpp

@@ -492,7 +492,7 @@ static void scanPackets( TransportData* transport, uint8_t*& unprocessed_begin,
 
 		if (checksumEnabled) {
 			bool isBuggifyEnabled = false;
-			if(g_network->isSimulated() && g_network->now() - g_simulator.lastConnectionFailure > g_simulator.connectionFailuresDisableDuration && BUGGIFY_WITH_PROB(0.001)) {
+			if(g_network->isSimulated() && g_network->now() - g_simulator.lastConnectionFailure > g_simulator.connectionFailuresDisableDuration && BUGGIFY_WITH_PROB(0.0001)) {
 				g_simulator.lastConnectionFailure = g_network->now();
 				isBuggifyEnabled = true;
 				TraceEvent(SevInfo, "BitsFlip");

fdbserver/fdbserver.vcxproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project DefaultTargets="Build" ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Import Project="$(SolutionDir)versions.target" />
   <PropertyGroup Condition="'$(Release)' != 'true' ">
@@ -92,7 +92,7 @@
     <ActorCompiler Include="workloads\DummyWorkload.actor.cpp" />
     <ActorCompiler Include="workloads\BackupCorrectness.actor.cpp" />
     <ActorCompiler Include="workloads\AtomicOps.actor.cpp" />
-    <ActorCompiler Include="workloads\TimeKeeperCorrectness.actor.cpp" />
+    <ActorCompiler Include="workloads\BackupToDBAbort.actor.cpp" />
     <ActorCompiler Include="workloads\BackupToDBCorrectness.actor.cpp" />
     <ActorCompiler Include="workloads\AtomicSwitchover.actor.cpp" />
     <ActorCompiler Include="workloads\AtomicRestore.actor.cpp" />
@@ -113,6 +113,7 @@
     <ActorCompiler Include="workloads\Ping.actor.cpp" />
     <ActorCompiler Include="workloads\RandomMoveKeys.actor.cpp" />
     <ActorCompiler Include="workloads\TargetedKill.actor.cpp" />
+    <ActorCompiler Include="workloads\TimeKeeperCorrectness.actor.cpp" />
     <ActorCompiler Include="workloads\WriteDuringRead.actor.cpp" />
     <ActorCompiler Include="workloads\Watches.actor.cpp" />
     <ActorCompiler Include="workloads\ThreadSafety.actor.cpp" />
@@ -296,4 +297,4 @@
   <Target Name="MyPreCompileSteps" AfterTargets="CLCompile">
     <Exec Command="..\bin\$(Configuration)\coveragetool.exe &quot;$(OutDir)coverage.$(TargetName).xml&quot; @(ActorCompiler -> '%(RelativeDir)%(Filename)%(Extension)', ' ') @(CLInclude -> '%(RelativeDir)%(Filename)%(Extension)', ' ') @(CLCompile -> '%(RelativeDir)%(Filename)%(Extension)', ' ')" />
   </Target>
-</Project>
+</Project>

fdbserver/fdbserver.vcxproj.filters

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <ItemGroup>
     <ActorCompiler Include="ClusterController.actor.cpp" />
@@ -240,6 +240,9 @@
     <ActorCompiler Include="workloads\TimeKeeperCorrectness.actor.cpp">
       <Filter>workloads</Filter>
     </ActorCompiler>
+    <ActorCompiler Include="workloads\BackupToDBAbort.actor.cpp">
+      <Filter>workloads</Filter>
+    </ActorCompiler>
     <ActorCompiler Include="workloads\BackupToDBCorrectness.actor.cpp">
       <Filter>workloads</Filter>
     </ActorCompiler>
@@ -345,4 +348,4 @@
       <UniqueIdentifier>{de5e282f-8d97-4054-b795-0a75b772326f}</UniqueIdentifier>
     </Filter>
   </ItemGroup>
-</Project>
+</Project>

fdbserver/workloads/BackupToDBAbort.actor.cpp

@@ -0,0 +1,113 @@
+/*
+ * BackupToDBAbort.actor.cpp
+ *
+ * This source file is part of the FoundationDB open source project
+ *
+ * Copyright 2013-2018 Apple Inc. and the FoundationDB project authors
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "flow/actorcompiler.h"
+#include "fdbclient/BackupAgent.h"
+#include "fdbclient/ManagementAPI.h"
+#include "fdbclient/NativeAPI.h"
+#include "workloads.h"
+
+struct BackupToDBAbort : TestWorkload {
+	double abortDelay;
+	Database extraDB;
+	Standalone<VectorRef<KeyRangeRef>> backupRanges;
+	UID lockid;
+
+	explicit BackupToDBAbort(const WorkloadContext& wcx)
+	    : TestWorkload(wcx) {
+		abortDelay = getOption(options, LiteralStringRef("abortDelay"), 50.0);
+
+		backupRanges.push_back_deep(backupRanges.arena(), normalKeys);
+
+		Reference<ClusterConnectionFile> extraFile(new ClusterConnectionFile(*g_simulator.extraDB));
+		Reference<Cluster> extraCluster = Cluster::createCluster(extraFile, -1);
+		extraDB = extraCluster->createDatabase(LiteralStringRef("DB")).get();
+
+		lockid = UID(0xbeeffeed, 0xdecaf00d);
+	}
+
+	virtual std::string description() override {
+		return "BackupToDBAbort";
+	}
+
+	virtual Future<Void> setup(const Database& cx) override {
+		if (clientId != 0) return Void();
+		return _setup(this, cx);
+	}
+
+	ACTOR static Future<Void> _setup(BackupToDBAbort* self, Database cx) {
+		state DatabaseBackupAgent backupAgent(cx);
+		state Future<Void> disabler = disableConnectionFailuresAfter(300, "BackupToDBAbort");
+		try {
+			TraceEvent("BDBA_Submit1");
+			Void _ = wait( backupAgent.submitBackup(self->extraDB, BackupAgentBase::getDefaultTag(), self->backupRanges, false, StringRef(), StringRef(), true) );
+			TraceEvent("BDBA_Submit2");
+		} catch( Error &e ) {
+			if( e.code() != error_code_backup_duplicate )
+				throw;
+		}
+		return Void();
+	}
+
+	virtual Future<Void> start(Database const& cx) override {
+		if (clientId != 0) return Void();
+		return _start(this, cx);
+	}
+
+	ACTOR static Future<Void> _start(BackupToDBAbort* self, Database cx) {
+		state DatabaseBackupAgent backupAgent(cx);
+		state Future<Void> disabler = disableConnectionFailuresAfter(300, "BackupToDBAbort");
+
+		TraceEvent("BDBA_Start").detail("delay", self->abortDelay);
+		Void _ = wait(delay(self->abortDelay));
+		TraceEvent("BDBA_Wait");
+		int _ = wait( backupAgent.waitBackup(self->extraDB, BackupAgentBase::getDefaultTag(), false) );
+		TraceEvent("BDBA_Lock");
+		Void _ = wait(lockDatabase(cx, self->lockid));
+		TraceEvent("BDBA_Abort");
+		Void _ = wait(backupAgent.abortBackup(self->extraDB, BackupAgentBase::getDefaultTag()));
+		TraceEvent("BDBA_Unlock");
+		Void _ = wait(backupAgent.unlockBackup(self->extraDB, BackupAgentBase::getDefaultTag()));
+		TraceEvent("BDBA_End");
+
+		// SOMEDAY: Remove after backup agents can exist quiescently
+		if (g_simulator.backupAgents == ISimulator::BackupToDB) {
+			g_simulator.backupAgents = ISimulator::NoBackupAgents;
+		}
+
+		return Void();
+	}
+
+	ACTOR static Future<bool> _check(BackupToDBAbort* self, Database cx) {
+		TraceEvent("BDBA_UnlockPrimary");
+		// Too much of the tester framework expects the primary database to be unlocked, so we unlock it
+		// once all of the workloads have finished.
+		Void _ = wait(unlockDatabase(cx, self->lockid));
+		return true;
+	}
+
+	virtual Future<bool> check(const Database& cx) override {
+		return _check(this, cx);
+	}
+
+	virtual void getMetrics(vector<PerfMetric>& m) {}
+};
+
+REGISTER_WORKLOAD(BackupToDBAbort);

fdbserver/workloads/BackupToDBCorrectness.actor.cpp

@@ -380,7 +380,7 @@ struct BackupToDBCorrectnessWorkload : TestWorkload {
 
 				Standalone<RangeResultRef> logValues = wait(tr->getRange(KeyRange(KeyRangeRef(backupLogValuesKey, strinc(backupLogValuesKey))), 100));
 
-				// Error if the log/mutation keyspace for the backup tag  is not empty
+				// Error if the log/mutation keyspace for the backup tag is not empty
 				if (logValues.size() > 0) {
 					displaySystemKeys++;
 					printf("BackupCorrectnessLeftOverLogKeys: (%d) %s\n", logValues.size(), printable(backupLogValuesKey).c_str());

fdbserver/workloads/workloads.h

@@ -133,6 +133,8 @@ struct WorkloadFactory : IWorkloadFactory {
 	}
 };
 
+#define REGISTER_WORKLOAD(classname) WorkloadFactory<classname> classname##WorkloadFactory( #classname )
+
 struct DistributedTestResults {
 	vector<PerfMetric> metrics;
 	int successes, failures;