wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix multiple (inline) definitions of canReplyWith 

canReplyWith was declared inline in two translation units with different
definitions. When building with clang, this resulted in
storageserver.actor.cpp using the definition from
StorageCache.actor.cpp. Fix that by giving both symbols internal
linkage.
This commit is contained in:
Andrew Noyes 2021-04-16 17:39:56 +00:00
parent 6571e9e78c
commit b75e25e012
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fdbserver/StorageCache.actor.cpp
View File

@ -43,7 +43,7 @@
// Need to look into refactoring common code out for better code readability and to avoid duplication
// TODO rename wrong_shard_server error to wrong_cache_server
inline bool canReplyWith(Error e) {
static inline bool canReplyWith(Error e) {
switch (e.code()) {
case error_code_transaction_too_old:
case error_code_future_version:

2
fdbserver/storageserver.actor.cpp
View File

@ -72,7 +72,7 @@
#define SHORT_CIRCUT_ACTUAL_STORAGE 0
inline bool canReplyWith(Error e) {
static inline bool canReplyWith(Error e) {
switch (e.code()) {
case error_code_transaction_too_old:
case error_code_future_version: