Added -Woverloaded-virtual warning for clang, and fixed accidental overloads in flow.h

This commit is contained in:
sfc-gh-tclinkenbeard 2020-05-24 13:24:52 -07:00
parent e898cb7f38
commit b7160bab2d
2 changed files with 9 additions and 15 deletions

View File

@ -241,7 +241,8 @@ else()
-Wno-delete-non-virtual-dtor
-Wno-undefined-var-template
-Wno-tautological-pointer-compare
-Wno-format)
-Wno-format
-Woverloaded-virtual)
if (USE_CCACHE)
add_compile_options(
-Wno-register

View File

@ -560,10 +560,8 @@ public:
cb->insertChain(this);
}
virtual void unwait() {
delFutureRef();
}
virtual void fire() { ASSERT(false); }
virtual void unwait() override { delFutureRef(); }
virtual void fire(T const&) override { ASSERT(false); }
};
template <class T>
@ -644,10 +642,9 @@ struct NotifiedQueue : private SingleCallback<T>, FastAllocated<NotifiedQueue<T>
ASSERT(SingleCallback<T>::next == this);
cb->insert(this);
}
virtual void unwait() {
delFutureRef();
}
virtual void fire() { ASSERT(false); }
virtual void unwait() override { delFutureRef(); }
virtual void fire(T const&) override { ASSERT(false); }
virtual void fire(T&&) override { ASSERT(false); }
};
@ -1006,12 +1003,8 @@ struct Actor<void> {
template <class ActorType, int CallbackNumber, class ValueType>
struct ActorCallback : Callback<ValueType> {
virtual void fire(ValueType const& value) {
static_cast<ActorType*>(this)->a_callback_fire(this, value);
}
virtual void error(Error e) {
static_cast<ActorType*>(this)->a_callback_error(this, e);
}
virtual void fire(ValueType const& value) override { static_cast<ActorType*>(this)->a_callback_fire(this, value); }
virtual void error(Error e) override { static_cast<ActorType*>(this)->a_callback_error(this, e); }
};
template <class ActorType, int CallbackNumber, class ValueType>