wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

EaR: Fix knob name (#9630) 

Description

Knob 'REST_KMS_ALLOW_NOT_SECURE_CONNECTION' got renamed in recent
patch, however, there are other places that needs an update too.

Testing

devRunCorrectness - 100K
RESTUtilUnits.toml
RESTKmsConnectorUnits.toml
This commit is contained in:
Ata E Husain Bohra 2023-03-08 17:37:39 -08:00 committed by GitHub
parent 2702665e35
commit b227007ab0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fdbclient/RESTUtils.actor.cpp
View File

@ -298,7 +298,7 @@ TEST_CASE("/RESTUtils/ValidURIWithParamsSecure") {
TEST_CASE("/RESTUtils/ValidURIWithParamsKnobNotEnabled") {
auto& g_knobs = IKnobCollection::getMutableGlobalKnobCollection();
g_knobs.setKnob("rest_kms_enable_not_secure_connection", KnobValueRef::create(bool{ false }));
g_knobs.setKnob("rest_kms_allow_not_secure_connection", KnobValueRef::create(bool{ false }));
std::string uri("http://host/foo/bar?param1,param2");
try {
RESTUrl r(uri);
@ -311,7 +311,7 @@ TEST_CASE("/RESTUtils/ValidURIWithParamsKnobNotEnabled") {
TEST_CASE("/RESTUtils/ValidURIWithParams") {
auto& g_knobs = IKnobCollection::getMutableGlobalKnobCollection();
g_knobs.setKnob("rest_kms_enable_not_secure_connection", KnobValueRef::create(bool{ true }));
g_knobs.setKnob("rest_kms_allow_not_secure_connection", KnobValueRef::create(bool{ true }));
std::string uri("http://host/foo/bar?param1,param2");
RESTUrl r(uri);
ASSERT_EQ(r.connType.secure, RESTConnectionType::NOT_SECURE_CONNECTION);

2
fdbserver/fdbserver.actor.cpp
View File

@ -1706,7 +1706,7 @@ private:
}
case OPT_KMS_REST_ALLOW_NOT_SECURE_CONECTION: {
TraceEvent("RESTKmsConnAllowNotSecureConnection");
knobs.emplace_back("rest_kms_enable_not_secure_connection", "true");
knobs.emplace_back("rest_kms_allow_not_secure_connection", "true");
break;
}
case OPT_KMS_CONN_VALIDATION_TOKEN_DETAILS: {