wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove knob reinitialization from updateInMemoryState

This commit is contained in:
sfc-gh-tclinkenbeard 2021-08-18 12:32:12 -07:00
parent 0bacc310ef
commit a7f9db8b76
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fdbserver/LocalConfiguration.actor.cpp
View File

@ -226,12 +226,9 @@ class LocalConfigurationImpl {
void updateInMemoryState(Version lastSeenVersion) {
this->lastSeenVersion = lastSeenVersion;
// TODO: Support randomization?
getKnobs().reset(Randomize::False, g_network->isSimulated() ? IsSimulated::True : IsSimulated::False);
configKnobOverrides.update(getKnobs());
manualKnobOverrides.update(getKnobs());
// Must reinitialize in order to update dependent knobs
getKnobs().initialize(Randomize::False, g_network->isSimulated() ? IsSimulated::True : IsSimulated::False);
// FIXME: Reinitialize in order to update dependent knobs?
}
ACTOR static Future<Void> setSnapshot(LocalConfigurationImpl* self,