wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

StorageEngineSwitch:Remove questions in comments

This commit is contained in:
Meng Xu 2019-08-22 11:49:39 -07:00
parent 5ddf2b16be
commit a377261740
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fdbserver/DataDistribution.actor.cpp
View File

@ -2564,8 +2564,9 @@ ACTOR Future<Void> removeWrongStoreType(DDTeamCollection* self) {
for (auto& server : self->server_info) {
if (!server.second->isCorrectStoreType(self->configuration.storageServerStoreType)) {
// Server may be removed due to failure while the wrongStoreTypeToRemove is sent to the storageServerTracker.
// This race may cause the server to be removed before react to wrongStoreTypeToRemove
// Server may be removed due to failure while the wrongStoreTypeToRemove is sent to the
// storageServerTracker. This race may cause the server to be removed before react to
// wrongStoreTypeToRemove
server.second->wrongStoreTypeToRemove.set(true);
removeServerID = server.second->id;
foundSSToRemove = true;

1
fdbserver/DataDistributionQueue.actor.cpp
View File

@ -248,7 +248,6 @@ public:
}
};
// MXQ: Why do we need to count the utilization for each priority? Can a relocationShard have multiple priorities?
struct Busyness {
vector<int> ledger;

5
fdbserver/MoveKeys.actor.cpp
View File

@ -259,10 +259,7 @@ ACTOR Future<vector<vector<UID>>> additionalSources(Standalone<RangeResultRef> s
}
// keyServer: map from keys to destination servers
// serverKeys: two-dimension map: [servers][keys], value is the servers' state of having the keys: active(not-have),
// complete(already has), ""()
// MXQ: What does serverKeys[dest][keys] mean? It seems having the same meaning with serverKeys[servers][keys]? (I think so.)
// serverKeys: two-dimension map: [servers][keys], value is the servers' state of having the keys: active(not-have), complete(already has), ""().
// Set keyServers[keys].dest = servers
// Set serverKeys[servers][keys] = active for each subrange of keys that the server did not already have, complete for each subrange that it already has
// Set serverKeys[dest][keys] = "" for the dest servers of each existing shard in keys (unless that destination is a member of servers OR if the source list is sufficiently degraded)