wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bug fix in DeltaTree - Insert() of record outside of lower/upper boundaries used for key decoding would calculate incorrect record delta.

This commit is contained in:
Steve Atherton 2022-02-10 01:36:24 -08:00
parent 6dc5921575
commit a023d49947
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fdbserver/DeltaTree.h
View File

@ -1545,7 +1545,17 @@ public:
T leftBase = leftBaseIndex == -1 ? cache->lowerBound : get(cache->get(leftBaseIndex));
T rightBase = rightBaseIndex == -1 ? cache->upperBound : get(cache->get(rightBaseIndex));
int common = leftBase.getCommonPrefixLen(rightBase, skipLen);
// If seek has reached a non-edge node then whatever bytes the left and right bases
// have in common are definitely in common with k. However, for an edge node there
// is no guarantee, as one of the bases will be the lower or upper decode boundary
// and it is possible to add elements to the DeltaTree beyond those boundaries.
int common;
if (leftBaseIndex == -1 || rightBaseIndex == -1) {
common = 0;
} else {
common = leftBase.getCommonPrefixLen(rightBase, skipLen);
}
int commonWithLeftParent = k.getCommonPrefixLen(leftBase, common);
int commonWithRightParent = k.getCommonPrefixLen(rightBase, common);
bool borrowFromLeft = commonWithLeftParent >= commonWithRightParent;