wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fixup! Fix the clang error when using std::move 

This patch is to fix the compile error

/root/src/fdbclient/S3BlobStore.actor.cpp:410:9: error: moving a local
object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
 return std::move(resource);
        ^
/root/src/fdbclient/S3BlobStore.actor.cpp:410:9: note: remove std::move
call here
 return std::move(resource);
        ^~~~~~~~~~        ~
1 error generated.
This commit is contained in:
Xiaoge Su 2022-06-14 11:17:17 -07:00
parent fd6f6eb06a
commit 9fb6e5bb05
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fdbclient/S3BlobStore.actor.cpp
View File

@ -395,7 +395,7 @@ std::string S3BlobStoreEndpoint::getResourceURL(std::string resource, std::strin
return r;
}
std::string constructResourcePath(Reference<S3BlobStoreEndpoint> b, std::string bucket, std::string object) {
std::string constructResourcePath(Reference<S3BlobStoreEndpoint> b, const std::string& bucket, const std::string& object) {
std::string resource;
if (b->getHost().find(bucket + ".") != 0) {
@ -407,7 +407,7 @@ std::string constructResourcePath(Reference<S3BlobStoreEndpoint> b, std::string
resource += object;
}
return std::move(resource);
return resource;
}
ACTOR Future<bool> bucketExists_impl(Reference<S3BlobStoreEndpoint> b, std::string bucket) {