wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add contract comments

This commit is contained in:
Xiaoxi Wang 2022-07-08 14:19:14 -07:00
parent f5a81154ef
commit 9cead35911
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fdbserver/include/fdbserver/DDTxnProcessor.h
View File

@ -25,6 +25,11 @@
#include "fdbserver/DataDistribution.actor.h"
#include "fdbserver/MoveKeys.actor.h"
/* Testability Contract:
* a. The DataDistributor has to use this interface to interact with data-plane (aka. run transaction), because the
* testability benefits from a mock implementation; b. Other control-plane roles should consider providing its own
* TxnProcessor interface to provide testability, for example, Ratekeeper.
* */
class IDDTxnProcessor {
public:
struct SourceServers {
@ -38,7 +43,7 @@ public:
virtual ~IDDTxnProcessor() = default;
virtual Future<MoveKeysLock> takeMoveKeysLock(UID ddId) const { return MoveKeysLock(); }
[[nodiscard]] virtual Future<MoveKeysLock> takeMoveKeysLock(UID ddId) const { return MoveKeysLock(); }
};
class DDTxnProcessorImpl;