wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix calculateTeamStorageQueueThreshold (#11196)

This commit is contained in:
Zhe Wang 2024-02-12 16:19:33 -08:00 committed by GitHub
parent b699a7e4f7
commit 9c795c5f52
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fdbserver/DDTeamCollection.actor.cpp
View File

@ -199,6 +199,9 @@ public:
// portion of teams that have longer storage queues // portion of teams that have longer storage queues
// A team storage queue size is defined as the longest storage queue size among all SSes of the team // A team storage queue size is defined as the longest storage queue size among all SSes of the team
static int64_t calculateTeamStorageQueueThreshold(const std::vector<Reference<TCTeamInfo>>& teams) { static int64_t calculateTeamStorageQueueThreshold(const std::vector<Reference<TCTeamInfo>>& teams) {
if (teams.size() == 0) {
return std::numeric_limits<int64_t>::max(); // disable this funcationality
}
std::vector<int64_t> queueLengthList; std::vector<int64_t> queueLengthList;
for (const auto& team : teams) { for (const auto& team : teams) {
Optional<int64_t> storageQueueSize = team->getLongestStorageQueueSize(); Optional<int64_t> storageQueueSize = team->getLongestStorageQueueSize();
@ -210,7 +213,7 @@ public:
} }
} }
double percentile = std::max(0.0, std::min(SERVER_KNOBS->DD_LONG_STORAGE_QUEUE_TEAM_MAJORITY_PERCENTILE, 1.0)); double percentile = std::max(0.0, std::min(SERVER_KNOBS->DD_LONG_STORAGE_QUEUE_TEAM_MAJORITY_PERCENTILE, 1.0));
int position = queueLengthList.size() * (1 - percentile); int position = (queueLengthList.size() - 1) * (1 - percentile);
std::nth_element(queueLengthList.begin(), queueLengthList.begin() + position, queueLengthList.end()); std::nth_element(queueLengthList.begin(), queueLengthList.begin() + position, queueLengthList.end());
int64_t threshold = queueLengthList[position]; int64_t threshold = queueLengthList[position];
TraceEvent(SevInfo, "StorageQueueAwareGotThreshold").suppressFor(5.0).detail("Threshold", threshold); TraceEvent(SevInfo, "StorageQueueAwareGotThreshold").suppressFor(5.0).detail("Threshold", threshold);