wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3351 from xumengpanda/mengxu/proto-version-comment-PR 

Explain the dev version in protocol version
This commit is contained in:
A.J. Beamon 2020-06-12 15:57:31 -07:00 committed by GitHub
parent 80334351c7 5da8f1b9aa
commit 9ac8a2007a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
flow/ProtocolVersion.h
View File

@ -73,6 +73,11 @@ public:
constexpr bool operator>(const ProtocolVersion other) const { return version() > other.version(); } constexpr bool operator>(const ProtocolVersion other) const { return version() > other.version(); }
public: // introduced features public: // introduced features
// The 5th digit from right is dev version, for example, 2 in 0x0FDB00B061020000LL;
// It was used to identify a protocol change (e.g., interface change) between major/minor versions (say 5.1 and 5.2)
// We stopped using the dev version consistently in the past.
// To ensure binaries work across patch releases (e.g., 6.2.0 to 6.2.22), we require that the protocol version be
// the same for each of them.
PROTOCOL_VERSION_FEATURE(0x0FDB00A200090000LL, Watches); PROTOCOL_VERSION_FEATURE(0x0FDB00A200090000LL, Watches);
PROTOCOL_VERSION_FEATURE(0x0FDB00A2000D0000LL, MovableCoordinatedState); PROTOCOL_VERSION_FEATURE(0x0FDB00A2000D0000LL, MovableCoordinatedState);
PROTOCOL_VERSION_FEATURE(0x0FDB00A340000000LL, ProcessID); PROTOCOL_VERSION_FEATURE(0x0FDB00A340000000LL, ProcessID);