wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

set local registry to null in destructor

This commit is contained in:
Fuheng Zhao 2021-07-26 09:36:55 -07:00
parent 61ffd6b372
commit 98e92ebde4
1 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
fdbserver/VersionedBTree.actor.cpp
View File

@ -1595,10 +1595,14 @@ struct RedwoodMetrics {
redwoodHistogramRegistry = new HistogramRegistry();
kvSizeWritten = Histogram::getHistogram(
LiteralStringRef("kvSize"), LiteralStringRef("Written"), Histogram::Unit::bytes, redwoodHistogramRegistry);
kvSizeReadByGet = Histogram::getHistogram(
LiteralStringRef("kvSize"), LiteralStringRef("ReadByGet"), Histogram::Unit::bytes, redwoodHistogramRegistry);
kvSizeReadByGetRange = Histogram::getHistogram(
LiteralStringRef("kvSize"), LiteralStringRef("ReadByGetRange"), Histogram::Unit::bytes, redwoodHistogramRegistry);
kvSizeReadByGet = Histogram::getHistogram(LiteralStringRef("kvSize"),
LiteralStringRef("ReadByGet"),
Histogram::Unit::bytes,
redwoodHistogramRegistry);
kvSizeReadByGetRange = Histogram::getHistogram(LiteralStringRef("kvSize"),
LiteralStringRef("ReadByGetRange"),
Histogram::Unit::bytes,
redwoodHistogramRegistry);
clear(redwoodHistogramRegistry);
}
@ -1616,6 +1620,24 @@ struct RedwoodMetrics {
startTime = g_network ? now() : 0;
}
~RedwoodMetrics() {
kvSizeWritten.clear();
kvSizeReadByGet.clear();
kvSizeReadByGetRange.clear();
for (RedwoodMetrics::Level& level : levels) {
level.buildFillPctSketch.clear();
level.modifyFillPctSketch.clear();
level.buildStoredPctSketch.clear();
level.modifyStoredPctSketch.clear();
level.buildItemCountSketch.clear();
level.modifyItemCountSketch.clear();
}
if (redwoodHistogramRegistry)
delete redwoodHistogramRegistry;
redwoodHistogramRegistry = nullptr;
}
// btree levels and one extra level for non btree level.
Level levels[btreeLevels + 1];
metrics metric;