wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add assertions that results are empty if no conflicts happen

This commit is contained in:
Chaoguang Lin 2020-05-13 00:39:21 -07:00
parent e93beee923
commit 8ab792d58b
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
fdbserver/workloads/ReportConflictingKeys.actor.cpp
View File

@ -121,6 +121,14 @@ struct ReportConflictingKeysWorkload : TestWorkload {
} while (deterministicRandom()->random01() < addWriteConflictRangeProb); } while (deterministicRandom()->random01() < addWriteConflictRangeProb);
} }
void emptyConflictingKeysTest(Reference<ReadYourWritesTransaction> ryw) {
// This test is called when you want to make sure there is no conflictingKeys,
// which means you will get an empty result form getRange(\xff\xff/transaction/conflicting_keys/, \xff\xff/transaction/conflicting_keys0)
auto resultFuture = ryw->getRange(conflictingKeysRange, CLIENT_KNOBS->TOO_MANY);
auto result = resultFuture.get();
ASSERT(!result.more && result.size() == 0);
}
ACTOR Future<Void> conflictingClient(Database cx, ReportConflictingKeysWorkload* self) { ACTOR Future<Void> conflictingClient(Database cx, ReportConflictingKeysWorkload* self) {
state ReadYourWritesTransaction tr1(cx); state ReadYourWritesTransaction tr1(cx);
@ -130,6 +138,11 @@ struct ReportConflictingKeysWorkload : TestWorkload {
loop { loop {
try { try {
// set the flag for empty key range testing
tr1.setOption(FDBTransactionOptions::REPORT_CONFLICTING_KEYS);
// tr1 should never have conflicting keys, the result should always be empty
self->emptyConflictingKeysTest(Reference<ReadYourWritesTransaction>::addRef(&tr1));
tr2.setOption(FDBTransactionOptions::REPORT_CONFLICTING_KEYS); tr2.setOption(FDBTransactionOptions::REPORT_CONFLICTING_KEYS);
// If READ_YOUR_WRITES_DISABLE set, it behaves like native transaction object // If READ_YOUR_WRITES_DISABLE set, it behaves like native transaction object
// where overlapped conflict ranges are not merged. // where overlapped conflict ranges are not merged.
@ -147,6 +160,8 @@ struct ReportConflictingKeysWorkload : TestWorkload {
++self->commits; ++self->commits;
wait(tr1.commit()); wait(tr1.commit());
++self->xacts; ++self->xacts;
// tr1 should never have conflicting keys, test again after the commit
self->emptyConflictingKeysTest(Reference<ReadYourWritesTransaction>::addRef(&tr1));
state bool foundConflict = false; state bool foundConflict = false;
try { try {