wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename function to be more clear.

This commit is contained in:
Suraj Gupta 2021-09-15 10:44:01 -04:00 committed by Josh Slocum
parent fe098b3b11
commit 6b4eb06201
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fdbserver/ClusterController.actor.cpp
View File

@ -3405,7 +3405,7 @@ ProcessClass::Fitness findBestFitnessForSingleton(const ClusterControllerData* s
// the singleton is stable (see below) and doesn't need to be rerecruited.
// Side effects: (possibly) initiates recruitment
template <class Interface>
bool rerecruitSingleton(ClusterControllerData* self,
bool isHealthySingleton(ClusterControllerData* self,
const WorkerDetails& newWorker,
const Singleton<Interface>& singleton,
const ProcessClass::Fitness& bestFitness,
@ -3439,7 +3439,7 @@ bool rerecruitSingleton(ClusterControllerData* self,
.detail("Excluded", currWorker.priorityInfo.isExcluded)
.detail("Fitness", currFitness)
.detail("BestFitness", bestFitness);
singleton.recruit(self);
singleton.recruit(self); // SIDE EFFECT: initiating recruitment
return false; // not healthy since needed to be rerecruited
} else {
return true; // healthy because doesn't need to be rerecruited
@ -3492,11 +3492,12 @@ void checkBetterSingletons(ClusterControllerData* self) {
auto rkSingleton = RatekeeperSingleton(db.ratekeeper);
auto ddSingleton = DataDistributorSingleton(db.distributor);
// Try to rerecruit the singletons to more optimal processes
bool rkHealthy = rerecruitSingleton<RatekeeperInterface>(
// Check if the singletons are healthy.
// side effect: try to rerecruit the singletons to more optimal processes
bool rkHealthy = isHealthySingleton<RatekeeperInterface>(
self, newRKWorker, rkSingleton, bestFitnessForRK, self->recruitingRatekeeperID);
bool ddHealthy = rerecruitSingleton<DataDistributorInterface>(
bool ddHealthy = isHealthySingleton<DataDistributorInterface>(
self, newDDWorker, ddSingleton, bestFitnessForDD, self->recruitingDistributorID);
// if any of the singletons are unhealthy (rerecruited or not stable), then do not