wbtiger
/
foundationdb
mirror of https://github.com/apple/foundationdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplified templates that were used to forward rvalue references to JsonBuilder write() functions when possible as the current design does not require or benefit from this.

This commit is contained in:
Stephen Atherton 2018-09-10 18:48:30 -07:00
parent 9e8c1941ec
commit 5c23f91c59
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
fdbclient/JsonString.h
View File

@ -259,11 +259,11 @@ public:
write('[');
}
template<typename VT> inline JsonBuilderArray & push_back(VT &&val) {
template<typename VT> inline JsonBuilderArray & push_back(const VT &val) {
if(elements++ > 0) {
write(',');
}
writeValue(std::forward<VT>(val));
writeValue(val);
return *this;
}
@ -287,18 +287,18 @@ public:
write('{');
}
template<typename KT, typename VT> inline JsonBuilderObject & setKey(KT &&name, VT &&val) {
template<typename KT, typename VT> inline JsonBuilderObject & setKey(const KT &name, const VT &val) {
if(elements++ > 0) {
write(',');
}
write('"');
write(name);
write("\":");
writeValue(std::forward<VT>(val));
writeValue(val);
return *this;
}
template<typename KT, typename VT> inline JsonBuilderObject & setKeyRawNumber(KT &&name, VT &&val) {
template<typename KT, typename VT> inline JsonBuilderObject & setKeyRawNumber(const KT &name, const VT &val) {
if(elements++ > 0) {
write(',');
}
@ -332,8 +332,8 @@ public:
JsonBuilderObjectSetter(JsonBuilderObject &dest, KT &&name) : dest(dest), name(std::forward<KT>(name)) {}
// Value is accepted as an rvalue if possible
template <class VT> inline void operator=(VT &&value) {
dest.setKey(name, std::forward<VT>(value));
template <class VT> inline void operator=(const VT &value) {
dest.setKey(name, value);
}
protected: